Re: [PATCH 6/6] phy: amlogic: meson8b-usb2: Add a compatible string for Meson8m2

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > The 3.10 vendor kernel sets the ACA_ENABLE bit on Meson8b, Meson8m2 and > GXBB, but not on Meson8. Add a compatible string for Meson8m2 which also > sets that bit. > While here, also update the Kconfig text and MODULE_DESCRIPTION. > > S

Re: [PATCH 5/6] phy: amlogic: meson8b-usb2: unset the IDDQ bit during PHY power-on

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > The vendor driver unsets the set_iddig bit during power-on as well and > sets it when suspending the PHY. I did not notice this in the vendor > driver first, because it's part of the dwc_otg driver there (instead of > their PHY code). W

Re: [PATCH 4/6] phy: amlogic: meson8b-usb2: Don't set REG_ADP_BC_ACA_ENABLE on Meson8

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > Skip setting REG_ADP_BC_ACA_ENABLE on Meson8 SoCs and polling for the > REG_ADP_BC_ACA_PIN_FLOAT bit. The vendor also skips this part on Meson8 > SoCs. > This fixes initialization of the host-only USB PHY on Meson8 which would > otherwi

Re: [PATCH 3/6] phy: amlogic: meson8b-usb2: Use a MMIO regmap

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > Using a MMIO regmap and switch to regmap_update_bits() to simplify the > code in the driver. Also switch to devm_platform_ioremap_resource() > instead of open-coding it. No functional changes intended. > > Signed-off-by: Martin Blumenst

Re: [PATCH 2/6] dt-bindings: phy: meson8b-usb2: Add compatible string for Meson8m2

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > The USB2 PHY on Meson8m2 is identical to the one on Meson8b but > different to the one on Meson8. The only known difference is that Meson8 > does not set the ACA_ENABLE bit while Meson8b and Meson8m2 do. > Add an explicit compatible str

Re: [PATCH 1/6] dt-bindings: phy: meson8b-usb2: Convert to json-schema

2020-05-04 Thread hex dump
On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl wrote: > > Now that we have the DT validation in place, let's convert the device > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > PHY over to a YAML schema. > > While here, also add the fallback compatible string > "amlogi

Re: [PATCH 1/1] ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805

2019-05-27 Thread hex dump
On Fri, May 24, 2019 at 8:19 PM Martin Blumenstingl wrote: > > The TRONFY MXQ comes with either 1GB or 2GB RAM. > > Both variants share (like most boards based on Amlogic reference > designs): > - 10/100 PHY (IC Plus IP101GR) with GPIOH_4 being the reset line and > GPIOH_3 the interrupt line > -