Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration

2021-04-05 Thread heying (H)
Hello, 在 2021/4/2 22:25, Greg KH 写道: On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote: When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC is not set, compiling errors are encountered as follows: drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk':

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear Alexandre, 在 2021/3/24 17:29, Alexandre Belloni 写道: On 24/03/2021 05:09:39-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread heying (H)
Dear, 在 2021/3/24 14:22, Christophe Leroy 写道: Le 24/03/2021 à 07:14, Christophe Leroy a écrit : Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear, 在 2021/3/24 6:18, Alexandre Belloni 写道: Hello, On 23/03/2021 05:12:57-0400, He Ying wrote: We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear Christophe, 在 2021/3/23 14:33, Christophe Leroy 写道: Le 23/03/2021 à 07:21, heying (H) a écrit : Dear Christophe, 在 2021/3/18 10:28, heying (H) 写道: 在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread heying (H)
Dear Christophe, 在 2021/3/18 10:28, heying (H) 写道: 在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol

Re: [PATCH v2] smp: kernel/panic.c - silence warnings

2021-03-18 Thread heying (H)
Dear Ingo, Peter and Christophe, I'm a bit confused. All of you have a good reason but have opposite opinions. If I don't add 'extern', can you accept it? Please let me know. Thanks, He Ying 在 2021/3/18 13:53, Christophe Leroy 写道: Le 17/03/2021 à 18:37, Peter Zijlstra a écrit : On

Re: [PATCH v2] smp: kernel/panic.c - silence warnings

2021-03-17 Thread heying (H)
在 2021/3/18 4:09, Ingo Molnar 写道: * Peter Zijlstra wrote: Now, the C people figured that distinction was useless and allowed sloppiness. But I still think there's merrit to that. And as mentioned earlier, it is consistent with variable declarations. Fully agreed, and my other point was

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-17 Thread heying (H)
在 2021/3/17 19:57, Michael Ellerman 写道: Daniel Axtens writes: "heying (H)" writes: Thank you for your reply. 在 2021/3/17 11:04, Daniel Axtens 写道: Hi He Ying, Thank you for this patch. I'm not sure what the precise rules for Fixes are, but I wonder if this should ha

Re: [PATCH -next] powerpc: kernel/time.c - cleanup warnings

2021-03-17 Thread heying (H)
在 2021/3/17 19:16, Christophe Leroy 写道: Le 17/03/2021 à 11:34, He Ying a écrit : We found these warnings in arch/powerpc/kernel/time.c as follows: warning: symbol 'decrementer_max' was not declared. Should it be static? warning: symbol 'rtc_lock' was not declared. Should it be static?

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-16 Thread heying (H)
Thank you for your reply. 在 2021/3/17 11:04, Daniel Axtens 写道: Hi He Ying, Thank you for this patch. I'm not sure what the precise rules for Fixes are, but I wonder if this should have: Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") Fixes: f79643787e0a ("powerpc/64s:

Re: [PATCH] smp: kernel/panic.c - silence warnings

2021-03-16 Thread heying (H)
Dear Christophe and Randy, You both are so nice. Thank you for your reply. 在 2021/3/16 14:58, Christophe Leroy 写道: Le 16/03/2021 à 07:35, heying (H) a écrit : Thanks for your reply. 在 2021/3/16 13:15, Randy Dunlap 写道: On 3/15/21 9:08 PM, He Ying wrote: We found these warnings in kernel

Re: [PATCH] smp: kernel/panic.c - silence warnings

2021-03-16 Thread heying (H)
Thanks for your reply. 在 2021/3/16 13:15, Randy Dunlap 写道: On 3/15/21 9:08 PM, He Ying wrote: We found these warnings in kernel/panic.c by using sparse tool: warning: symbol 'panic_smp_self_stop' was not declared. warning: symbol 'nmi_panic_self_stop' was not declared. warning: symbol