RE: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid

2018-04-19 Thread heyunlei
>-Original Message- >From: Chao Yu [mailto:yuch...@huawei.com] >Sent: Friday, April 20, 2018 9:53 AM >To: jaeg...@kernel.org >Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net >Subject: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid > >As most indirect

RE: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid

2018-04-19 Thread heyunlei
>-Original Message- >From: Chao Yu [mailto:yuch...@huawei.com] >Sent: Friday, April 20, 2018 9:53 AM >To: jaeg...@kernel.org >Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net >Subject: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid > >As most indirect

RE: [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread heyunlei
>-Original Message- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaeg...@kernel.org; c...@kernel.org; Yuchao (T); yunlong.s...@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; >linux-f2fs-de...@lists.sourceforge

RE: [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread heyunlei
>-Original Message- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaeg...@kernel.org; c...@kernel.org; Yuchao (T); yunlong.s...@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; >linux-f2fs-de...@lists.sourceforge

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, Can we split in place update bios into single sbi->f2fs_bio_info for more page merged in out place update? This case can be show as below: in place update submit a bio with one page out place update submit a bio with one page in place update submit a bio with one page

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, Can we split in place update bios into single sbi->f2fs_bio_info for more page merged in out place update? This case can be show as below: in place update submit a bio with one page out place update submit a bio with one page in place update submit a bio with one page

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, I try this patch and find it can fix below case: kworker/u16:3-423 [002] 183.812347: submit_bio: kworker/u16:3(423): WRITE block 104749352 on mmcblk0p50 (8 sectors) fio-2122 [003] 183.812380: submit_bio: fio(2122): WRITE block 104749360 on

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, I try this patch and find it can fix below case: kworker/u16:3-423 [002] 183.812347: submit_bio: kworker/u16:3(423): WRITE block 104749352 on mmcblk0p50 (8 sectors) fio-2122 [003] 183.812380: submit_bio: fio(2122): WRITE block 104749360 on

Re: [f2fs-dev] [PATCH 1/2] f2fs: write small sized IO to hot log

2017-03-30 Thread heyunlei
Hi Jaegeuk, On 2017/3/30 4:48, Jaegeuk Kim wrote: It would better split small and large IOs separately in order to get more consecutive big writes. The default threshold is set to 64KB, but configurable by sysfs/min_hot_blocks. Signed-off-by: Jaegeuk Kim ---

Re: [f2fs-dev] [PATCH 1/2] f2fs: write small sized IO to hot log

2017-03-30 Thread heyunlei
Hi Jaegeuk, On 2017/3/30 4:48, Jaegeuk Kim wrote: It would better split small and large IOs separately in order to get more consecutive big writes. The default threshold is set to 64KB, but configurable by sysfs/min_hot_blocks. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c| 9 +

Re: [f2fs-dev] [PATCH 1/5] f2fs: relax node version check for victim data in gc

2017-03-29 Thread heyunlei
Hi all, On 2017/3/26 5:27, Jaegeuk Kim wrote: On 03/25, Chao Yu wrote: Hi Jaegeuk, On 2017/3/25 15:59, Jaegeuk Kim wrote: - has_not_enough_free_secs node_secs: 0 dent_secs: 0 freed:0 free_segments:103 reserved:104 - f2fs_gc - get_victim_by_default alloc_mode 0,

Re: [f2fs-dev] [PATCH 1/5] f2fs: relax node version check for victim data in gc

2017-03-29 Thread heyunlei
Hi all, On 2017/3/26 5:27, Jaegeuk Kim wrote: On 03/25, Chao Yu wrote: Hi Jaegeuk, On 2017/3/25 15:59, Jaegeuk Kim wrote: - has_not_enough_free_secs node_secs: 0 dent_secs: 0 freed:0 free_segments:103 reserved:104 - f2fs_gc - get_victim_by_default alloc_mode 0,

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk, On 2017/1/13 6:44, Jaegeuk Kim wrote: This patch adds stat information for flush and discard commands. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 7 +-- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 4 3 files changed, 11 insertions(+), 3

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk, On 2017/1/13 6:44, Jaegeuk Kim wrote: This patch adds stat information for flush and discard commands. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 7 +-- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 4 3 files changed, 11 insertions(+), 3 deletions(-) diff

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk Kim, On 2017/1/13 6:44, Jaegeuk Kim wrote: This patch adds stat information for flush and discard commands. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 7 +-- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 4 3 files changed, 11 insertions(+), 3

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk Kim, On 2017/1/13 6:44, Jaegeuk Kim wrote: This patch adds stat information for flush and discard commands. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c | 7 +-- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 4 3 files changed, 11 insertions(+), 3 deletions(-) diff

Re: [f2fs-dev] [PATCH] f2fs: fix to account total free nid correctly

2016-11-17 Thread heyunlei
On 2016/11/15 4:45, Jaegeuk Kim wrote: On Mon, Nov 14, 2016 at 07:24:56PM +0800, Chao Yu wrote: Thread AThread BThread C - f2fs_create - f2fs_new_inode - f2fs_lock_op - alloc_nid alloc last nid - f2fs_unlock_op - f2fs_create

Re: [f2fs-dev] [PATCH] f2fs: fix to account total free nid correctly

2016-11-17 Thread heyunlei
On 2016/11/15 4:45, Jaegeuk Kim wrote: On Mon, Nov 14, 2016 at 07:24:56PM +0800, Chao Yu wrote: Thread AThread BThread C - f2fs_create - f2fs_new_inode - f2fs_lock_op - alloc_nid alloc last nid - f2fs_unlock_op - f2fs_create

Re: [f2fs-dev] [PATCH] f2fs: fix to set superblock dirty correctly

2016-08-26 Thread heyunlei
Hi all, On 2016/8/27 9:01, Jaegeuk Kim wrote: On Fri, Aug 26, 2016 at 10:20:18PM +0800, Chao Yu wrote: From: Chao Yu tests/generic/251 of fstest suit complains us with below message: [ cut here ] invalid opcode: [#1] PREEMPT SMP CPU: 2 PID:

Re: [f2fs-dev] [PATCH] f2fs: fix to set superblock dirty correctly

2016-08-26 Thread heyunlei
Hi all, On 2016/8/27 9:01, Jaegeuk Kim wrote: On Fri, Aug 26, 2016 at 10:20:18PM +0800, Chao Yu wrote: From: Chao Yu tests/generic/251 of fstest suit complains us with below message: [ cut here ] invalid opcode: [#1] PREEMPT SMP CPU: 2 PID: 7698 Comm: fstrim