Re: [PATCH] libbpf: add support for printing BTF character arrays as strings

eature/test-libbpf.c?h=perf-tools-next Currently these features are only used if perf is built with LIBBPF_DYNAMIC=1 as part of the build arguments (ie its not the default): https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/Makefile.confi

[PATCH][next] selftests/futex: Fix spelling mistake "manaul" -> "manual"

There is a spelling mistake in a ksft_test_result message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/futex/functional/futex_priv_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/futex/functional/futex_priv_hash.c b/tools

[PATCH][next] selftests/futex: Fix spelling mistake "unitiliazed" -> "uninitialized"

There is a spelling mistake in a fail error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/futex/functional/futex_numa_mpol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools

[PATCH][next] selftests/perf_events: Fix spelling mistake "sycnhronize" -> "synchronize"

There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/perf_events/watermark_signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/perf_events/watermark_signal.c b/tools/testing/selftests

[PATCH][next] KVM: selftests: Fix spelling mistake "avaialable" -> "available"

There is a spelling mistake in a ksft_test_result_skip message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c b

[PATCH]][next] KVM: selftests: Fix spelling mistake "UFFDIO_CONINUE" -> "UFFDIO_CONTINUE"

There is a spelling mistake in a PER_PAGE_DEBUG debug message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/userfaultfd_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/userfaultfd_util.c b/tools/testing

[PATCH][next] selftests/x86/xstate: Fix spelling mistake "hader" -> "header"

There is a spelling mistake in a sig_print message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/x86/xstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/xstate.c b/tools/testing/selftests/x86/xstate.c index 875777911d82

[PATCH][next] KVM: selftests: Fix spelling mistake "Unabled" -> "Unable"

There is a spelling mistake in a TEST_FAIL message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/kvm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c

[PATCH] KVM: selftests: Fix spelling mistake "initally" -> "initially"

There is a spelling mistake in a literal string and in the function test_get_inital_dirty. Fix them. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cmma_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/kvm/s390

[PATCH][next] KVM: selftests: Fix spelling mistake "initally" -> "initially"

There is a spelling mistake in a literal string. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cmma_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390/cmma_test.c b/tools/testing/selftests/kvm/s390

Re: [PATCH] perf tools: Fixup end address of modules

e able to track other segments (like data/rodata), > but that would require some changes in /proc/modules IMHO. > > Reported-by: Blake Jones > Cc: Luis Chamberlain > Cc: Petr Pavlu > Cc: Sami Tolvanen > Cc: Daniel Gomez > Cc: linux-modu...@vger.kernel.org > Signed-

[PATCH][next] virtio_vdpa: remove redundant check on desc

ned-off-by: Colin Ian King --- drivers/virtio/virtio_vdpa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index 7364bd53e38d..1f60c9d5cb18 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdp

[PATCH][next] KVM: s390: selftests: Fix spelling mistake "avaialable" -> "available"

There is a spelling mistake in a ksft_test_result_skip message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390x/cpumodel_subfuncs_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390x/cpumodel_subfuncs_test.c b

[PATCH][next] firewire: core: Fix spelling mistakes in tracepoint messages

There are two spelling mistakes in the tracepoint message text. Fix them. Signed-off-by: Colin Ian King --- include/trace/events/firewire.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h index

[PATCH][next] dax: remove redundant assignment to variable rc

Signed-off-by: Colin Ian King --- drivers/dax/bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 797e1ebff299..f758afbf8f09 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -1204,7 +1204,6 @@ static ssize_t mapping_store(struct device *d

Re: [RFC PATCH 0/4] perf: Correlating user process data to samples

here is some factoring work > under perf to make it easier to add more dump types using the existing > ABI. This is mostly to make the patches clearer, certainly the refactor > parts could get dropped and we could have duplicated/specialized paths. fs and gs may be used for more than just th

Re: [PATCH v1 0/4] perf parse-regs: Cleanup config and building

perf build: Remove unused CONFIG_PERF_REGS > perf parse-regs: Always build perf register functions > perf parse-regs: Introduce a weak function arch__sample_reg_masks() > perf build: Cleanup perf register configuration Thanks Leo, this is great cleanup! Series: Reviewed-by: I

[PATCH][next] fsdax: remove redundant variable 'error'

ue is never actually read from 'error' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/dax.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 2ababb89918d..cb36c6746fc4 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1830,

[PATCH] nvdimm/region: Fix spelling mistake "memergion" -> "memregion"

There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/nvdimm/region_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 83dbf398ea84..8f5274b04348 100644 --- a

Re: [PATCH] perf/x86: Fix integer overflow when left shifting an integer more than 32 bits

On 20/04/2021 16:31, Peter Zijlstra wrote: > On Tue, Apr 20, 2021 at 05:03:03PM +0200, Peter Zijlstra wrote: >> On Tue, Apr 20, 2021 at 03:29:07PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The 64 bit value read from MSR_ARCH_PERFMON_FIXED_CTR_CT

re: phy: nxp-c45: add driver for tja1103

Hi, Static analysis with Coverity on linux-next has found a potential issue in drivers/net/phy/nxp-c45-tja11xx.c, function nxp_c45_get_phase_shift. The analysis by Coverity is as follows: 350 static u64 nxp_c45_get_phase_shift(u64 phase_offset_raw) 351 { 352/* The delay in degree phase is

Re: [PATCH v3 0/4] kernfs: proposed locking and concurrency improvement

On Mon, 2021-04-19 at 15:56 +0800, Fox Chen wrote: > On Fri, Apr 9, 2021 at 9:14 AM Ian Kent wrote: > > There have been a few instances of contention on the kernfs_mutex > > during > > path walks, a case on very large IBM systems seen by myself, a > > report by > >

[PATCH] perf arm64: Fix off-by-one directory paths.

Relative path include works in the regular build due to -I paths but may break in other situations. Signed-off-by: Ian Rogers --- tools/perf/arch/arm64/util/kvm-stat.c | 4 ++-- tools/perf/arch/arm64/util/pmu.c | 4 ++-- tools/perf/arch/arm64/util/unwind-libunwind.c | 4

Re: [PATCH 55/57] staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used

-const-variable=] Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman Cc: Thierry Reding Cc: "Uwe Kleine-König" Cc: Lee Jones Cc: "David A. Schleef" Cc: Mori Hess Cc: Truxton Fulton Cc: linux-stag...@lists.linux.dev Cc: linux-...@vger.kernel.org Signed-off-by: Lee

Re: [PATCH 48/57] staging: comedi: drivers: jr3_pci: Remove set but unused variable 'min_full_scale'

-variable] Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman Cc: "Alexander A. Klimov" Cc: Anders Blomdell Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/comedi/drivers/jr3_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

On 15/04/2021 10:03, Marc Kleine-Budde wrote: > On 15.04.2021 09:55:35, Colin King wrote: >> From: Colin Ian King >> >> The pointer cf is being null checked earlier in the code, however the >> update of the rx_bytes statistics is dereferencing cf without null >>

Re: [RFC] Improve workload error in 'perf record'

On Wed, Apr 14, 2021 at 6:16 AM Arnaldo Carvalho de Melo wrote: > > Hi, > > Please take a look, > > Best regards, Acked-by: Ian Rogers Having been confused by this for a case in the past, thanks! It'd be nice for code coverage's sake to have a shel

Re: mmotm 2021-04-11-20-47 uploaded (ni_routes_test.c)

ld: drivers/staging/comedi/drivers/tests/ni_routes_test.o: in function `test_ni_sort_device_routes': ni_routes_test.c:(.text+0x16ef): undefined reference to `ni_sort_device_routes' Full randconfig file is attached. Hi all, That should be fixed by commit e7442ffe1cc5 ("staging: comedi:

Re: [PATCH][next] KEYS: trusted: Fix missing null return from kzalloc call

On 12/04/2021 17:48, James Bottomley wrote: > On Mon, 2021-04-12 at 17:01 +0100, Colin King wrote: >> From: Colin Ian King >> >> The kzalloc call can return null with the GFP_KERNEL flag so >> add a null check and exit via a new error exit label. Use the >> same e

Re: [PATCH] Staging: Remove line to fix checkpatch error

rated during the kernel build process. There is no point checking them with checkpatch.pl. If you are adding them to your git repository, then you are doing something wrong. -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=-

Re: [PATCH] xfs: fix return of uninitialized value in variable error

On 09/04/2021 15:28, Brian Foster wrote: > On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote: >> From: Colin Ian King >> >> A previous commit removed a call to xfs_attr3_leaf_read that >> assigned an error return code to variable error. We now have >>

cnic: issue with double assignment to ictx->xstorm_st_context.common.flags

Hi, Analysis of linux with Coverity has detected an issue with the assignment of ictx->xstorm_st_context.common.fla in drivers/net/ethernet/broadcom/cnic.c in function cnic_setup_bnx2x_ctx. This was introduced a while back with the following commit: commit 619c5cb6885b936c44ae1422ef805b69c629148

Re: [PATCH v3 2/4] kernfs: use VFS negative dentry caching

On Fri, 2021-04-09 at 16:26 +0800, Ian Kent wrote: > On Fri, 2021-04-09 at 01:35 +, Al Viro wrote: > > On Fri, Apr 09, 2021 at 09:15:06AM +0800, Ian Kent wrote: > > > + parent = kernfs_dentry_node(dentry->d_parent); > > > + if (parent) { > >

Re: [PATCH][next] mlxsw: spectrum_router: remove redundant initialization of variable force

On 29/03/2021 08:13, Ido Schimmel wrote: > On Sat, Mar 27, 2021 at 10:33:34PM +, Colin King wrote: >> From: Colin Ian King >> >> The variable force is being initialized with a value that is >> never read and it is being updated later with a new value. The >>

Re: [PATCH] clk: uniphier: Fix potential infinite loop

On 09/04/2021 07:46, Masahiro Yamada wrote: > On Thu, Apr 8, 2021 at 12:25 AM Colin King wrote: >> >> From: Colin Ian King >> >> The for-loop iterates with a u8 loop counter i and compares this >> with the loop upper limit of num_parents that is an int type. >

Re: [PATCH v3 2/4] kernfs: use VFS negative dentry caching

On Fri, 2021-04-09 at 01:35 +, Al Viro wrote: > On Fri, Apr 09, 2021 at 09:15:06AM +0800, Ian Kent wrote: > > + parent = kernfs_dentry_node(dentry->d_parent); > > + if (parent) { > > + const void *ns = NULL; > >

[PATCH v3 4/4] kernfs: use i_lock to protect concurrent inode updates

tiple processes concurrently updating the inode attributes and link count in kernfs_refresh_inode(). The inode i_lock seems like the sensible thing to use to protect these inode attribute updates so use it in kernfs_refresh_inode(). Signed-off-by: Ian Kent --- fs/kernfs/inode.c | 10 ++---

[PATCH v3 3/4] kernfs: switch kernfs to use an rwsem

The kernfs global lock restricts the ability to perform kernfs node lookup operations in parallel during path walks. Change the kernfs mutex to an rwsem so that, when opportunity arises, node searches can be done in parallel with path walk lookups. Signed-off-by: Ian Kent --- fs/kernfs/dir.c

[PATCH v3 2/4] kernfs: use VFS negative dentry caching

lookups. Signed-off-by: Ian Kent --- fs/kernfs/dir.c | 55 +-- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index 4c69e2af82dac..edfeee1bf38ec 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs

[PATCH v3 1/4] kernfs: move revalidate to be near lookup

ill need to call kernfs_find_ns(). So, to avoid a forward declaration, move it to be near kernfs_iop_lookup(). There's no functional change from this patch. Signed-off-by: Ian Kent --- fs/kernfs/dir.c | 86 --- 1 file changed, 43 insertion

[PATCH v3 0/4] kernfs: proposed locking and concurrency improvement

- drop the patch that tried to stay in rcu-walk mode. - drop the use a revision to identify if a directory has changed patch. Changes since v1: - fix locking in .permission() and .getattr() by re-factoring the attribute handling code. --- Ian Kent (4): kernfs: move revalidate to be near lo

[PATCH] perf arm-spe: Avoid potential buffer overrun.

SPE extended headers are >1 byte so ensure the buffer contains at least this before reading. This issue was detected by fuzzing. Signed-off-by: Ian Rogers --- tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/p

Re: [PATCH v2 1/6] perf metricgroup: Make find_metric() public with name change

On Thu, Mar 25, 2021 at 3:38 AM John Garry wrote: > > Function find_metric() is required for the metric processing in the > pmu-events testcase, so make it public. Also change the name to include > "metricgroup". Would it make more sense as "pmu_events_map__find_metri

re: drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal

Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal The ana

re: ALSA: control - add layer registration routines

Hi, Static analysis on linux-next with Coverity has detected a potential issue in the following commit: commit 3f0638a0333bfdd0549985aa620f2ab69737af47 Author: Jaroslav Kysela Date: Wed Mar 17 18:29:41 2021 +0100 ALSA: control - add layer registration routines The static analysis is as f

Re: [PATCH] mm/page_alloc: Add a bulk page allocator -fix -fix

On 30/03/2021 12:48, Mel Gorman wrote: > Colin Ian King reported the following problem (slightly edited) > > Author: Mel Gorman > Date: Mon Mar 29 11:12:24 2021 +1100 > > mm/page_alloc: add a bulk page allocator > > ... > >

re: mm/page_alloc: add a bulk page allocator

Hi, Static analysis on linux-next with Coverity has found a potential uninitialized variable issue in function __alloc_pages_bulk with the following commit: commit b0e0a469733fa571ddd8fe147247c9561b51b2da Author: Mel Gorman Date: Mon Mar 29 11:12:24 2021 +1100 mm/page_alloc: add a bulk pa

Periodic locking IO is causing server to stop responding

ory:fb10-fb1f So far we have not seen this on any of other servers on the same kernel version. Please let me know if I can provide anymore information, we have since restarted the server. Kind regards Ian Coetzee

re: drm/ttm: switch to per device LRU lock

Hi, Static analysis with Coverity in linux-next has detected an issue in drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: commit a1f091f8ef2b680a5184db065527612247cb4cae Author: Christian König Date: Tue Oct 6 17:26:42 2020 +0200 drm/ttm: switch to per device LRU lock Instead of

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

On Wed, Mar 24, 2021 at 6:54 AM Borislav Petkov wrote: > > On Wed, Mar 24, 2021 at 10:43:20AM -0300, Arnaldo Carvalho de Melo wrote: > > Borislav, was this addressed? Ian? > > Yap: > > https://git.kernel.org/tip/0705ef64d1ff52b817e278ca6e28095585ff31e1 Tested on PPC and

Re: [PATCH] x86/kprobes: Remove dead code

On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > The condition in switch statement `opcode & 0xf0` cannot evaluate to > 0xff. So this case statement will never execute. Remove it. > > Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for > single-step") > Signed-off-by: Muhammad U

Re: [PATCH][next] staging: rtl8188eu: Fix null pointer dereference on free_netdev call

On 24/03/2021 16:11, Martin Kaiser wrote: > Hello Colin, > > Thus wrote Colin King (colin.k...@canonical.com): > >> From: Colin Ian King > >> An unregister_netdev call checks if pnetdev is null, hence a later >> call to free_netdev can potentially be passing

re: x86/kprobes: Use int3 instead of debug trap for single-step

Hi, Static analysis on linux-next using Coverity has detected an issue in the following commit: commit 6256e668b7af9d81472e03c6a171630c08f8858a Author: Masami Hiramatsu Date: Wed Mar 3 00:25:46 2021 +0900 x86/kprobes: Use int3 instead of debug trap for single-step The analysis is as foll

Re: [RFC PATCH] autofs: find_autofs_mount overmounted parent support

On Tue, 2021-03-09 at 13:43 +0300, Alexander Mikhalitsyn wrote: > On Sat, 06 Mar 2021 17:13:32 +0800 > Ian Kent wrote: > > > On Fri, 2021-03-05 at 14:55 +0300, Alexander Mikhalitsyn wrote: > > > On Fri, 05 Mar 2021 18:10:02 +0800 > > > Ian Kent wrote: > >

Re: [PATCH RFC v2 8/8] selftests/perf: Add kselftest for remove_on_exec

s and Vince Weaver's tests [1]. It is possible to run standalone tests from within perf test by having them be executed by a shell test. Thanks, Ian [1] https://github.com/deater/perf_event_tests > Thanks, > -- Marco > > -- >8 -- > > diff --git a/tools/testing/sel

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

On 19/03/2021 15:54, Dan Schatzberg wrote: > On Thu, Mar 18, 2021 at 03:16:26PM +, Colin King wrote: >> From: Colin Ian King >> >> The 3rd argument to alloc_workqueue should be the max_active count, >> however currently it is the lo->lo_number that is intended

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

On 18/03/2021 20:12, Jens Axboe wrote: > On 3/18/21 9:16 AM, Colin King wrote: >> From: Colin Ian King >> >> The 3rd argument to alloc_workqueue should be the max_active count, >> however currently it is the lo->lo_number that is intended for the >> loop

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

On 11/02/2021 19:05, Stephen Boyd wrote: > Quoting Michael Tretter (2021-02-10 23:39:06) >> On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote: >>> Quoting Colin King (2021-02-10 10:49:38) >>>> From: Colin Ian King >>>> >>>> The pointer

Re: linux-next: build failure after merge of the tip tree

On Wed, Mar 17, 2021 at 3:54 AM Borislav Petkov wrote: > > + Ian. > > On Wed, Mar 17, 2021 at 03:08:58PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (native perf) > > failed like this: > >

Re: [PATCH] staging: comedi: das800: fix request_irq() warn

break userspace, so we are changing the parameters passed to request_irq() Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- drivers/staging/comedi/drivers/das800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/st

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

oid insn_init(struct insn *insn, const void *kaddr, int buf_len, int > x86_64); > -extern void insn_get_prefixes(struct insn *insn); > -extern void insn_get_opcode(struct insn *insn); > -extern void insn_get_modrm(struct insn *insn); > -extern void insn_get_sib(

[PATCH v2 1/3] perf test: Remove unused argument

Remove unused argument from daemon_exit. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/perf/tests/shell/daemon.sh b/tools/perf/tests/shell/daemon.sh index 5ad3ca8d681b..66ad56b4e0a5 100755

[PATCH v2 2/3] perf test: Cleanup daemon if test is interrupted.

Reorder daemon_start and daemon_exit as the trap handler is added in daemon_start referencing daemon_exit. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 34 +++- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/tools/perf/tests/shell

[PATCH v2 3/3] perf test: Add 30s timeout for wait for daemon start.

Retry the ping loop upto 600 times, or approximately 30 seconds, to make sure the test does hang at start up. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/tests/shell/daemon.sh b/tools/perf/tests/shell

Re: [PATCH] staging: comedi: replace slash in name

On 15/03/2021 20:00, Tong Zhang wrote: Thanks Ian, I have submitted a v2 patch based on your suggestions. Thanks, - Tong Thanks. I think the only other Comedi driver with the same problem is "drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as the nam

Re: [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn

: [1.574722] proc_mkdir+0x18/0x20 [1.576629] request_threaded_irq+0xfe/0x160 [1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- v2: revert changes to .name field so that we dont break userspace drivers/staging/comedi/drivers/cb

Re: [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn

: [1.639976] proc_mkdir+0x18/0x20 [1.641946] request_threaded_irq+0xfe/0x160 [1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- v2: revert changes to .name field so that we dont break userspace drivers/staging/comedi/drivers/

Re: [PATCH] staging: comedi: cb_pcidas: replace slash in name

.name = "pci-das1602/16/jr", > + .name = "pci-das1602-16-jr", > .ai_speed = 5000, > .fifo_size = 512, > .is_16bit = 1, > As for cb_pcidas64, the board n

Re: [PATCH] staging: comedi: replace slash in name

On 15/03/2021 10:44, Ian Abbott wrote: > On 14/03/2021 03:57, Tong Zhang wrote: >> request_irq() wont accept a name which contains slash so we need to >> repalce it with something else -- otherwise it will trigger a warning >> and the entry in /proc/irq/ will not be create

Re: [PATCH] staging: comedi: replace slash in name

static const struct pcidas64_board pcidas64_boards[] = { > .has_8255 = 0, > }, > [BOARD_PCIDAS4020_12] = { > - .name = "pci-das4020/12", > + .name = "pci-das4020-12", > .

Re: pinctrl: core: Handling pinmux and pinconf separately

On 12/03/2021 12:45, Andy Shevchenko wrote: > On Thu, Mar 11, 2021 at 1:26 PM Colin Ian King > wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> On 3/11/21 11:57 AM, Colin Ian King wrote: > >>>> For the PIN_MAP_TYPE_CONFIGS_PIN and PIN_MAP_TYPE_CONFIG

Re: [PATCH] pinctrl: core: Set ret to 0 when group is skipped

ze ret to 0 to avoid uninitialized ret value in first > loop or reusing ret value from first loop in second. > > Addresses-Coverity: ("Uninitialized variables") > Signed-off-by: Michal Simek > CC: Colin Ian King > CC: Dan Carpenter > --- > > drivers/pinctrl/c

Re: [PATCH][next] nvmem: core: Fix unintentional sign extension issue

On 11/03/2021 17:12, Doug Anderson wrote: > Hi, > > On Thu, Mar 11, 2021 at 1:53 AM Colin King wrote: >> >> From: Colin Ian King >> >> The shifting of the u8 integer buf[3] by 24 bits to the left will >> be promoted to a 32 bit signed int and then sign-

Re: [PATCH 2/3] perf test: Cleanup daemon if test is interrupted.

On Thu, Mar 11, 2021 at 2:38 AM Jiri Olsa wrote: > > On Wed, Mar 10, 2021 at 12:41:17PM -0800, Ian Rogers wrote: > > Reorder daemon_start and daemon_exit as the trap handler is added in > > daemon_start referencing daemon_exit. > > makes sense, minor comments below >

Re: pinctrl: core: Handling pinmux and pinconf separately

On 11/03/2021 11:28, Michal Simek wrote: > > > On 3/11/21 12:24 PM, Colin Ian King wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> >>> >>> On 3/11/21 11:57 AM, Colin Ian King wrote: >>>> Hi, >>>> >>>> Static an

Re: pinctrl: core: Handling pinmux and pinconf separately

On 11/03/2021 11:16, Michal Simek wrote: > > > On 3/11/21 11:57 AM, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next with Coverity has found a potential issue >> in drivers/pinctrl/core.c with the following commit: >> >> commit 0952b

re: scsi: sg: Replace sg_allow_access()

Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/scsi/sg.c in function sg_remove_sfp_usercontext with the following recent commit: commit 0c32296d73ec5dec64729eb555f1a29ded8a7272 Author: Douglas Gilbert Date: Fri Feb 19 21:00:28 2021 -0500 scsi: sg: Replace

re: pinctrl: core: Handling pinmux and pinconf separately

Hi, Static analysis on linux-next with Coverity has found a potential issue in drivers/pinctrl/core.c with the following commit: commit 0952b7ec1614abf232e921aac0cc2bca8e60e162 Author: Michal Simek Date: Wed Mar 10 09:16:54 2021 +0100 pinctrl: core: Handling pinmux and pinconf separately

re: scsi: sg: NO_DXFER move to/from kernel buffers

Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/scsi/sg.c with the following recent commit: commit b32ac463cb59e758b4560260fd168a2b4ea6e81a Author: Douglas Gilbert Date: Fri Feb 19 21:00:54 2021 -0500 scsi: sg: NO_DXFER move to/from kernel buffers The ana

[PATCH 3/3] perf test: Add 30s timeout for wait for daemon start.

Retry the ping loop upto 600 times, or approximately 30 seconds, to make sure the test does hang at start up. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/tests/shell/daemon.sh b/tools/perf/tests/shell

[PATCH 1/3] perf test: Remove unused argument

Remove unused argument from daemon_exit. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/perf/tests/shell/daemon.sh b/tools/perf/tests/shell/daemon.sh index 5ad3ca8d681b..66ad56b4e0a5 100755

[PATCH 2/3] perf test: Cleanup daemon if test is interrupted.

Reorder daemon_start and daemon_exit as the trap handler is added in daemon_start referencing daemon_exit. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/daemon.sh | 34 +++- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/tools/perf/tests/shell

[PATCH] perf synthetic events: Avoid write of uninitialized memory.

Account for alignment bytes in the zero-ing memset. Signed-off-by: Ian Rogers --- tools/perf/util/synthetic-events.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c index b698046ec2db

[PATCH] tools include: Add __sum16 and __wsum definitions.

/types.h then I say it is preferred. Signed-off-by: Ian Rogers --- tools/include/linux/types.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/include/linux/types.h b/tools/include/linux/types.h index e9c5a215837d..6e14a533ab4e 100644 --- a/tools/include/linux/types.h +++ b/tools

Re: [RFC PATCH] autofs: find_autofs_mount overmounted parent support

On Fri, 2021-03-05 at 14:55 +0300, Alexander Mikhalitsyn wrote: > On Fri, 05 Mar 2021 18:10:02 +0800 > Ian Kent wrote: > > > On Thu, 2021-03-04 at 13:11 +0300, Alexander Mikhalitsyn wrote: > > > On Thu, 04 Mar 2021 14:54:11 +0800 > > > Ian Kent wrote: > >

[PATCH 2/3] perf tool: Enable warnings when compiling BPF programs

Add -Wall -Werror when compiling BPF skeletons. Signed-off-by: Ian Rogers --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 5345ac70cd83..f43d2551f3de 100644 --- a/tools/perf/Makefile.perf

[PATCH 3/3] perf bpf: Minor whitespace cleanup.

Missed space after #include. Signed-off-by: Ian Rogers --- tools/perf/util/bpf_counter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/bpf_counter.h b/tools/perf/util/bpf_counter.h index 2eca210e5dc1..cb9c532e0a07 100644 --- a/tools/perf/util/bpf_counter.h

[PATCH 1/3] perf skel: Remove some unused variables.

Fixes -Wall warnings. Signed-off-by: Ian Rogers --- tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c index c7cec92d0236

Re: [RFC PATCH] autofs: find_autofs_mount overmounted parent support

On Thu, 2021-03-04 at 13:11 +0300, Alexander Mikhalitsyn wrote: > On Thu, 04 Mar 2021 14:54:11 +0800 > Ian Kent wrote: > > > On Wed, 2021-03-03 at 18:28 +0300, Alexander Mikhalitsyn wrote: > > > It was discovered that find_autofs_mount() function > > > in aut

net: mscc: ocelot: issue with uninitialized pointer read in ocelot_flower_parse_key

Hi, Static analysis with Coverity had detected an uninitialized pointer read in function ocelot_flower_parse_key in drivers/net/ethernet/mscc/ocelot_flower.c introduced by commit: commit 75944fda1dfe836fdd406bef6cb3cc8a80f7af83 Author: Xiaoliang Yang Date: Fri Oct 2 15:02:23 2020 +0300 ne

Re: [RFC PATCH] autofs: find_autofs_mount overmounted parent support

independent and intuitively this is a bug but what is the actual use and expected result. But anyway, aren't you saying that the VFS path walk isn't handling mount namespaces properly or are you saying that a process outside this new mount namespace becomes broken because of it? Either wa

Re: [PATCH] usb: dwc3: Fix dereferencing of null dwc->usb_psy

On 03/03/2021 21:29, Heiko Thiery wrote: > Hi all, > >> On Wed, Mar 3, 2021 at 6:00 PM Colin King wrote: >>> >>> From: Colin Ian King >>> >>> Currently the null check logic on dwc->usb_psy is inverted as it allows >>> calls to power_su

Re: f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

On 03/03/2021 19:44, Jaegeuk Kim wrote: > On 03/02, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next detected a potential uninitialized >> variable dn.node_changed that does not get set when a call to >> f2fs_get_node_page() fails. This uninitializ

re: drm/amd/display: Implement dmub trace event

Hi, Static analysis on linux-next wit Coverity has found a potential null pointer dereference in commit: commit 70732504c53b2d3aae2cebc457515a304672d5bb Author: Yongqiang Sun Date: Fri Feb 19 14:50:23 2021 -0500 drm/amd/display: Implement dmub trace event The analysis is as follows: 400

Re: [PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

On 03/03/2021 09:46, Miquel Raynal wrote: > Hi Colin, > > Colin King wrote on Wed, 3 Mar 2021 > 09:42:46 +: > >> From: Colin Ian King >> >> The less than zero comparison with status is always false because status >> is a u8. Fix this by using

f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

Hi, Static analysis on linux-next detected a potential uninitialized variable dn.node_changed that does not get set when a call to f2fs_get_node_page() fails. This uninitialized value gets used in the call to f2fs_balance_fs() that may or not may not balances dirty node and dentry pages depending

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

On 02/03/2021 08:44, Krzysztof Kozlowski wrote: > On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently the array gpmc_cs is indexed by cs before it cs is range checked >> and the pointer read from this out-of-index rea

[PATCH] perf trace: Ensure read cmdlines are null terminated.

Issue detected by address sanitizer. Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing header) Signed-off-by: Ian Rogers --- tools/perf/util/trace-event-read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace

[PATCH] perf tools: Fix documentation of verbose options

Option doesn't take a value, make sure the man pages agree. For example: $ perf evlist --verbose=1 Error: option `verbose' takes no value Signed-off-by: Ian Rogers --- tools/perf/Documentation/perf-evlist.txt | 2 +- tools/perf/Documentation/perf-ftrace.txt | 4 ++--

re: cifs: Retain old ACEs when converting between mode bits and ACL.

Hi, Static analysis on linux-next with Coverity had detected a potential null pointer dereference with the following commit: commit f5065508897a922327f32223082325d10b069ebc Author: Shyam Prasad N Date: Fri Feb 12 04:38:43 2021 -0800 cifs: Retain old ACEs when converting between mode bits

  1   2   3   4   5   6   7   8   9   10   >