Re: [PATCH v2] IB/mlx4: Increase the timeout for CM cache

2019-02-17 Thread jackm
On Sun, 17 Feb 2019 15:45:12 +0100 Håkon Bugge wrote: > Using CX-3 virtual functions, either from a bare-metal machine or > pass-through from a VM, MAD packets are proxied through the PF driver. > > Since the VF drivers have separate name spaces for MAD Transaction Ids > (TIDs), the PF driver ha

Re: [PATCH] mlx4_ib: Increase the timeout for CM cache

2019-02-06 Thread jackm
On Wed, 6 Feb 2019 16:40:14 +0100 Håkon Bugge wrote: > Jack, > > A major contributor to the long processing time in the PF driver > proxying QP1 packets is: > > create_pv_resources >-> ib_create_cq(ctx->ib_dev, mlx4_ib_tunnel_comp_handler, >NULL, ctx, cq_si

Re: [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate agent number (fwd)

2018-06-16 Thread jackm
On Sat, 16 Jun 2018 18:04:41 +0200 (CEST) Julia Lawall wrote: > ib_mad_client_id is declared as u32, so it will not be < 0 (line 382). > > julia > Julia, your are correct. However, I was under the impression that this patch set was abandoned in favor of the one submitted by Matthew Wilcox! (Con

Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs

2018-06-13 Thread jackm
On Fri, 8 Jun 2018 10:42:18 -0700 Matthew Wilcox wrote: > From: Matthew Wilcox > > Allocate agent IDs from a global IDR instead of an atomic variable. > This eliminates the possibility of reusing an ID which is already in > use after 4 billion registrations, and we can also limit the assigned

Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs

2018-06-12 Thread jackm
On Fri, 8 Jun 2018 10:42:18 -0700 Matthew Wilcox wrote: > + rcu_read_lock(); > + mad_agent = idr_find(&ib_mad_clients, hi_tid); > + if (mad_agent > && !atomic_inc_not_zero(&mad_agent->refcount)) > + mad_agent = NULL; > + rcu_rea

Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs

2018-06-11 Thread jackm
On Mon, 11 Jun 2018 10:19:18 -0600 Jason Gunthorpe wrote: > On Mon, Jun 11, 2018 at 09:19:14AM +0300, jackm wrote: > > On Sun, 10 Jun 2018 22:42:03 -0600 > > Jason Gunthorpe wrote: > > > > > Er, the spec has nothing to do with this. In Linux the TID is made >

Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs

2018-06-10 Thread jackm
On Sun, 10 Jun 2018 22:42:03 -0600 Jason Gunthorpe wrote: > Er, the spec has nothing to do with this. In Linux the TID is made > unique because the core code provides 32 bits that are unique and the > user provides another 32 bits that are unique. The driver cannot > change any of those bits with

Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number

2018-05-30 Thread jackm
On Tue, 29 May 2018 12:54:45 +0300 Leon Romanovsky wrote: > On Tue, May 29, 2018 at 11:54:59AM +0300, Leon Romanovsky wrote: > > On Tue, May 29, 2018 at 09:38:08AM +0200, Hans Westgaard Ry wrote: > > > The agent TID is a 64 bit value split in two dwords. The least > > > significant dword is th

Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number

2018-05-30 Thread jackm
On Tue, 29 May 2018 10:40:32 -0600 Jason Gunthorpe wrote: > On Tue, May 29, 2018 at 06:16:14PM +0200, Håkon Bugge wrote: > > > > > On 29 May 2018, at 17:49, Jason Gunthorpe wrote: > > > > > > On Tue, May 29, 2018 at 09:38:08AM +0200, Hans Westgaard Ry > > > wrote: > > >> The agent TID is a

Re: [PATCH] IB/core: Make ib_mad_client_id atomic

2018-04-30 Thread jackm
On Mon, 30 Apr 2018 13:10:49 -0400 Doug Ledford wrote: Looks good! -Jack > On Mon, 2018-04-30 at 08:49 -0600, Jason Gunthorpe wrote: > > On Mon, Apr 23, 2018 at 10:16:18PM +0300, jackm wrote: > > > > > > > TIDs need to be globally unique on the entire machine

Re: [PATCH] IB/core: Make ib_mad_client_id atomic

2018-04-26 Thread jackm
On Thu, 26 Apr 2018 18:06:10 +0200 Håkon Bugge wrote: > > On 23 Apr 2018, at 21:16, jackm wrote: > > > > On Mon, 23 Apr 2018 16:19:57 +0200 > > Håkon Bugge wrote: > > > > > >>> > >>> This actually looks like

Re: [PATCH] IB/core: Make ib_mad_client_id atomic

2018-04-23 Thread jackm
On Mon, 23 Apr 2018 16:19:57 +0200 Håkon Bugge wrote: > > > > This actually looks like a genuine bug, why is it described only as > > 'confusing'? ib_register_mad_agent is callable from userspace, so at > > least two userspace agents can race and get the same TID’s. > > My understanding is t