soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
Add support to ov772x driver for frame intervals handling and enumeration.
Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for
10, 15 and 30 frame per second rates.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/ov772x.c | 212
o the end of the series to silence 0-day bot
- Renamed tw9910 clock to 'xti' as per video decoder manual
- Changed all SPDX identifiers to GPL-2.0 from previous GPL-2.0+
v1->v2:
- DT
-- Addressed Geert's comments and added clocks for CEU to mstp6 clock source
-- Specified suppor
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1661 +
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Hi Todor,
thanks for the patch.
Is the datsheet for this sensor public? I failed to find any reference
to it online, am I wrong?
On Thu, Feb 08, 2018 at 10:53:38AM +0200, Todor Tomov wrote:
> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image
> Sensor from Omnivision.
>
>
Hi Geert,
thanks for review
On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
> wrote:
> > Add initial PFC support for R-Car M3-N (r8a77965) SoC.
> > No groups or functions defined
Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965)
SoC.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt
b/Documentation/devicetree
Add support for R-Car M3-N (r8a77965) power areas and reset.
M3-N power areas are identical to M3-W ones, so just copy and rename
them.
Signed-off-by: Jacopo Mondi
---
.../bindings/power/renesas,rcar-sysc.txt | 1 +
.../devicetree/bindings/reset/renesas,rst.txt | 1 +
drivers
Add initial support for R-Car M3-N Salvator-x and r8a77965 SoC in
device tree with cpg-mssr, reset and clock nodes.
Add place-holder device nodes for all nodes referred by
"salvator-common.dtsi"
Signed-off-by: Jacopo Mondi
---
arch/arm64/Kconfig.platforms |
Add documentation for r8a77965 compatible string to rcar-dmac device
tree bindings documentation.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar
Add documentation for r8a77965 compatible string to reneass sci-serial
device tree bindings documentation.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings
Add dmac[0-2] device nodes for R-Car M3-N (r8a77965) SoC.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 96 ++-
1 file changed, 93 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
b/arch/arm64/boot
Add SCIF[0-5] groups and pin function definitions for R-Car M3-N.
Signed-off-by: Jacopo Mondi
---
drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 296 ++
1 file changed, 296 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
b/drivers/pinctrl/sh-pfc/pfc
Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
drivers/gpio/gpio-rcar.c | 4
2 files changed, 5 insertions(+)
diff --git a/Documentation
Add documentation for r8a77965 compatible string to renesas ravb device
tree bindings documentation.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 85 ---
1 file changed, 79 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
b/arch/arm64/boot/dts
Add EtherAVB groups and functions definitions for R-Car M3-N.
Signed-off-by: Jacopo Mondi
---
drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 110 ++
1 file changed, 110 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
b/drivers/pinctrl/sh-pfc/pfc
Populate the ethernet@e680 device node to enable Ethernet interface
for R-Car M3-N (r8a77965) SoC.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot
Add initial PFC support for R-Car M3-N (r8a77965) SoC.
No groups or functions defined, just pin and registers enumeration.
Signed-off-by: Jacopo Mondi
---
.../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 +
drivers/pinctrl/sh-pfc/Kconfig |5 +
drivers/pinctrl/sh
Initial support for R-Car M3-N (r8a77965), including core and module
clocks.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/clock/renesas,cpg-mssr.txt | 1 +
drivers/clk/renesas/Kconfig| 5 +
drivers/clk/renesas/Makefile | 1
Add GPIO nodes to r8a77965 SoC device tree file.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 152 +++---
1 file changed, 120 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
b/arch/arm64/boot/dts
the exception of
a missing PLL line used to power M3-W Cortex-A53 little cores, not present in
M3-N.
Few functionalities have currently been enabled in DTS and tested: serial
boot console, EtherAVB and gpios (tested as ethernet interface reset).
Thanks
j
Jacopo Mondi (15):
Documentation
Hi Laurent,
thanks for review
Resuming here the brief conversation on #v4l with you and Hans...
On Wed, Jan 31, 2018 at 12:34:59PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tuesday, 30 January 2018 11:58:18 EET Jacopo Mondi wrote:
>
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/renesas,ceu.txt | 81 ++
1 file changed, 81 insertions
forms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 11 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov772x.c | 172 ++---
include/media/i2c/ov772x.h | 6
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1661 +
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
chitecture specific part from CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/sh/boards/mach-migor/setup.c | 225 +++--
arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
2 files changed, 101 insertions(+), 126
-compliance, which supplies a mbus format description
structure and checks for all fields to be properly set.
Without this commit, v4l2-compliance fails when testing formats with:
fail: v4l2-test-formats.cpp(335): ycbcr_enc >= 0xff
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov7670.c | 4
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Add support to ov772x driver for frame intervals handling and enumeration.
Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for
10, 15 and 30 frame per second rates.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 210
10 and ov772x) drivers headers and drivers to close
remarks from Hans and Laurent:
--- Removed platform callbacks and handle clocks and gpios from sensor drivers
--- Remove g/s_mbus_config operations
Jacopo Mondi (11):
dt-bindings: media: Add Renesas CEU bindings
include: media: Add Renesas CEU dr
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch
Hi Laurent,
On Mon, Jan 29, 2018 at 01:01:01PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Friday, 26 January 2018 15:55:26 EET Jacopo Mondi wrote:
> > Add support to ov772x driver for frame intervals handling and enumeration.
> >
Hi Geert,
On Thu, Jan 25, 2018 at 03:39:32PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
[snip]
> >> > ---
> >> > drivers/sh/clk/core.c | 9 ++---
> >> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
> >> > index 928
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1661 +
forms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 11 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov772x.c | 169 ++---
include/media/i2c/ov772x.h | 6
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
chitecture specific part from CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/sh/boards/mach-migor/setup.c | 225 +++--
arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
2 files changed, 101 insertions(+), 126
-compliance, which supplies a mbus format description
structure and checks for all fields to be properly set.
Without this commit, v4l2-compliance fails when testing formats with:
fail: v4l2-test-formats.cpp(335): ycbcr_enc >= 0xff
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov7670.c | 4
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch
Add support to ov772x driver for frame intervals handling and enumeration.
Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for
10, 15 and 30 frame per second rates.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 315
vers headers and drivers to close
remarks from Hans and Laurent:
--- Removed platform callbacks and handle clocks and gpios from sensor drivers
--- Remove g/s_mbus_config operations
Jacopo Mondi (11):
dt-bindings: media: Add Renesas CEU bindings
include: media: Add Renesas CEU driver interfa
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/renesas,ceu.txt | 81 ++
1 file changed, 81 insertions
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/renesas,ceu.txt | 81 ++
1 file changed, 81 insertions
UUUPS
please ignore this submission as it contains patches from a previous
version (you may have noticed some patches in the series reports
[xx/09] in the subject).
I will resend.
Sorry for the noise
On Fri, Jan 26, 2018 at 02:48:32PM +0100, Jacopo Mondi wrote:
> Hello,
> 7th round f
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1659 +
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
chitecture specific part from CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/sh/boards/mach-migor/setup.c | 225 +++--
arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
2 files changed, 101 insertions(+), 126
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
chitecture specific part from CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/sh/boards/mach-migor/setup.c | 225 +++--
arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
2 files changed, 101 insertions(+), 126
Add support to ov772x driver for frame intervals handling and enumeration.
Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for
10, 15 and 30 frame per second rates.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 315
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
forms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 11 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov772x.c | 169 ++---
include/media/i2c/ov772x.h | 6
vers headers and drivers to close
remarks from Hans and Laurent:
--- Removed platform callbacks and handle clocks and gpios from sensor drivers
--- Remove g/s_mbus_config operations
Jacopo Mondi (11):
dt-bindings: media: Add Renesas CEU bindings
include: media: Add Renesas CEU driver interfa
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1661 +
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch
Hi Geert,
On Thu, Jan 25, 2018 at 02:53:41PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> CC linux-clk (yes I know this is about the legacy SH clock framework, but
> the public API is/should be the same)
>
> On Thu, Jan 25, 2018 at 12:24 PM, Jacopo Mondi
> wrote:
>
match test, allowing selection of clock rates
immediately slower than the required one.
Signed-off-by: Jacopo Mondi
---
Hello renesas lists,
I'm now working on handling frame rate for the ov7720 image sensor to have that
driver accepted as part of v4l2. The sensor is installed on on Migo-R
ation
- Addressed Sakari's comments on v1
- Check for return values of register writes in set_fmt()
- TODO: decide if "pll-bypass" should be an OF property.
Jacopo Mondi (2):
media: dt-bindings: Add OF properties to ov7670
v4l2: i2c: ov7670: Implement OF mbus configurat
data to suppress pixel clock output during horizontal
blanking.
While at there, check return value of register writes in set_fmt
function and rationalize spacings.
Signal polarities and pixel clock blanking verified through scope and
image capture.
Signed-off-by: Jacopo Mondi
---
drivers/media
description while at there.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/media/i2c/ov7670.txt | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov7670.txt
b/Documentation/devicetree/bindings/media
Hi Randy,
thanks for noticing,
On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote:
> On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
> > Hello,
> >new version of CEU after Hans' review.
> >
> > Added his Acked-by to most patches and closed review comme
Hi Hans,
On Fri, Jan 19, 2018 at 12:26:09PM +0100, Hans Verkuil wrote:
> Hi Jacopo,
>
> On 01/16/18 22:44, Jacopo Mondi wrote:
> > Hello,
> >new version of CEU after Hans' review.
> >
> > Added his Acked-by to most patches and closed review comments.
&g
Hi Hans,
On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote:
> On 21/01/18 11:21, Hans Verkuil wrote:
> > On 21/01/18 10:53, jacopo mondi wrote:
> >> Hi Hans,
> >>
> >> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
> >>>
Hi Sakari,
On Fri, Jan 19, 2018 at 12:26:48AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Fri, Jan 12, 2018 at 06:56:48PM +0100, Jacopo Mondi wrote:
[snip]
> > +static int ov7670_parse_dt(struct device *dev,
> > + struct ov7670_info *info)
> > +
> > + ret = devm_request_irq(dev, irq, ceu_irq,
> > + 0, dev_name(dev), ceudev);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Unable to request CEU interrupt.\n");
> > + goto error_free_ceudev;
> > + }
> > +
> > + pm_runtime_enable(dev);
> > +
> > + ret = v4l2_device_register(dev, &ceudev->v4l2_dev);
> > + if (ret)
> > + goto error_pm_disable;
> > +
> > + if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
> > + ceu_data = of_match_device(ceu_of_match, dev)->data;
> > + num_subdevs = ceu_parse_dt(ceudev);
> > + } else if (dev->platform_data) {
> > + /* Assume SH4 if booting with platform data. */
> > + ceu_data = &ceu_data_sh4;
> > + num_subdevs = ceu_parse_platform_data(ceudev,
> > + dev->platform_data);
> > + } else {
> > + num_subdevs = -EINVAL;
> > + }
> > +
> > + if (num_subdevs < 0) {
> > + ret = num_subdevs;
> > + goto error_v4l2_unregister;
> > + }
> > + ceudev->irq_mask = ceu_data->irq_mask;
> > +
> > + ceudev->notifier.v4l2_dev = &ceudev->v4l2_dev;
> > + ceudev->notifier.subdevs= ceudev->asds;
> > + ceudev->notifier.num_subdevs= num_subdevs;
> > + ceudev->notifier.ops= &ceu_notify_ops;
> > + ret = v4l2_async_notifier_register(&ceudev->v4l2_dev,
> > + &ceudev->notifier);
> > + if (ret)
> > + goto error_v4l2_unregister;
> > +
> > + dev_info(dev, "Renesas Capture Engine Unit %s\n", dev_name(dev));
> > +
> > + return 0;
> > +
> > +error_v4l2_unregister:
> > + v4l2_device_unregister(&ceudev->v4l2_dev);
> > +error_pm_disable:
> > + pm_runtime_disable(dev);
> > +error_free_ceudev:
> > + kfree(ceudev);
> > +
> > + return ret;
> > +}
> > +
> > +static int ceu_remove(struct platform_device *pdev)
> > +{
> > + struct ceu_device *ceudev = platform_get_drvdata(pdev);
> > +
> > + pm_runtime_disable(ceudev->dev);
> > +
> > + v4l2_async_notifier_unregister(&ceudev->notifier);
> > +
> > + v4l2_device_unregister(&ceudev->v4l2_dev);
> > +
> > + video_unregister_device(&ceudev->vdev);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct dev_pm_ops ceu_pm_ops = {
> > + SET_RUNTIME_PM_OPS(ceu_runtime_suspend,
> > + ceu_runtime_resume,
> > + NULL)
> > +};
> > +
> > +static struct platform_driver ceu_driver = {
> > + .driver = {
> > + .name = DRIVER_NAME,
> > + .pm = &ceu_pm_ops,
> > + .of_match_table = of_match_ptr(ceu_of_match),
> > + },
> > + .probe = ceu_probe,
> > + .remove = ceu_remove,
> > +};
> > +
> > +module_platform_driver(ceu_driver);
> > +
> > +MODULE_DESCRIPTION("Renesas CEU camera driver");
> > +MODULE_AUTHOR("Jacopo Mondi ");
> > +MODULE_LICENSE("GPL v2");
> >
>
> Regards,
>
> Hans
rote:
> > >> On 01/16/18 22:44, Jacopo Mondi wrote:
> > >>> Remove soc_camera framework dependencies from ov772x sensor driver.
> > >>> - Handle clock and gpios
> > >>> - Register async subdevice
> > >>> - Remove soc_camera s
Hi Sakari,
it's the second series this week where I fail to handle BT.656
properly, sorry about this :)
On Wed, Jan 17, 2018 at 09:59:59AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Jan 16, 2018 at 10:44:53PM +0100, Jacopo Mondi wrote:
> > Add bindings docum
forms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 11 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov772x.c | 169 ++---
include/media/i2c/ov772x.h | 6
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
chitecture specific part from CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/sh/boards/mach-migor/setup.c | 225 +++--
arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
2 files changed, 101 insertions(+), 126
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/renesas,ceu.txt | 81 ++
1 file changed, 81 insertions
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file
moved soc_camera legacy operations g/s_mbus_format
-- Update to new notifier implementation
-- Fixed several comments from Hans, Laurent and Sakari
- Migo-R
-- Register clocks and gpios for sensor drivers in Migo-R setup
-- Updated sensors (tw9910 and ov772x) drivers headers and drivers to close
rem
RZ
platform GR-Peach.
Tested with ov7725 camera sensor on SH4 platform Migo-R.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/Kconfig |9 +
drivers/media/platform/Makefile |1 +
drivers/media/platform/renesas-ceu.c | 1659 +
v3 I guess, since then it has not changed.
I will include that in v6 cover letter.
> On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> > Add driver for Renesas Capture Engine Unit (CEU).
> >
> > The CEU interface supports capturing 'data' (YUV422) and 'images'
>
Hi Hans,
On Tue, Jan 16, 2018 at 11:08:17AM +0100, Hans Verkuil wrote:
> On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> > Remove soc_camera framework dependencies from ov772x sensor driver.
> > - Handle clock and gpios
> > - Register async subdevice
> > - Remove soc_came
Hello Hans,
On Fri, Jan 12, 2018 at 04:27:50PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Friday, 12 January 2018 16:04:00 EET Jacopo Mondi wrote:
> > Hello,
> >(hopefully) last round for CEU driver.
> >
> > Changelog is quite thin, I have updated C
kari's comments on v1
- Check for return values of register writes in set_fmt()
- TODO: decide if "pll-bypass" should be an OF property.
Jacopo Mondi (2):
media: dt-bindings: Add OF properties to ov7670
v4l2: i2c: ov7670: Implement OF mbus configuration
.../devi
child nodes description while at there.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/media/i2c/ov7670.txt | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov7670.txt
b/Documentation/devicetree
data to suppress pixel clock output during horizontal
blanking.
While at there, check return value of register writes in set_fmt
function and rationalize spacings.
Signal polarities and pixel clock blanking verified through scope and
image capture.
Signed-off-by: Jacopo Mondi
---
drivers/media
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi
forms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 11 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov772x.c | 177 ++---
include/media/i2c/ov772x.h | 6
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent
soc_camera based driver as long
as other platforms depends on soc_camera-based CEU driver.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 9 +++
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9910.c | 162
701 - 800 of 949 matches
Mail list logo
