kselftests for memory.oom.group

2018-09-07 Thread jgkamat
Here is the third version of the patchset. Changes since the last patchset: - Updated commit message of first patch to clarify fixes - Add ack from Roman There should be no code changes since the last patchset. Let me know if any improvements can be made, and thanks for your time! -Jay

[PATCH v3 1/2] Fix cg_read_strcmp()

2018-09-07 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings. Previously, this function read to a size = 1 buffer when comparing against empty strings, which would lead to cg_read_strcmp() co

[PATCH v3 2/2] Add tests for memory.oom.group

2018-09-07 Thread jgkamat
From: Jay Kamat Add tests for memory.oom.group for the following cases: - Killing all processes in a leaf cgroup, but leaving the parent untouched - Killing all processes in a parent and leaf cgroup - Keeping processes marked by OOM_SCORE_ADJ_MIN alive when considered for being killed by the

kselftests for memory.oom.group

2018-09-07 Thread jgkamat
Here is an amended patch which fixes those issues. Please let me know if you see anything else that could be improved. Changes since the last patchset: - Use if statement to check for empty string in cgroup_util.c - Cleanup and return properly when failing to kill process in test_memcg_oom_gro

[PATCH 2/2] Add tests for memory.oom.group

2018-09-07 Thread jgkamat
From: Jay Kamat Add tests for memory.oom.group for the following cases: - Killing all processes in a leaf cgroup, but leaving the parent untouched - Killing all processes in a parent and leaf cgroup - Keeping processes marked by OOM_SCORE_ADJ_MIN alive when considered for being killed by the

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests") Signed-off-b

kselftests for memory.oom.group

2018-09-04 Thread jgkamat
Hi Shuah, I wrote some tests for the new memory.oom.group feature in cgroups 2. In the process, I discovered a few small bugs in the cgroups tests, which I have fixed as well in a separate commit. This is my first ever patch to Linux, so let me know if you see any issues or improvements that can

[PATCH 2/2] Add tests for memory.oom.group

2018-09-04 Thread jgkamat
From: Jay Kamat Add tests for memory.oom.group for the following cases: - Killing all processes in a leaf cgroup, but leaving the parent untouched - Killing all processes in a parent and leaf cgroup - Keeping processes marked by OOM_SCORE_ADJ_MIN alive when considered for being killed by the

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-04 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests") Signed-off-b