[PATCH] mfd: twl: endian fixups in i2c write and read wrappers.

2019-10-13 Thread jic23
From: Jonathan Cameron Use a local variable to ensure correct endian types for intermediate results. Identified by sparse when building the IIO driver. Signed-off-by: Jonathan Cameron Cc: Lee Jones --- include/linux/mfd/twl.h | 12 1 file changed, 8 insertions(+), 4 deletions(-)

Re: [PATCH 1/3] iio: adxl372: Provide validate_trigger and validate_device callbacks

2018-08-20 Thread jic23
On 20.08.2018 16:47, Lars-Peter Clausen wrote: On 08/20/2018 04:53 PM, Stefan Popa wrote: This patch provides a validate_device callback for the trigger which makes sure that other devices are rejected. Signed-off-by: Stefan Popa @@ -762,11 +762,24 @@ static int adxl372_dready_trig_set_state(s

Re: [PATCH 0/4] IIO wrapper drivers, dpot-dac and envelope-detector

2016-10-21 Thread jic23
On 20.10.2016 19:17, Peter Rosin wrote: On 2016-10-20 19:37, Jonathan Cameron wrote: On 20 October 2016 18:30:19 BST, Jonathan Cameron wrote: On 20 October 2016 13:55:12 BST, Lars-Peter Clausen wrote: On 10/20/2016 11:25 AM, Peter Rosin wrote: Also, is there some agreed-upon way to dig out t

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-29 Thread jic23
On 28.09.2016 18:39, Dmitry Torokhov wrote: On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander wrote: From: Roderick Colenbrander This patch introduces new axes for acceleration and angular velocity. David Herrmann's work served as a base, but we extended the specification with various

Re: [PATCH 1/1] iio: adc: Add driver for the TI INA3221 Triple Current/Voltage Monitor

2016-04-12 Thread jic23
On 12.04.2016 09:34, ji...@jic23.retrosnub.co.uk wrote: On 11.04.2016 19:08, Guenter Roeck wrote: On Mon, Apr 11, 2016 at 11:47:44AM -0500, Andrew F. Davis wrote: On 04/11/2016 11:38 AM, Guenter Roeck wrote: > On Mon, Apr 11, 2016 at 10:48:27AM -0500, Andrew F. Davis wrote: >> On 04/1

Re: [PATCH 1/1] iio: adc: Add driver for the TI INA3221 Triple Current/Voltage Monitor

2016-04-12 Thread jic23
On 11.04.2016 19:08, Guenter Roeck wrote: On Mon, Apr 11, 2016 at 11:47:44AM -0500, Andrew F. Davis wrote: On 04/11/2016 11:38 AM, Guenter Roeck wrote: > On Mon, Apr 11, 2016 at 10:48:27AM -0500, Andrew F. Davis wrote: >> On 04/10/2016 06:57 AM, Jonathan Cameron wrote: >>> On 08/04/16 19:19, And

Re: [PATCH 1/1] iio: adc: Add driver for the TI INA3221 Triple Current/Voltage Monitor

2016-04-12 Thread jic23
On 11.04.2016 16:48, Andrew F. Davis wrote: On 04/10/2016 06:57 AM, Jonathan Cameron wrote: On 08/04/16 19:19, Andrew F. Davis wrote: The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C and SMBUS compatible interface. Signed-off-by: Andrew F. Davis Hi Andre

Re: [PATCH v5] iio: potentiometer: add driver for Microchip MCP413X/414X/415X/416X/423X/424X/425X/426X

2016-03-29 Thread jic23
On 29.03.2016 09:51, Slawomir Stepien wrote: On Mar 28, 2016 15:58, Jonathan Cameron wrote: On 23/03/16 08:57, Slawomir Stepien wrote: > The following functionalities are supported: > - write, read from volatile memory > > Datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/22060b.pdf >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread jic23
On 01.03.2016 02:42, Michael Welling wrote: On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for pow

Re: [RFC 1/2] ABI: iio: support AVERAGING_RATIO setting

2015-11-17 Thread jic23
On 17.11.2015 10:44, Marc Titinger wrote: Some ADC devices allow averaging/downsampling. The minimal parameter set for this will be the number of taps used for computing a mean value. In some cases the ratio will hold discrete values for instance "1, 4, 16" hence an averaging_ratio_available

Re: [PATCH v3 1/2] iio: fix drivers that consider 0 as a valid IRQ in client->irq

2015-07-23 Thread jic23
Octavian Purdila writes: On Fri, Jun 5, 2015 at 4:59 PM, Octavian Purdila wrote: Since patch "i2c / ACPI: Use 0 to indicate that device does not have interrupt assigned" [1], 0 is not a valid i2c client irq anymore, so change all driver's checks accordingly. The same issue occurs when the d

Re: [PATCH] DocBook: Add initial documentation for IIO

2015-07-17 Thread jic23
Daniel Baluta writes: On Thu, Jul 16, 2015 at 10:31 PM, Jonathan Cameron wrote: Thanks for your review Jonathan! I will try to address your comments in v2. + The main purpose of the Industrial I/O subsystem (IIO) is to provide + support for devices that in some sense are analog

Re: [PATCH v2] iio: light: Add support for ROHM RPR0521 sensor

2015-06-11 Thread jic23
Daniel Baluta writes: On Sun, Jun 7, 2015 at 12:08 AM, Jonathan Cameron wrote: On 06/03/2015 09:56 AM, Daniel Baluta wrote: On Thu, May 28, 2015 at 5:17 PM, Daniel Baluta wrote: +static const struct iio_chan_spec rpr0521_channels[] = { + { + .type = IIO_INTENSITY, +

Re: [PATCH v2 0/3] Introduce support for MMC35240 magnetic sensor

2015-05-08 Thread jic23
Daniel Baluta writes: On Sun, Apr 26, 2015 at 8:00 PM, Jonathan Cameron wrote: On 24/04/15 16:58, Daniel Baluta wrote: This adds support for Memsic's MMC35240 magnetometer. The sensor does not offer an interrupt line for data ready so for the moment we only expose raw readings via sysfs inter

Re: [PATCH v2] iio: mcp320x: Fix occasional incorrect readings

2015-05-08 Thread jic23
Michael Welling writes: On Thu, May 07, 2015 at 11:13:15AM +0100, Jonathan Cameron wrote: On 06/05/15 17:49, Michael Welling wrote: > Without the cacheline alignment, the readings will occasionally incorrectly > return 0. > > Signed-off-by: Michael Welling Applied to the fixes-togreg branch