Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm

2015-07-29 Thread jilaiw
Thanks for this information, Daniel. I will change it to use rotation prop in next patch. > On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote: >> Add plane properties hflip/vflip which are used in MDP driver to flip >> the input horizontally/vertically. >> >> Signed-off-by: Jilai Wang > >

Re: [PATCH] drm/msm/mdp5:Add DMA pipe planes for MDP5

2015-07-09 Thread jilaiw
Hi Rob, DMA pipes can be configured to work in either line mode or block mode. In line mode, it is the same as RGB/VIG pipes except no CSC/SCALE/PP/... support. So it can be used by any CRTC. In block mode, it is used as a rotator with writeback(0/1) interface which is not covered by this change.

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-08 Thread jilaiw
> On Tue, Apr 07, 2015 at 03:55:45PM -, jil...@codeaurora.org wrote: >> > On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote: >> >> So, from a quick look, it seems like there is a lot of potential to >> >> split the v4l part out into some drm helpers.. it looks pretty >> >> generic(ish),

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-07 Thread jilaiw
> On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote: >> So, from a quick look, it seems like there is a lot of potential to >> split the v4l part out into some drm helpers.. it looks pretty >> generic(ish), or at least it could be with some strategically placed >> vfuncs in drm_v4l2_helper_

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-02 Thread jilaiw
> On Thu, Apr 2, 2015 at 2:24 PM, Paul Bolle wrote: >> Hi Jilai, >> >> On Thu, 2015-04-02 at 17:58 +, jil...@codeaurora.org wrote: >>> Thanks Paul. Some comments embedded and for the rest I will update the >>> code accordingly. >> >> Most of my comments appear to be ill informed, so I wouldn't

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-02 Thread jilaiw
> On Thu, Apr 2, 2015 at 2:24 PM, Paul Bolle wrote: >> Hi Jilai, >> >> On Thu, 2015-04-02 at 17:58 +, jil...@codeaurora.org wrote: >>> Thanks Paul. Some comments embedded and for the rest I will update the >>> code accordingly. >> >> Most of my comments appear to be ill informed, so I wouldn't

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-02 Thread jilaiw
Thanks Emil. Please check the comments embedded and for the rest I will update the code. > Hi Jilai, > > Just a few questions, not really a review as I'm not that familiar > with the code. > > >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -27,6 +27,16 @@ config DRM_MSM_FBDEV >> support. Not

Re: [PATCH 2/3] drm:msm: Initial Add Writeback Support

2015-04-02 Thread jilaiw
Thanks Paul. Some comments embedded and for the rest I will update the code accordingly. > A few nits follow. > > On Wed, 2015-04-01 at 17:12 -0400, Jilai Wang wrote: >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig > >> +config DRM_MSM_WB >> +bool "Enable writeback su

Re: [PATCH] drm/msm: Refactor msm drm driver by introducing msm_drm_sub_dev

2015-03-24 Thread jilaiw
> On Tue, Mar 24, 2015 at 11:18 AM, wrote: >> >>> On Thu, Mar 12, 2015 at 4:48 PM, Jilai Wang >>> wrote: Introduce msm_drm_sub_dev for each mdp interface component such as HDMI/eDP/DSI to contain common information shared with MDP. Signed-off-by: Jilai Wang --- dr

Re: [PATCH] drm/msm: Refactor msm drm driver by introducing msm_drm_sub_dev

2015-03-24 Thread jilaiw
> On Thu, Mar 12, 2015 at 4:48 PM, Jilai Wang wrote: >> Introduce msm_drm_sub_dev for each mdp interface component such as >> HDMI/eDP/DSI to contain common information shared with MDP. >> >> Signed-off-by: Jilai Wang >> --- >> drivers/gpu/drm/msm/edp/edp.c | 18 +-- >> driver

Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support (V2)

2015-02-11 Thread jilaiw
There is one issue to use i2c_smbus_XX functions: i2c_smbus_read_i2c_block_data has limitation with the maximum count I2C_SMBUS_BLOCK_MAX. But in function hdmi_hdcp_recv_ksv_fifo, since the downstream ksv_fifo size will exceed this limitation and must be read in a single transaction, we can't use

Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support

2014-12-03 Thread jilaiw
> On Wed, Dec 3, 2014 at 9:16 AM, wrote: > [..] > + enum hdmi_hdcp_state hdcp_state; > + struct mutex state_mutex; > + struct delayed_work hdcp_reauth_work; > + struct delayed_work hdcp_auth_part1_1_work; > + struct delayed_work hdcp_auth_part1_2_

Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support

2014-12-03 Thread jilaiw
Hi Bjorn, > On Tue, Dec 2, 2014 at 8:46 PM, Bjorn Andersson wrote: >> On Mon, Dec 1, 2014 at 1:56 PM, Jilai Wang >> wrote: >>> Add HDMI HDCP support including HDCP PartI/II/III authentication. >>> >>> Signed-off-by: Jilai Wang >>> --- >> >> Hi Jilai, >> >> [..] >> >>> diff --git a/drivers/gpu/d