_LIST=y. Make sure CIs take advantage
> of CONFIG_PROVE_RCU_LIST=y, recent fixes in networking
> indicate that it does catch bugs.
>
> Signed-off-by: Jakub Kicinski
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> I'd be slightly tempted to still send it to
On Tue, Oct 15, 2024 at 04:02:37PM -0700, Paul E. McKenney wrote:
> On Tue, Oct 15, 2024 at 02:49:06PM -0400, Joel Fernandes wrote:
> > On Wed, Oct 09, 2024 at 11:05:02AM -0700, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > This series contains RCU
nds.
>
> 3.Finer-grained grace-period-end checks in rcu_dump_cpu_stacks().
>
Other than small nit in 2/3,
Reviewed-by: Joel Fernandes (Google)
I was curious if you're seeing perf or other improvements with the
finer-grained rnp locking.
thanks,
- Joel
>
if (gp_seq != rcu_state.gp_seq) {
> + pr_err("INFO: Stall ended during stack backtracing.\n");
> + return;
> + }
small nit, this also needs data_race() like you did in next patch? Although
you did delete this code in
san_record_aux_stack_noalloc(head);
> > > > +
> > > > local_irq_save(flags);
> > > > rdp = this_cpu_ptr(&rcu_data);
> > > > + RCU_LOCKDEP_WARN(rcu_rdp_cpu_online(rdp), "Callback enqueued on
> > > > offline
> > > > CPU!");
> > >
> > > This should be !rcu_rdp_cpu_online(rdp)
> > >
> > > Sigh...
> >
> > I am pulling this in for testing with this change, thank you!
>
> And:
>
> Tested-by: Paul E. McKenney
With the correction,
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
; alternative fix be (pseudocode):
> >
> > Change the following in the "if (was_alldone)" block:
> >
> >if (!irqs_disabled_flags(flags)) {
> >
> > to:
> >if (!irqs_disabled_flags(flags) && !in_softirq())
> >
> > ?
> >
> > That way perhaps an additional RCU_NOCB flag is not needed.
> >
> > Or does that not work for some reason?
>
> It works but this forces the wake-up through the timer when a callback is
> enqueued from softirqs. And waking up from the timer is a bit more overhead
> and also added GP delay. It could be this though:
>
> if (!irqs_disabled_flags(flags) && cpu_online(smp_processor_id()))
>
This makes sense to me and also will future-proof this code path from
potential users who end up here. I think it will work.
Feel free to add to this and the next patch:
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
NE,
> + TPS("WakeEmptyIsDeferredOffline"));
> + } else if (lazy_len && bypass_len == lazy_len) {
Since the call stack is when softirqs are disabled, would an
alternative fix be (pseudocode):
Change the following in the "if (was_alldone)" block:
if (!irqs_disabled_flags(flags)) {
to:
if (!irqs_disabled_flags(flags) && !in_softirq())
?
That way perhaps an additional RCU_NOCB flag is not needed.
Or does that not work for some reason?
thanks,
- Joel
he mm_struct object because direct
access to mm_struct should require a proper mmgrab(), not a lazy_tlb
flavored one? -- correct me if I'm wrong though.
Also, isn't it that on x86, now with this patch there will be more
IPIs, whereas previously the global refcount was not requiring that as
the last kthread switching out would no longer access the old mm?
Might it be worth checking the performance of fork/exit and if that
scales?
thanks,
- Joel
xtract the AST for superior code
browsing/completion.
Also have you looked at the benefits of inlining for hp.h?
hp_dereference_allocate() seems large enough that inlining may not
matter much, but I haven't compiled it and looked at the asm myself.
Will continue staring at the code.
thanks,
- J
Cc: Boqun Feng
> Cc: Alan Stern
> Cc: John Stultz
> Cc: Neeraj Upadhyay
> Cc: Linus Torvalds
> Cc: Boqun Feng
> Cc: Frederic Weisbecker
> Cc: Joel Fernandes
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
On Thu, Oct 3, 2024 at 10:21 AM Mathieu Desnoyers
wrote:
> >
> > Reviewed-by: Joel Fernandes (Google)
>
> Please double-check with -O2, and let me know if you still agree with
> the patch :)
>
You are quite right, with -O2 I can indeed see that the optimize hide
var fi
a and b
stored on the stack through a washing machine:
ldr x0, [sp, 8]
str x0, [sp, 8]
ldr x0, [sp]
str x0, [sp]
And here I thought the "" in OPTIMIZER_HIDE_VAR was not supposed to generate
any code but I guess it is still a NOOP.
Anyway, as such this LGTM since whether OPTIMIZER_HIDE_VAR() used or not, it
does fix the problem.
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
On Tue, Oct 10, 2023 at 03:22:34PM -0700, Luis Chamberlain wrote:
> On Mon, Oct 02, 2023 at 01:30:35PM +0200, Joel Granados via B4 Relay wrote:
> > V3:
> > * Removed the ia64 patch to avoid conflicts with the ia64 removal
> > * Rebased onto v6.6-rc4
> > * Kept/added
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
What?
These commits remove the sentinel element (last empty element) from the
sysctl arrays of all the files under the "arch/" directory that use a
sysctl array for registration. The merging of the preparation patches
(in https://lore.kernel.org/all/zo5yx
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which will
reduce the overall build time size of the kernel and run time memory
bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
What?
These commits remove the sentinel element (last empty element) from the
sysctl arrays of all the files under the "arch/" directory that use a
sysctl array for registration. The merging of the preparation patches
(in https://lore.kernel.org/all/zo5yx
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https
From: Joel Granados
This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which will
reduce the overall build time size of the kernel and run time memory
bloat by ~64 bytes per sentinel (further information Link :
https
ow the prctl(2).
This has the nice design that the security is enforced on entering the
sandbox, and prior to entering the sandbox, no permissions need be given.
Let me know if that makes sense and if you had any other questions. thanks,
-Joel
On Tue, Apr 06, 2021 at 10:16:12AM -0400, Tejun Heo wrote:
> Hello,
>
> On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote:
> > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com
> > as mentioned above, let me know if you need any more deta
On Tue, 16 Mar 2021 at 08:59, Troy Lee wrote:
>
> Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same
> openbmc-flash-layout-64.dtsi requires to resize the flash partition.
>
> The updated flash layout as follows:
> - u-boot: 896 KiB
> - u-boot-env: 128 KiB
> - kernel: 9MiB
> - ro
On Thu, 15 Apr 2021 at 14:05, Paul Fertser wrote:
>
> The ADM1278 IC is accessible on I2C bus and on both Wiwynn and Quanta
> Tioga Pass implementations a pair of parallel 0.5 mOhm resistors is used
> for current measurement.
>
> Signed-off-by: Paul Fertser
Thanks, applied.
> ---
> arch/arm/bo
On Thu, 15 Apr 2021 at 15:53, Konstantin Aladyshev
wrote:
>
> Enable all I2C busses that are used in AMD EthanolX CRB:
> i2c0 - APML P0
> i2c1 - APML P1
> i2c2 - FPGA
> i2c3 - 24LC128 EEPROM
> i2c4 - P0 Power regulators
> i2c5 - P1 Power regulators
> i2c6 - P0/P1 Thermal diode
> i2c7 - The
s/1000, which are
microseconds. I think the existing test is correct?
As far as integer overflow is concerned, max_hw_heartbeat_ms is an
unsigned int. We set it to 4294967, which *1000 = 0xfed8. This
should be fine.
> + wdd->timeout = actual;
This might be the correct t
merged (both to mainline for v5.13 and in
openbmc), so any fixups need to come as patches on top of the existing
code.
Cheers,
Joel
ices registered with devm_spi_alloc_{master,slave}() to be
> mistakenly identified as legacy, non-devm managed devices and have their
> reference counters decremented below 0.
Thanks for spending the time to track down the bug and sending a fix
for it. I appreciate it!
Reviewed-by: Jo
gt; > It appears these patches are doing roughly the right thing, and we may still
> > be able to get them into v5.13, but I'm not sure what your plan for
> > maintaining
> > them is. The two options are that you either send your patches to be picked
> > up
>
er job of communicating
> that :)
I'll merge the first five through the aspeed tree this coming merge
window. We have acks from the relevant maintainers.
Arnd: would you prefer that this come as it's own pull request, or as
part of the device tree branch?
Andrew, Corey: once I've got my pull requests out I'll look at
reviewing the rest of the series. Perhaps it would pay to re-send that
hunk of patches Andrew with the nits fixed?
Cheers,
Joel
f-by: Chia-Wei Wang
> Reviewed-by: Andrew Jeffery
Reviewed-by: Joel Stanley
f-by: Chia-Wei Wang
> Reviewed-by: Andrew Jeffery
> Acked-by: Linus Walleij
Reviewed-by: Joel Stanley
f-by: Chia-Wei Wang
> Reviewed-by: Andrew Jeffery
> Acked-by: Haiyue Wang
Reviewed-by: Joel Stanley
ted in the DTS node examples
> are also fixed to adapt to the LPC DTS change.
Is this accurate:
The node examples change their reg address to be an offset from the
LPC HC to be an offset from the base of the LPC region.
Reviewed-by: Joel Stanley
>
> Signed-off-by: Chia-Wei Wang
>
This patch adds audio support for Xiaomi Poco F1 phone. Phone's primary
Mic and 3.5mm Headphone jack are handled through the SDM845 sound card
and WCD9340 codec.
Tested-by: Amit Pundir
Signed-off-by: Joel Selvaraj
---
.../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 117
t; error
> > condition unless there is no valid response before the timeout
> > expires. So
> > change the starting sequence number and check for the un-initialized
> > OCC
> > state before returning the response in order to detect this condition
> > and
> >
On Tue, 9 Feb 2021 at 17:13, Eddie James wrote:
>
> Log an error if the response checksum doesn't match the
> calculated checksum.
Reviewed-by: Joel Stanley
>
> Signed-off-by: Eddie James
> ---
> drivers/fsi/fsi-occ.c | 10 +++---
> 1 file changed,
On Tue, 9 Feb 2021 at 17:12, Eddie James wrote:
>
> If the OCC is not initialized and responds as such, the driver
> should continue waiting for a valid response until the timeout
> expires.
>
> Signed-off-by: Eddie James
Reviewed-by: Joel Stanley
I guess we should ad
oper
> interface but that's the least of concerns here.
>
> Can someone point me to a realistic and concrete usage scenario for this
> feature?
Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com
as mentioned above, let me know if you need any more details about
usecase.
About the file name, how about kernel/sched/smt.c ? That definitely
provides more information than 'core_sched.c'.
Thanks,
- Joel
On Thu, 1 Apr 2021 at 00:57, Zev Weiss wrote:
>
> This provides a simple boolean to use instead of the deprecated
> aspeed,sirq-polarity-sense property.
>
> Signed-off-by: Zev Weiss
> ---
> drivers/tty/serial/8250/8250_aspeed_vuart.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dr
Zev Weiss
Reviewed-by: Joel Stanley
> ---
> Documentation/devicetree/bindings/serial/8250.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml
> b/Documentation/devicetree/bindings/serial/8250.yaml
> index f54cae9ff7b
intainers to apply a patch directly without going
through another maintainer. In this case the patch should go through
the aspeed maintainer's tree (me), so you don't need to cc that
address.
> Signed-off-by: Zev Weiss
> Reviewed-by: Joel Stanley
> ---
This spot just here is where
Signed-off-by: Anton D. Kachalov
I believe you discussed what approach to take and this was agreed
upon. Can I get an ack from some other nuvoton people before I apply?
Cheers,
Joel
> > ---
> > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 38 +++
> > 1 file
On Wed, 31 Mar 2021 at 07:41, Joel Stanley wrote:
>
> On Tue, 30 Mar 2021 at 00:25, Zev Weiss wrote:
> >
> > This is a relatively low-cost AST2500-based Xeon E-2100/E-2200 series
> > mini-ITX board that we hope can provide a decent platform for OpenBMC
> > dev
On Wed, 31 Mar 2021 at 07:41, Joel Stanley wrote:
>
> On Tue, 30 Mar 2021 at 00:25, Zev Weiss wrote:
> >
> > This is a relatively low-cost AST2500-based Xeon E-2100/E-2200 series
> > mini-ITX board that we hope can provide a decent platform for OpenBMC
> > dev
on for
> basic BMC functionality such as host power control, serial console and
> KVM support, and POST code snooping.
>
> Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
> ---
> .../boot/dts/aspeed-bmc-asrock-e3c246d4i.dts | 188 ++
> 1 file changed, 188 inser
the lines more obvious.
>
> Signed-off-by: Nichole Wang
Thanks for the patch. The syntax is good, and I will assume the
information is correct. I will apply it to the tree.
Reviewed-by: Joel Stanley
Cheers,
Joel
> ---
> arch/arm/boot/dts/asp
On Mon, 29 Mar 2021 at 12:18, Quan Nguyen wrote:
>
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
>
> This commits adds support specifically for Aspeed AST2500 which commonly
> used as Board Manageme
1d30
> [<7f00deb8>] ast_vhub_ep0_handle_setup+0xa4/0x1bc
> [<7f02ee94>] ast_vhub_dev_irq+0x58/0x84
> [<7f0309e0>] ast_vhub_irq+0xb0/0x1c8
> [<7f02e118>] __handle_irq_event_percpu+0x50/0x19c
> [<8015e5bc>] handle_irq_event_percpu+0x38/0x8c
> [<8015e758
https://lore.kernel.org/lkml/20200812112400.2406734-1-j...@jms.id.au/
The intent is to remove it from both the bindings and the code.
There's already no users of it in any device tree.
How would you like Zev to go about doing this?
Cheers,
Joel
>
> >
> > Signed-off-by: Zev
n_unsupported that should
trigger was not displaying any output).
Adding this patch resolved the issue and the test now passes.
Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Joel Stanley
---
fs/jffs2/file.c | 1 +
1 file change
On Wed, 24 Mar 2021 at 22:05, Eddie James wrote:
>
> Updated restricted chips have trouble processing multiple sequenced
> operations. So remove the capability to sequence multiple operations and
> reduce the maximum transfer size to 8 bytes.
>
> Signed-off-by: Eddie James
Signed-off-by: Joel Fernandes (Google)
---
.../admin-guide/hw-vuln/core-scheduling.rst | 460 ++
Documentation/admin-guide/hw-vuln/index.rst | 1 +
2 files changed, 461 insertions(+)
create mode 100644 Documentation/admin-guide/hw-vuln/core-scheduling.rst
diff --git a
From: chris hyser
This patch provides support for setting, clearing and copying core
scheduling 'task cookies' between threads (PID), processes (TGID), and
process groups (PGID).
The value of core scheduling isn't that tasks don't share a core, 'nosmt'
can do that. The value lies in exploiting a
Add a kselftest test to ensure that the core-sched interface is working
correctly.
Co-developed-by: Chris Hyser
Signed-off-by: Chris Hyser
Co-developed-by: Josh Don
Signed-off-by: Josh Don
Tested-by: Julien Desfossez
Signed-off-by: Joel Fernandes (Google)
Signed-off-by: chris hyser
Tested-by: Julien Desfossez
Not-Signed-off-by: Peter Zijlstra (Intel)
---
kernel/sched/core.c | 40 +++-
kernel/sched/fair.c | 12
2 files changed, 51 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a7338
From: Josh Don
This adds the API to set/get the cookie for a given cgroup. This
interface lives at cgroup/cpu.core_tag.
The cgroup interface can be used to toggle a unique cookie value for all
descendent tasks, preventing these tasks from sharing with any others.
See Documentation/admin-guide/hw
sk wakeup, find the idlest CPU whose core
cookie matches with task's cookie
Signed-off-by: Aubrey Li
Signed-off-by: Tim Chen
Signed-off-by: Vineeth Remanan Pillai
Signed-off-by: Joel Fernandes (Google)
---
kernel/sched/fair.c | 29 ++
kerne
.
Core scheduler has extra overhead. Enable it only for machines with
more than one SMT hardware thread.
Co-developed-by: Chris Hyser
Signed-off-by: Chris Hyser
Co-developed-by: Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google)
Tested-by: Julien Desfossez
Signed-off-by: Julien
From: chris hyser
Provides a selftest and examples of using the interface.
Signed-off-by: Chris Hyser
Signed-off-by: Josh Don
---
tools/testing/selftests/sched/.gitignore | 1 +
tools/testing/selftests/sched/Makefile| 14 +
tools/testing/selftests/sched/config | 1 +
snapshotting of min_vruntime for CGroups
- Disable coresched on certain AMD HW.
Changes in v8
=
- New interface/API implementation
- Joel
- Revised kernel protection patch
- Joel
- Revised Hotplug fixes
- Joel
- Minor bug fixes and address review comments
- Vineeth
On Sat, Mar 20, 2021 at 04:40:20PM +0100, Peter Zijlstra wrote:
> On Fri, Mar 19, 2021 at 04:32:47PM -0400, Joel Fernandes (Google) wrote:
> > Enclosed is interface related core scheduling patches and one for migration.
> > The main core scheduling patches were already pulled i
ed-off-by: Aubrey Li
Signed-off-by: Tim Chen
Signed-off-by: Vineeth Remanan Pillai
Signed-off-by: Joel Fernandes (Google)
---
kernel/sched/fair.c | 33 +---
kernel/sched/sched.h | 72
2 files changed, 101 insertions(+), 4 deletions(-)
more than one SMT hardware thread.
Co-developed-by: Chris Hyser
Signed-off-by: Chris Hyser
Co-developed-by: Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google)
Tested-by: Julien Desfossez
Signed-off-by: Julien Desfossez
Signed-off-by: Tim Chen
Signed-off-by: Peter Zijlstra (Intel
From: chris hyser
This patch provides support for setting, clearing and copying core
scheduling 'task cookies' between threads (PID), processes (TGID), and
process groups (PGID).
The value of core scheduling isn't that tasks don't share a core, 'nosmt'
can do that. The value lies in exploiting a
Add a kselftest test to ensure that the core-sched interface is working
correctly.
Co-developed-by: Chris Hyser
Signed-off-by: Chris Hyser
Co-developed-by: Josh Don
Signed-off-by: Josh Don
Tested-by: Julien Desfossez
Signed-off-by: Joel Fernandes (Google)
---
tools/testing/selftests/sched
Signed-off-by: Joel Fernandes (Google)
---
.../admin-guide/hw-vuln/core-scheduling.rst | 460 ++
Documentation/admin-guide/hw-vuln/index.rst | 1 +
2 files changed, 461 insertions(+)
create mode 100644 Documentation/admin-guide/hw-vuln/core-scheduling.rst
diff --git a
Tested-by: Julien Desfossez
Not-Signed-off-by: Peter Zijlstra (Intel)
---
kernel/sched/core.c | 40 +++-
kernel/sched/fair.c | 9 +
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a62e8ad5
From: Joel Fernandes
Core-Scheduling
===
Enclosed is interface related core scheduling patches and one for migration.
The main core scheduling patches were already pulled in by Peter with these
bits left.
Main changes are the simplification of the core cookie scheme,
new prctl code
This patch adds audio support for Xiaomi Poco F1 phone. Phone's primary
Mic and 3.5mm Headphone jack are handled through the SDM845 sound card
and WCD9340 codec.
Signed-off-by: Joel Selvaraj
---
.../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 117 ++
1 file changed
On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote:
>
> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote:
> >
> > The interrupt handler may set the flag to reset the mac in the future,
> > but that flag is not cleared once the reset has occured.
> >
> > Fixes: 1
On Thu, 4 Mar 2021 at 08:12, Greg Kroah-Hartman
wrote:
>
> On Tue, Mar 02, 2021 at 12:09:21AM +, Yoo, Jae Hyun wrote:
> > > From: Joel Stanley
> > > Jae, John; with this backported do we need to also provide a corresponding
> > > device tree change fo
o longer probe?
>
> Fixes: 3772e5da4454 ("drivers/misc: Aspeed LPC snoop output using misc
> chardev")
> Signed-off-by: Jae Hyun Yoo
> Signed-off-by: Vernon Mauery
> Signed-off-by: John Wang
> Reviewed-by: Joel Stanley
> Link:
> https://lore.kernel.org/r/202012
On Tue, 23 Feb 2021 at 08:04, wrote:
>
> From: dingsenjie
>
> remove unneeded variable: "ret".
>
> Signed-off-by: dingsenjie
Thanks for the patch. Instead of removing the unused variable, I think
the code could be improved to return error codes when the re
his support for your changes. I will take time to
closely review your proposal this week.
We will set the goal of having this rework merged for the next merge window.
Cheers,
Joel
> Thanks.
>
> Chiawei
>
> > -Original Message-
> > From: Andrew Jeffery
> &g
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 6bc335828056f3b301a3deadda782de4e8f0db08
Gitweb:
https://git.kernel.org/tip/6bc335828056f3b301a3deadda782de4e8f0db08
Author:Joel Fernandes (Google)
AuthorDate:Tue, 03 Nov 2020 09:25:57 -05:00
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: c2e13112e830c06825339cbadf0b3bc2bdb9a716
Gitweb:
https://git.kernel.org/tip/c2e13112e830c06825339cbadf0b3bc2bdb9a716
Author:Joel Fernandes (Google)
AuthorDate:Tue, 03 Nov 2020 09:26:03 -05:00
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: ae5c2341ed3987bd434ed495bd4f3d8b2bc3e623
Gitweb:
https://git.kernel.org/tip/ae5c2341ed3987bd434ed495bd4f3d8b2bc3e623
Author:Joel Fernandes (Google)
AuthorDate:Wed, 23 Sep 2020 11:22:09 -04:00
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: b4e6039e8af8c20dfbbdfcaebfcbd7c9d9ffe713
Gitweb:
https://git.kernel.org/tip/b4e6039e8af8c20dfbbdfcaebfcbd7c9d9ffe713
Author:Joel Fernandes (Google)
AuthorDate:Wed, 18 Nov 2020 11:15:41 -05:00
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 68804cf1c905ce227e4e1d0bc252c216811c59fd
Gitweb:
https://git.kernel.org/tip/68804cf1c905ce227e4e1d0bc252c216811c59fd
Author:Joel Fernandes (Google)
AuthorDate:Wed, 14 Oct 2020 18:21:53 -04:00
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 3afe7fa535491ecd0382c3968dc2349602bff8a2
Gitweb:
https://git.kernel.org/tip/3afe7fa535491ecd0382c3968dc2349602bff8a2
Author:Joel Fernandes (Google)
AuthorDate:Sat, 14 Nov 2020 14:31:32 -05:00
The last (only?) user of this was removed in commit ba364fc752da ("ARM:
Kirkwood: Remove mach-kirkwood"), back in v3.17.
Signed-off-by: Joel Stanley
---
arch/arm/include/asm/kexec.h| 3 ---
arch/arm/kernel/machine_kexec.c | 8
2 files changed, 11 deletions(-)
diff --git
or wait for a combined pull
> > > request
> > > with other work.
> >
> > Hello Arnd,
> > Thanks your update.
> >
> > >Joel, please let me know what you prefer.
> > >
> > Hello Joel,
> > Could you help check on this patch?
On Thu, Feb 04, 2021 at 03:52:53PM +0100, Peter Zijlstra wrote:
> On Fri, Jan 22, 2021 at 08:17:01PM -0500, Joel Fernandes (Google) wrote:
> > +static void sched_core_update_cookie(struct task_struct *p, unsigned long
> > cookie,
> > +enum s
Hi Peter,
On Thu, Feb 04, 2021 at 02:59:58PM +0100, Peter Zijlstra wrote:
> On Wed, Feb 03, 2021 at 05:51:15PM +0100, Peter Zijlstra wrote:
> >
> > I'm slowly starting to go through this...
> >
> > On Fri, Jan 22, 2021 at 08:17:01PM -0500, Joel Fernandes (G
h the patch and it looks correct to me, I will further review it
and await further reviews from others as well, and then backport the patch to
our kernels. Thanks Vince and everyone!
Tested-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> kernel/sched/fair.c | 32 +++---
t I agree with, is that running
> update_blocked_averages with preempt and irq off is not a good thing
> because we don't manage the number of csf_rq to update and I'm going
> to provide a patchset for this
That's fine, as long as we agree on this problem ;-) Thanks for
providing the patches and I will try them once they are ready.
> > for this.
> >
> > > Also update_blocked_averages was supposed called in newlyidle_balance
> > > when the coming idle duration is expected to be long enough
> >
> > No, we do not want the schedule loop to take half a millisecond.
>
> keep in mind that you are scaling frequency so everything takes time
> at lowest frequency/capacity ...
Agreed, I was also thinking the same. But that doesn't change the fact
that there is room for improvement and I'm grateful to you for trying
to improve it!
thanks,
- Joel
Hi Vincent,
On Thu, Jan 28, 2021 at 8:57 AM Vincent Guittot
wrote:
> > On Mon, Jan 25, 2021 at 03:42:41PM +0100, Vincent Guittot wrote:
> > > On Fri, 22 Jan 2021 at 20:10, Joel Fernandes
> > > wrote:
> > > > On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent
Hi Vincent,
On Mon, Jan 25, 2021 at 03:42:41PM +0100, Vincent Guittot wrote:
> On Fri, 22 Jan 2021 at 20:10, Joel Fernandes wrote:
> > On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent Guittot wrote:
> > > On Fri, 22 Jan 2021 at 16:46, Joel Fernandes (Google)
> > > w
chine mechanism for now that avoids
such complications.
Core scheduler has extra overhead. Enable it only for core with
more than one SMT hardware threads.
Co-developed-by: Josh Don
Co-developed-by: Chris Hyser
Co-developed-by: Joel Fernandes (Google)
Tested-by: Julien Desfossez
Signed-o
1 - 100 of 1751 matches
Mail list logo
