Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
On Fri, Aug 28, 2020 at 03:11:32PM +, Deucher, Alexander wrote: > There are hw bugs on Raven and probably Carrizo/Stoney where they need > 1:1 mapping to avoid bugs in some corner cases with the displays. > Other GPUs should be fine. The VIDs is 0x1002 and the DIDs are 0x15dd > and 0x15d8 for

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
Hi Felix, On Fri, Aug 28, 2020 at 09:54:59AM -0400, Felix Kuehling wrote: > Yes, we're working on this. IOMMUv2 is only needed for KFD. It's not > needed for graphics. And we're making it optional for KFD as well. Okay, KFD should fail gracefully because it can't initialize the device's iommuv2

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
On Wed, Aug 26, 2020 at 03:25:58PM +, Deucher, Alexander wrote: > > Alex, do you know if anyone has tested amdgpu on an APU with SME > > enabled? Is this considered something we support? > > It's not something we've tested. I'm not even sure the GPU portion of > APUs will work properly

Re: [PATCH RESEND 1/1] PCI: Add ATS-disable quirk for AMD Radeon R7 GPUs

2019-04-11 Thread jroe...@suse.de
On Wed, Apr 10, 2019 at 03:59:57PM +, Deucher, Alexander wrote: > > + a few AMD people > > > > Seeing this bug makes it more clear. I don't think this is a problem with > > the > > GPU. I think it's a problem with either the sbios or iommu. I think the > > original > > quirk added for

Re: [PATCH 00/22 v2] Introduce default domains for iommu groups

2015-06-05 Thread jroe...@suse.de
Hi Will, Thanks for having a look! On Fri, Jun 05, 2015 at 03:22:06PM +0100, Will Deacon wrote: > > Most of this looks fine to me, modulo by comments about the dm regions > (which I'm not sure how to implement for ARM). When there are no direct mapping requirements from the firmware on ARM,

Re: [PATCH 10/22] iommu: Introduce direct mapped region handling

2015-06-05 Thread jroe...@suse.de
Hi Will, On Fri, Jun 05, 2015 at 03:17:50PM +0100, Will Deacon wrote: > On Thu, May 28, 2015 at 05:41:33PM +0100, Joerg Roedel wrote: > > +/** > > + * struct iommu_dm_region - descriptor for a direct mapped memory region > > + * @list: Linked list pointers > > + * @start: System physical start

Re: [PATCH 10/22] iommu: Introduce direct mapped region handling

2015-06-05 Thread jroe...@suse.de
Hi Will, On Fri, Jun 05, 2015 at 03:17:50PM +0100, Will Deacon wrote: On Thu, May 28, 2015 at 05:41:33PM +0100, Joerg Roedel wrote: +/** + * struct iommu_dm_region - descriptor for a direct mapped memory region + * @list: Linked list pointers + * @start: System physical start address of

Re: [PATCH 00/22 v2] Introduce default domains for iommu groups

2015-06-05 Thread jroe...@suse.de
Hi Will, Thanks for having a look! On Fri, Jun 05, 2015 at 03:22:06PM +0100, Will Deacon wrote: Most of this looks fine to me, modulo by comments about the dm regions (which I'm not sure how to implement for ARM). When there are no direct mapping requirements from the firmware on ARM, you