Re: [PATCH net-next 2/2] net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread k...@kernel.org
On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote: > On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote: > > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id) > > > +{ > > > + struct s3fwrn82_uart_phy *phy = phy_id; >

Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread k...@kernel.org
On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: > On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote: > > > > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > examples: > > >- | > > > #include > > > @@ -

Re: [PATCH net-next 2/2] net: nfc: s3fwrn5: Support a UART interface

2020-11-23 Thread k...@kernel.org
On Mon, Nov 23, 2020 at 04:56:58PM +0900, Bongsu Jeon wrote: > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 uses NCI protocol and supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon Please start sending emails properly, e.g. with git send-email, so all your

Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-23 Thread k...@kernel.org
On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon > --- > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +-- > 1 file changed, 26

Re: [PATCH net-next v2 1/3] nfc: s3fwrn5: Remove the max_payload

2020-11-16 Thread k...@kernel.org
On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote: > max_payload is unused. Why did you resend the patch ignoring my review? I already provided you with a tag, so you should include it. https://www.kernel.org/doc/html/latest/process/submitting-patches.html Reviewed-by: Krzysztof

Re: [PATCH net-next v2 2/3] nfc: s3fwrn5: Fix the misspelling in a comment

2020-11-16 Thread k...@kernel.org
On Tue, Nov 17, 2020 at 10:17:42AM +0900, Bongsu Jeon wrote: > stucture should be replaced by structure. > > Signed-off-by: Bongsu Jeon I already reviewed it. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code

2020-11-16 Thread k...@kernel.org
On Tue, Nov 17, 2020 at 10:18:50AM +0900, Bongsu Jeon wrote: > ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/s3fwrn5.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) I already reviewed it. Reviewed-by:

Re: [PATCH net-next 2/3] nfc: s3fwrn5: Fix the misspelling in a comment

2020-11-16 Thread k...@kernel.org
On Mon, Nov 16, 2020 at 10:17:55AM +0900, Bongsu Jeon wrote: > stucture should be replaced by structure. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code

2020-11-16 Thread k...@kernel.org
On Mon, Nov 16, 2020 at 10:19:50AM +0900, Bongsu Jeon wrote: > ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/s3fwrn5.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best

Re: [PATCH net-next 1/3] nfc: s3fwrn5: Remove the max_payload

2020-11-16 Thread k...@kernel.org
On Mon, Nov 16, 2020 at 10:12:05AM +0900, Bongsu Jeon wrote: > max_payload is unused. > > Signed-off-by: Bongsu Jeon Please version your patches (this should be a v2) and describe changes between versions in changelog, either in cover letter or after --- separator. Reviewed-by: Krzysztof

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread k...@kernel.org
On Wed, Sep 09, 2020 at 08:57:36AM +, Vaittinen, Matti wrote: > Hello Krzysztof, > > On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > > On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > > On Tue, 2020-09-08 at 16:59 +0200, K

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread k...@kernel.org
On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt > > flags. > > These are simple defines so they could be used in DTS but they will > > not > >

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 08:22:18AM +, Vaittinen, Matti wrote: > Hello Krzysztof, > > On Tue, 2020-08-25 at 09:50 +0200, k...@kernel.org wrote: > > On Tue, Aug 25, 2020 at 09:45:00AM +0200, k...@kernel.org wrote: > > > On Tue, Aug 25, 2020 at 09:25:37AM +020

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 09:45:00AM +0200, k...@kernel.org wrote: > On Tue, Aug 25, 2020 at 09:25:37AM +0200, k...@kernel.org wrote: > > On Tue, Aug 25, 2020 at 06:51:33AM +, Vaittinen, Matti wrote: > > > Hello Krzysztof, > > > > > > Just some question

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 09:25:37AM +0200, k...@kernel.org wrote: > On Tue, Aug 25, 2020 at 06:51:33AM +, Vaittinen, Matti wrote: > > Hello Krzysztof, > > > > Just some questions - please ignore if I misunderstood the impact of > > the change. > > >

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 06:51:33AM +, Vaittinen, Matti wrote: > Hello Krzysztof, > > Just some questions - please ignore if I misunderstood the impact of > the change. > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > Device tree schema expects regulator names to be

Re: [PATCH 01/16] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 06:23:36AM +, Vaittinen, Matti wrote: > > Hello Krzysztof, > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > The input clock and number of clock provider cells are not required > > for > > the PMIC to operate. They are needed only for the optional

Re: [PATCH 05/10] ARM: dts: imx6ul-kontron-n6x1x: Add 'chosen' node with 'stdout-path'

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:28PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The Kontron N6x1x SoMs all use uart4 as a debug serial interface. > Therefore we set in the 'chosen' node. > > Signed-off-by: Frieder Schrempf > --- >

Re: [PATCH 09/10] dt-bindings: arm: fsl: Add more Kontron i.MX6UL/ULL compatibles

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:36PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > Add the compatibles for Kontron i.MX6UL N6311 SoM and boards and > the compatibles for Kontron i.MX6ULL N6411 SoM and boards. > > Signed-off-by: Frieder Schrempf > --- >

Re: [PATCH 04/10] ARM: dts: Add support for two more Kontron evalkit boards 'N6311 S' and 'N6411 S'

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:28PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The 'N6311 S' and the 'N6411 S' are similar to the Kontron 'N6310 S' > evaluation kit boards. Instead of the N6310 SoM, they feature a N6311 > or N6411 SoM. > > Signed-off-by: Frieder Schrempf > ---

Re: [PATCH 03/10] ARM: dts: imx6ul-kontron-n6310-s: Move common nodes to a separate file

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:25PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The baseboard for the Kontron N6310 SoM is also used for other SoMs > such as N6311 and N6411. In order to share the code, we move the > definitions of the baseboard to a separate dtsi file. > >

Re: [PATCH 02/10] ARM: dts: Add support for two more Kontron SoMs N6311 and N6411

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:21PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The N6311 and the N6411 SoM are similar to the Kontron N6310 SoM. > They are pin-compatible, but feature a larger RAM and NAND flash > (512MiB instead of 256MiB). Further, the N6411 has an i.MX6ULL

Re: [PATCH 01/10] ARM: dts: imx6ul-kontron-n6310: Move common SoM nodes to a separate file

2019-10-21 Thread k...@kernel.org
On Wed, Oct 16, 2019 at 03:07:19PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The Kontron N6311 and N6411 SoMs are very similar to N6310. In > preparation to add support for them, we move the common nodes to a > separate file imx6ul-kontron-n6x1x-som-common.dtsi. > >