static unsigned int nv_adma_tf_to_cpb(struct ata_taskfile *tf, __le16
*cpb)
-
Best regards,
Kuan Luo
---
This email message is for the sole use of the intended recipient(s) and may
contain
confidential information.
Robert wrote:
> Kuan Luo wrote:
> > Robert worte.
> >> Kuan, does this patch (using the notifiers to see if the
> command is
> >> really done) still work if one port on the controller has
> >> ADMA disabled
> >> because it's in ATAPI mode? I
robert wrote:
> Kuan Luo wrote:
> > Robert worte.
> >> Kuan, does this patch (using the notifiers to see if the
> command is
> >> really done) still work if one port on the controller has
> >> ADMA disabled
> >> because it's in ATAPI mode? I
Robert worte.
>
> Kuan, does this patch (using the notifiers to see if the command is
> really done) still work if one port on the controller has
> ADMA disabled
> because it's in ATAPI mode? I seem to recall Allen Martin mentioning
> that notifiers wouldn't work in this case.
>
I just tried
Robert Hancock wrote:
> As I mentioned, this doesn't seem to resolve the problem we're seeing
> with rapidly intermixed NCQ commands and cache flushes (at
> least, if I
> take out the arbitrary 20usec delay from the driver and add
> this patch,
> the problem still shows up). It could be a simi
Robert hancock wrote:
> What problem does this resolve? I tested it against the cache
> flush/NCQ
> write switching problem we've been trying to solve, and it
> doesn't look
> like it fixes that one - if I apply this patch and then remove the
> udelay(20) in sata_nv.c that I added which preven
Tejun Heo wrote:
> Which kernel version are you using? The following commit should have
> fixed the problem. Please give a shot at 2.6.24-rc5. Thanks.
>
> commit 32ebbc0c0d5d18c0135b55d1eb0029f48c54aff0
> Author: Tejun Heo <[EMAIL PROTECTED]>
> Date: Thu Nov 8 13:09:00 2007 +0900
>
> libata
hi,
The below error happens when i rmmod sata_nv in adma mode on ck804
chipset with 2.6.24 kernel.
I traced the code and found that the driver attempts to write device mem
that has been unmapped.
Only simply removing the code" writew(0, mmio + NV_ADMA_CTL);" in the
nv_adma_port_stop function or re
From: Kuan Luo <[EMAIL PROTECTED]>
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller. NCQ function is disable by default, you can enable it with
'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or
MCP55 rev 0xa2 platform.
Signed-
A pretty good way. I will modify my code.
-Original Message-
From: Andrew Morton [mailto:[EMAIL PROTECTED]
Sent: Wednesday, June 27, 2007 5:21 PM
To: Kuan Luo
Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Peer Chen
Subject: Re: [PATCH] ata: Add the SW NCQ support to sata_nv for
ion be done in a more type-friendly way?
Yes, i am sure.
I allocated prdt memory of 32 commands.
pp->prd = dmam_alloc_coherent(dev, ATA_PRD_TBL_SZ * ATA_MAX_QUEUE,
&pp->prd_dma, GFP_KERNEL);
Maybe below way is more type-friendly.
prd = pp->prd + ATA_MAX_PRD * qc
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller.
NCQ function is disable by default, you can enable it with 'swncq=1'
Signed-off-by: Kuan Luo <[EMAIL PROTECTED]>
Signed-off-by: Peer Chen <[EMAIL PROTECTED]>
---
diff -Nurp a/sata_nv.c b/sat
Thanks for your comment, see the explaination inline.
We'll apply your advice in later patch.
-Original Message-
From: Robert Hancock [mailto:[EMAIL PROTECTED]
Sent: Friday, May 18, 2007 9:48 AM
To: Peer Chen
Cc: linux-kernel@vger.kernel.org; Jeff Garzik;
[EMAIL PROTECTED]; Kua
13 matches
Mail list logo