Re: [PATCH][next] net: hns3: Fix uninitialized return from function

在 2021/2/10 23:26, Colin King 写道: From: Colin Ian King Currently function hns3_reset_notify_uninit_enet is returning the contents of the uninitialized variable ret. Fix this by removing ret (since it is no longer used) and replace it with a return of the literal value 0. you can not

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

On 2019/1/1 9:22, dann frazier wrote: On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and

Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

On 2018/8/26 2:07, Andrew Lunn wrote: This patch is a  theoretical protect, and the problem does not really happen. I think you really get the point, do you think we need this patch? I think it is not needed. And if it was needed, it would indicate there is a bug somewhere else. Hi,

Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

On 2018/8/26 2:07, Andrew Lunn wrote: This patch is a  theoretical protect, and the problem does not really happen. I think you really get the point, do you think we need this patch? I think it is not needed. And if it was needed, it would indicate there is a bug somewhere else. Hi,

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 00/11] add some new features and fix some bugs

On 2018/1/12 1:07, David Miller wrote: From: Peng Li Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver.

Re: [PATCH net-next 00/11] add some new features and fix some bugs

On 2018/1/12 1:07, David Miller wrote: From: Peng Li Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver. [patch 3/11] adds

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" <lipeng...@huawei.com> Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch,

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted.

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted. [patch 12/20 ]

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" <lipeng...@huawei.com> Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new fea

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 -

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

On 2017/12/20 3:18, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:24 +0800 @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv) return ret; } +static void hns3_put_ring_config(struct hns3_nic_priv *priv) +{ +

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

On 2017/12/20 3:18, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:24 +0800 @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv) return ret; } +static void hns3_put_ring_config(struct hns3_nic_priv *priv) +{ + struct

Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

On 2017/12/20 3:16, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:23 +0800 @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) ae_dev->priv = NULL; } +static u32 hclge_get_max_channels(struct hnae3_handle

Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

On 2017/12/20 3:16, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:23 +0800 @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) ae_dev->priv = NULL; } +static u32 hclge_get_max_channels(struct hnae3_handle *handle) +{ +

Re: [PATCH net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

On 2017/12/18 17:08, Sergei Shtylyov wrote: On 12/18/2017 12:31 PM, Lipeng wrote: TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43 (net: hns3: Add tc-based TM support for sriov

Re: [PATCH net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

On 2017/12/18 17:08, Sergei Shtylyov wrote: On 12/18/2017 12:31 PM, Lipeng wrote: TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43 (net: hns3: Add tc-based TM support for sriov

Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features

On 2017/12/18 17:07, Sergei Shtylyov wrote: Hello! On 12/18/2017 12:31 PM, Lipeng wrote: From: Fuyun Liang commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization) adds default supported features for phy, but our hardware Ten cited

Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features

On 2017/12/18 17:07, Sergei Shtylyov wrote: Hello! On 12/18/2017 12:31 PM, Lipeng wrote: From: Fuyun Liang commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization) adds default supported features for phy, but our hardware Ten cited commit's summary needs

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

On 2017/11/8 22:30, Andrew Lunn wrote: On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

On 2017/11/8 22:30, Andrew Lunn wrote: On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5 bits. So 0-31 are all

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

please ignore this patch-set. I should remove "{topost}" from the subject. sorry for that, I will resend the patch-set. On 2017/11/8 15:31, Lipeng wrote: This patch-set introduces some bug fixes and code improvements. As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

please ignore this patch-set. I should remove "{topost}" from the subject. sorry for that, I will resend the patch-set. On 2017/11/8 15:31, Lipeng wrote: This patch-set introduces some bug fixes and code improvements. As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently

Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

On 2017/11/4 3:52, Florian Fainelli wrote: On 11/02/2017 09:18 PM, Lipeng wrote: From: Fuyun Liang This patch adds set_link_ksettings support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng ---

Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

On 2017/11/4 3:52, Florian Fainelli wrote: On 11/02/2017 09:18 PM, Lipeng wrote: From: Fuyun Liang This patch adds set_link_ksettings support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++