Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio

2021-04-20 Thread liulongfang
On 2021/4/20 20:59, Jason Gunthorpe wrote: > On Tue, Apr 20, 2021 at 08:50:12PM +0800, liulongfang wrote: >> On 2021/4/19 20:33, Jason Gunthorpe wrote: >>> On Mon, Apr 19, 2021 at 08:24:40PM +0800, liulongfang wrote: >>> >>>>> I'm also confused how thi

Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio

2021-04-20 Thread liulongfang
On 2021/4/19 20:33, Jason Gunthorpe wrote: > On Mon, Apr 19, 2021 at 08:24:40PM +0800, liulongfang wrote: > >>> I'm also confused how this works securely at all, as a general rule a >>> VFIO PCI driver cannot access the MMIO memory of the function it is >>>

Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio

2021-04-19 Thread liulongfang
On 2021/4/16 6:01, Jason Gunthorpe wrote: > On Tue, Apr 13, 2021 at 11:36:22AM +0800, Longfang Liu wrote: >> Register the live migration driver of the accelerator module to vfio >> >> Signed-off-by: Longfang Liu >> drivers/vfio/pci/vfio_pci.c | 11 +++ >>

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-17 Thread liulongfang
On 2021/4/16 23:20, Alan Stern wrote: > On Fri, Apr 16, 2021 at 10:03:21AM +0800, liulongfang wrote: >> On 2021/4/15 22:43, Alan Stern wrote: >>> On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: >>>> When the number of ports on the USB hub is 0, skip t

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-16 Thread liulongfang
On 2021/4/16 23:20, Alan Stern wrote: > On Fri, Apr 16, 2021 at 10:03:21AM +0800, liulongfang wrote: >> On 2021/4/15 22:43, Alan Stern wrote: >>> On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: >>>> When the number of ports on the USB hub is 0, skip t

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread liulongfang
On 2021/4/15 20:34, Greg KH wrote: > On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: >> When the number of ports on the USB hub is 0, skip the registration >> operation of the USB hub. > > That's crazy. Why not fix the hardware? How has this hub passed the > USB certification

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread liulongfang
On 2021/4/15 22:43, Alan Stern wrote: > On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: >> When the number of ports on the USB hub is 0, skip the registration >> operation of the USB hub. >> >> The current Kunpeng930's XHCI hardware controller is defective. The number >> of ports on

Re: [RFC PATCH v3 0/3] vfio/hisilicon: add acc live migration driver

2021-04-12 Thread liulongfang
On 2021/4/13 9:20, Longfang Liu wrote: > The live migration solution relies on the vfio_device_migration_info protocol. > The structure vfio_device_migration_info is placed at the 0th offset of > the VFIO_REGION_SUBTYPE_MIGRATION region to get and set VFIO device related > migration information.

Re: [RFC PATCH v3 0/3] vfio/hisilicon: add acc live migration driver

2021-04-12 Thread liulongfang
On 2021/4/12 16:53, Longfang Liu wrote: > The live migration solution relies on the vfio_device_migration_info protocol. > The structure vfio_device_migration_info is placed at the 0th offset of > the VFIO_REGION_SUBTYPE_MIGRATION region to get and set VFIO device related > migration information.

Re: [PATCH v2] USB:ohci:fix ohci interruption problem

2021-04-11 Thread liulongfang
On 2021/4/9 23:07, Alan Stern wrote: > On Fri, Apr 09, 2021 at 03:47:02PM +0800, Longfang Liu wrote: >> The operating method of the system entering S4 sleep mode: >> echo reboot > /sys/power/disk >> echo disk > /sys/power/state >> >> When OHCI enters the S4 sleep state, check the log and find that

Re: [PATCH v4] USB:ehci:fix Kunpeng920 ehci hardware problem

2021-04-09 Thread liulongfang
On 2021/4/9 16:31, Longfang Liu wrote: > Kunpeng920's EHCI controller does not have SBRN register. > Reading the SBRN register when the controller driver is > initialized will get 0. > > When rebooting the EHCI driver, ehci_shutdown() will be called. > if the sbrn flag is 0, ehci_shutdown() will

Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread liulongfang
On 2021/4/8 22:53, Alan Stern wrote: > On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote: >> (1) Add a whitelist for EHCI devices without SBRN registers. >> (2) Add Kunpeng920's EHCI device to the whitelist. >> >> Changes in v2: >> - Fix some code style issues. >> - Update

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread liulongfang
On 2021/4/8 17:22, Greg KH Wrote: > On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote: >> Some types of EHCI controllers do not have SBRN registers. >> By comparing the white list, the operation of reading the SBRN >> registers is skipped. >> >> Subsequent EHCI controller types without

Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-08 Thread liulongfang
On 2021/4/8 17:33, Oliver Neukum wrote: > Am Donnerstag, den 08.04.2021, 17:11 +0800 schrieb Longfang Liu: >> Some types of EHCI controllers do not have SBRN registers. >> By comparing the white list, the operation of reading the SBRN >> registers is skipped. >> >> Subsequent EHCI controller types

Re: [PATCH 0/2] USB:ehci:fix the no SRBN register problem

2021-04-08 Thread liulongfang
On 2021/4/8 17:09, Longfang Liu wrote: > (1) Add a whitelist for EHCI devices without SBRN registers. > (2) Add Kunpeng920's EHCI device to the whitelist. > > Longfang Liu (2): > USB:ehci:Add a whitelist for EHCI controllers > USB:ehci:fix Kunpeng920 ehci hardware problem > >

Re: [PATCH] USB:ehci:fix ehci hardware problem

2021-04-08 Thread liulongfang
On 2021/4/8 15:03, Longfang Liu wrote: > When rebooting the EHCI driver, ehci_shutdown() will be called. > if the sbrn flag is 0, ehci_shutdown() will return directly. > > Our EHCI hardware does not define the SBRN register, which cause > its value to default to 0. The sbrn flag being 0 will

Re: [PATCH] USB:ohci:fix ohci interruption problem

2021-04-06 Thread liulongfang
2021/4/2 23:26, Alan Stern 写道: > On Fri, Apr 02, 2021 at 05:27:59PM +0800, Longfang Liu wrote: >> The operating method of the system entering S4 sleep mode: >> echo disk > /sys/power/state > > This discussion is still not right. > The operating method is: echo reboot > /sys/power/disk echo disk

Re: [PATCH] USB:ohci:fix ohci interruption problem

2021-04-02 Thread liulongfang
On 2021/4/2 17:11, Longfang Liu wrote: > The operating method of the system entering S4 sleep mode: > echo disk > /sys/power/state > > When OHCI enters the S4 sleep state, the USB sleep process will call > check_root_hub_suspend() and ohci_bus_suspend() instead of > ohci_suspend() and

Re: [RFC PATCH] USB:ohci:fix ohci interruption problem

2021-03-29 Thread liulongfang
On 2021/3/26 23:28, Alan Stern wrote: > On Fri, Mar 26, 2021 at 04:54:56PM +0800, Longfang Liu wrote: >> When OHCI enters the S4 sleep state, the USB sleep process will call >> check_root_hub_suspend() and ohci_bus_suspend() instead of >> ohci_suspend() and ohci_bus_suspend(), this causes the OHCI

Re: [PATCH] crypto: hisilicon/sec - Fix a module parameter error

2021-03-27 Thread liulongfang
On 2021/3/27 17:29, Longfang Liu Wrote: > ctx_q_num is a module parameter set by the user to specify the > number of qp queues required to create a ctx. > > When the number of qp queues allocated by PF or VF is less than > the ctx_q_num, an error will be reported when ctx is initialized > in

Re: [RFC PATCH] USB:XHCI:Adjust the log level of hub

2021-03-25 Thread liulongfang
On 2021/3/25 18:31, Greg KH wrote: > On Thu, Mar 25, 2021 at 06:04:12PM +0800, Longfang Liu wrote: >> When the number of ports of the hub is not between 1 and Maxports, >> it will only exit the registration of the hub on the current controller, >> but it will not affect the function of the

Re: [PATCH v3 1/2] crypto: hisilicon/sec - fixes some log printing style

2021-03-12 Thread liulongfang
On 2021/3/12 20:59, Herbert Xu wrote: > On Thu, Mar 04, 2021 at 02:18:54PM +0800, Longfang Liu wrote: >> >> @@ -727,7 +725,7 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, >> struct sec_req *req, >> struct aead_request *aead_req = req->aead_req.aead_req; >> struct

Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error

2021-03-03 Thread liulongfang
On 2021/3/4 12:41, Herbert Xu wrote: > On Sat, Feb 20, 2021 at 05:51:22PM +0800, liulongfang wrote: > . >> Since patch3 is an unnecessary patch, >> can you just remove it and merge patch1 and patch2? > > Please repost. > > Thanks, > Ok. Thanks, Longfang

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-03-03 Thread liulongfang
On 2021/3/4 9:35, Peter Chen wrote: > On 21-02-27 11:31:00, liulongfang wrote: >> On 2021/2/26 16:38, Greg KH wrote: >>> On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: >>>> Our current XHCI hardware controller has been customized to o

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-28 Thread liulongfang
On 2021/2/28 0:27, Alan Stern Wrote: > On Sat, Feb 27, 2021 at 11:38:08AM +0800, liulongfang wrote: >> On 2021/2/27 0:30, Alan Stern wrote: >>> On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: >>>> Our current XHCI hardware controller has been customize

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-26 Thread liulongfang
On 2021/2/27 11:38, liulongfang wrote: > On 2021/2/27 0:30, Alan Stern wrote: >> On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: >>> Our current XHCI hardware controller has been customized to only >>> support USB 2.0 ports. When using the current xhci dri

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-26 Thread liulongfang
On 2021/2/27 0:30, Alan Stern wrote: > On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: >> Our current XHCI hardware controller has been customized to only >> support USB 2.0 ports. When using the current xhci driver, an xhci >> controller device and an ehci controller device will be

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-26 Thread liulongfang
On 2021/2/26 17:22, Mathias Nyman wrote: > On 26.2.2021 10.21, Longfang Liu wrote: >> Our current XHCI hardware controller has been customized to only >> support USB 2.0 ports. When using the current xhci driver, an xhci >> controller device and an ehci controller device will be created >>

Re: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller

2021-02-26 Thread liulongfang
On 2021/2/26 16:38, Greg KH wrote: > On Fri, Feb 26, 2021 at 04:21:37PM +0800, Longfang Liu wrote: >> Our current XHCI hardware controller has been customized to only >> support USB 2.0 ports. > > That sounds like a spec violation, right? Why do you want to do this? > > greg k-h > . > I hope

Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-20 Thread liulongfang
On 2021/2/5 19:44, Herbert Xu Wrote: > On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote: >> If this configuration item is not turned on, >> the allocation of crypto_tfm will fail when >> the shash algorithm calculates the hash >> through the software. >> >> Signed-off-by: Longfang Liu

Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-20 Thread liulongfang
On 2021/2/18 10:06, Herbert Xu wrote: > On Thu, Feb 18, 2021 at 10:01:58AM +0800, liulongfang wrote: >> >>>> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c >>>> b/drivers/crypto/hisilicon/sec2/sec_crypto.c >>>> index d2c4a2c..988faf7 10

Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-17 Thread liulongfang
On 2021/2/10 14:43, Herbert Xu Wrote: > On Sun, Feb 07, 2021 at 06:04:40PM +0800, Longfang Liu wrote: >> If the header file "crypto/internal/hash.h" not >> added, the allocation of crypto_tfm will fail when >> the shash algorithm calculates the hash >> through the software. >> >> Signed-off-by:

Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-07 Thread liulongfang
On 2021/2/7 16:02, Ard Biesheuvel wrote: > On Sun, 7 Feb 2021 at 03:47, liulongfang wrote: >> >> On 2021/2/5 19:44, Herbert Xu write: >>> On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote: >>>> If this configuration item is not turned on, >>

Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-06 Thread liulongfang
On 2021/2/5 19:44, Herbert Xu write: > On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote: >> If this configuration item is not turned on, >> the allocation of crypto_tfm will fail when >> the shash algorithm calculates the hash >> through the software. >> >> Signed-off-by: Longfang Liu

Re: [PATCH v2 0/6] crypto: hisilicon - enable new algorithms of SEC

2021-02-04 Thread liulongfang
On 2021/1/4 19:33, Herbert Xu Wrote: > On Mon, Jan 04, 2021 at 04:15:13PM +0800, liulongfang wrote: >> >> Currently, we have not conducted Fuzz testing. >> For SEC driver, we only adds support for these new algorithms >> with existing interfaces of Crypto. So, do

Re: [PATCH v2] USB:ehci:fix an interrupt calltrace error

2021-01-11 Thread liulongfang
On 2021/1/12 1:07, Alan Stern Wrote: > On Mon, Jan 11, 2021 at 07:29:37PM +0800, Longfang Liu wrote: >> The system that use Synopsys USB host controllers goes to suspend >> when using USB audio player. This causes the USB host controller >> continuous send interrupt signal to system, When the

Re: [PATCH] USB:ehci:fix an interrupt calltrace error

2021-01-11 Thread liulongfang
On 2020/11/28 11:22, liulongfang Wrote: > On 2020/11/27 23:47, Alan Stern Wrote: >> On Fri, Nov 27, 2020 at 10:29:03AM +0800, liulongfang wrote: >>> On 2020/11/27 0:08, Alan Stern Wrote: >>>> On Thu, Nov 26, 2020 at 11:34:33AM +0800, Longfang Liu wrote: >>>&

Re: [PATCH v2 0/6] crypto: hisilicon - enable new algorithms of SEC

2021-01-04 Thread liulongfang
On 2021/1/3 5:00, Herbert Xu wrote: > On Thu, Dec 10, 2020 at 07:10:01PM +0800, Longfang Liu wrote: >> Add support for new algorithms of SEC accelerator on Kunpeng930, >> the driver and test case needs to be updated >> >> Longfang Liu (5): >> crypto: hisilicon/sec - add new type of sqe for

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-07 Thread liulongfang
On 2020/12/7 15:47, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 03:46:28PM +0800, liulongfang wrote: >> >> I need to use "__packed __aligned(n)" to make sure the structure length is >> normal. >> Is it possible to use "__packed __aligned(n)" in th

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/7 11:45, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 11:43:38AM +0800, liulongfang wrote: >> >> Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? > > We normally just use __aligned(n) in the kernel. > > Cheers, > I need to use "

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> ---

Re: [PATCH 0/5] crypto: hisilicon - add some new algorithms

2020-12-06 Thread liulongfang
On 2020/12/7 9:33, Herbert Xu wrote: > On Mon, Dec 07, 2020 at 09:20:05AM +0800, liulongfang wrote: >> >> Did any test case tests fail? > > You tell me :) > > If it passed all of the tests in your testing, please state that > in the cover letter or in one of the

Re: [PATCH 0/5] crypto: hisilicon - add some new algorithms

2020-12-06 Thread liulongfang
On 2020/12/4 15:05, Herbert Xu wrote: > On Thu, Nov 26, 2020 at 10:18:01AM +0800, Longfang Liu wrote: >> As the new Kunpeng930 supports some new algorithms, >> the driver needs to be updated >> >> Longfang Liu (4): >> crypto: hisilicon/sec - add new type of sqe for Kunpeng930 >> crypto:

Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930

2020-12-06 Thread liulongfang
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h

Re: [PATCH] USB:ehci:fix an interrupt calltrace error

2020-11-28 Thread liulongfang
On 2020/11/27 23:47, Alan Stern Wrote: > On Fri, Nov 27, 2020 at 10:29:03AM +0800, liulongfang wrote: >> On 2020/11/27 0:08, Alan Stern Wrote: >>> On Thu, Nov 26, 2020 at 11:34:33AM +0800, Longfang Liu wrote: >>>> The system goes to suspend when using USB audio pl

Re: [PATCH] USB:ehci:fix an interrupt calltrace error

2020-11-26 Thread liulongfang
On 2020/11/27 0:08, Alan Stern Wrote: > On Thu, Nov 26, 2020 at 11:34:33AM +0800, Longfang Liu wrote: >> The system goes to suspend when using USB audio player. This causes >> the USB device continuous send interrupt signal to system, When the >> number of interrupts exceeds 10, the system