Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-30 Thread liuyonglong
On 2019/7/31 13:44, Heiner Kallweit wrote: > On 31.07.2019 05:33, liuyonglong wrote: >> >> >> On 2019/7/31 3:04, Heiner Kallweit wrote: >>> On 30.07.2019 08:35, liuyonglong wrote: >>>> :/sys/kernel/debug/tracing$ cat trace >>>> # tracer: n

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-30 Thread liuyonglong
On 2019/7/31 3:04, Heiner Kallweit wrote: > On 30.07.2019 08:35, liuyonglong wrote: >> :/sys/kernel/debug/tracing$ cat trace >> # tracer: nop >> # >> # entries-in-buffer/entries-written: 45/45 #P:128 >> # >> #

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-30 Thread liuyonglong
On 2019/7/30 14:35, liuyonglong wrote: > :/sys/kernel/debug/tracing$ cat trace > # tracer: nop > # > # entries-in-buffer/entries-written: 45/45 #P:128 > # > # _-=> irqs-off > #

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-30 Thread liuyonglong
fconfig-1327 [011] 187.196036: mdio_access: mii-:bd:00.1 read phy:0x03 reg:0x00 val:0x1040 ifconfig-1327 [011] 187.196046: mdio_access: mii-:bd:00.1 write phy:0x03 reg:0x00 val:0x1840 On 2019/7/30 14:08, Heiner Kallweit wrote: > On 30.07.2019 06:03, li

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-29 Thread liuyonglong
On 2019/7/30 4:57, Heiner Kallweit wrote: > On 29.07.2019 05:59, liuyonglong wrote: >> >> >> On 2019/7/27 2:14, Heiner Kallweit wrote: >>> On 26.07.2019 11:53, Yonglong Liu wrote: >>>> According to the datasheet of Marvell phy and Realtek phy, the

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-28 Thread liuyonglong
On 2019/7/27 2:14, Heiner Kallweit wrote: > On 26.07.2019 11:53, Yonglong Liu wrote: >> According to the datasheet of Marvell phy and Realtek phy, the >> copper link status should read twice, or it may get a fake link >> up status, and cause up->down->up at the first time when link up. >> This

Re: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-26 Thread liuyonglong
On 2019/7/27 6:18, Joe Perches wrote: > On Fri, 2019-07-26 at 22:00 +, Saeed Mahameed wrote: >> On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote: >>> From: Yonglong Liu >>> >>> Some times just see the eth interface have been down/up via >>> dmesg, but can not know why the eth down. So

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread liuyonglong
As Saeed said, we will use netif_msg_drv() which is default off, this can be easily open with ethtool. Thanks for your reply! On 2019/7/26 9:28, Jakub Kicinski wrote: > On Thu, 25 Jul 2019 21:59:08 +, Saeed Mahameed wrote: >> I couldn't find any rules regarding what to put in kernel log,

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread liuyonglong
We will change all of them to netif_msg_drv() which is default off Thanks for your reply! On 2019/7/26 5:59, Saeed Mahameed wrote: > On Thu, 2019-07-25 at 20:28 +0800, liuyonglong wrote: >> >> On 2019/7/25 3:12, Saeed Mahameed wrote: >>> On Wed, 2019-07-24 at 11:18 +

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-25 Thread liuyonglong
On 2019/7/25 21:08, Andrew Lunn wrote: >> You are discussing about the DT configuration, is Matthias Kaehlcke's work >> also provide a generic way to configure PHY LEDS using ACPI? > > In general, you should be able to use the same properties in ACPI as > DT. If the device_property_read_X()

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread liuyonglong
On 2019/7/25 3:12, Saeed Mahameed wrote: > On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: >> From: Yonglong Liu >> >> Some times just see the eth interface have been down/up via >> dmesg, but can not know why the eth down. So adds some debug >> messages to identify the cause for this.

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-25 Thread liuyonglong
On 2019/7/25 12:28, Andrew Lunn wrote: > On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: >>> Revert "net: hns: fix LED configuration for marvell phy" >>> This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. >>> >>> An

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread liuyonglong
> Revert "net: hns: fix LED configuration for marvell phy" > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > Andrew Lunn says this should be handled another way. > > Signed-off-by: David S. Miller Hi Andrew: I see this patch have been reverted, can you tell me the better way