zsmalloc.c: s/of/or, s/give/given
Signed-off-by: Shijie Luo
Signed-off-by: Miaohe Lin
---
include/linux/gfp.h| 2 +-
include/linux/mmzone.h | 2 +-
mm/rmap.c | 2 +-
mm/swap.c | 4 ++--
mm/swap_state.c| 2 +-
mm/z3fold.c| 2 +-
mm/zsmalloc.c
zsmalloc.c: s/of/or, s/give/given
Signed-off-by: Shijie Luo
Signed-off-by: Miaohe Lin
---
include/linux/gfp.h| 2 +-
include/linux/mmzone.h | 2 +-
mm/rmap.c | 2 +-
mm/swap.c | 4 ++--
mm/swap_state.c| 2 +-
mm/z3fold.c| 2 +-
mm/zsmalloc.c
pter_t *)SCSIHOST2ADAP(SCP2HOST(scp))
So fix those by enclosed by parentheses.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/mbox_defs.h| 2 +-
drivers/scsi/megaraid/mega_common.h | 16
drivers/scsi/megaraid/megaraid_sas.h | 6 +++---
3
}
+ else
So fix them all.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/megaraid_mbox.c | 57 ++---
drivers/scsi/megaraid/megaraid_mm.c | 10 ++---
drivers/scsi/megaraid/megaraid_sas_base.c | 7 ++--
d
Following error is reported by checkpatch.pl
ERROR: code indent should use tabs where possible
+^I^Iunsigned long arg)$
So fix them all.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/mega_common.h | 2 +-
drivers/scsi/megaraid/megaraid_mm.c | 2 +-
drivers/scsi
There are several kinds of error are reported by checkpatch.pl.
So fix them together.
Luo Jiaxing (8):
scsi: megaraid: clean up for white space
scsi: megaraid_sas: use parentheses to enclose macros with complex
values
scsi: megaraid: clean up for blank lines
scsi: megaraid: clean up
Following error is reported by checkpatch.pl:
ERROR: do not initialise statics to 0
+static int megaraid_expose_unconf_disks = 0;
So fix them.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/megaraid_mbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
There are some blank line alerts when running
checkpatch.pl, so fix them together here.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/mbox_defs.h| 1 -
drivers/scsi/megaraid/megaraid_ioctl.h | 4 ---
drivers/scsi/megaraid/megaraid_mm.h | 1 -
drivers/scsi
;buf_vaddr, $
ERROR: need consistent spacing around '*' (ctx:WxV)
+ u32 reply_q_sz = sizeof(u32) *(instance->max_mfi_cmds + 1);
so fix them together here.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/mbox_defs.h | 20 +--
drivers/scsi/megaraid
Following error is reported by checkpatch.pl:
"foo * bar" should be "foo *bar"
+ struct megasas_iocpacket __user * user_ioc,
The format of the pointer variable must be "foo *bar", so fix
them.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/me
Following error is reported by checkpatch.pl:
ERROR: trailing statements should be on next line
+ if (iterator++ == adapno) break;
So fix them.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/megaraid/megaraid_mbox.c | 30 --
drivers/scsi/megaraid
Some errors are found like below when run checkpatch.pl
ERROR: space prohibited before that ',' (ctx:WxW)
+int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha , void *piomb);
It all about white space, so fix them.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
--
There are few error about open brace is reported by checkpatch.pl:
ERROR: that open brace { should be on the previous line
+static struct error_fw flash_error_table[] =
+{
So fix them all.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
---
drivers/scsi/pm8001/pm8001_ctl.c | 6
Several error is reported by checkpatch.pl, here are two patches to clean
them up.
---
v1->v2:
1. modify AAP1_MEMMAP() to inline function
2. set flash_command_table and flash_error_table as const
v2->v3:
1. use lower case names for AAP1_MEMMAP
---
Luo J
Some errors are found like below when run checkpatch.pl
ERROR: space prohibited before that ',' (ctx:WxW)
+int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha , void *piomb);
It all about white space, so fix them.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
--
There are few error about open brace is reported by checkpatch.pl:
ERROR: that open brace { should be on the previous line
+static struct error_fw flash_error_table[] =
+{
So fix them all.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
---
drivers/scsi/pm8001/pm8001_ctl.c | 6
Several error is reported by checkpatch.pl, here are two patches to clean
them up.
---
v1->v2:
1. modify AAP1_MEMMAP() to inline function
2. set flash_command_table and flash_error_table as const
---
Luo Jiaxing (2):
scsi: pm8001: clean up for white space
scsi: pm8
Several error is reported by checkpatch.pl, here are two patches to clean
them up.
Luo Jiaxing (2):
scsi: pm8001: clean up for white space
scsi: pm8001: clean up for open brace
drivers/scsi/pm8001/pm8001_ctl.c | 8 +++-
drivers/scsi/pm8001/pm8001_hwi.c | 14 +++---
drivers/scsi
Many error are found like below when run checkpatch.pl
ERROR: space prohibited before that ',' (ctx:WxW)
+int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha , void *piomb);
It all about white space, so fix them.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
--
There are few error about open brace is reported by checkpatch.pl:
ERROR: that open brace { should be on the previous line
+static struct error_fw flash_error_table[] =
+{
So fix them all.
Signed-off-by: Jianqin Xie
Signed-off-by: Luo Jiaxing
---
drivers/scsi/pm8001/pm8001_ctl.c | 6
One checkpatch error is found in sas_to_ata_err() that switch and case is
not at the same indent. So fix it.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/libsas/sas_ata.c | 74 ---
1 file changed, 34 insertions(+), 40 deletions(-)
diff --git a/drivers
Some checkpatch errors are found that some white spaces are missing or
being used inappropriately. So fix them all.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/libsas/sas_discover.c | 2 +-
drivers/scsi/libsas/sas_expander.c | 15 ---
2 files changed, 9 insertions(+), 8 deletions
Two types of errors are detected by the checkpatch.
1. Alignment between switches and cases
2. Improper use of some spaces
Here are the clean up patches.
Luo Jiaxing (2):
scsi: libsas: make switch and case at the same indent in
sas_to_ata_err()
scsi: libsas: clean up for white spaces
to prevent users
from mistakenly considering non-removable disks as removable disks and
performing related operations.
Signed-off-by: Xingui Yang
Signed-off-by: Luo Jiaxing
Reviewed-by: John Garry
---
drivers/ata/ahci.c| 5 +
drivers/ata/ahci.h| 1 +
drivers/ata/libahci.c | 5
在 2021/3/9 21:37, Jeff Layton 写道:
On Thu, 2021-02-25 at 22:58 -0500, Luo Longjun wrote:
Commit fd7732e033e3 ("fs/locks: create a tree of dependent requests.")
has put blocked locks into a tree.
So, with a for loop, we can't check all locks information.
To solve this pro
stination, and no NUL-terminated string is
automatically added. There are some potential risks.
So use snprintf() to replace strncpy().
Signed-off-by: Luo Jiaxing
---
drivers/gpu/drm/nouveau/nvkm/engine/device/user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/dr
Commit fd7732e033e3 ("fs/locks: create a tree of dependent requests.")
has put blocked locks into a tree.
So, with a for loop, we can't check all locks information.
To solve this problem, we should traverse the tree.
Signed-off-by: Luo Longjun
---
stination, and no NUL-terminated is
automatically added. There are some potential risks.
Signed-off-by: Luo Jiaxing
---
drivers/gpu/drm/nouveau/nvkm/engine/device/user.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/user
After switch to new allocator, dev is no longer used here and should be
deleted.
Fixes: 461619f5c324 ("drm/nouveau: switch to new allocator")
Signed-off-by: Luo Jiaxing
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/d
nouveau_framebuffer_new() call drm_format_info_plane_width() to get a width
of plane, but width is not used then, so it's a useless function call here.
Signed-off-by: Luo Jiaxing
---
drivers/gpu/drm/nouveau/nouveau_display.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_prepare’:
drivers/gpu/drm/nouveau/dispnv50/disp.c:1413:6: warning: variable ‘ret’ set but
not used [-Wunused-but-set-variable]
1413 | int ret;
| ^~~
Signed-off-by: Luo Jiaxing
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 8
Commit fd7732e033e3 ("fs/locks: create a tree of dependent requests.")
has put blocked locks into a tree.
So, with a for loop, we can't check all locks information.
To solve this problem, we should traverse the tree by non-recursion DFS.
Signed-off-by: Luo Longjun
---
Commit fd7732e033e3 ("fs/locks: create a tree of dependent requests.")
has put blocked locks into a tree.
So, with a for loop, we can't check all locks information.
To solve this problem, we should traverse the tree by DFS.
Signed-off-by: Luo Longjun
---
patch set contains a bugfix patch and a patch
for appending debugging information.
Luo Jiaxing (2):
irqchip/gic-v3-its: don't set bitmap for LPI which user didn't
allocate
genirq/msi: add an error print when __irq_domain_alloc_irqs() failed
drivers/irqchip/irq-gic-v3-its.c | 4 ++
allocate the same numbers of interrupts next time.
Therefore, clear the redundant bits set in LPI bitmap.
Fixes: 4615fbc3788d ("genirq/irqdomain: Don't try to free an interrupt that has
no mapping")
Signed-off-by: Luo Jiaxing
---
drivers/irqchip/irq-gic-v3-its.c | 4
1
().
Signed-off-by: Luo Jiaxing
---
kernel/irq/msi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index b338d62..f8729b0 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -418,6 +418,7 @@ int __msi_domain_alloc_irqs(struct irq_domain *domain,
struct
There is no need to use API with _irqsave in omap_gpio_irq_handler(),
because it already be in a irq-disabled context.
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-omap.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers
There is no need to use API with _irqsave in hard IRQ handler, So replace
those with spin_lock.
Luo Jiaxing (2):
gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in
omap_gpio_irq_handler()
gpio: grgpio: Replace spin_lock_irqsave with spin_lock in
grgpio_irq_handler
There is no need to use API with _irqsave in omap_gpio_irq_handler(),
because it already be in a irq-disabled context.
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-omap.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers
There is no need to use API with _irqsave in grgpio_irq_handler(),
because it already be in a irq-disabled context.
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-grgpio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio
There is no need to use API with _irqsave in hard IRQ handler, So replace
those with spin_lock.
Luo Jiaxing (2):
gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in
omap_gpio_irq_handler()
gpio: grgpio: Replace spin_lock_irqsave with spin_lock in
grgpio_irq_handler
kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
unused variables. So delete it.
Reported-by: kernel test robot
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-hisi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c
3. Replace "hisi-ngpio" with "ngpios", fix firmware too
4. Direction setting is modified to be handle by generic GPIO
5. Add error code print
6. Some tiny clean up
---
Luo Jiaxing (3):
gpio: gpio-hisi: Add HiSilicon GPIO support
MAINTAINER
0x20
}
})
}
}
Signed-off-by: Luo Jiaxing
---
drivers/gpio/Kconfig | 11 ++
drivers/gpio/Makefile| 1 +
drivers/gpio/gpio-hisi.c | 328 +++
3 files changed, 340 insertions(+)
create mode 100644 drivers/gpio/gpio-hisi.c
diff
Enable GPIO controller for HiSilicon's ARM SoC.
GPIO is common driver for HiSilicon's ARM SoC and it provide support for
some function of I2C and SPI.
Signed-off-by: Luo Jiaxing
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/d
Here add maintainer information for HiSilicon GPIO driver.
Signed-off-by: Luo Jiaxing
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2daa6ee..8d13419a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7896,6 +7896,13 @@ L: dmaeng
Here add maintainer information for HiSilicon GPIO driver.
Signed-off-by: Luo Jiaxing
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2daa6ee..8d13419a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7896,6 +7896,13 @@ L: dmaeng
0x20
}
})
}
}
Signed-off-by: Luo Jiaxing
---
drivers/gpio/Kconfig | 11 ++
drivers/gpio/Makefile| 1 +
drivers/gpio/gpio-hisi.c | 356 +++
3 files changed, 368 insertions(+)
create mode 100644 drivers/gpio/gpio-hisi.c
diff
Enable GPIO controller for HiSilicon's ARM SoC.
GPIO is common driver for HiSilicon's ARM SoC and it provide support for
some function of I2C and SPI.
Signed-off-by: Luo Jiaxing
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/d
This series is the GPIO driver for HiSilicon's ARM SoC.
It provide patches for device driver, MAINTAINER file, and enable gpio-hisi
at defconfig.
Thanks
Jiaxing
Luo Jiaxing (3):
gpio: gpio-hisi: Add HiSilicon GPIO support
MAINTAINERS: Add maintainer for HiSilicon GPIO driver
h it's
irq_data too. For example, in __irq_enable(), IRQD_IRQ_DISABLED and
IRQD_IRQ_MASKED are both clear, but GPIO controller do not perform unmask.
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-dwapb.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpio/gpio-dwapb.c b/d
managed GPIO-chip add data
method")
Signed-off-by: Luo Jiaxing
Acked-by: Serge Semin
Reviewed-by: Andy Shevchenko
---
v1->v2:
1. reduce calltrace log
2. delete blank line in tag block
---
---
drivers/gpio/gpio-dwapb.c | 2 ++
1 file changed, 2 insertions(
uot;gpio: dwapb: Use resource managed GPIO-chip add data
method")
Signed-off-by: Luo Jiaxing
---
drivers/gpio/gpio-dwapb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 2a9046c..4275c18 100644
--- a/drivers/gpio/gpio-dwapb.c
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at dwc3 debugfs to reduce some duplicated
code.
While at that, also use DEFINE_SHOW_ATTRIBUTE() where possible.
Signed-off-by: Luo Jiaxing
Acked-by: Felipe Balbi
---
drivers/usb/dwc3/debugfs.c
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but many of drivers want a helper macro for read-write
file too.
So we make one to decrease code duplication.
Signed-off-by: Luo Jiaxing
---
include/linux/seq_file.h | 15 +++
1 file
o's comment to v1->v2's revision description.
2.Fixed a spelling mistakes of "marco" to "macro".
---
Luo Jiaxing (5):
seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
scsi:
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at qla2xxx to reduce some duplicated code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/qla2xxx/qla_dfs.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we use it at our code to reduce some duplicated code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 135 --
1 file changed, 16 insertions(+), 119
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at drm/i915/display to reduce some
duplicated code.
Signed-off-by: Luo Jiaxing
---
.../gpu/drm/i915/display/intel_display_debugfs.c | 55 ++
1 file changed, 4 insertions(+), 51
Fix a mutex_unlock() issue where before copy_from_user() is
not called mutex_locked.
Fixes: 4b1a29a7f542 ("error-injection: Support fault injection framework")
Reported-by: Hulk Robot
Signed-off-by: Luo Meng
---
kernel/fail_function.c | 5 +++--
1 file changed, 3 insertions(+), 2
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at drm/i915/display to reduce some
duplicated code.
Signed-off-by: Luo Jiaxing
---
.../gpu/drm/i915/display/intel_display_debugfs.c | 55 ++
1 file changed, 4 insertions(+), 51
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we use it at our code to reduce some duplicated code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 135 --
1 file changed, 16 insertions(+), 119
to DEFINE_SHOW_STORE_ATTRIBUTE().
v2->v3:
1.Fixed some spelling mistakes in commit.
2.Revised resumes are added for easy tracing.
---
Luo Jiaxing (5):
seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but many of drivers want a helper macro for read-write
file too.
So we make one to decrease code duplication.
Signed-off-by: Luo Jiaxing
---
include/linux/seq_file.h | 15 +++
1 file
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at qla2xxx to reduce some duplicated code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/qla2xxx/qla_dfs.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a
Seq introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, so we apply it at dwc3 debugfs to reduce some duplicated
code.
While at that, also use DEFINE_SHOW_ATTRIBUTE() where possible.
Signed-off-by: Luo Jiaxing
Acked-by: Felipe Balbi
---
drivers/usb/dwc3/debugfs.c
May I ask what's the map that fd 0 is mapped to? IIUC, it looks like
the tests (of tracing programs) access the map of fd 0 and the
verifier complains the map is not preallocated. I think it's faster
just ask here.
Thanks,
Hao
On Thu, Oct 29, 2020 at 1:49 PM Hao Luo wrote:
>
> S
Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, So we apply it at qla2xxx to reduce some duplicate code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/qla2xxx/qla_dfs.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a
Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, So we use it at our code to reduce some duplicate code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 135 --
1 file changed, 16 insertions(+), 119
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers also want a helper marco for
read-write file too.
So we try to add this macro to help decrease code duplication.
Luo Jiaxing (5):
seq_file: Introduce
Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate
code.
Signed-off-by: Luo Jiaxing
---
drivers/usb/dwc3/debugfs.c | 52 --
1 file changed, 4 insertions(+), 48
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers want a helper marco for
read-write file too.
So we try to make one to decrease code duplication.
Signed-off-by: Luo Jiaxing
---
include/linux/seq_file.h | 15
Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
Read-Write file, So we apply it at drm/i915/display to reduce some
duplicate code.
Signed-off-by: Luo Jiaxing
---
.../gpu/drm/i915/display/intel_display_debugfs.c | 55 ++
1 file changed, 4 insertions(+), 51
Sure, let me take a look at it.
On Thu, Oct 29, 2020 at 1:43 PM Andrii Nakryiko
wrote:
>
> Hao,
>
> This seems to be coming from resolve_pseudo_ldimm64(), could you
> please take a look? Thanks!
>
> -- Andrii
>
> On Thu, Oct 29, 2020 at 5:58 AM kernel test robot wrote:
> >
> > Greeting,
> >
> >
Seq instroduce a new helper marco DEFINE_STORE_ATTRIBUTE for
Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate
code.
Signed-off-by: Luo Jiaxing
---
drivers/usb/dwc3/debugfs.c | 52 --
1 file changed, 4 insertions(+), 48
Seq instroduce a new helper marco DEFINE_STORE_ATTRIBUTE for
Read-Write file, So we use it at our code to reduce some duplicate code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 135 --
1 file changed, 16 insertions(+), 119 deletions
Seq instroduce a new helper marco DEFINE_STORE_ATTRIBUTE for
Read-Write file, So we apply it at drm/i915/display to reduce some
duplicate code.
Signed-off-by: Luo Jiaxing
---
.../gpu/drm/i915/display/intel_display_debugfs.c | 55 ++
1 file changed, 4 insertions(+), 51
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers want a helper marco for
read-write file too.
So we try to make one to decrease code duplication.
Signed-off-by: Luo Jiaxing
---
include/linux/seq_file.h | 15
Seq instroduce a new helper marco DEFINE_STORE_ATTRIBUTE for
Read-Write file, So we apply it at qla2xxx to reduce some duplicate code.
Signed-off-by: Luo Jiaxing
---
drivers/scsi/qla2xxx/qla_dfs.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers also want a helper marco for
read-write file too.
So we try to add this macro to help decrease code duplication.
Luo Jiaxing (5):
seq_file: Introduce
On Tue, Oct 20, 2020 at 10:10 AM Andrii Nakryiko
wrote:
>
> On Tue, Oct 20, 2020 at 10:05 AM Hao Luo wrote:
> >
> > Thanks for reporting this and cc'ing me. I forgot to update the error
> > messages when renaming the flags. I will send a patch to fix the error
&g
Thanks for reporting this and cc'ing me. I forgot to update the error
messages when renaming the flags. I will send a patch to fix the error
message.
The commit
commit f3d9054ba8ff1df0fc44e507e3a01c0964cabd42
Author: Hao Luo
AuthorDate: Wed Jul 8 13:44:10 2020 -0700
btf_encoder:
to lock the pte resp. page_table_lock again..
Fixes: a7f40cfe3b7a ("mm: mempolicy: make mbind() return -EIO when
MPOL_MF_STRICT is specified")
Signed-off-by: Shijie Luo
Signed-off-by: Miaohe Lin
---
mm/mempolicy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
On 2020/10/19 14:59, Michal Hocko wrote:
On Fri 16-10-20 22:11:51, Shijie Luo wrote:
When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks
and passing origin pte - 1 to pte_unmap_unlock seems like not a good idea.
This would really benefit from some improvements.
When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks
and passing origin pte - 1 to pte_unmap_unlock seems like not a good idea.
Signed-off-by: Shijie Luo
Signed-off-by: Michal Hocko
Signed-off-by: Miaohe Lin
---
mm/mempolicy.c | 6 +++---
1 file changed, 3 inser
On 2020/10/16 22:05, osalva...@suse.de wrote:
On 2020-10-16 15:42, Michal Hocko wrote:
OK, I finally managed to convince my friday brain to think and grasped
what the code is intended to do. The loop is hairy and we want to
prevent from spurious EIO when all the pages are on a proper node. So
th
On 2020/10/15 20:58, osalva...@suse.de wrote:
On 2020-10-15 14:15, Shijie Luo wrote:
When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks
and passing origin pte - 1 to pte_unmap_unlock seems like not a good
idea.
Signed-off-by: Shijie Luo
Signed-off-by: linm
When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks
and passing origin pte - 1 to pte_unmap_unlock seems like not a good idea.
Signed-off-by: Shijie Luo
Signed-off-by: linmiaohe
---
mm/mempolicy.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Ack. Sent one with just deletion.
Hao
On Tue, Oct 6, 2020 at 7:04 PM Alexei Starovoitov
wrote:
>
> On Tue, Oct 06, 2020 at 06:23:13PM -0700, Hao Luo wrote:
> > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched
> > the order of check_subprogs() a
k for subprogs comes first. It's now
pointless to validate that half of ldimm64 won't be the last
instruction.
Tested:
# ./test_verifier
Summary: 1129 PASSED, 537 SKIPPED, 0 FAILED
and the full set of bpf selftests.
Fixes: 4976b718c355 ("bpf: Introduce pseudo_btf_id")
Sig
k for subprogs comes first. It's now
pointless to validate that half of ldimm64 won't be the last
instruction.
Tested:
# ./test_verifier
Summary: 1129 PASSED, 537 SKIPPED, 0 FAILED
and the full set of bpf selftests.
Fixes: 4976b718c355 ("bpf: Introduce pseudo_btf_id")
Sig
On Tue, Oct 6, 2020 at 5:43 PM Andrii Nakryiko
wrote:
>
> On Tue, Oct 6, 2020 at 4:45 PM Hao Luo wrote:
> >
> > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched
> > the order of check_subprogs() and resolve_pseudo_ldimm() in
> > the verif
k for subprogs comes
first. Fix the expection of the error message.
Tested:
# ./test_verifier
Summary: 1130 PASSED, 538 SKIPPED, 0 FAILED
and the full set of bpf selftests.
Fixes: 4976b718c355 ("bpf: Introduce pseudo_btf_id")
Signed-off-by: Hao Luo
---
tools/testing/selftests/bpf/ver
Ack. Will do.
On Tue, Oct 6, 2020 at 12:05 PM Alexei Starovoitov
wrote:
>
> On Tue, Sep 29, 2020 at 4:50 PM Hao Luo wrote:
> >
> > - ret = replace_map_fd_with_map_ptr(env);
> > - if (ret < 0)
> > - goto skip_full_check;
> > -
&g
Thanks, Alexei and Andrii and other reviewers for the comments. It's a
pleasure to work with you and contribute to bpf.
Hao
On Fri, Oct 2, 2020 at 3:16 PM Alexei Starovoitov
wrote:
>
> On Tue, Sep 29, 2020 at 11:48 PM Hao Luo wrote:
> >
> > Ah, this is the bug in pahole
PM Alexei Starovoitov
wrote:
>
> On Tue, Sep 29, 2020 at 4:50 PM Hao Luo wrote:
> >
> > v3 -> v4:
> > - Rebasing
> > - Cast bpf_[per|this]_cpu_ptr's parameter to void __percpu * before
> >passing into per_cpu_ptr.
>
&g
On Mon, Sep 21, 2020 at 11:11 AM Andrii Nakryiko
wrote:
>
> On Thu, Sep 17, 2020 at 12:14 PM Hao Luo wrote:
> >
> > I need to cast the pointer to "const void __percpu *" before passing
> > into per_cpu_ptr. I will update and resend.
>
> You can try jus
Hi, Andrii,
Thanks for taking a look. Sorry for the late reply. Spent some time on
rebasing and fixing a build issue in my development environment that
started happening in v5.9.
On Mon, Sep 21, 2020 at 11:09 AM Andrii Nakryiko
wrote:
>
> On Wed, Sep 16, 2020 at 3:39 PM Hao Luo
: Hao Luo
---
.../testing/selftests/bpf/prog_tests/ksyms.c | 38 --
.../selftests/bpf/prog_tests/ksyms_btf.c | 70 +++
.../selftests/bpf/progs/test_ksyms_btf.c | 23 ++
tools/testing/selftests/bpf/trace_helpers.c | 27 +++
tools/testing/selftests/bpf
y: Andrii Nakryiko
Signed-off-by: Hao Luo
---
include/linux/bpf_verifier.h | 7 ++
include/linux/btf.h| 15
include/uapi/linux/bpf.h | 36 +++---
kernel/bpf/btf.c | 15
kernel/bpf/verifier.c | 125 +
1 - 100 of 376 matches
Mail list logo
