Re: [PATCH v1 0/2] scsi: libsas: few clean up patches

2021-04-08 Thread luojiaxing
kindly ping Hi, jejb, martin, would you mind to take a look for these tiny clean up patches. Thanks Jiaxing On 2021/3/25 20:29, Luo Jiaxing wrote: Two types of errors are detected by the checkpatch. 1. Alignment between switches and cases 2. Improper use of some spaces Here are the

Re: [PATCH v2 0/2] scsi: pm8001: tiny clean up patches

2021-04-08 Thread luojiaxing
A reply to v1 cause v2 code need to be modified, so please ignore this, and directly check v3 later. Thanks Jiaxing On 2021/4/7 18:07, Luo Jiaxing wrote: Several error is reported by checkpatch.pl, here are two patches to clean them up. --- v1->v2: 1. modify AAP1_MEMMAP() to

Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space

2021-04-08 Thread luojiaxing
On 2021/4/8 5:56, Bart Van Assche wrote: On 4/5/21 11:39 PM, luojiaxing wrote: On 2021/4/3 0:01, Bart Van Assche wrote: On 4/2/21 2:08 AM, Luo Jiaxing wrote:   #define AAP1_MEMMAP(r, c) \ -    (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) * 32 \ +    (*(u32 *)(

Re: [PATCH v2] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

2021-04-06 Thread luojiaxing
On 2021/4/2 6:34, Jolly Shah wrote: Hi Luojiaxing, On Mon, Mar 22, 2021 at 1:41 AM luojiaxing wrote: On 2021/3/20 20:14, John Garry wrote: On 19/03/2021 01:43, Jason Yan wrote: 在 2021/3/19 6:56, Jolly Shah 写道: When the cache_type for the scsi device is changed, the scsi layer issues

Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

2021-04-06 Thread luojiaxing
On 2021/4/3 0:03, Bart Van Assche wrote: On 4/2/21 2:08 AM, Luo Jiaxing wrote: -static struct flash_command flash_command_table[] = -{ +static struct flash_command flash_command_table[] = { {"set_nvmd",FLASH_CMD_SET_NVMD}, {"update", FLASH_CMD_UPDATE}, {"",

Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space

2021-04-06 Thread luojiaxing
On 2021/4/3 0:01, Bart Van Assche wrote: On 4/2/21 2:08 AM, Luo Jiaxing wrote: #define AAP1_MEMMAP(r, c) \ - (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) * 32 \ + (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + (r) * 32 \ + (c))) Since

Re: [PATCH v1] ata: ahci: Disable SXS for Hisilicon Kunpeng920

2021-03-31 Thread luojiaxing
kindly ping. Hi, Jens,  are there any further comments from you? Two weeks from your first comment now. And it's a bugfix for our SoC, So the customer is asking whether this patch is merged or not. They want to pull back. Thanks Jiaxing On 2021/3/12 18:24, Luo Jiaxing wrote: From:

Re: [PATCH v2] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

2021-03-22 Thread luojiaxing
handle ata non data commands separately so num_scatter and total_xfer_len remain 0. Fixes: 53de092f47ff ("scsi: libsas: Set data_dir as DMA_NONE if libata marks qc as NODATA") Signed-off-by: Jolly Shah Reviewed-by: John Garry @luojiaxing, can you please test this? Sure

Re: [PATCH v1] ata: ahci: Disable SXS for Hisilicon Kunpeng920

2021-03-15 Thread luojiaxing
On 2021/3/12 22:27, Jens Axboe wrote: Is this controller arm exclusive? Yes, our SoC is base on ARM64 only. Thanks Jiaxing

Re: [Linuxarm] [PATCH v1] drm/nouveau/device: append a NUL-terminated character for the string which filled by strncpy()

2021-02-27 Thread luojiaxing
; linux...@openeuler.org; luojiaxing Subject: [Linuxarm] [PATCH v1] drm/nouveau/device: append a NUL-terminated character for the string which filled by strncpy() Following warning is found when using W=1 to build kernel: In function ‘nvkm_udevice_info’, inlined from ‘nvkm_udevice_mthd

Re: [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock

2021-02-09 Thread luojiaxing
On 2021/2/9 17:42, Andy Shevchenko wrote: On Tue, Feb 9, 2021 at 11:24 AM luojiaxing wrote: On 2021/2/8 21:28, Andy Shevchenko wrote: On Mon, Feb 8, 2021 at 11:11 AM luojiaxing wrote: Sorry, my operation error causes a patch missing from this patch set. I re-send the patch set. Please

Re: [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock

2021-02-09 Thread luojiaxing
On 2021/2/8 21:28, Andy Shevchenko wrote: On Mon, Feb 8, 2021 at 11:11 AM luojiaxing wrote: Sorry, my operation error causes a patch missing from this patch set. I re-send the patch set. Please check the new one. What is the new one?! You have to give proper versioning and change log

Re: [PATCH v1 1/2] irqchip/gic-v3-its: don't set bitmap for LPI which user didn't allocate

2021-02-08 Thread luojiaxing
On 2021/2/8 19:59, Marc Zyngier wrote: On 2021-02-08 10:58, Luo Jiaxing wrote: The driver sets the LPI bitmap of device based on get_count_order(nvecs). This means that when the number of LPI interrupts does not meet the power of two, redundant bits are set in the LPI bitmap. However, when

Re: [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock

2021-02-08 Thread luojiaxing
Sorry, my operation error causes a patch missing from this patch set. I re-send the patch set. Please check the new one. On 2021/2/8 16:56, Luo Jiaxing wrote: There is no need to use API with _irqsave in hard IRQ handler, So replace those with spin_lock. Luo Jiaxing (2): gpio: omap:

Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()

2020-12-22 Thread luojiaxing
On 2020/12/21 18:35, Andy Shevchenko wrote: On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing wrote: kernel test rebot report that dat, set and clr in hisi_gpio_probe() is unused variables. So delete it. Fixes: tag? Fixes: 356b01a986a5 ("gpio: gpio-hisi: Add HiSilicon GPIO support") Should

Re: [PATCH v1 1/3] gpio: gpio-hisi: Add HiSilicon GPIO support

2020-12-09 Thread luojiaxing
On 2020/12/7 7:12, Linus Walleij wrote: Hi Luo! thanks for your patch! I see that Andy already provided a crowd of comments, here are some more! On Wed, Dec 2, 2020 at 10:32 AM Luo Jiaxing wrote: +config GPIO_HISI + tristate "HISILICON GPIO controller driver" + depends on

Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

2020-12-07 Thread luojiaxing
On 2020/12/7 2:50, Marc Zyngier wrote: On 2020-12-06 15:02, Linus Walleij wrote: On Sat, Dec 5, 2020 at 11:15 PM Serge Semin wrote: Hmm, that sounds like a problem, but the explanation is a bit unclear to me. AFAICS you are saying that the only callbacks which are called during the IRQ

Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

2020-12-07 Thread luojiaxing
On 2020/12/6 23:02, Linus Walleij wrote: On Sat, Dec 5, 2020 at 11:15 PM Serge Semin wrote: Hmm, that sounds like a problem, but the explanation is a bit unclear to me. AFAICS you are saying that the only callbacks which are called during the IRQ request/release are the irq_enable(), right?

Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

2020-12-07 Thread luojiaxing
On 2020/12/6 6:15, Serge Semin wrote: On Tue, Dec 01, 2020 at 04:59:21PM +0800, luojiaxing wrote: On 2020/11/30 19:22, Andy Shevchenko wrote: On Mon, Nov 30, 2020 at 05:36:19PM +0800, Luo Jiaxing wrote: The mask and unmask registers are not configured in dwapb_irq_enable

Re: [PATCH v1 1/3] gpio: gpio-hisi: Add HiSilicon GPIO support

2020-12-04 Thread luojiaxing
Hi On 2020/12/2 18:04, Andy Shevchenko wrote: On Wed, Dec 02, 2020 at 05:32:21PM +0800, Luo Jiaxing wrote: This GPIO driver is for HiSilicon's ARM SoC. HiSilicon's GPIO controller support double-edge interrupt and multi-core concurrent access. ACPI table example for this GPIO controller:

Re: [RFC PATCH v1 1/4] irqchip/gic-v4.1: Plumb get_irqchip_state VLPI callback

2020-12-01 Thread luojiaxing
On 2020/11/28 18:18, Marc Zyngier wrote: On Sat, 28 Nov 2020 07:19:48 +, luojiaxing wrote: Hi, shenming I got few questions about this patch. Although it's a bit late and not very appropriate, I'd like to ask before you send next version. On 2020/11/23 14:54, Shenming Lu wrote: From

Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

2020-12-01 Thread luojiaxing
On 2020/11/30 19:22, Andy Shevchenko wrote: On Mon, Nov 30, 2020 at 05:36:19PM +0800, Luo Jiaxing wrote: The mask and unmask registers are not configured in dwapb_irq_enable() and dwapb_irq_disable(). In the following situations, the IRQ will be masked by default after the IRQ is enabled:

Re: [RFC PATCH v1 1/4] irqchip/gic-v4.1: Plumb get_irqchip_state VLPI callback

2020-11-28 Thread luojiaxing
Hi, shenming I got few questions about this patch. Although it's a bit late and not very appropriate, I'd like to ask before you send next version. On 2020/11/23 14:54, Shenming Lu wrote: From: Zenghui Yu Up to now, the irq_get_irqchip_state() callback of its_irq_chip leaves

Re: [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

2020-11-05 Thread luojiaxing
Hi , Alan On 2020/11/3 21:45, Alan Stern wrote: On Tue, Nov 03, 2020 at 02:36:44PM +0100, Greg KH wrote: On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers

Re: [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

2020-11-05 Thread luojiaxing
Hi, Greg On 2020/11/3 21:36, Greg KH wrote: On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers also want a helper macro for read-write file too. So we add this

Re: [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

2020-11-03 Thread luojiaxing
Hi On 2020/10/30 16:44, Greg KH wrote: On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers also want a helper marco for read-write file too. So we try to add

Re: [PATCH v1 1/5] seq_file: Introduce DEFINE_STORE_ATTRIBUTE() helper macro

2020-10-23 Thread luojiaxing
Hi On 2020/10/22 22:22, Andy Shevchenko wrote: On Thu, Oct 22, 2020 at 04:39:53PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers want a helper marco for read-write file too. I would expect

Re: [PATCH v1 0/5] Introduce a new helper marco DEFINE_STORE_ATTRIBUTE at seq_file.c

2020-10-23 Thread luojiaxing
Hi On 2020/10/22 20:28, Al Viro wrote: On Thu, Oct 22, 2020 at 04:39:52PM +0800, Luo Jiaxing wrote: We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but we found many of drivers also want a helper marco for read-write file too.

Re: [PATCH net-next] net: stmmac: Remove unused variable 'ret' at stmmac_rx_buf1_len()

2020-09-10 Thread luojiaxing
On 2020/9/11 3:29, Jakub Kicinski wrote: On Thu, 10 Sep 2020 10:42:45 +0800 Luo Jiaxing wrote: Fixes the following warning when using W=1 to build kernel: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret,

Re: [PATCH v2 0/2] scsi: libsas: An improvement on error handle and tidy-up

2020-07-25 Thread luojiaxing
sorry,I missed Martin's e-mail "Re: [PATCH v1 0/2] scsi: libsas: An improvement on error handle and tidy-up" here. Please ignore this set of patches. On 2020/7/25 16:18, Luo Jiaxing wrote: This patch introduces an improvement to reduce error handle time and a tidy-up, including: - postreset()

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread luojiaxing
Hi, Qinglang On 2020/7/16 16:47, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu --- drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++ 1 file changed, 10 insertions(+), 127 deletions(-)