is greater than
maximum supported frequency.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/drivers/media/platform/qcom/venus/pm_helpers.c
index
the mbps calculation in calculate_inst_freq().
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/drivers/media/platform/qcom/venus/pm_helpers.c
the mbps calculation.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/drivers/media/platform/qcom/venus/pm_helpers.c
index 57877ea..001513f
emove CNOC voting while device
suspend")
Signed-off-by: Mansur Alisha Shaik
Reviewed-by: Stephen Boyd
---
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/pla
not entering
to suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume()
and unvote during venus_runtime_suspend().
Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device
suspend")
Signe
As per bandwidth table video driver is voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device
suspend")
Signed-off-by: Mansur Alisha Sh
---
Resending v4 series by correcting fixes tag for all patches in series`
Mansur Alisha Shaik (4):
venus: core: change clk enable and disable order in resume and suspend
venus: core: vote for video-mem path
venus: core: vote with average bandwidth and peak bandwidth as zero
venus: put dummy vote
by putting dummy vote on "video-mem" after last video
session release and unvoting it during suspend.
Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device
suspend")
Signed-off-by: Mansur Alisha Shaik
Reviewed-by: Stephen Boyd
---
Changes in v4:
- As per
As per bandwidth table video driver is voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha Sh
---
Resending v3 patches by correcting fixes tag
Mansur Alisha Shaik (4):
venus: core: change clk enable and disable order in resume and suspend
venus: core: vote for video-mem path
venus: core: vote with average bandwidth and peak bandwidth as zero
venus: put dummy vote on video-mem path after last
by putting dummy vote on "video-mem" after last video
session release and unvoting it during suspend.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha Shaik
Reviewed-by: Stephen Boyd
---
drivers/media/platform/qcom/venus/p
emove CNOC voting while device
suspend")
Signed-off-by: Mansur Alisha Shaik
Reviewed-by: Stephen Boyd
---
- Resending by corecting fixes tag
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/
not entering
to suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume()
and unvote during venus_runtime_suspend().
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-
Add shutdown callback for venus driver.
Handle race conditions in concurrency usecases like
multiple browser YouTube browser tabs(approx 50 tabs)
graphics_Stress, WiFi ON/OFF, Bluetooth ON/OF,
and reboot in parallel.
Mansur Alisha Shaik (3):
venus: core: handle race condititon for core ops
11c/0x12c
Signed-off-by: Mansur Alisha Shaik
Acked-by: Stanimir Varbanov
---
Changes in v5:
- Addressed review comments by stan in v4 version
drivers/media/platform/qcom/venus/hfi.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/hfi.c
b/driv
venus_core_shutdown+0x1c/0x34 [venus_core]
platform_drv_shutdown+0x28/0x34
device_shutdown+0x154/0x1fc
kernel_restart_prepare+0x40/0x4c
kernel_restart+0x1c/0x64
__arm64_sys_reboot+0x190/0x238
el0_svc_common+0xa4/0x154
el0_svc_compat_handler+0x2c/0x38
el0_svc_compat+0x8/0x10
Signed-o
After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which may
lead to crash.
So implemented shutdown callback, which detach iommu maps.
Signed-off-by: Mansur Alisha Shaik
Acked
by putting dummy vote on "video-mem" after last video
session release and unvoting it during suspend.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha Shaik
---
Changes in v3:
- Added fixes tag
drivers/media/platfor
not entering
to suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume()
and unvote during venus_runtime_suspend().
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-
As per bandwidth table video driver is voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha Shaik
---
Ch
locks and pm domains control")
Signed-off-by: Mansur Alisha Shaik
Reviewed-by: Stephen Boyd
---
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/
The intention of this patchset is to correct clock enable and disable
order and vote for venus-ebi and cpucfg paths with average bandwidth
instad of peak bandwidth since with current implementation we are seeing
clock related warning during XO-SD and suspend device while video playback
Mansur
On 2020-09-11 15:52, Stanimir Varbanov wrote:
Hi,
On 9/10/20 3:44 PM, Mansur Alisha Shaik wrote:
In concurrency usecase and reboot scenario we are
observing race condition and seeing NULL pointer
dereference crash. In shutdown path and system
recovery path we are destroying the same mutex
On 2020-09-11 15:40, Stanimir Varbanov wrote:
On 9/10/20 3:44 PM, Mansur Alisha Shaik wrote:
For core ops we are having only write protect but there
is no read protect, because of this in multthreading
and concurrency, one CPU core is reading without wait
which is causing the NULL pointer
On 2020-09-09 00:08, Stephen Boyd wrote:
Quoting Mansur Alisha Shaik (2020-09-07 20:44:38)
Currently we are voting for venus0-ebi path during buffer processing
with an average bandwidth of all the instances and unvoting during
session release.
While video streaming when we try to do XO-SD
As per bandwidth table we are voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
---
Resending as all patches not updated properly because
of some mailing issues
Mansur Alisha Shaik (4):
venus: core: change clk enable and disable order in resume and suspend
venus: core: vote for video-mem path
venus: core: vote with average bandwidth and peak bandwidth as zero
venus: put dummy
mains control")
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/core.c
index 6103aaf..52a3
ting dummy vote on "video-mem" after last video
session release and unvoting it during suspend.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/pm_helpers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/dr
suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume()
and unvote during venus_runtime_suspend().
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alis
On 2020-09-09 00:05, Stephen Boyd wrote:
Quoting Mansur Alisha Shaik (2020-09-07 20:44:05)
Currently video driver is voting after clk enable and un voting
before clk disable. Basically we should vote before clk enable
and un vote after clk disable.
Corrected this by changing the order of clk
---
Resending as all patches not updated properly because
of some mailing issues.
Mansur Alisha Shaik (4):
venus: core: change clk enable and disable order in resume and suspend
venus: core: vote for video-mem path
venus: core: vote with average bandwidth and peak bandwidth as zero
venus: put dummy
mains control")
Signed-off-by: Mansur Alisha Shaik
---
Changes in V2:
- Added fixes tag
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/co
suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume
and unvote during venus_runtime_suspend.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha S
As per bandwidth table we are voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
ting dummy vote on "video-mem" after last video
session release and unvoting it during suspend.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/pm_helpers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/dr
suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume
and unvote during venus_runtime_suspend.
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha S
As per bandwidth table we are voting with average bandwidth
for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
in bandwidth table.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
mains control")
Signed-off-by: Mansur Alisha Shaik
---
Changes in V2:
- Added fixes tag
drivers/media/platform/qcom/venus/core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/co
The intention of this patchset is to correct clock enable and disable
order and vote for venus-ebi and cpucfg paths with average bandwidth
instad of peak bandwidth since with current implementation we are seeing
clock related warning during XO-SD and suspend device while video playback
Mansur
After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which may
lead to crash.
So implemented shutdown callback, which detach iommu maps.
Signed-off-by: Mansur Alisha Shaik
Acked
11c/0x12c
Signed-off-by: Mansur Alisha Shaik
Acked-by: Stanimir Varbanov
---
Changes in V4:
- Addressed review comments by Stan in patch series
https://lore.kernel.org/patchwork/patch/1303678/
and combining this change along with shutdown callback
as we are facing race conditions with shutdown
us_core_shutdown+0x1c/0x34 [venus_core]
platform_drv_shutdown+0x28/0x34
device_shutdown+0x154/0x1fc
kernel_restart_prepare+0x40/0x4c
kernel_restart+0x1c/0x64
__arm64_sys_reboot+0x190/0x238
el0_svc_common+0xa4/0x154
el0_svc_compat_handler+0x2c/0x38
el0_svc_compat+0x8/0x10
Signed-o
Add shutdown callback for venus driver.
Handle race conditions in concurrency usecases like
multiple browser YouTube browser tabs(approx 50 tabs)
graphics_Stress, WiFi ON/OFF, Bluetooth ON/OF,
and reboot in parallel.
Mansur Alisha Shaik (3):
venus: core: handle race condititon for core ops
The intention of this patchset is to handle race
conditions during concurrency usecases like
Multiple YouTube browser tabs(approx 50 plus tabs),
graphics_Stress, WiFi ON/OFF, Bluetooth ON/OF,
and reboot in parallel.
Mansur Alisha Shaik (3):
venus: core: handle race condititon for core ops
venus_core_shutdown+0x1c/0x34 [venus_core]
platform_drv_shutdown+0x28/0x34
device_shutdown+0x154/0x1fc
kernel_restart_prepare+0x40/0x4c
kernel_restart+0x1c/0x64
__arm64_sys_reboot+0x190/0x238
el0_svc_common+0xa4/0x154
el0_svc_compat_handler+0x2c/0x38
el0_svc_compat+0x8/0x10
Signed-o
venus_hfi_destroy+0x28/0x98 [venus_core]
hfi_destroy+0x1c/0x28 [venus_core]
venus_sys_error_handler+0x60/0x14c [venus_core]
process_one_work+0x210/0x3d0
worker_thread+0x248/0x3f4
kthread+0x11c/0x12c
ret_from_fork+0x10/0x18
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus
11c/0x12c
Signed-off-by: Mansur Alisha Shaik
Acked-by: Stanimir Varbanov
---
Changes in V2:
- Addressed review comments by stan by validating on top
- of https://lore.kernel.org/patchwork/project/lkml/list/?series=455962
drivers/media/platform/qcom/venus/hfi.c | 5 -
1 file changed, 4 inserti
suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume
and unvote during venus_runtime_suspend.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 10 +-
1 file changed,
Currently video driver is voting after clk enable and un voting
before clk disable. Basically we should vote before clk enable
and un vote after clk disable.
Corrected this by changing the order of clk enable and clk disable.
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom
ures while streaming.
Mansur Alisha Shaik (2):
venus: core: change clk enable and disable order in resume and suspend
venus: core: vote for video-mem icc path and change avg, peak bw
drivers/media/platform/qcom/venus/core.c | 23 +--
1 file changed, 17 insertions(+), 6
On 2020-08-21 16:29, Stanimir Varbanov wrote:
Hi Mansur,
On 8/10/20 12:50 PM, Stanimir Varbanov wrote:
Hi Mansur,
Thanks for the patches!
On 8/7/20 9:24 AM, Mansur Alisha Shaik wrote:
For core ops we are having only write protect but there
is no read protect, because
errors.
Mansur Alisha Shaik (3):
venus: core: handle race condititon for core ops
venus: core: cancel pending work items in workqueue
venus: handle use after free for iommu_map/iommu_unmap
drivers/media/platform/qcom/venus/core.c | 6 +-
drivers/media/platform/qcom/venus/firmware.c
venus_hfi_destroy+0x28/0x98 [venus_core]
hfi_destroy+0x1c/0x28 [venus_core]
venus_sys_error_handler+0x60/0x14c [venus_core]
process_one_work+0x210/0x3d0
worker_thread+0x248/0x3f4
kthread+0x11c/0x12c
ret_from_fork+0x10/0x18
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus
/0x230 [venus_core]
venus_sys_error_handler+0xa0/0x14c [venus_core]
process_one_work+0x210/0x3d0
worker_thread+0x248/0x3f4
kthread+0x11c/0x12c
ret_from_fork+0x10/0x18
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/firmware.c | 17 +
1 file changed, 13
igned-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 2 +-
drivers/media/platform/qcom/venus/hfi.c | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/core.c
index 203c653
The intenstion of this patchset is to handle race
conditions during concurrency usecase.
Mansur Alisha Shaik (3):
venus: core: handle race condititon for core ops
venus: core: cancel pending work items in workqueue
venus: handle use after free for iommu_map/iommu_unmap
drivers/media
/0x12c
ret_from_fork+0x10/0x18
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/core.c
index fe99c83..41a293e 100644
--- a/drivers
venus_boot+0x184/0x230 [venus_core]
venus_sys_error_handler+0xa0/0x14c [venus_core]
process_one_work+0x210/0x3d0
worker_thread+0x248/0x3f4
kthread+0x11c/0x12c
ret_from_fork+0x10/0x18
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/firmware.c | 17 +
1 file
11c/0x12c
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 2 +-
drivers/media/platform/qcom/venus/hfi.c | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/core.c
inde
.iommu
arm-smmu: consumer: video-firmware.0 supplier=1500.iommu
So implemented shutdown callback, which detach iommu maps.
Signed-off-by: Mansur Alisha Shaik
---
Changes in V3:
- Fix build errors
drivers/media/platform/qcom/venus/core.c | 11 +++
1 file changed, 11 insertions
Hi Sai,
On 2020-06-24 12:17, Sai Prakash Ranjan wrote:
Hi Mansur,
On 2020-06-13 16:03, Mansur Alisha Shaik wrote:
After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which
.iommu
arm-smmu: consumer: video-firmware.0 supplier=1500.iommu
So implemented shutdown callback, which detach iommu maps.
Change-Id: I0f0f331056e0b84b92f1d86f66618d4b1caaa24a
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 11 +++
1 file changed, 11
Hi Stan,
On 2020-06-13 17:43, Stanimir Varbanov wrote:
Hi Mansur,
Thanks for the patch!
How you test this? Is it enough to start playback and issue reboot
(did
you test with reboot -f) ?
Yes, I have tested it with "reboot -f" and started video playback
(YouTube browser and l
.iommu
arm-smmu: consumer: video-firmware.0 supplier=1500.iommu
So implemented shutdown callback, which detach iommu maps.
Change-Id: I0f0f331056e0b84b92f1d86f66618d4b1caaa24a
Signed-off-by: Mansur Alisha Shaik
---
drivers/media/platform/qcom/venus/core.c | 9 +
1 file changed, 9
On 2020-03-11 08:34, Alexandre Courbot wrote:
On Tue, Mar 10, 2020 at 7:07 AM Jeffrey Kardatzke
wrote:
On Thu, Mar 5, 2020 at 11:50 PM Alexandre Courbot
wrote:
>
> On Fri, Mar 6, 2020 at 2:34 PM Mansur Alisha Shaik
> wrote:
> >
> > This change will avoid extra locking
lve this by considering the instances whose session has started.
Signed-off-by: Mansur Alisha Shaik
---
Changes in V2:
- As per Alex and Jeffrey comments, elaborated problem
and addressed review comments.
drivers/media/platform/qcom/venus/pm_helpers.c | 4
1 file changed, 4 insertions(+)
diff --
On 8/11/2014 8:46 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2014-08-05 at 15:51 +0100, One Thousand Gnomes wrote:
>> On Tue, 05 Aug 2014 20:12:09 +0530
>> Vishal Mansur wrote:
>>
>>> EEH kernel services are inconsistently exported by the
>>> kernel. ee
On 8/11/2014 8:46 AM, Benjamin Herrenschmidt wrote:
On Tue, 2014-08-05 at 15:51 +0100, One Thousand Gnomes wrote:
On Tue, 05 Aug 2014 20:12:09 +0530
Vishal Mansur vman...@linux.vnet.ibm.com wrote:
EEH kernel services are inconsistently exported by the
kernel. eeh_check_failure is exported
where caller needs eeh status.
This functionality is provided by eeh_dev_check_failure.
This patch relaxes the export for eeh_dev_check_failure
to make it consistent with eeh_check_failure() and
usable by non-GPL modules.
Signed-off-by: Vishal Mansur
---
arch/powerpc/kernel/eeh.c | 3 +--
1
where caller needs eeh status.
This functionality is provided by eeh_dev_check_failure.
This patch relaxes the export for eeh_dev_check_failure
to make it consistent with eeh_check_failure() and
usable by non-GPL modules.
Signed-off-by: Vishal Mansur
---
arch/powerpc/kernel/eeh.c | 3 +--
1
where caller needs eeh status.
This functionality is provided by eeh_dev_check_failure.
This patch relaxes the export for eeh_dev_check_failure
to make it consistent with eeh_check_failure() and
usable by non-GPL modules.
Signed-off-by: Vishal Mansur vman...@linux.vnet.ibm.com
---
arch/powerpc
where caller needs eeh status.
This functionality is provided by eeh_dev_check_failure.
This patch relaxes the export for eeh_dev_check_failure
to make it consistent with eeh_check_failure() and
usable by non-GPL modules.
Signed-off-by: Vishal Mansur vman...@linux.vnet.ibm.com
---
arch/powerpc
73 matches
Mail list logo
