Re: [PATCH v3 2/2] Bluetooth: Support the vendor specific debug events

> + bt_dev_dbg(hdev, "enable %d", enable); > + > + /* Read the Intel supported features and if new exception formats > + * supported, need to load the additional DDC config to enable. > + */ > + err = btintel_read_debug_features(hdev, &features); > +

Re: [PATCH v3 1/2] Bluetooth: btusb: support link statistics telemetry events

e additional DDC config to enable. > - */ > - btintel_read_debug_features(hdev, &features); > - > - /* Set DDC mask for available debug features */ > - btintel_set_debug_features(hdev, &features); > - > /* Read the Intel version information after loading the FW */ > err = btintel_read_version_tlv(hdev, &version); > if (err) so I don’t like this kind of removing and adding things at the same time. Please separate these patches properly. Regards Marcel

Re: [PATCH] Bluetooth: btusb: fix memory leak

r > Mediatek Chip.") > Signed-off-by: Muhammad Usama Anjum > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 2/2] Bluetooth: btusb: Add support for Lite-On Mediatek Chip

S= 64 Ivl=125us > I: If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us > > Signed-off-by: mark-yw.chen > --- > drivers/bluetooth/btusb.c | 5 + > 1 file changed, 5 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/2] Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.

patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH][next] Bluetooth: virtio_bt: add missing null pointer check on alloc_skb call return

rt for virtio transport driver") > Signed-off-by: Colin Ian King > --- > drivers/bluetooth/virtio_bt.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: Return whether a connection is outbound

> net/bluetooth/hci_event.c| 8 > net/bluetooth/l2cap_core.c | 2 +- > net/bluetooth/mgmt.c | 6 +- > 5 files changed, 12 insertions(+), 7 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH -next] Bluetooth: use flexible-array member instead of zero-length array

; > Signed-off-by: Qiheng Lin > --- > net/bluetooth/msft.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: hci_h5: btrtl: Add quirk for keep power in suspend/resume

reprobe->dev = get_device(&h5->hu->serdev->dev); > + queue_work(system_long_wq, &reprobe->work); > + } > return 0; > } > > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h > index ea4ae551c426..1e4c2a97ab8d 100644 > --- a/include/net/bluetooth/hci.h > +++ b/include/net/bluetooth/hci.h > @@ -246,6 +246,15 @@ enum { >* HCI after resume. >*/ > HCI_QUIRK_NO_SUSPEND_NOTIFIER, > + > + /* When this quirk is set, the controller does not power off > + * during suspend and resume. This mechanism lets BT devices wake > + * the Host up if the Host and chips support. > + * > + * This quirk can be set before hci_register_dev is called or > + * during the hdev->setup vendor callback. > + */ > + HCI_QUIRK_DEVICES_WAKEUP_SUPPORTED, > }; Since this hci_uart specific, please don’t introduce another quirk and keep this internal. Regards Marcel

Re: [PATCH v1] Bluetooth: Return whether a connection is outbound

flags |= MGMT_DEV_CONN_INITIATED_CONNECTION; > + else > + flags &= ~MGMT_DEV_CONN_INITIATED_CONNECTION; > + And then this should be just this: if (conn->out) flags |= MGMT_DEV_CONN_INITIATED_CONNECTION; > ev->flags = __cpu_to_le32(flags); > > /* We must ensure that the EIR Data fields are ordered and Regards Marcel

Re: [PATCH] net/Bluetooth - delete unneeded variable initialization

Hi Kai, > Delete unneeded variable initialization. > > Signed-off-by: Kai Ye > --- > net/bluetooth/6lowpan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: Add ncmd=0 recovery handling

i_skb_pkt_type(skb) = HCI_EVENT_PKT; skb_put_data(skb, hw_err, 3); + bt_dev_err(hdev, "Injecting HCI hardware error event"); + /* Send Hardware Error to upper stack */ return hci_recv_frame(hdev, skb); } This has the advantage that if you take a btmon trace, you know this event is injected. Or more precisely eventually will be able to know since we haven’t merged my patches yet that will redirect bt_dev_{err,warn,..} into btmon as well. Regards Marcel

Re: [PATCH 0/2] Bluetooth: Avoid centralized adv handle tracking for extended features

_adv_instance in adv param MGMT request > > net/bluetooth/hci_event.c | 16 +++- > net/bluetooth/mgmt.c | 1 - > 2 files changed, 7 insertions(+), 10 deletions(-) both patches have been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] net/Bluetooth - use the correct print format

le changed, 8 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/1] Bluetooth: btusb: Enable quirk boolean flag for Mediatek Chip.

Hi Mark, > Adding support LE scatternet and WBS for Mediatek Chip > > Signed-off-by: mark-yw.chen > --- > drivers/bluetooth/btusb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Check inquiry status before sending one

end Discovery MGMT with status > disabled, but we don't cancel the inquiry. > > Signed-off-by: Archie Pusaka > Reviewed-by: Sonny Sasaka > --- > > net/bluetooth/hci_request.c | 3 +++ > 1 file changed, 3 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 0/2] net/Blutooth - Coding style fix

- > net/bluetooth/hci_event.c | 2 +- > net/bluetooth/hci_request.c | 6 ++ > net/bluetooth/l2cap_core.c | 7 +++ > 5 files changed, 11 insertions(+), 17 deletions(-) both patches have been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

Hi Liu On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote: > On Tue, 2021-03-23 at 01:03 +0000, Marcel Ziswiler wrote: > > Hi Liu > > > > Some further discrepancy with them binding examples: > > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (re

Re: [PATCH] Bluetooth: L2CAP: Rudimentary typo fixes

Hi Bhaskar, > s/minium/minimum/ > s/procdure/procedure/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/bluetooth/l2cap_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: SCO - Remove trailing semicolon in macros

Hi Meng, > Macros should not use a trailing semicolon. > > Signed-off-by: Meng Yu > --- > > Changes in v2 > -Modify comments > > net/bluetooth/sco.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Always call advertising disable before setting params

rtising. This can be called > + * whether or not there is an active advertisement. > + */ > + __hci_req_disable_advertising(req); can you include a btmon trace that shows that we don’t get a HCI error. Since if we get one, then the complete request will fail. And that has further side effects. Regards Marcel

Re: [PATCH v1] Bluetooth: Return whether a connection is outbound

hou > Reviewed-by: Alain Michaud > > Signed-off-by: Yu Liu > --- > > Changes in v1: > - Initial change please send a patch to describe the API change in doc/mgmt-api.txt first. Regards Marcel

Re: [PATCH v2] Bluetooth: Remove trailing semicolon in macros

bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: check for zapped sk before connecting

t-Subedi > Reviewed-by: Guenter Roeck > --- > > Changes in v2: > * Modify locking order for better visibility > > net/bluetooth/l2cap_sock.c | 8 ++++ > 1 file changed, 8 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

welcome. Thanks! Cheers Marcel On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > Hi, > > This is the v6 series to add some DRM bridge drivers support > for i.MX8qm/qxp SoCs. > > The bridges may chain one by one to form display pipes to support > LVDS displays. 

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > > v1-

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with padding low per component are transmitted on a 30-bit > input bus(10-bit per

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

ow I just put all the examples from the various Documentation/devicetree/bindings/*/imx8qxp-*.yaml files directly into arch/arm64/boot/dts/freescale/imx8qxp.dtsi. Maybe you do have the various device tree parts available somewhere as well? Any suggestions? Do you by any chance have a git tree av

Re: [PATCH] bluetooth: fix set_ecdh_privkey() prototype

d Bergmann > --- > net/bluetooth/ecdh_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Remove trailing semicolon in macros

Hi Meng, > 1. remove trailing semicolon in macros; > 2. fix some coding style. > > Signed-off-by: Meng Yu > --- > net/bluetooth/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) the patch doesn’t apply to bluetooth-next, please re-base and send again. Regards Marcel

Re: [PATCH] Bluetooth: hci_qca: Mundane typo fix

Hi Bhaskar, > s/packat/packet/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/bluetooth/hci_qca.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: verify AMP hci_chan before amp_destroy

tmail.com > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > --- > > include/net/bluetooth/hci_core.h | 1 + > net/bluetooth/hci_event.c| 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Set CONF_NOT_COMPLETE as l2cap_chan default

on.c:348 > int_ret_from_sys_call+0x25/0xa3 > > Signed-off-by: Archie Pusaka > Reported-by: syzbot+338f014a98367a08a...@syzkaller.appspotmail.com > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Reviewed-by: Guenter Roeck > --- > > net/bluetooth/l2cap_core.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: check for zapped sk before connecting

sock(sk); > + return -EINVAL; > + } > + release_sock(sk); > + hmmm. I wonder if this would look better and easy to see that the locking is done correctly. lock_sock(sk); zapped = sock_flag(sk, SOCK_ZAPPED); release_sock(sk); if (zapped) return -EINVAL; Regards Marcel

Re: [PATCH v1] Bluetooth: Add ncmd=0 recovery handling

gt; + > + bt_dev_err(hdev, "ncmd timeout"); > + > + if (hci_dev_do_close(hdev)) > + return; > + > + hci_dev_do_open(hdev); > +} > + I am pretty certain this can dead-lock if ncmd=0 happens inside hci_dev_do_open,do_close itself. The second thing is that do_close+do_open is heavy hammer you are swinging here. It will also result in mgmt powered down/up. Is this something you really want since bluetoothd will notice this and has to re-init everything. Regards Marcel

Re: [PATCH] Bluetooth: avoid deadlock between hci_dev->lock and socket lock

7 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 > 01 c3 48 8b 0d 52 0f 0c 00 f7 d8 64 89 01 48 > RSP: 002b:7fffcfbbbf08 EFLAGS: 0203 ORIG_RAX: 0037 > RAX: ffda RBX: 0019 RCX: 7fb73df33eee > RDX: 000e RSI: 0112 RDI: 0018 > RBP: R08: 7fffcfbbbf44 R09: > R10: 7fffcfbbbf3c R11: 0203 R12: > R13: 0018 R14: R15: 556fcefc70d0 > > Fixes: eab2404ba798 ("Bluetooth: Add BT_PHY socket option") > Signed-off-by: Jiri Kosina > --- > net/bluetooth/hci_conn.c | 4 > 1 file changed, 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [RFC PATCH v2] Bluetooth: hci_qca: Add device_may_wakeup support

e may wakeup > > Signed-off-by: Venkata Lakshmi Narayana Gubba > --- > drivers/bluetooth/hci_qca.c | 15 +++ > 1 file changed, 15 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Allow scannable adv with extended MGMT APIs

chen Chou > Signed-off-by: Daniel Winkler > --- > > include/net/bluetooth/mgmt.h | 1 + > net/bluetooth/hci_request.c | 3 ++- > net/bluetooth/mgmt.c | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v3 1/1] Bluetooth: Remove unneeded commands for suspend

ions(+), 17 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2 1/1] Bluetooth: Remove unneeded commands for suspend

_u8 *)skb->data); > + struct hci_cp_set_event_filter *cp; > + void *sent; > + > + BT_DBG("%s status 0x%2.2x", hdev->name, status); > + > + sent = hci_sent_cmd_data(hdev, HCI_OP_SET_EVENT_FLT); > + if (!sent || status) > + return; can we do this: if (status) return; sent = hci_.. if (!sent) return; Regards Marcel

Re: [PATCH 2/2] Bluetooth: Remove unneeded commands for suspend

/* Prevent disconnects from causing scanning to be re-enabled */ > hdev->scanning_paused = true; > > @@ -1364,7 +1371,10 @@ void hci_req_prepare_suspend(struct hci_dev *hdev, > enum suspended_state next) > hdev->suspended = false; > hdev->scanning_paused = false; > > + /* Clear any event filters and restore scan state */ > hci_req_clear_event_filter(&req); > + __hci_req_update_scan(&req); > + > /* Reset passive/background scanning to normal */ > __hci_update_background_scan(&req); > /* Enable all of the advertisement filters */ Rest looks good. Regards Marcel

Re: [PATCH 1/2] Bluetooth: Notify suspend on le conn failed

gt; ... > < HCI Command: Set Event Filter (0x03|0x0005) plen 1 > #187808 [hci0] 2021-02-04 09:23:07.313591 >Type: Clear All Filters (0x00) > > net/bluetooth/hci_conn.c | 10 ++ > 1 file changed, 10 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

+-- > net/bluetooth/msft.c | 21 ++--- > 2 files changed, 20 insertions(+), 5 deletions(-) can you please re-base this against bluetooth-next tree since it no longer applies cleanly. Thanks. Regards Marcel

Re: [PATCH 1/1] Bluetooth: btusb: Fix incorrect type in assignment and uninitialized symbol

u to fix incorrect type in assignment. > > Signed-off-by: mark-yw.chen > --- > drivers/bluetooth/btusb.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v1] Bluetooth: hci_qca:Fixed issue during suspend

a > --- > drivers/bluetooth/hci_qca.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btusb: fix excessive stack usage

s intended there is now undone. > > Fixes: 48c13301e6ba ("Bluetooth: btusb: Fine-tune mt7663 mechanism.") > Signed-off-by: Arnd Bergmann > --- > drivers/bluetooth/btusb.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btusb: remove set but not used variable in btusb_mtk_setup_firmware_79xx

used-but-set-variable] > struct btmtk_patch_header *patchhdr = NULL; > ^~~~ > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/bluetooth/btusb.c | 4 > 1 file changed, 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v4] Bluetooth: btusb: Fix typo and correct the log print

the patch again > v3: update bluetooth-next tree and regenerate the patch > v2: correct the log print and update the patch From: and Signed-off-by: > --- > drivers/bluetooth/btusb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v1] Bluetooth: Fix crash in mgmt_add_adv_patterns_monitor_complete

e_work+0x257/0x506 > worker_thread+0x10d/0x284 > kthread+0x14c/0x154 > ? process_one_work+0x506/0x506 > ? kthread_blkcg+0x2c/0x2c > ret_from_fork+0x1f/0x40 > > Reviewed-by: Miao-chen Chou > Reviewed-by: Manish Mandlik > Reviewed-by: Archie Pusaka > Signed-off-by: Howard Chung > --- > > net/bluetooth/mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v3] Bluetooth: btusb: Fix typo and correct the log print

the patch > v2: correct the log print and update the patch From: and Signed-off-by: > --- > drivers/bluetooth/btusb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) this must have been caught up again in between other patches, but it does not apply cleanly anymore. Please rebase again. Regards Marcel

Re: [PATCH v2] Bluetooth: btusb: Fix memory leak in btusb_mtk_wmt_recv

y to bluetooth-next tree. Please rebase. Regards Marcel

Re: [PATCH v2] Bluetooth: btusb: Fix typo and correct the log print

e changed, 2 insertions(+), 2 deletions(-) patch doesn’t not apply cleanly to bluetooth-next tree. Please rebase. Regards Marcel

Re: [PATCH v4 0/2] Bluetooth: btusb: Add protocol for MediaTek bluetooth devices

s > > drivers/bluetooth/btusb.c | 211 +- > 1 file changed, 206 insertions(+), 5 deletions(-) both patches have been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2] Bluetooth: hci_qca: check for SSR triggered flag while suspend

i_qca: Wait for timeout during suspend") > Signed-off-by: Venkata Lakshmi Narayana Gubba > --- > drivers/bluetooth/hci_qca.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v3] Bluetooth: Skip eSCO 2M params when not supported

type instead of adding new field > > Changes in v2: > - Fix title > > Changes in v1: > - Initial change > > include/net/bluetooth/hci_core.h | 1 + > net/bluetooth/hci_conn.c | 20 ++-- > 2 files changed, 19 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt_recv

Hi Jupeng, >>>> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should >>>> be released. >>>> >>>> Signed-off-by: zhongjupeng >>> >>> please provide a proper From: and Signed-off-by line with full name. >&

Re: [PATCH v4] Bluetooth: btrtl: Enable WBS for the specific Realtek devices

d { fix the whitespace part here. > + CHIP_ID_8723A, > + CHIP_ID_8723B, > + CHIP_ID_8821A, > + CHIP_ID_8761A, > + CHIP_ID_8822B = 8, > + CHIP_ID_8723D, > + CHIP_ID_8821C, > + CHIP_ID_8822C = 13, > + CHIP_ID_8761B, > + CHIP_ID_8852A = 18, > +}; > + Regards Marcel

Re: [PATCH v5] Bluetooth: btrtl: Enable WBS for the specific Realtek devices

drivers/bluetooth/btrtl.o drivers/bluetooth/btrtl.c: In function ‘btrtl_setup_realtek’: drivers/bluetooth/btrtl.c:754:1: warning: label ‘done’ defined but not used [-Wunused-label] 754 | done: | ^~~~ Regards Marcel

Re: [PATCH] net/bluetooth: Fix the follow coccicheck warnings

ine with the patch, put please make sure the indentation alignment of the second line is also correct. Regards Marcel

Re: [PATCH v3] Bluetooth: btrtl: Enable WBS for the specific Realtek devices

HIP_ID_8822C: > + case CHIP_ID_8852A: > set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks); > + set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks); > break; > default: > rtl_dev_dbg(hdev, "Central-peripheral role not enabled."); > + rtl_dev_dbg(hdev, "WBS supported not enabled."); > break; > } Regards Marcel

Re: [PATCH v3] Bluetooth: Keep MSFT ext info throughout ahci_dev's life cycle

symmetry and re-read the value every time we init. We can make sure to release the msft_data on unregister. Regards Marcel

Re: [PATCH] Bluetooth: hci_h5: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for btrtl

applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btusb: Add a Kconfig option to disable USB wakeup by default

en quirk it inside the driver. Regards Marcel

Re: [PATCH v2] Bluetooth: btusb: fix memory leak on suspend and resume

notifier_call_chain+0x1a/0x20 > pm_suspend.cold.9+0x334/0x352 > state_store+0x84/0xf0 > kobj_attr_store+0x12/0x20 > sysfs_kf_write+0x3b/0x40 > kernfs_fop_write+0xda/0x1c0 > vfs_write+0xbb/0x250 > ksys_write+0x61/0xe0 > __x64_sys_write+0x1a/0x20 > do_syscall_64+0x37/0x80 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > Fix hci_suspend_notifer(), not to act on events when flag HCI_UNREGISTER > is set. > > Signed-off-by: Vamshi K Sthambamkadi > --- > net/bluetooth/hci_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v5 trivial/resend] dt-bindings: net: btusb: DT fix s/interrupt-name/interrupt-names/

ain > --- > Who takes this patch, before it celebrates its 4th birthday? > > v5: > - Add Reviewed-by, Acked-by, > > v4: > - Add Acked-by, > > v3: > - New. > --- > Documentation/devicetree/bindings/net/btusb.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 3/3] Bluetooth: btusb: Expose reset gpio to debugfs

s/bluetooth/btusb.c | 46 +++ > 1 file changed, 46 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 880e9cd4ee713..702be1871ed88 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -6,6 +6,7 @@ &

Re: [PATCH] Bluetooth: drop HCI device reference before return

1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/3] Bluetooth: btusb: Refactor gpio reset

t Realtek device via gpio"); > - gpiod_set_value_cansleep(reset_gpio, 1); > - msleep(200); > - gpiod_set_value_cansleep(reset_gpio, 0); > + btusb_toggle_gpio(data->reset_gpio, data->reset_duration_ms); > } You need to explain why this patch is correct. You are removing more code here. And there is an extra check in case of Realtek and a large comment. Regards Marcel

Re: [PATCH] Bluetooth: Put HCI device if inquiry procedure interrupts

| 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v6 0/7] MSFT offloading support for advertisement monitor

oth/mgmt.c | 391 +++--- > net/bluetooth/msft.c | 460 ++++++- > net/bluetooth/msft.h | 30 ++ > 7 files changed, 1015 insertions(+), 141 deletions(-) all 7 patches have been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra

Hi Daniel Is it just me or something looks rather askew with the indentation of your dts' (e.g. tabs vs. spaces)? Cheers Marcel On Thu, 2021-01-21 at 15:12 -0800, Daniel Walker wrote: > Add Petra and Hellcat dts file. These platforms are based on > the Xilinx Zynqmp platform. >

Re: [PATCH v2] Bluetooth: btrtl: Add null check in setup

Bluetooth: btrtl: Enable central-peripheral role) > Signed-off-by: Abhishek Pandit-Subedi > --- > > Changes in v2: > - Added nullcheck with goto done > > drivers/bluetooth/btrtl.c | 4 > 1 file changed, 4 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v1] Bluetooth: hci_qca: Wait for SSR completion during suspend

bac5a8 ("Bluetooth: hci_qca: Wait for timeout during suspend") > Signed-off-by: Venkata Lakshmi Narayana Gubba > --- > drivers/bluetooth/hci_qca.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: hci_qca: Fix memleak in qca_controller_memdump

i_qca.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: avoid u128_xor() on potentially misaligned inputs

- > 1 file changed, 2 insertions(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 2/2] Bluetooth: hci_h5: Add support for binding RTL8723DS with device tree

Hi John-Eric, > RTL8723DS could be handled by btrtl-driver, so add ability to bind it > using device tree. > > Signed-off-by: John-Eric Kamps > --- > drivers/bluetooth/hci_h5.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/1] [Add support Mediatek mt7921U]

gt;> doing something wrong. > > We would like to unify state machine, dev allocate, hif_hook and hif_register. > [Unify Common Part]: btmtk_main > State machine: Mediatek chip error recovery > Dev allocate: Bluetooth dev. > Mediatek chip-related behavior: Firmware download. > HCI device-related: hci register, open, close and send_frame. > > [HIF Part] : btmtkusb/btmtksdio/btmtkuart > hif_hook (cif interface): read/write register, open/close, chip reset and etc. > hif_register (cif register): hif registration-related, such as > usb_register/sdio_register_driver. > > May we use the driver architecture? You can do that, but then first start with the existing btmtksdio and btmtkuart drivers to show me how you want to design it. You still have to design it cleanly. Regards Marcel

Re: [PATCH] Bluetooth: btrtl: Add null check in setup

break; > + default: > + rtl_dev_dbg(hdev, > + "Central-peripheral role not enabled."); > + break; > + } > } if (!btrtl_dev->ic_info) goto done; > > btrtl_free(btrtl_dev); Regards Marcel

Re: [PATCH] Bluetooth: btrtl: Enable central-peripheral role

l". > > Reviewed-by: Daniel Winkler > Signed-off-by: Abhishek Pandit-Subedi > --- > > drivers/bluetooth/btrtl.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btusb: Remove duplicate newlines from logging

> 1 file changed, 4 insertions(+), 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v3 4/5] Bluetooth: advmon offload MSFT handle controller reset

ger plans with this struct? I would just skip it. >> > This struct is also used in patch 5/5 to store the "enabled" status of > the filter. > Suspend/resume would need to enable/disable the filter, but it is not > yet implemented in this patch series. just do it without the nested structs. I think you are overdoing it here. Regards Marcel

Re: [PATCH v3 4/5] Bluetooth: advmon offload MSFT handle controller reset

ring:1; > + } flags; > }; hmmm. Do you have bigger plans with this struct? I would just skip it. Regards Marcel

Re: [PATCH v3 2/5] Bluetooth: advmon offload MSFT add monitor

_size += sizeof(*pattern) + entry->length; > + } > + > + cp = kmalloc(total_size, GFP_KERNEL); > + if (!cp) > + return -ENOMEM; > + > + cp->sub_opcode = MSFT_OP_LE_MONITOR_ADVERTISEMENT; > + cp->rssi_high = monitor->rssi.high_threshold; > + cp->rssi_low = monitor->rssi.low_threshold; > + cp->rssi_low_interval = (u8)monitor->rssi.low_threshold_timeout; > + cp->rssi_sampling_period = monitor->rssi.sampling_period; > + > + cp->cond_type = MSFT_MONITOR_ADVERTISEMENT_TYPE_PATTERN; > + > + pattern_data = (void *)cp->data; > + pattern_data->count = pattern_count; > + > + list_for_each_entry(entry, &monitor->patterns, list) { > + pattern = (void *)(pattern_data->data + offset); > + /* the length also includes data_type and offset */ > + pattern->length = entry->length + 2; > + pattern->data_type = entry->ad_type; > + pattern->start_byte = entry->offset; > + memcpy(pattern->pattern, entry->value, entry->length); > + offset += sizeof(*pattern) + entry->length; > + } > + > + hci_req_init(&req, hdev); > + hci_req_add(&req, hdev->msft_opcode, total_size, cp); > + err = hci_req_run_skb(&req, msft_le_monitor_advertisement_cb); > + kfree(cp); > + > + if (!err) > + msft->pending_add_handle = monitor->handle; > + > + return err; > } > diff --git a/net/bluetooth/msft.h b/net/bluetooth/msft.h > index e9c478e890b8..0ac9b15322b1 100644 > --- a/net/bluetooth/msft.h > +++ b/net/bluetooth/msft.h > @@ -12,16 +12,28 @@ > > #if IS_ENABLED(CONFIG_BT_MSFTEXT) > > +bool msft_monitor_supported(struct hci_dev *hdev); > void msft_do_open(struct hci_dev *hdev); > void msft_do_close(struct hci_dev *hdev); > void msft_vendor_evt(struct hci_dev *hdev, struct sk_buff *skb); > __u64 msft_get_features(struct hci_dev *hdev); > +int msft_add_monitor_pattern(struct hci_dev *hdev, struct adv_monitor > *monitor); > > #else > > +static inline bool msft_monitor_supported(struct hci_dev *hdev) > +{ > + return false; > +} > + > static inline void msft_do_open(struct hci_dev *hdev) {} > static inline void msft_do_close(struct hci_dev *hdev) {} > static inline void msft_vendor_evt(struct hci_dev *hdev, struct sk_buff *skb) > {} > static inline __u64 msft_get_features(struct hci_dev *hdev) { return 0; } > +static inline int msft_add_monitor_pattern(struct hci_dev *hdev, > +struct adv_monitor *monitor) > +{ > + return -EOPNOTSUPP; > +} Regards Marcel

Re: [PATCH v3 1/5] Bluetooth: advmon offload MSFT add rssi support

MGMT_OP_ADD_ADV_PATTERNS_MONITOR); > +} > + > +static int add_adv_patterns_monitor_rssi(struct sock *sk, struct hci_dev > *hdev, > + void *data, u16 len) > +{ > + return __add_adv_patterns_monitor(sk, hdev, data, len, > + MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI); > +} > + Is this really the best way to handle this. I would put the parameter parsing into these functions and then call the common function. > static int remove_adv_monitor(struct sock *sk, struct hci_dev *hdev, > void *data, u16 len) > { > @@ -8234,6 +8284,9 @@ static const struct hci_mgmt_handler mgmt_handlers[] = { > HCI_MGMT_VAR_LEN }, > { add_ext_adv_data,MGMT_ADD_EXT_ADV_DATA_SIZE, > HCI_MGMT_VAR_LEN }, > + { add_adv_patterns_monitor_rssi, > +MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE, > + HCI_MGMT_VAR_LEN }, > }; Regards Marcel

Re: [PATCH] Bluetooth:btmtksdio Fixed switch and case should be at the same indent

Hi Jagdish, > Switch and case where not properly aligned > > Signed-off-by: Jagdish Tirumala > --- > drivers/bluetooth/btmtksdio.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: hci_bcm: Add support for ISO packets

Hi Jakub, > This enables bcm driver to properly handle ISO packets. > > Signed-off-by: Jakub Pawlowski > --- > drivers/bluetooth/hci_bcm.c | 1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2 1/4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

ction exactly this way so they are symmetric with hci_dev_do_{open,close}. Regards Marcel

Re: [PATCH v2 3/4] Bluetooth: btusb: Enable MSFT extension for Intel controllers

Miao-chen Chou > Reviewed-by: Abhishek Pandit-Subedi > Reviewed-by: Archie Pusaka > --- > > (no changes since v1) > > drivers/bluetooth/btusb.c | 3 +++ > 1 file changed, 3 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2 2/4] Bluetooth: btqca: Enable MSFT extension for Qualcomm WCN399x

> --- > > (no changes since v1) > > drivers/bluetooth/btqca.c | 13 + > 1 file changed, 13 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v2 4/4] Bluetooth: btrtl: Enable MSFT extension for RTL8822CE controller

d-off-by: Miao-chen Chou > Reviewed-by: Abhishek Pandit-Subedi > Reviewed-by: Archie Pusaka > --- > > (no changes since v1) > > drivers/bluetooth/btrtl.c | 6 ++ > 1 file changed, 6 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: Pause service discovery for suspend

> 1 file changed, 8 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v1] Bluetooth: btusb: add shutdown function for wcn6855

Hi Zijun, > we should send hci reset command before bt turn off, which can reset bt > firmware status. > > Signed-off-by: Tim Jiang > --- > drivers/bluetooth/btusb.c | 15 +++ > 1 file changed, 15 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH 1/1] Bluetooth: Remove hci_req_le_suspend_config

ng suspend task bits") > Reviewed-by: Alain Michaud > Signed-off-by: Abhishek Pandit-Subedi > --- > > net/bluetooth/hci_request.c | 25 - > 1 file changed, 8 insertions(+), 17 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: hci_uart: Fix a race for write_work scheduling

add serdev driver support library") > Signed-off-by: Claire Chang > --- > drivers/bluetooth/hci_ldisc.c | 7 +++ > drivers/bluetooth/hci_serdev.c | 4 ++-- > 2 files changed, 5 insertions(+), 6 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v4] Bluetooth: btqca: Add support to read FW build version for WCN3991 BTSoC

+++ > drivers/bluetooth/btqca.h | 1 + > 2 files changed, 55 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS

he current behavior would be to fall back to alt 0, which can not > possibly work either, and so is no better. > > Signed-off-by: Trent Piepho > --- > drivers/bluetooth/btusb.c | 20 ++-- > 1 file changed, 6 insertions(+), 14 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH] Bluetooth: btqcomsmd: Fix a resource leak in error handling paths in the probe function

> > Fixes: 1511cc750c3d ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI > driver") > Signed-off-by: Christophe JAILLET > --- > drivers/bluetooth/btqcomsmd.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support

ruct mgmt_adv_pattern patterns[]; >>>>> } __packed; >>>> >>>> This is something we can not do. It breaks an userspace facing API. Is the >>>> mgmt opcode 0x0052 in an already released kernel? >>> >>> Yes, the opcode does exist in an already released kernel. >>> >>> The DBus method which accesses this API is put behind the experimental >>> flag, therefore we expect they are flexible enough to support changes. >>> Previously, we already had a discussion in an email thread with the >>> title "Offload RSSI tracking to controller", and the outcome supports >>> this change. >>> >>> Here is an excerpt of the discussion. >> >> it doesn’t matter. This is fixed API now and so we can not just change it. >> The argument above is void. What matters if it is in already released kernel. > > If that is the case, do you have a suggestion to allow RSSI to be > considered when monitoring advertisement? Would a new MGMT opcode with > these parameters suffice? its the only way. Regards Marcel

Re: [PATCH v1] Bluetooth: Set missing suspend task bits

bluetooth/hci_request.c | 8 > 1 file changed, 8 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel

  1   2   3   4   5   6   7   8   9   10   >