[PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" I've been reviewing changes proactively, and plan on doing more of this work. I'm doing this early as I should be getting e-mailed about proposed changes. Signed-off-by: Luis R. Rodriguez --- MAINTAINERS | 1 + 1 file changed, 1

[PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" We've determined that very sadly we cannot nuke the usermode helper. The firmware code is a bit hard to follow, and so is the history, document the reasons for why we cannot remove the usermode helper and the only thing we can do is compartamentalize

[PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" I've been reviewing changes proactively, and plan on doing more of this work. I'm doing this early as I should be getting e-mailed about proposed changes. Signed-off-by: Luis R. Rodriguez --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" We've determined that very sadly we cannot nuke the usermode helper. The firmware code is a bit hard to follow, and so is the history, document the reasons for why we cannot remove the usermode helper and the only thing we can do is compartamentalize it. While it, add

[PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" We need to ensure no one else adds *anything* that requests the usermode helper without really meaning it, to police it we now have an SmPL script but no formal annotation is present to help us ensure the call has been validated. Add a dummy

[PATCH v3 0/5] firmware: add SmPL grammar to avoid issues

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" Greg, This v3 is a simple respin without any modifications other than a rebase from the last v2 series [0] to apply to today's linux-next tre. The v2 series did not make it in in time. [0]

[PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" We need to ensure no one else adds *anything* that requests the usermode helper without really meaning it, to police it we now have an SmPL script but no formal annotation is present to help us ensure the call has been validated. Add a dummy DECLARE_FW_LOADER_USER()

[PATCH v3 0/5] firmware: add SmPL grammar to avoid issues

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" Greg, This v3 is a simple respin without any modifications other than a rebase from the last v2 series [0] to apply to today's linux-next tre. The v2 series did not make it in in time. [0] https://lkml.kernel.org/r/1466117661-22075-1-git-send-email-mcg...@kernel.org

[PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe

2016-08-23 Thread mcgrof
who directly use the request_firmware*() API on the initial probe or init routine. There are 4 offenders at this time: mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report drivers/fmc/fmc-

[PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe

2016-08-23 Thread mcgrof
are*() API on the initial probe or init routine. There are 4 offenders at this time: mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report drivers/fmc/fmc-fakedev.c: ERROR: driver ca

[PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" The firmware cache purposely kills all non-udev (usermode helper) pending requests prior to suspend with kill_requests_without_uevent() right before it calls out to request for firmware for the fw cache. It is pointless to again run into the possible

[PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend

2016-08-23 Thread mcgrof
From: "Luis R. Rodriguez" The firmware cache purposely kills all non-udev (usermode helper) pending requests prior to suspend with kill_requests_without_uevent() right before it calls out to request for firmware for the fw cache. It is pointless to again run into the possible issue of queing up