Re: [PATCH 3/3] thermal: of: notify sensor driver on trip updates

2014-12-01 Thread navneet kumar
On 12/01/2014 01:23 PM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > On Mon, Dec 01, 2014 at 12:45:52PM -0800, navneet kumar wrote: >> Hi Eduardo, >> >> On 11/27/2014 06:32 AM, Eduardo Valentin wrote: >>>> Old Signed by an unknown key >

Re: [PATCH 3/3] thermal: of: notify sensor driver on trip updates

2014-12-01 Thread navneet kumar
Hi Eduardo, On 11/27/2014 06:32 AM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > Hello Navneet, > > On Wed, Nov 26, 2014 at 05:16:29PM -0800, Navneet Kumar wrote: >> From: navneet kumar >> >> some thermal sensor hardwares include logic which &

Re: [PATCH 2/3] thermal: of: consolidate sensor callbacks as ops

2014-12-01 Thread navneet kumar
Hi Eduardo, On 11/27/2014 06:28 AM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > > Hello Navneet, > > On Wed, Nov 26, 2014 at 05:16:28PM -0800, Navneet Kumar wrote: >> From: navneet kumar >> >> Consolidate all the sensor call

[PATCH 2/3] thermal: of: consolidate sensor callbacks as ops

2014-11-26 Thread Navneet Kumar
From: navneet kumar Consolidate all the sensor callbacks (get_temp/get_trend) into a 'thermal_of_sensor_ops' struct. As a part of this, introduce a 'thermal_zone_of_sensor_register2' sensor API that accepts sensor_ops instead of the two callbacks as separate arguments to t

[PATCH 3/3] thermal: of: notify sensor driver on trip updates

2014-11-26 Thread Navneet Kumar
From: navneet kumar some thermal sensor hardwares include logic which can raise interrupts at certain programmed temperature thresholds. Drivers for such sensors should be able to learn the appropriate threshold temperatures for interrupts by querying the thermal framework. This change

[PATCH 1/3] thermal: of: support writable trips via dt

2014-11-26 Thread Navneet Kumar
From: navneet kumar Support writable trip points configuration from the device tree. 'OF' reads this configuration and adjusts the 'trips' mask accordingly to allow the 'set_trip_xxx' calls to be effective. Signed-off-by: Diwakar Tundlam --- drivers/thermal/of-th

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread navneet kumar
On 11/26/2014 01:12 PM, Guenter Roeck wrote: > On 11/26/2014 12:43 PM, navneet kumar wrote: >> >> Hi Eduardo, Lukasz, >> >> [Combining my concerns as a single text blob here] >> >> I. Firstly, with the current patch >> 1. is it really needed to du

Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points

2014-11-26 Thread navneet kumar
Hi Eduardo, Lukasz, [Combining my concerns as a single text blob here] I. Firstly, with the current patch 1. is it really needed to duplicate the struct thermal_trip? Why don’t we get rid of the __thermal_trip and stay with the 'thermal_trip' ? it is not a big change.