Re: [PATCH V2 2/3] scsi: ufs: add a vops to configure VCC voltage level

2021-04-01 Thread nitirawa
On 2021-03-31 23:30, Asutosh Das (asd) wrote: On 3/21/2021 2:57 PM, Nitin Rawat wrote: Add a vops to configure VCC voltage VCC voltage level for platform supporting both ufs2.x and ufs 3.x devices. Suggested-by: Stanley Chu Suggested-by: Asutosh Das Suggested-by: Bjorn Andersson

Re: [PATCH V2 2/3] scsi: ufs: add a vops to configure VCC voltage level

2021-04-01 Thread nitirawa
On 2021-03-31 23:30, Asutosh Das (asd) wrote: On 3/21/2021 2:57 PM, Nitin Rawat wrote: Add a vops to configure VCC voltage VCC voltage level for platform supporting both ufs2.x and ufs 3.x devices. Suggested-by: Stanley Chu Suggested-by: Asutosh Das Suggested-by: Bjorn Andersson

Re: [PATCH V2 3/3] scsi: ufs-qcom: configure VCC voltage level in vendor file

2021-04-01 Thread nitirawa
On 2021-03-31 23:49, Bjorn Andersson wrote: On Wed 24 Mar 16:55 CDT 2021, nitir...@codeaurora.org wrote: On 2021-03-23 20:58, Bjorn Andersson wrote: > On Sun 21 Mar 16:57 CDT 2021, Nitin Rawat wrote: > > > As a part of vops handler, VCC voltage is updated > > as per the ufs device probed after

Re: [PATCH V2 3/3] scsi: ufs-qcom: configure VCC voltage level in vendor file

2021-03-24 Thread nitirawa
On 2021-03-23 20:58, Bjorn Andersson wrote: On Sun 21 Mar 16:57 CDT 2021, Nitin Rawat wrote: As a part of vops handler, VCC voltage is updated as per the ufs device probed after reading the device descriptor. We follow below steps to configure voltage level. 1. Set the device to SLEEP state.

Re: [PATCH V1 0/3] scsi: ufs: Add a vops to configure VCC voltage level

2021-02-19 Thread nitirawa
On 2021-02-08 17:52, Avri Altman wrote: >> The flow should be generic - isn't it? >> Why do you need the entire flow to be vendor-specific? >> Why not just the parameters vendor-specific? >> >> Thanks, >> Avri > > Hi Avri, > This vops change was done as per the below mail thread > discussion

Re: [PATCH V1 0/3] scsi: ufs: Add a vops to configure VCC voltage level

2021-02-08 Thread nitirawa
On 2021-02-01 14:01, nitir...@codeaurora.org wrote: On 2021-01-31 19:32, Avri Altman wrote: UFS specification allows different VCC configurations for UFS devices, for example, (1)2.70V - 3.60V (For UFS 2.x devices) (2)2.40V - 2.70V (For UFS 3.x devices) For platforms

Re: [PATCH V2] scsi: ufs: Add UFS3.0 in ufs HCI version check

2021-02-01 Thread nitirawa
On 2021-01-30 00:55, Bean Huo wrote: On Tue, 2021-01-19 at 17:37 +0530, Nitin Rawat wrote: As per JESD223D UFS HCI v3.0 spec, HCI version 3.0 is also supported. Hence Adding UFS3.0 in UFS HCI version check to avoid logging of the error message. Signed-off-by: Nitin Rawat ---

Re: [PATCH V1 0/3] scsi: ufs: Add a vops to configure VCC voltage level

2021-02-01 Thread nitirawa
On 2021-01-31 19:32, Avri Altman wrote: UFS specification allows different VCC configurations for UFS devices, for example, (1)2.70V - 3.60V (For UFS 2.x devices) (2)2.40V - 2.70V (For UFS 3.x devices) For platforms supporting both ufs 2.x (2.7v-3.6v) and ufs 3.x (2.4v-2.7v),

Re: [PATCH V1 1/3] scsi: ufs: export api for use in vendor file

2021-02-01 Thread nitirawa
On 2021-01-31 19:29, Avri Altman wrote: Exporting functions ufshcd_set_dev_pwr_mode, ufshcd_disable_vreg and ufshcd_enable_vreg so that vendor drivers can make use of them in setting vendor specific regulator setting in vendor specific file. As for ufshcd_{enable,disable}_vreg - maybe inline