[PATCH v3 4/4] pinctrl: abx500: rework error path

2013-06-24 Thread patrice.chotard.st
From: Patrice Chotard At several places, return value was not tested and error output was missing. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 114 +- 1 file changed, 87 insertions(+), 27 deletions(-) diff --git a/drivers/pinctrl/

[PATCH v3 1/4] pinctrl: abx500: suppress hardcoded value

2013-06-24 Thread patrice.chotard.st
From: Patrice Chotard Replace hardcoded value by corresponding #define's. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-

[PATCH v2 3/4] pinctrl: abx500: factorize code

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard Factorize code by adding abx500_pullud_supported() which improve code readability. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/pinctrl/

[PATCH v2 4/4] pinctrl: abx500: rework error path

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard At several places, return value was not tested and error output was missing. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 114 +- 1 file changed, 87 insertions(+), 27 deletions(-) diff --git a/drivers/pinctrl/

[PATCH v2 2/4] pinctrl: abx500: fix abx500_gpio_get()

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard _ allow to get output GPIO value _ as there is no GPIO0 on ABX500, use correct offset with abx500_gpio_get_bit() Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/

[PATCH v2 0/2] pinctrl: ABX500: Add device tree support

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard This patchset replaces previously submitted patch regarding device tree support for ABX500 Asic family. It now uses pin configuration generic parsing code proposed by Heiko Stuebner.*** SUBJECT HERE *** Patrice Chotard (2): pinctrl: abx500: Add device tree support pinc

[PATCH v2 2/2] pinctrl: abx500: fix abx500_pin_config_set()

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard _ Update abx500_pin_config_set() in order to take in account PIN_CONFIG_BIAS_DISABLE state to disable pull up or pull down. _ Rework error path. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 31 +-- 1 file changed, 25

[PATCH v2 0/4] pinctrl: ABX500: fix

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard Patrice Chotard (4): pinctrl: abx500: suppress hardcoded value pinctrl: abx500: fix abx500_gpio_get() pinctrl: abx500: factorize code pinctrl: abx500: rework error path drivers/pinctrl/pinctrl-abx500.c | 173 +++- include/linux/mf

[PATCH v2 1/4] pinctrl: abx500: suppress hardcoded value

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard Replace hardcoded value by corresponding #define's. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 18 ++ include/linux/mfd/abx500/ab8500-gpio.h |5 + 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH v2 1/2] pinctrl: abx500: Add device tree support

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard We use the same way to define pin muxing and pin configuration than for nomadik. So pickup code from pinctrl_nomadik.c to be able to implement pin multiplexing and pin configuration using the device tree. Pin configuration uses generic parsing code. Signed-off-by: Gabriel F

[PATCH 1/2] pinctrl: abx500: suppress hardcoded value

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard Replace hardcoded value by corresponding #define's. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 18 ++ include/linux/mfd/abx500/ab8500-gpio.h |5 + 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 0/2] pinctrl: ABX500: fix

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard Patrice Chotard (2): pinctrl: abx500: suppress hardcoded value pinctrl: abx500: fix abx500_gpio_get() drivers/pinctrl/pinctrl-abx500.c | 34 ++-- include/linux/mfd/abx500/ab8500-gpio.h |5 + 2 files changed, 33 insertions(+),

[PATCH 2/2] pinctrl: abx500: fix abx500_gpio_get()

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard _ allow to get output GPIO value. _ as there is no GPIO0 on ABX500, use correct offset with abx500_gpio_get_bit(). Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] pinctrl: abx500: fix abx500_pin_config_set()

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard _ Update abx500_pin_config_set() in order to take in account PIN_CONFIG_BIAS_DISABLE state to disable pull up or pull down. _ Rework error path. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c | 31 +-- 1 file changed, 25

[PATCH 1/2] pinctrl: abx500: Add device tree support

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard We use the same way to define pin muxing and pin configuration than for nomadik. So pickup code from pinctrl_nomadik.c to be able to implement pin multiplexing and pin configuration using the device tree. Pin configuration uses generic parsing code. Signed-off-by: Gabriel

[PATCH 0/2] pinctrl: ABX500: Add device tree support

2013-06-20 Thread patrice.chotard.st
From: Patrice Chotard This patchset replaces previously submitted patch regarding device tree support for ABX500 Asic family. It now uses pin configuration generic parsing code proposed by Heiko Stuebner. Patrice Chotard (2): pinctrl: abx500: Add device tree support pinctrl: abx500: fix abx

[PATCH] pinctrl: abx500: fix build warning

2013-06-11 Thread patrice.chotard.st
From: Patrice Chotard pinctrl-abx500.c: In function 'abx500_gpio_dbg_show_one': pinctrl-abx500.c:534:14: warning: 'pud' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] pinctrl: pinctrl-abx500: Add device tree support

2013-06-07 Thread patrice.chotard.st
From: Patrice Chotard We use the same way to define pin muxing and pin configuration than for nomadik. So pickup code from pinctrl_nomadik.c to be able to implement pin multiplexing and pin configuration using the device tree. Signed-off-by: Gabriel Fernandez Signed-off-by: Patrice Chotard ---

[PATCH 2/3] pinctrl: abx500: allow to set pull up

2013-05-24 Thread patrice.chotard.st
From: Patrice Chotard On ABx500 chip family, all pins support only pull down except for AB8540 which supports pull up/down on some pins. Rework abx500_pin_config_set to be able to set pull up on pins which support this feature. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.

[PATCH 3/3] pinctrl: abx500: fix abx500_gpio_dbg_show_one() to show pull up/down

2013-05-24 Thread patrice.chotard.st
From: Patrice Chotard _ rework abx500_gpio_dbg_show_one() to take in account pull up/down feature available on AB8540 only. _ add abx500_get_pull_updown() needed by abx500_gpio_dbg_show_one() _ rename abx500_config_pull_updown() to abx500_set_pull_updown() Signed-off-by: Patrice Chotard ---

[PATCH 1/3] pinctrl: abx500: fix abx500_config_pull_updown

2013-05-24 Thread patrice.chotard.st
From: Patrice Chotard Fix abx500_config_pull_updown() to set correct bit in AB8540_GPIO_PULL_UPDOWN_REG. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl

[PATCH 0/3] pinctrl: abx500: Fix pull up/down feature

2013-05-24 Thread patrice.chotard.st
From: Patrice Chotard This series fixes the pull up/down feature of ABx500 family ASIC. Patrice Chotard (3): pinctrl: abx500: fix abx500_config_pull_updown pinctrl: abx500: allow to set pull up pinctrl: abx500: fix abx500_gpio_dbg_show_one() to show pull up/down drivers/pinctrl/pinctrl-a

[PATCH 0/3] pinctrl: abx500: Fix pull up/down feature

2013-05-24 Thread patrice.chotard.st
From: Patrice Chotard This series fixes the pull up/down feature of ABx500 family ASIC. Patrice Chotard (3): pinctrl: abx500: fix abx500_config_pull_updown pinctrl: abx500: allow to set pull up pinctrl: abx500: fix abx500_gpio_dbg_show_one() to show pull up/down drivers/pinctrl/pinctrl-a

[PATCH] pinctrl: abx500: suppress unused mutex

2013-05-23 Thread patrice.chotard.st
From: Patrice Chotard Suppress a mutex which was initialized on probe and destroyed on remove but never used. Signed-off-by: Patrice Chotard --- drivers/pinctrl/pinctrl-abx500.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pi