;
+ ecc_size1 = BCH_ECC_SIZE1;
break;
case OMAP_ECC_BCH8_CODE_HW:
bch_type = 1;
Thanks for the clean-up ..
Reviewed-by: Pekon Gupta
with regards, pekon
Powered by BigRock.com
--
To unsubscribe from this list: send the line
On Tuesday 19 August 2014 07:42 AM, Brian Norris wrote:
On Wed, Aug 06, 2014 at 02:32:18AM +0530, pe...@pek-sem.com wrote:
On Tuesday 05 August 2014 07:53 PM, Lee Jones wrote:
On Thu, 03 Jul 2014, Gupta, Pekon wrote:
+ /* Load last page of block */
+ offs = (loff_t)block <<
Hello Lee,
On Wednesday 13 August 2014 02:41 PM, Lee Jones wrote:
Hi Brian, Pekon,
I believe all of your queries have either been answered or addressed
and I am hoping this will be the last submission. :)
/me crosses fingers!
Kind regards,
Lee
Lee Jones (8):
ARM: multi-v7: Enable ST BCH
Hello,
On Tuesday 05 August 2014 07:53 PM, Lee Jones wrote:
On Thu, 03 Jul 2014, Gupta, Pekon wrote:
From: Brian Norris [mailto:computersforpe...@gmail.com]
On Wed, May 28, 2014 at 10:20:05AM +0100, Lee Jones wrote:
[...]
+static void bch_wait_seq(struct nandi_controller *nandi
Can you please share the ecc-layout of the NAND page, because
as per [1] you should not be able to Boot from NAND then.
IIRC..
- ECC layout of HAM1_SW has ECC bytes towards end of OOB-section.
- ECC layout of HAM1_HW has ECC bytes towards staring of OOB section.
with regards, pekon
[1] http://ww
unctions entirely.
>
>I presume you have some out-of-tree driver that uses these functions,
>then?
>
Please don't drop nand_{unlock, lock} interfaces at-least for sometime.
I remember there were some users trying to use these for secure
applications. But due to lack of proper userland u
ain.I test and it works Ok.It can be accepted now?
>
>Yes. Pushed to l2-mtd.git.
>
This works well with Spansion NOR device (S29GL512S10) present on
J6-EVM, using http://patchwork.ozlabs.org/patch/372866/.
Though it's already accepted in l2-mtd.git, but just for record.
Tested-by: Pek
>From: Quadros, Roger
>>On 07/11/2014 10:43 AM, Gupta, Pekon wrote:
>>> From: Quadros, Roger
[...]
>>> @@ -1176,6 +1172,7 @@ static int __maybe_unused
>>> omap_calculate_ecc_bch(struct mtd_info
>*mtd,
>>> {
>>> struct omap_
>From: Quadros, Roger
>>On 07/11/2014 10:27 AM, Gupta, Pekon wrote:
>>> From: Tony Lindgren [mailto:t...@atomide.com]
>>>> * Roger Quadros [140709 05:39]:
>>>> Hi,
>>>>
>>>> The following hardware modules/registers are meant fo
e[12] = ((bch_val[3] >> 8) & 0xFF);
>+ ecc_code[13] = ((bch_val[3] >> 0) & 0xFF);
>+
>+ ecc_code[14] = ((bch_val[2] >> 24) & 0xFF);
>+ ecc_code[15] = ((bch_val[2] >> 16) & 0xFF);
>+
have some wrapper functions to match
the MTD interface arguments.
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
r-page granularity (or something like this).
Therefore you have custom implementation of
chip->ecc.read_page = omap_read_page_bch()
Also if you change the configurations here, it will break the compatibility
with
u-boot, so images flashed via u-boot will stop to boot in kernel and
vice-versa.
u8 sector, u32 *result);
>
This one looks good, but you should also take in int 'ecc-scheme'.
Actually you can just move omap_calculate_ecc_bch(...) out of NAND
driver into GPMC driver and rename it, because support of ECC
scheme is property of hardware controller not NAND driver.
What ec
n this file, you'll find the pattern should be something
>like:
>
>"ARM: OMAP2+: GPMC should only probe enabled devices"
>
>Other than this, the patch looks correct.
>
Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.
Tested-by:
ts difficult for layman user to decipher NAND signal timings
from datasheet and then convert it into controller understandable DT
(2) ONFI parameter page on NAND has these timings specified
on-die itself, and these timings are characterized for best performance
so NAND driver should re-configure these tim
cussed in other thread, this is incorrect interpretation for
bitflip_threshold. As per MTD sub-system bitflips_threshold == 0
means ECC correction is not implemented.
@@drivers/mtd/mtdcore.c: mtd_read()
return ret_code >= mtd->bitflip_threshold ? -EUCLEAN : 0;
>+ bool
g initialisation, the NAND Controller timing registers are
>configured
>+according to one of the following methods, in order of precedence:
>+
>+ 1. Configuration based on "st,nand_timing_spec" if supplied.
>+
Not sure if this mode is really required, as almost al
t be passed via DT.
>> It's neither a hardware parameter, nor it’s a static constant.
>
>Ah, I see. I will fixup, thanks for the explanation.
>
Please wait, I'll review your [v2] series also, then you can further
send all fixes together. I'm bit caught in other commitments for 3.16,
so hopefully I'll be able to review your patches by next week.
with regards, pekon
on
why NAND_NO_SUBPAGE_WRITE should _not_ be set,
because it breaks compatibility with older UBIFS images.
http://lists.infradead.org/pipermail/linux-mtd/2014-April/053262.html
Also below is the appropriate fix without breaking backward compatibility.
http://lists.infradead.org/pipermail/l
>
Do you really want to have *custom* partition format ?
If your previous code was non-DT (platform file based), then I think
It's good point to move to unified generic partition format which others
are following, as you make your driver DT compliant, and in mainline.
I understand you primary objective would be to get ST driver work
out of mainline asap, but if you upstream too many custom stuff you
are only adding maintenance burden for your code. This is where
most of my comments originate.
However, I leave it to Brian to decide, if he is okay with these.
with regards, pekon
>From: Lee Jones [mailto:lee.jo...@linaro.org]
>>On Wed, 26 Mar 2014, Gupta, Pekon wrote:
[...]
>> >+ /* Reset and disable boot-mode controller */
>> >+ writel(BOOT_CFG_RESET, nandi->base + NANDBCH_BOOTBANK_CFG);
>> >+ udelay(1);
>> >+ write
rning
>> "‘erased_sector_bitflips’ defined but not used [-Wunused-function]" when
>> compiling without CONFIG_MTD_NAND_OMAP_BCH. Move function
>> erased_sector_bitflips() into the same ifdef section as the only caller.
>>
>> Signed-off-by: Christian Engelmayer
&
p = nandi->page_buf;
>+ nandi->cached_page = -1;
>+ } else {
>+ p = buf;
>+ }
>+
>+ if (nandi->cached_page == page_num)
>+ nandi->cached_page = -1;
>+
i->base + NANDBCH_CONTROLLER_CFG);
>+
>+ /* Set EMI Bank */
>+ writel(0x1 << emi_bank, nandi->base + NANDBCH_FLEX_MUXCTRL);
>+
>+ /* Reset ECC stats */
>+ writel(0x7f0, nandi->base + NANDBCH_CONTROLLER_CFG);
>+ udelay(1);
>+
"0x7f0&qu
#x27; bits at zero.
>+ */
>+ ret = check_erased_page(buf, page_size,
>+ nandi->sectors_per_page);
This is also not correct. Here 'max_zeros' should be ecc.strength
>+ if (ret >= 0)
>+
if (!banksnp)
>+ return NULL;
>+
>+ sprintf(name, "bank%d", bank_nr);
>+ banknp = of_get_child_by_name(banksnp, name);
>+ if (banknp)
>+ return NULL;
>+
>+ partsnp = of_get_child_by_name(banknp, "partitions&quo
clk_disable_unprepare(nandi->emi_clk);
>+ if (nandi->bch_clk)
>+ clk_disable_unprepare(nandi->bch_clk);
>+}
>+
same, please move this to
[RFC 11/47] mtd: nand: stm_nand_bch: add Power Management
Also as Ezequiel suggested.
You can trim down the number
ully */
>+ }
>+ if (status & NAND_INT_RBN) {
>+ /* Hamming */
>+ writel(NAND_INT_CLR_RBN, nandi->base + NANDHAM_INT_CLR);
>+ complete(&nandi->rbn_completed);
-- same for this --
return IRQ_HANDLED; /* HAM ECC
available in public domain somewhere ?
with regards, pekon
gt;Anyway, what's the best thing to do in this instance? Should I just
>send it to the list as an RFC and be done with it?
>
with regards, pekon
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
+ }
>+
>+ ecc->mode = mode;
>+ ret = nand_ecc_ctrl_init(mtd, ecc);
>+ if (ret)
>+ goto err;
>+
>+ ecc->release = nand_release_ecc_ctrl;
>+
>+ return ecc;
>+
>+err:
>+ kfree(ecc);
>+ return ERR_PTR(ret);
>+}
>+EXPORT_SYMBOL(nand_get_ecc_ctrl);
>+
I'll be happy to extend and test this, if you plan a complete version.
[1] http://comments.gmane.org/gmane.linux.ports.arm.omap/108083
(you can skip initial discussion about OMAP3, and jump to Thomas Petazzoni | 2
Dec 17:19 2013)
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
y use
GPIO instead. It's the way a hardware controller is designed.
Request you to please consider Ack from MTD Maintainers 'at-least' for
generic NAND DT bindings. There is already a discussion going in
a separate thread for which there are still no replies [1].
[1] http://lists.in
om MTD Maintainers 'at-least' for
generic NAND DT bindings. There is already a discussion going in
a separate thread for which is still not awaiting replies [1].
[1] http://lists.infradead.org/pipermail/linux-mtd/2014-January/051625.html
with regards, pekon
--
To unsubscribe fro
Hi Shawn,
>From: Shawn Guo [mailto:shawn@linaro.org]
>>On Tue, Dec 17, 2013 at 05:00:53AM +, Gupta, Pekon wrote:
>> >From: Huang Shijie [mailto:b32...@freescale.com]
>>> >On Tue, Dec 17, 2013 at 04:08:33AM +, Gupta, Pekon wrote:
[...]
>> >>
error
> paths, or is it returning 0? Of course the answer is the former, but
> it's possible to misread it.) If it helps, I can try to tweak the
> wording a bit when applying this patch.
>
> Pekon, can I get an Acked-by?
>
Yes sure .. Sorry I was away from both mailbox an
Hi Mark,
>
> Pekon, could you please re-send this version of the patches?
>
As already there are feedbacks on the patches, so re-sending the
Patch series might clutter someone else's mailbox.
Will it be possible for you to fetch the patches from MTD archives?
else I would send y
plified the NAND driver code.
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Brian,
>
> Hi Pekon,
>
> On Wed, Sep 25, 2013 at 08:46:19AM -0500, Felipe Balbi wrote:
> > + akpm
> >
> > On Tue, Sep 24, 2013 at 01:04:05PM -0500, Gupta, Pekon wrote:
[snip]
> > >
> > > Dear Olof and other DT Maintainers,
> > >
>
t this reverted. I have already re-sent a updated version of this series
with fixes & copying devicetree-discuss.
http://lists.infradead.org/pipermail/linux-mtd/2013-July/047530.html
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bod
>
> On Mon, Jul 1, 2013 at 10:44 PM, Gupta, Pekon wrote:
> >>
> >> Hi all,
> >>
> >> Today's linux-next merge of the arm-soc tree got a conflict in
> >> Documentation/devicetree/bindings/mtd/gpmc-nand.txt between
> commits
> >&
you shouldn't find such issues, as code is more stable now.
Thanks for help.
with regards, pekon
> diff --cc Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> index b3f23df,df338cb..000
> --- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> +++ b/Documentation/device
>;
> +compatible = "ti,am3359-adc";
> +};
> +
> +};
> +
> + elm: elm@4808 {
> + compatible = "ti,am3352-elm";
> + reg = <0x4808
ap/msg91165.html
>
> [PATCH v4,1/3] http://www.spinics.net/lists/linux-omap/msg91166.html
>
> [PATCH v4,2/3] (please skip this one)
> instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
>
> [PATCH v4,3/3] (typo)
http://www.spinics.net/lists/l
//www.spinics.net/lists/linux-omap/msg91166.html
[PATCH v4,2/3] (please skip this one)
instead pick http://www.spinics.net/lists/linux-omap/msg91161.html
[PATCH v4,3/3] http://www.spinics.net/lists/linux-omap/msg91167.html
Thanks..
with regards, pekon
--
To unsubscribe from this list: send the
s> this.
> Lars> Correct the properties in the dts to provide the right values for the
> Lars> gpmc driver.
>
> Lars> Signed-off-by: Lars Poeschel
>
> Acked-by: Peter Korsgaard
>
Acked-by: Pekon Gupta
My another patch [V3, 2/3] on same can be dropped
r development.
> >
> Yes, accepted. This has been already fixed in v3 of this patch set.
> If all fine, then please pull this for next merge..
>
> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
>
> http://lists.infradead.org/pipermail/linux-mtd/2013-
then please pull this for next merge..
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html (already
pulled)
http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html
with regards, pekon
--
To unsubsc
From: Philip Avinash
NAND flash connected in am335x-evm on GPMC controller. This patch adds
device tree node in am3355-evm with GPMC contoller timing for NAND flash
interface, NAND partition table, ECC scheme, elm handle id.
Signed-off-by: Philip Avinash
Signed-off-by: Gupta, Pekon
From: avinash philip
NAND flash connected in am335x-evm on GPMC controller. This patch adds
device tree node in am3355-evm with GPMC contoller timing for NAND flash
interface, NAND partition table, ECC scheme, elm handle id.
Signed-off-by: Philip Avinash
Signed-off-by: Gupta, Pekon
---
arch
t; Tested this patch with Micron MT29F64G08CBABAWP.
>
> Signed-off-by: Huang Shijie
Acked-by: Pekon Gupta
Thanks..
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
i_ext_section{} for extended sections,
> [4] and adds onfi_ext_param_page{} for the Extended Parameter
> Page.
>
> Signed-off-by: Huang Shijie
Acked-by: Pekon Gupta
Thanks..
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> 于 2013年05月02日 13:42, Gupta, Pekon 写道:
> >>>> -*busw = 0;
> >>>> -if (le16_to_cpu(p->features)& 1)
> >>>> -*busw = NAND_BUSWIDTH_16;
> >>>> +
return 0;
> > }
> >
> >
> I think checking the onfi_version has no relationship with this patch. :)
> This patch is just replace the hardcode for 16-bit onfi nand check.
>
[Pekon]: [Patch 3/9]: add a helper to get the supported features
I mean, do you really need this helpe
d the 'onfi_version' above in
nand_flash_detect_onfi() ..
if (!chip->onfi_version) {
pr_info("%s: unsupported ONFI version: %d\n", __func__, val);
return 0;
}
with regards, pekon
--
To unsubscribe from this list: send the line &q
From: avinash philip
NAND flash connected in am335x-evm on GPMC controller. This patch adds
device tree node in am3355-evm with GPMC contoller timing for NAND flash
interface, NAND partition table, ECC scheme, elm handle id.
Signed-off-by: Philip Avinash
Tested-by: Pekon Gupta
---
arch/arm
From: avinash philip
From: "Philip, Avinash"
Add GPMC data node to AM33XX device tree file.
Signed-off-by: Philip Avinash
Acked-by: Peter Korsgaard
Tested-by: Pekon Gupta
---
Changes since v2:
- Change number of chip select to 7
arch/arm/boot/dts/am33xx.d
From: avinash philip
From: "Philip, Avinash"
Add ELM data node to AM33XX device tree file.
Signed-off-by: Philip Avinash
Acked-by: Peter Korsgaard
Tested-by: Pekon Gupta
---
Changes since v2:
- Replace literals to 52
- remove tab
arch/arm/boot/dts/am33xx.d
;s make the option "tristate" in Kconfig to fix this allmodconfig
> > build error:
> >
> > ERROR: "elm_config" [drivers/mtd/nand/omap2.ko] undefined!
> > ERROR: "elm_decode_bch_error_page" [drivers/mtd/nand/omap2.ko]
> undefined!
> >
[Pekon]:
58 matches
Mail list logo
