Re: Warning seen when removing a module using irqdomain framework

2019-07-25 Thread pheragu
On 2019-07-23 23:51, Marc Zyngier wrote: On Tue, 23 Jul 2019 14:52:34 -0700 pher...@codeaurora.org wrote: Hi Prakruthi, Hi, I have been working on a interrupt controller driver that uses tree based mapping for its domain (irq_domain_add_tree(..)). If I understand correctly, the clients get a

Warning seen when removing a module using irqdomain framework

2019-07-23 Thread pheragu
Hi, I have been working on a interrupt controller driver that uses tree based mapping for its domain (irq_domain_add_tree(..)). If I understand correctly, the clients get a mapping when they call platform_get_irq(..). However, after these clients are removed (rmmod), when I try to remove the i

Re: [PATCH] genirq: Avoid race between cpu hot plug and irq_desc() allocation paths

2018-09-05 Thread pheragu
On 2018-09-05 11:23, Thomas Gleixner wrote: On Wed, 5 Sep 2018, Prakruthi Deepak Heragu wrote: One of the cores might have just allocated irq_desc() and other core might be doing irq migration in the hot plug path. In the hot plug path during the IRQ migration, for_each_active_irq macro is tr

Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver

2018-08-20 Thread pheragu
On 2018-08-17 12:47, Trilok Soni wrote: Hi Prakruthi, On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote: + +#define EUD_INT_VBUS BIT(2) +#define EUD_INT_CHGR BIT(3) +#define EUD_INT_SAFE_MODE BIT(4) + +#define EUD_NR 1 I don't see any use of EUD_NR i

Re: [PATCH 1/2] dt-bindings: Documentation for qcom,eud

2018-08-02 Thread pheragu
On 2018-08-01 07:04, Rob Herring wrote: On Tue, Jul 31, 2018 at 12:22 PM Prakruthi Deepak Heragu wrote: Documentation for Embedded USB Debugger (EUD) device tree bindings. If you want bindings reviewed, send them to the correct list and people (hint: run get_maintainers.pl). New bindings sh

Re: [PATCH 2/2] Embedded USB Debugger (EUD) driver

2018-07-31 Thread pheragu
On 2018-07-31 12:29, Trilok Soni wrote: Hi Prakruthi, On 7/31/2018 11:22 AM, Prakruthi Deepak Heragu wrote: Add support for control peripheral of EUD (Embedded USB Debugger) to listen to events such as USB attach/detach, charger enable/disable, pet EUD to indicate software is functional. We

Re: Reminder to review a few patches sent two weeks ago

2018-07-25 Thread pheragu
On 2018-07-24 17:33, Joe Perches wrote: On Tue, 2018-07-24 at 14:56 -0700, pher...@codeaurora.org wrote: A reminder to review a few patches I had sent last week. Below are the links for the patches. https://lkml.org/lkml/2018/7/5/798 I have no fundamental object to this one, but the 80 column

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-25 Thread pheragu
On 2018-07-16 11:20, pher...@codeaurora.org wrote: On 2018-07-13 17:08, Joe Perches wrote: On Fri, 2018-07-13 at 16:28 -0700, pher...@codeaurora.org wrote: On 2018-07-13 14:46, Joe Perches wrote: > On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: > > Commit text is almost alway

Reminder to review a few patches sent two weeks ago

2018-07-24 Thread pheragu
A reminder to review a few patches I had sent last week. Below are the links for the patches. https://lkml.org/lkml/2018/7/5/798 http://lists-archives.com/linux-kernel/29168320-checkpatch-check-for-invalid-return-codes.html - Prakruthi Deepak Heragu

Reminder about previous patches

2018-07-16 Thread pheragu
A reminder to review a few patches I had sent last week. Below are the links for the patches. https://lkml.org/lkml/2018/7/5/798 http://lists-archives.com/linux-kernel/29168320-checkpatch-check-for-invalid-return-codes.html - Prakruthi Deepak Heragu

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-16 Thread pheragu
On 2018-07-13 17:08, Joe Perches wrote: On Fri, 2018-07-13 at 16:28 -0700, pher...@codeaurora.org wrote: On 2018-07-13 14:46, Joe Perches wrote: > On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: > > Commit text is almost always necessary to explain why a change is > > needed. >

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread pheragu
On 2018-07-13 14:46, Joe Perches wrote: On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: Commit text is almost always necessary to explain why a change is needed. This bit seems sensible, but perhaps it should just count the number of lines after the end of email headers and b

Re: [PATCH] checkpatch: Add exceptions for dsb keyword usage

2018-07-06 Thread pheragu
On 2018-07-05 22:45, Mark Rutland wrote: On Thu, Jul 05, 2018 at 02:14:28PM -0700, Joe Perches wrote: On Thu, 2018-07-05 at 11:19 -0700, Prakruthi Deepak Heragu wrote: > mb() API can relpace the dsb() API in the kernel code. So, dsb() usage > is discouraged. However, there are exceptions when ds

Re: [PATCH] checkpatch: Add exceptions for dsb keyword usage

2018-07-06 Thread pheragu
On 2018-07-05 22:52, Joe Perches wrote: On Fri, 2018-07-06 at 06:45 +0100, Mark Rutland wrote: On Thu, Jul 05, 2018 at 02:14:28PM -0700, Joe Perches wrote: > On Thu, 2018-07-05 at 11:19 -0700, Prakruthi Deepak Heragu wrote: > > mb() API can relpace the dsb() API in the kernel code. So, dsb() usa

Re: [PATCH] checkpatch: Check for illegal return codes

2018-07-03 Thread pheragu
On 2018-07-03 11:19, Joe Perches wrote: On Tue, 2018-07-03 at 11:09 -0700, Prakruthi Deepak Heragu wrote: The only legal integer return is 0, anything else following "return" should be -ERRCODE or a function. http://lkml.org/lkml/2010/7/23/318 There's lots of "return -1;" statements in this p