Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 8e583c2..f4fa6c5 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie
On ARM64, setting the root bus number to -1 causes probe failure.
Moreover, we should use the bus number specified in the DT as we
could have multiple PCIe controllers with different bus ranges.
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 2 +-
1 file changed, 1 insertion
is based on commit <499733e0cc1a00523c5056a690f65dea7b9da140>
"PCI: generic: Remove dependency on ARM-specific struct hw_pci".
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 76
1 file changed, 48 insertions(+), 28 de
.
Phil Edworthy (4):
PCI: rcar-pcie: Make PCI aware of the IO resources
PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
PCI: rcar-pcie: Set root bus nr to that provided in DT
PCI: rcar-pcie: Fix IO offset for multiple instances
drivers/pci/host/pcie-rcar.c | 86
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 7678fe0..27e2c20 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
.
Phil Edworthy (4):
PCI: rcar-pcie: Make PCI aware of the IO resources
PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
PCI: rcar-pcie: Set root bus nr to that provided in DT
PCI: rcar-pcie: Fix IO offset for multiple instances
drivers/pci/host/pcie-rcar.c | 86
Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 7678fe0..27e2c20 100644
--- a/drivers/pci/host/pcie-rcar.c
is based on commit <499733e0cc1a00523c5056a690f65dea7b9da140>
"PCI: generic: Remove dependency on ARM-specific struct hw_pci".
Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 76
1 file
On ARM64, setting the root bus number to -1 causes probe failure.
Moreover, we should use the bus number specified in the DT as we
could have multiple PCIe controllers with different bus ranges.
Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 2
Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 8e583c2..f4fa6c5 100644
--- a/drivers/pci/host/pcie-rcar.c
-clock";
clocks = <_core>;
#clock-cells = <0>;
clock-div = <1>;
clock-mult = <2>;
};
};
Phil
On 10/09/2015 16:57, Martin Sperl wrote:
>> On 10.09.2015, at 17:48, Noralf Trønnes wrote:
>>
>> This looks in
r netlink, but if you apply patch 1/3 from this thread,
test_rhashtable.c starts generating many insert failures during the
multiple thread test.
Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.ke
r netlink, but if you apply patch 1/3 from this thread,
test_rhashtable.c starts generating many insert failures during the
multiple thread test.
Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.ke
-clock";
clocks = <_core>;
#clock-cells = <0>;
clock-div = <1>;
clock-mult = <2>;
};
};
Phil
On 10/09/2015 16:57, Martin Sperl wrote:
>> On 10.09.2015, at 17:48, Noralf Trønnes <nor...@tronnes.org> wrote:
>
On Tue, Sep 01, 2015 at 09:50:19PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 03:43:11PM +0200, Phil Sutter wrote:
> >
> > Hmm. Since memory allocation is first tried with GFP_ATOMIC set and upon
> > failure retried in background, this seems like a situation which mi
On Tue, Sep 01, 2015 at 09:00:57PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 02:46:48PM +0200, Phil Sutter wrote:
> >
> > This is not an inherent behaviour of the implementation but general
> > agreement. The insertion may fail non-permanently (returning -EBUSY),
&
On Tue, Sep 01, 2015 at 07:43:00PM +0800, Herbert Xu wrote:
> On Mon, Aug 31, 2015 at 01:00:12PM +0200, Phil Sutter wrote:
> >
> > The variable would be used to track if the worker has failed to allocate
> > memory in background.
> >
> > Since the failing inse
On Tue, Sep 01, 2015 at 07:43:00PM +0800, Herbert Xu wrote:
> On Mon, Aug 31, 2015 at 01:00:12PM +0200, Phil Sutter wrote:
> >
> > The variable would be used to track if the worker has failed to allocate
> > memory in background.
> >
> > Since the failing inse
On Tue, Sep 01, 2015 at 09:50:19PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 03:43:11PM +0200, Phil Sutter wrote:
> >
> > Hmm. Since memory allocation is first tried with GFP_ATOMIC set and upon
> > failure retried in background, this seems like a situation which mi
On Tue, Sep 01, 2015 at 09:00:57PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 02:46:48PM +0200, Phil Sutter wrote:
> >
> > This is not an inherent behaviour of the implementation but general
> > agreement. The insertion may fail non-permanently (returning -EBUSY),
&
On Sun, Aug 30, 2015 at 03:47:17PM +0800, Herbert Xu wrote:
> Phil Sutter wrote:
> >
> > Should we introduce a new field to struct rhashtable to track the
> > internal state? This might allow to clean up some rather obscure tests,
> > e.g. whether a table resize is i
On Sun, Aug 30, 2015 at 03:47:17PM +0800, Herbert Xu wrote:
> Phil Sutter <p...@nwl.cc> wrote:
> >
> > Should we introduce a new field to struct rhashtable to track the
> > internal state? This might allow to clean up some rather obscure tests,
> > e.g. whet
On Sat, Aug 29, 2015 at 12:43:03AM +0200, Thomas Graf wrote:
> On 08/28/15 at 03:34pm, Phil Sutter wrote:
> > Quite ugly, IMHO: rhashtable_insert_fast() may return -ENOMEM as
> > non-permanent error, if allocation in GFP_ATOMIC failed. In this case,
> > allocation in
On Sat, Aug 29, 2015 at 12:43:03AM +0200, Thomas Graf wrote:
On 08/28/15 at 03:34pm, Phil Sutter wrote:
Quite ugly, IMHO: rhashtable_insert_fast() may return -ENOMEM as
non-permanent error, if allocation in GFP_ATOMIC failed. In this case,
allocation in GFP_KERNEL is retried
On Fri, Aug 28, 2015 at 01:13:20PM +0200, Phil Sutter wrote:
> On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
> > On 08/28/15 at 12:28pm, Phil Sutter wrote:
> > > After adding cond_resched() calls to threadfunc(), a surprisingly high
> > > rate of insert
On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
> On 08/28/15 at 12:28pm, Phil Sutter wrote:
> > After adding cond_resched() calls to threadfunc(), a surprisingly high
> > rate of insert failures occurred probably due to table resizes getting a
> > better chance
the exact number of objects upon table init won't
suffice as that value is being rounded down to the next power of two -
anticipate this by rounding up to the next power of two in beforehand.
Signed-off-by: Phil Sutter
---
lib/test_rhashtable.c | 8 +---
1 file changed, 5 insertions(+), 3
-by: Phil Sutter
---
lib/test_rhashtable.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 63654e3..093cf84 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -244,7 +244,7 @@ static int thread_lookup_test
This should fix for soft lockup bugs triggered on slow systems.
Signed-off-by: Phil Sutter
---
lib/test_rhashtable.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 8c1ad1c..63654e3 100644
--- a/lib/test_rhashtable.c
+++ b/lib
This should fix for soft lockup bugs triggered on slow systems.
Signed-off-by: Phil Sutter p...@nwl.cc
---
lib/test_rhashtable.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 8c1ad1c..63654e3 100644
--- a/lib/test_rhashtable.c
+++ b
-by: Phil Sutter p...@nwl.cc
---
lib/test_rhashtable.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 63654e3..093cf84 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -244,7 +244,7 @@ static int
the exact number of objects upon table init won't
suffice as that value is being rounded down to the next power of two -
anticipate this by rounding up to the next power of two in beforehand.
Signed-off-by: Phil Sutter p...@nwl.cc
---
lib/test_rhashtable.c | 8 +---
1 file changed, 5 insertions
On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
On 08/28/15 at 12:28pm, Phil Sutter wrote:
After adding cond_resched() calls to threadfunc(), a surprisingly high
rate of insert failures occurred probably due to table resizes getting a
better chance to run in background
On Fri, Aug 28, 2015 at 01:13:20PM +0200, Phil Sutter wrote:
On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
On 08/28/15 at 12:28pm, Phil Sutter wrote:
After adding cond_resched() calls to threadfunc(), a surprisingly high
rate of insert failures occurred probably due
Hi,
(Full-quoting here due to added maling lists.)
Looks like this is a problem of slow systems. I will try to reproduce
and come up with a similar fix as in commit 685a015 ("rhashtable: Allow
other tasks to be scheduled in large lookup loops").
Thanks for reporting,
Phil
On Mon, Au
Hi,
(Full-quoting here due to added maling lists.)
Looks like this is a problem of slow systems. I will try to reproduce
and come up with a similar fix as in commit 685a015 (rhashtable: Allow
other tasks to be scheduled in large lookup loops).
Thanks for reporting,
Phil
On Mon, Aug 24, 2015
s being
modified.
Please see
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/353421.html
Of course, as a quick fix for the compile test failure, this is fine.
Best regards
Phil
>
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/pci/host/Kconfig | 6 --
> 1
-kernel/2015-July/353421.html
Of course, as a quick fix for the compile test failure, this is fine.
Best regards
Phil
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
---
drivers/pci/host/Kconfig | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci
On Sun, Aug 16, 2015 at 08:12:35PM +0200, Florian Westphal wrote:
> Phil Sutter wrote:
> > After having tested insertion, lookup, table walk and removal, spawn a
> > number of threads running operations on the same rhashtable. Each of
> > them will:
>
> [..]
>
On Sun, Aug 16, 2015 at 08:12:35PM +0200, Florian Westphal wrote:
Phil Sutter p...@nwl.cc wrote:
After having tested insertion, lookup, table walk and removal, spawn a
number of threads running operations on the same rhashtable. Each of
them will:
[..]
+ if (down_interruptible
a second on my
local VM with two cores. Running 200 threads took about four seconds. If
slow systems suffer too much from this though, the default could be
lowered or even set to zero so this extended test does not run at all by
default.
Signed-off-by: Phil Sutter
---
lib/test_rhashtable.c | 155
Hi,
I found the problem, it was a bug in my own code. For details see below:
On Wed, Aug 12, 2015 at 05:09:31PM +0200, Phil Sutter wrote:
[...]
> Here is the reproducer code (kthread_test.c) I used:
>
> ---8<--
a second on my
local VM with two cores. Running 200 threads took about four seconds. If
slow systems suffer too much from this though, the default could be
lowered or even set to zero so this extended test does not run at all by
default.
Signed-off-by: Phil Sutter p...@nwl.cc
---
lib
Hi,
I found the problem, it was a bug in my own code. For details see below:
On Wed, Aug 12, 2015 at 05:09:31PM +0200, Phil Sutter wrote:
[...]
Here is the reproducer code (kthread_test.c) I used:
---8---
#include linux
top failed for thread %d: %d\n",
__func__, i, err);
}
kfree(tsk);
printk(KERN_INFO "%s: test run ended\n", __func__);
return 0;
}
static void __exit exit_kthread_test(void)
{
}
module_init(init_kthread_test);
module_exit(exit_kthread_test);
MODULE_LI
);
return 0;
}
static void __exit exit_kthread_test(void)
{
}
module_init(init_kthread_test);
module_exit(exit_kthread_test);
MODULE_LICENSE(GPL);
---8---
Cheers, Phil
--
To unsubscribe from this list: send the line unsubscribe linux
On Fri, Jul 17, 2015 at 12:26:36PM +0200, Phil Sutter wrote:
> On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote:
> > On 07/02/15 at 10:09pm, Meelis Roos wrote:
> > > [ 33.425061] Running rhashtable test nelem=8, max_size=65536,
> > > shrinking=0
&
34.896936] Traversal complete: counted=49993, nelems=5,
> > entries=5, table-jumps=12
> > [ 34.897056] Test failed: Total count mismatch ^^^
>
> I do see count mismatches as well due to the design of the walker
> which restarts and thus sees certain entries
mismatch ^^^
I do see count mismatches as well due to the design of the walker
which restarts and thus sees certain entries multiple times.
Do you have this commit as well?
Author: Phil Sutter p...@nwl.cc
Date: Mon Jul 6 15:51:20 2015 +0200
rhashtable: fix for resize events during
On Fri, Jul 17, 2015 at 12:26:36PM +0200, Phil Sutter wrote:
On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote:
On 07/02/15 at 10:09pm, Meelis Roos wrote:
[ 33.425061] Running rhashtable test nelem=8, max_size=65536,
shrinking=0
[ 33.425154] Test 00:
[ 33.534470
Hi Sergei,
On 13 July 2015 18:10, Sergei wrote:
> On 07/13/2015 07:55 PM, Phil Edworthy wrote:
>
> >>>>>>> Instead of statically selecting the PHY connection to either the
> >>>>>>> USBHS (Function) or PCI0 (Host) IP blocks, this change allow
Hi Sergei,
On 13 July 2015 17:37, Sergei wrote:
> On 07/13/2015 06:02 PM, Phil Edworthy wrote:
>
> >>>>> Instead of statically selecting the PHY connection to either the
> >>>>> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
>
Hi Laurent,
On 13 July 2015 16:51, Laurent wrote:
> Hi Phil,
>
> Thank you for the patch.
>
> On Monday 13 July 2015 16:30:18 Phil Edworthy wrote:
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of VBUS.
> >
> &g
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy
---
v6:
- Rename vbus_indirect_value to vbus_active
v5:
- Avoid race when vbus_is_indirect may or may not be read
before the phy has called vbus_session. In doing
Hi Laurent,
On 09 July 2015 02:03, Laurent wrote:
> Hi Phil,
>
> On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote:
> > On 08 July 2015 00:08, Laurent wrote:
> > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote:
> > > > These changes allow a PH
Hi Sergei,
On 13 July 2015 11:17, Sergei wrote:
> Hello.
>
> On 7/13/2015 12:04 PM, Phil Edworthy wrote:
>
> >>> Instead of statically selecting the PHY connection to either the
> >>> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> >
Hi Sergei,
On 10 July 2015 17:36, Sergei wrote:
> Hello.
>
> On 07/07/2015 02:55 PM, Phil Edworthy wrote:
>
> > Instead of statically selecting the PHY connection to either the
> > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> > dts to s
Hi Sergei,
On 10 July 2015 17:36, Sergei wrote:
Hello.
On 07/07/2015 02:55 PM, Phil Edworthy wrote:
Instead of statically selecting the PHY connection to either the
USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
dts to specifiy gpio pins for the vbus and id signals
Hi Sergei,
On 13 July 2015 11:17, Sergei wrote:
Hello.
On 7/13/2015 12:04 PM, Phil Edworthy wrote:
Instead of statically selecting the PHY connection to either the
USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
dts to specifiy gpio pins for the vbus and id signals
Hi Sergei,
On 13 July 2015 18:10, Sergei wrote:
On 07/13/2015 07:55 PM, Phil Edworthy wrote:
Instead of statically selecting the PHY connection to either the
USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
dts to specifiy gpio pins for the vbus and id signals
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v6:
- Rename vbus_indirect_value to vbus_active
v5:
- Avoid race when vbus_is_indirect may or may not be read
before the phy has
Hi Laurent,
On 13 July 2015 16:51, Laurent wrote:
Hi Phil,
Thank you for the patch.
On Monday 13 July 2015 16:30:18 Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor
Hi Laurent,
On 09 July 2015 02:03, Laurent wrote:
Hi Phil,
On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote:
On 08 July 2015 00:08, Laurent wrote:
On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt
Hi Sergei,
On 13 July 2015 17:37, Sergei wrote:
On 07/13/2015 06:02 PM, Phil Edworthy wrote:
Instead of statically selecting the PHY connection to either the
USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
dts to specifiy gpio pins for the vbus and id signals
Hi Laurent,
On 08 July 2015 00:08, Laurent wrote:
> Hi Phil,
>
> Thank you for the patch.
>
> On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote:
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of VBUS.
> >
Hi Laurent,
On 08 July 2015 00:08, Laurent wrote:
Hi Phil,
Thank you for the patch.
On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Note that switch SW5 and SW6 on Koelsch board needs to be set to
position 3 for this to work.
Signed-off-by: Phil Edworthy
.
Note: the R-Car USB PHY only allows this Host/Function switching
on channel 0.
This has been tested on a r8a7791 based Koelsch board, which uses
a MAX3355 device to supply vbus power when needed.
Signed-off-by: Phil Edworthy
---
v3:
- Do not call usb_gadget_vbus_disconnect will a NULL ptr
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy
---
v5:
- Avoid race when vbus_is_indirect may or may not be read
before the phy has called vbus_session. In doing so, the
changes have also been isolated
Hi Laurent,
On 06 July 2015 09:20, Laurent wrote:
> Hi Phil,
>
> Thank you for the patch.
Thanks for your review!
> On Thursday 02 July 2015 11:26:33 Phil Edworthy wrote:
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of
Hi Shimoda-san,
On 06 July 2015 08:28, Shimoda-san wrote:
> Hi Phil-san,
>
> > Sent: Thursday, July 02, 2015 7:27 PM
> >
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of VBUS.
> >
> > Signed-off-by: P
Hi Shimoda-san,
On 06 July 2015 08:18, Shimoda-san wrote:
> Hi Phil-san,
>
> Thank you very much for the patch!
>
> > Sent: Thursday, July 02, 2015 5:06 PM
> < snip >
> > +/* VBUS change IRQ handler */
> > +static irqreturn_t gpio_vbus_irq(int
Hi Laurent,
On 06 July 2015 09:20, Laurent wrote:
Hi Phil,
Thank you for the patch.
Thanks for your review!
On Thursday 02 July 2015 11:26:33 Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil
Hi Shimoda-san,
On 06 July 2015 08:28, Shimoda-san wrote:
Hi Phil-san,
Sent: Thursday, July 02, 2015 7:27 PM
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
Thank you
Hi Shimoda-san,
On 06 July 2015 08:18, Shimoda-san wrote:
Hi Phil-san,
Thank you very much for the patch!
Sent: Thursday, July 02, 2015 5:06 PM
snip
+/* VBUS change IRQ handler */
+static irqreturn_t gpio_vbus_irq(int irq, void *data)
+{
+ struct rcar_gen2_channel *channel
.
Note: the R-Car USB PHY only allows this Host/Function switching
on channel 0.
This has been tested on a r8a7791 based Koelsch board, which uses
a MAX3355 device to supply vbus power when needed.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v3:
- Do not call
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Note that switch SW5 and SW6 on Koelsch board needs to be set to
position 3 for this to work.
Signed-off-by: Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v5:
- Avoid race when vbus_is_indirect may or may not be read
before the phy has called vbus_session. In doing so, the
changes have
On Mon, Jul 06, 2015 at 09:30:40PM +0800, Herbert Xu wrote:
> On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote:
> > diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> > index a60a6d3..e36b94b 100644
> > --- a/lib/rhashtable.c
> > +++ b/lib/rhashtable.c
&
) although not explicitly tested.
Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash")
Signed-off-by: Phil Sutter
---
Changes since v1:
- Use simplified solution suggested by Herbert Xu.
---
lib/rhashtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
) although not explicitly tested.
Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash")
Signed-off-by: Phil Sutter
---
lib/rhashtable.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index a60a6d3..e36b94b 100644
--
not explicitly tested.
Fixes: eddee5ba (rhashtable: Fix walker behaviour during rehash)
Signed-off-by: Phil Sutter p...@nwl.cc
---
lib/rhashtable.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index a60a6d3..e36b94b 100644
--- a/lib
not explicitly tested.
Fixes: eddee5ba (rhashtable: Fix walker behaviour during rehash)
Signed-off-by: Phil Sutter p...@nwl.cc
---
Changes since v1:
- Use simplified solution suggested by Herbert Xu.
---
lib/rhashtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib
On Mon, Jul 06, 2015 at 09:30:40PM +0800, Herbert Xu wrote:
On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote:
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index a60a6d3..e36b94b 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -585,6 +585,7 @@ void
Hi Kishon,
On 02 July 2015 09:22, Kishon wrote:
> Hi,
>
> On Monday 22 June 2015 08:12 PM, Phil Edworthy wrote:
> > Instead of statically selecting the PHY connection to either the
> > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> > dts to spec
Hi Sergei.
On 02 July 2015 12:32, Sergei wrote:
> Hello.
>
> On 7/2/2015 11:14 AM, Phil Edworthy wrote:
>
> > Both USB Host (pci0) and Function (USBHS) drivers are enabled.
> > The USB PHY driver determines which IP block should be connected
> > based on vbus
Hi Sergei,
On 02 July 2015 12:17, Sergei wrote:
> To: Phil Edworthy; Yoshihiro Shimoda
> Hello.
>
> On 7/2/2015 10:36 AM, Phil Edworthy wrote:
>
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of VBUS.
>
&g
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy
---
v3:
- Changed how indirect vbus is plumbed in.
- Removed unnecessary (void) on call to otg_set_peripheral.
- Moved code that connects to bus through transceiver
Hi Laurent,
On 02 July 2015 09:15, Laurent wrote:
> Hi Phil,
>
> (CC'ing Morimoto-san)
>
> Thank you for the patch.
>
> On Thursday 02 July 2015 08:36:42 Phil Edworthy wrote:
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Note that switch SW5 and SW6 on Koelsch board needs to be set to
position 3 for this to work.
---
Not for upstream until
.
Note: the R-Car USB PHY only allows this Host/Function switching
on channel 0.
This has been tested on a r8a7791 based Koelsch board, which uses
a MAX3355 device to supply vbus power when needed.
Signed-off-by: Phil Edworthy
---
Tested with patch "usb: renesas_usbhs: Allow an OTG PHY d
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy
---
v2:
- vbus variables changed from int to bool.
- dev_info() changed to dev_err()
---
drivers/usb/renesas_usbhs/common.h | 2 ++
drivers/usb/renesas_usbhs
.
Note: the R-Car USB PHY only allows this Host/Function switching
on channel 0.
This has been tested on a r8a7791 based Koelsch board, which uses
a MAX3355 device to supply vbus power when needed.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
Tested with patch usb: renesas_usbhs: Allow
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v2:
- vbus variables changed from int to bool.
- dev_info() changed to dev_err()
---
drivers/usb/renesas_usbhs/common.h | 2
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Note that switch SW5 and SW6 on Koelsch board needs to be set to
position 3 for this to work.
---
Not for upstream until
Hi Laurent,
On 02 July 2015 09:15, Laurent wrote:
Hi Phil,
(CC'ing Morimoto-san)
Thank you for the patch.
On Thursday 02 July 2015 08:36:42 Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v3:
- Changed how indirect vbus is plumbed in.
- Removed unnecessary (void) on call to otg_set_peripheral.
- Moved code that connects
Hi Sergei,
On 02 July 2015 12:17, Sergei wrote:
To: Phil Edworthy; Yoshihiro Shimoda
Hello.
On 7/2/2015 10:36 AM, Phil Edworthy wrote:
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy phil.edwor
Hi Sergei.
On 02 July 2015 12:32, Sergei wrote:
Hello.
On 7/2/2015 11:14 AM, Phil Edworthy wrote:
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Note
Hi Kishon,
On 02 July 2015 09:22, Kishon wrote:
Hi,
On Monday 22 June 2015 08:12 PM, Phil Edworthy wrote:
Instead of statically selecting the PHY connection to either the
USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
dts to specifiy gpio pins for the vbus and id
901 - 1000 of 1263 matches
Mail list logo
