Re: [PATCH 1/5] spi: spi-zynqmp-gqspi: fix clk_enable/disable imbalance issue

2021-04-16 Thread quanyang.wang
Hi Mark, On 4/16/21 8:55 PM, Mark Brown wrote: On Fri, Apr 16, 2021 at 08:46:48AM +0800, quanyang.w...@windriver.com wrote: Since pm_runtime works now, clks can be enabled/disabled by calling zynqmp_runtime_suspend/resume. So we don't need to enable these clks explicitly in

Re: [PATCH] [v4] spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

2021-04-15 Thread quanyang.wang
On 4/15/21 3:46 PM, Dinghao Liu wrote: There is a PM usage counter decrement after zynqmp_qspi_init_hw() without any refcount increment, which leads to refcount leak.Add a refcount increment to balance the refcount. Also set auto_runtime_pm to resume suspended spi controller. Fixes:

Re: [PATCH] [v3] spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

2021-04-15 Thread quanyang.wang
Hi Dinghao, On 4/15/21 3:17 PM, Dinghao Liu wrote: There is a PM usage counter decrement after zynqmp_qspi_init_hw() without any refcount increment, which leads to refcount leak.Add a refcount increment to balance the refcount. Also set auto_runtime_pm to resume suspended spi controller.

Re: [PATCH] spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

2021-04-08 Thread quanyang.wang
Hi Dinghao, On 4/8/21 6:33 PM, Michal Simek wrote: ++ On 4/8/21 11:25 AM, Dinghao Liu wrote: When platform_get_irq() fails, a pairing PM usage counter increment is needed to keep the counter balanced. It's the same for the following error paths. Signed-off-by: Dinghao Liu ---

Re: [V2] [PATCH] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-03-31 Thread quanyang.wang
Hi Stephen, On 4/1/21 9:49 AM, Stephen Boyd wrote: Quoting quanyang.w...@windriver.com (2021-03-30 05:17:01) From: Quanyang Wang If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, we shouldn't skip invoking PM_CLOCK_ENABLE fn even though this pll has been enabled. In ATF

Re: [PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-03-31 Thread quanyang.wang
Hi Stephen, On 4/1/21 9:48 AM, Stephen Boyd wrote: Quoting quanyang.w...@windriver.com (2021-03-31 02:00:18) From: Quanyang Wang The round_rate callback should only perform rate calculation and not involve calling zynqmp_pll_set_mode to change the pll mode. So let's move zynqmp_pll_set_mode

Re: [PATCH 1/2] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-03-30 Thread quanyang.wang
Hi Laurent, On 3/21/21 8:01 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Fri, Mar 19, 2021 at 06:07:17PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, we shouldn't skip invoking

Re: [PATCH] cpufreq: dt: check the error returned by dev_pm_opp_of_cpumask_add_table

2021-03-24 Thread quanyang.wang
Hi Viresh, On 3/25/21 1:24 PM, Viresh Kumar wrote: On 25-03-21, 13:15, quanyang.wang wrote: Thank you for pointing it out.  Do you mean that even if dev_pm_opp_of_cpumask_add_table returns an error, dev_pm_opp_get_opp_count may still return count > 0 because someone may call dev_pm_opp_

Re: [PATCH] cpufreq: dt: check the error returned by dev_pm_opp_of_cpumask_add_table

2021-03-24 Thread quanyang.wang
Hi Viresh, On 3/25/21 12:45 PM, Viresh Kumar wrote: On 25-03-21, 12:31, quanyang.w...@windriver.com wrote: From: Quanyang Wang The function dev_pm_opp_of_cpumask_add_table may return zero or an error. When it returns an error, this means that no OPP table is added for the cpumask because

Re: [PATCH 1/2] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-03-22 Thread quanyang.wang
Hi Laurent, On 3/21/21 8:01 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Fri, Mar 19, 2021 at 06:07:17PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, we shouldn't skip invoking

Re: [PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers

2021-03-22 Thread quanyang.wang
Hi Laurent, On 3/21/21 4:08 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Sat, Mar 20, 2021 at 04:37:39PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the error log as below:

Re: [PATCH] drm: xlnx: call pm_runtime_get_sync before setting pixel clock

2021-03-17 Thread quanyang.wang
c layer opaque) (Patch 2), the DP will work well. Thanks, Quanyang Thanks, Rohit -Original Message- From: Michal Simek Sent: Wednesday, March 17, 2021 1:56 PM To: quanyang.wang ; Laurent Pinchart ; Rohit Visavalia Cc: Hyun Kwon ; David Airlie ; Daniel Vetter ; Michal Simek ;

Re: [PATCH] drm: xlnx: call pm_runtime_get_sync before setting pixel clock

2021-03-16 Thread quanyang.wang
Hi Laurent, On 3/17/21 4:32 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Wed, Mar 10, 2021 at 12:59:45PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang The Runtime PM subsystem will force the device "fd4a.zynqmp-display" to enter suspend state

Re: [PATCH] drm: xlnx: call pm_runtime_get_sync before setting pixel clock

2021-03-16 Thread quanyang.wang
Ping. Any comment on this patch? Thanks, Quanyang On 3/10/21 12:59 PM, quanyang.w...@windriver.com wrote: From: Quanyang Wang The Runtime PM subsystem will force the device "fd4a.zynqmp-display" to enter suspend state while booting if the following conditions are met: - the usage

Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328

2021-03-08 Thread quanyang.wang
Hi Michal, On 3/8/21 4:47 PM, Michal Simek wrote: Hi, On 3/8/21 9:35 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang The function of_i2c_get_board_info will call

Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328

2021-03-08 Thread quanyang.wang
Hi Laurent, On 3/8/21 4:35 PM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang The function of_i2c_get_board_info will call of_modalias_node to check if a device_node contains

Re: [PATCH] drm/tilcdc: send vblank event when disabling crtc

2021-02-09 Thread quanyang.wang
Hi Jyri, On 2/9/21 3:58 PM, Jyri Sarha wrote: On 2021-02-09 5:09, quanyang.wang wrote: Ping. Could you resend the original patch (I have not received it) so I can easily test and merge it? OK, I will resend it. Thanks, Quanyang I'll find some time to do it soon. Best regards, Jyri

Re: [PATCH] drm/tilcdc: send vblank event when disabling crtc

2021-02-08 Thread quanyang.wang
Ping. On 1/29/21 3:58 PM, Tomi Valkeinen wrote: Dropped the @ti.com addresses and added the new ones. Tomi On 29/01/2021 07:58, quanyang.w...@windriver.com wrote: From: Quanyang Wang When run xrandr to change resolution on Beaglebone Black board, it will print the error information:

Re: [PATCH] gpiolib: free device name on error path to fix kmemleak

2021-01-29 Thread quanyang.wang
Hi Andy, On 1/30/21 1:26 AM, Andy Shevchenko wrote: On Fri, Jan 29, 2021 at 2:01 PM wrote: From: Quanyang Wang In gpiochip_add_data_with_key, we should check the return value of dev_set_name to ensure that device name is allocated successfully and then add a label on the error path to free

Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

2020-12-08 Thread quanyang.wang
Hi Michal, On 12/8/20 8:42 PM, Michal Simek wrote: Hi, On 08. 12. 20 13:35, quanyang.w...@windriver.com wrote: From: Quanyang Wang The Zynqmp Ultrascale clock controller generates clocks for peripherals, so we need to enable it when ARCH_ZYNQMP is selected. Signed-off-by: Quanyang Wang

[PATCH V3] time/sched_clock: mark sched_clock_read_begin/retry as notrace

2020-09-29 Thread quanyang.wang
From: Quanyang Wang Since sched_clock_read_begin and sched_clock_read_retry are called by notrace function sched_clock, they shouldn't be traceable either, or else ftrace_graph_caller will run into a dead loop on the path as below (arm for instance): ftrace_graph_caller

[PATCH V2] time/sched_clock: mark sched_clock_read_begin/retry as notrace

2020-09-28 Thread quanyang.wang
From: Quanyang Wang Since sched_clock_read_begin and sched_clock_read_retry are called by notrace function sched_clock, they shouldn't be traceable either, or else ftrace_graph_caller will run into a dead loop on the path as below (arm for instance): ftrace_graph_caller

[PATCH] time/sched_clock: mark sched_clock_read_begin as notrace

2020-09-28 Thread quanyang.wang
From: Quanyang Wang Since sched_clock_read_begin is called by notrace function sched_clock, it shouldn't be traceable either, or else __ftrace_graph_caller will run into a dead loop on the path (arm for instance): ftrace_graph_caller prepare_ftrace_return function_graph_enter