The retry loop in neigh_resolve_output() and neigh_connected_output()
call dev_hard_header() with out reseting the skb to network_header.
This causes the retry to fail with skb_under_panic. The fix is to
reset the network_header within the retry loop.
Signed-off-by: Ramesh Nagappa
Reviewed-by
Hi Eric,
Yes, that is a good optimization. neigh_resolve_output() also has the
__skb_pull() outside the loop, is that required ? The changes would be
like ...
neigh_resolve_output()
...
-__skb_pull(skb, skb_network_offset(skb));
if (!neigh_event_send(neigh, skb)) {
From: Ramesh Nagappa
The retry loop in neigh_resolve_output() and neigh_connected_output()
call dev_hard_header() with out reseting the skb to network_header.
This causes the retry to fail with skb_under_panic. The fix is to
reset the network_header within the retry loop.
Signed-off-by: Ramesh
>
> Why is all of this in the middle of the changelog section?
>
> I'm guessing you didn't use 'git send-email' for this?
>
> And why are you copying me on the patch?
I got the CC list from scripts/get_maintainers.pl
asglx-2-300 $ scripts/get_maintainer.pl
0001-net-fix-neigh_resolve_output-ca
Sorry, Outlook managled the patch. I will try to find a way to re-submit it.
>
> You need a blank line before the first Signed-off-by: line.
> Surely one of the reviewers should have caught this basic thing?
>
> greg k-h
>
-- Ramesh--
To unsubscribe from this list: send the line "unsubscribe
>From fd023edd911ef12aca38a72b40241661c202684f Mon Sep 17 00:00:00 2001
From: Ramesh Nagappa
Date: Thu, 27 Sep 2012 10:20:58 -0700
Subject: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic
The retry loop in the neigh_resolve_output() and neigh_connected_output() can
ad
6 matches
Mail list logo
