[PATCH] virtio_config: clarify output parameters

2025-08-29 Thread Alyssa Ross
This was ambiguous enough for a broken patch (206cc44588f7 ("virtio: reject shm region if length is zero")) to make it into the kernel, so make it clearer. Link: https://lore.kernel.org/r/20250816071600-mutt-send-email-...@kernel.org/ Signed-off-by: Alyssa Ross --- include/linux/virti

Re: [REGRESSION] virtio: reject shm region if length is zero

2025-08-16 Thread Alyssa Ross
"Michael S. Tsirkin" writes: > On Fri, Aug 15, 2025 at 09:19:34PM +0200, Alyssa Ross wrote: >> Alyssa Ross writes: >> >> > On Mon, May 12, 2025 at 07:51:53AM +0930, samiuddinsami.md...@gmail.com >> > wrote: >> >> From: Sami Uddin >&

Re: [REGRESSION] virtio: reject shm region if length is zero

2025-08-15 Thread Alyssa Ross
Alyssa Ross writes: > On Mon, May 12, 2025 at 07:51:53AM +0930, samiuddinsami.md...@gmail.com wrote: >> From: Sami Uddin >> >> Prevent usage of shared memory regions where the length is zero, >> as such configurations are not valid and may lead to unexpected behavior

[REGRESSION] virtio: reject shm region if length is zero

2025-08-15 Thread Alyssa Ross
On Mon, May 12, 2025 at 07:51:53AM +0930, samiuddinsami.md...@gmail.com wrote: > From: Sami Uddin > > Prevent usage of shared memory regions where the length is zero, > as such configurations are not valid and may lead to unexpected behavior. > > Signed-off-by: Sami Uddin > --- > v3: > - Use idio

Re: Virtio interrupt remapping

2025-06-14 Thread Alyssa Ross
Demi Marie Obenour writes: > On 6/13/25 14:13, Jean-Philippe Brucker wrote: >> Hi, >> >> On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: >>> I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], >>> and am running into a problem. All of the current interrupt r

Re: [PATCH 2/2] kunit: enable hardware acceleration when available

2024-11-01 Thread Alyssa Ross
On Fri, Oct 25, 2024 at 05:03:54PM -0400, Tamir Duberstein wrote: > @@ -124,6 +125,29 @@ class > LinuxSourceTreeOperationsQemu(LinuxSourceTreeOperations): > '-no-reboot', > '-nographic', > '-serial', self._se

Re: [RFC PATCH 1/5] vsock/virtio: Extend virtio-vsock spec with an "order" field

2024-05-23 Thread Alyssa Ross
(CCing virtio-comment, since this proposes adding a field to a struct that is standardized[1] in the VIRTIO spec, so changes to the Linux implementation should presumably be coordinated with changes to the spec.) [1]: https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-

Re: [PATCH 5.11 000/306] 5.11.7-rc1 review

2021-03-16 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.10 000/290] 5.10.24-rc1 review

2021-03-16 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 000/168] 5.4.106-rc1 review

2021-03-16 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 4.19 000/120] 4.19.181-rc1 review

2021-03-16 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-10 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-10 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-10 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 4.19 00/39] 4.19.180-rc1 review

2021-03-10 Thread Ross Schmidt
any issues with these being applied, please > let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

2021-03-10 Thread Ross Lagerwall
On 2021-03-09 08:57, Ross Lagerwall wrote: > On 2021-03-09 05:14, Jürgen Groß wrote: >> On 08.03.21 21:33, Boris Ostrovsky wrote: >>> >>> On 3/6/21 11:18 AM, Juergen Gross wrote: >>>> An event channel should be kept masked when an eoi is pending for it. >

Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending

2021-03-09 Thread Ross Lagerwall
gen Gross >>> Reviewed-by: Julien Grall >>> --- >>> V2: >>> - introduce a lock around masking/unmasking >>> - merge patch 3 into this one (Jan Beulich) >>> V4: >>> - don't set eoi masking flag in lateeoi_mask_ack_dynirq() >>

Re:

2021-03-06 Thread Ms Ross
I'm the above named person Ms. Siena Ross, It is the situation of things surrounding me has made me to cry to you because I never knew things would turn this way after a painful death of my beloved husband during the Italian corona virus and I became sick since and very unwell up to the dat

Re: [PATCH 5.11 00/12] 5.11.2-rc1 review

2021-02-25 Thread Ross Schmidt
let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.10 00/23] 5.10.19-rc1 review

2021-02-25 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 00/17] 5.4.101-rc1 review

2021-02-25 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending

2021-02-23 Thread Ross Lagerwall
asked in dom0 which breaks networking in the guest. The issue seems to have been introduced with this patch, though at first glance it appears correct. I haven't yet looked into why it is happening. Have you seen anything like this with this patch? Thanks, Ross

Re: [PATCH v2 8/8] xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices

2021-02-17 Thread Ross Lagerwall
Ensure ring contents visible */ > - if (u->ring_cons == u->ring_prod++) { > + if (cons == prod++) { > + WRITE_ONCE(u->ring_prod, prod); > wake_up_interruptible(&u->evtchn_wait); > kill_fasync(&u->evtchn_async_queue, > SIGIO, POLL_IN); This doesn't work correctly since now u->ring_prod is only updated if cons == prod++. Ross

Re: [PATCH 5.10 000/104] 5.10.17-rc1 review

2021-02-16 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 00/60] 5.4.99-rc1 review

2021-02-16 Thread Ross Schmidt
let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.10 00/54] 5.10.16-rc1 review

2021-02-12 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 00/24] 5.4.98-rc1 review

2021-02-12 Thread Ross Schmidt
let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 4.19 00/27] 4.19.176-rc2 review

2021-02-12 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.10 000/120] 5.10.15-rc1 review

2021-02-09 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 5.4 00/65] 5.4.97-rc1 review

2021-02-09 Thread Ross Schmidt
let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 4.19 00/38] 4.19.175-rc1 review

2021-02-09 Thread Ross Schmidt
> let me know. > Compiled and booted with no regressions on x86_64. Tested-by: Ross Schmidt thanks, Ross

Re: [PATCH 2/7] xen/events: don't unmask an event channel when an eoi is pending

2021-02-08 Thread Ross Lagerwall
his patch but processes using the userspace evtchn device did not work very well without the clear_evtchn() call. Ross > + > +static void lateeoi_mask_ack_dynirq(struct irq_data *data) > +{ > + struct irq_info *info = info_for_irq(data->irq); > + evtchn_port_t evtchn =

[PATCH v2 18/21] staging: rtl8723bs: replace EID_BSSIntolerantChlReport

2020-12-07 Thread Ross Schmidt
Replace unique EID_BSSIntolerantChlReport constant with kernel provided WLAN_EID_BSS_INTOLERANT_CHL_REPORT from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 21/21] staging: rtl8723bs: remove ELEMENT_ID enum

2020-12-07 Thread Ross Schmidt
The ELEMENT_ID enum is no longer used, remove it. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/wifi.h | 76 1 file changed, 76 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h index

[PATCH v2 20/21] staging: rtl8723bs: remove unused macros

2020-12-07 Thread Ross Schmidt
Remove many macros from wifi.h and ieee80211.h because they are unused. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/ieee80211.h | 5 - drivers/staging/rtl8723bs/include/wifi.h | 15 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging

[PATCH v2 17/21] staging: rtl8723bs: replace EID_BSSCoexistence

2020-12-07 Thread Ross Schmidt
Replace unique EID_BSSCoexistence constant with kernel provided WLAN_EID_BSS_COEX_2040 from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH v2 08/21] staging: rtl8723bs: replace _DSSET_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _DSSET_IE_ macro with kernel provdied WLAN_EID_DS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10

[PATCH v2 05/21] staging: rtl8723bs: replace WLAN_EID_VHT_OP_MODE_NOTIFY

2020-12-07 Thread Ross Schmidt
Replace unique WLAN_EID_VHT_OP_MODE_NOFITY macro with kernel provided WLAN_EID_OPMODE_NOTIF from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 1 - 2 files changed, 1 insertion(+), 2

[PATCH v2 19/21] staging: rtl8723bs: replace EID_EXTCapability

2020-12-07 Thread Ross Schmidt
Replace unique EID_EXTCapability constant with kernel provided WLAN_EID_EXT_CAPABILITY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[PATCH v2 15/21] staging: rtl8723bs: replace _WAPI_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _WAPI_IE_ macro with kernel provided WLAN_EID_BSS_AC_ACCESS_DELAY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 2 insertions(+), 3 deletions

[PATCH v2 16/21] staging: rtl8723bs: replace _MME_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _MME_IE_ macro with kernel provided WLAN_EID_MMIE from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 1 - 3 files

[PATCH v2 11/21] staging: rtl8723bs: replace _COUNTRY_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _COUNTRY_IE_ macro with kernel provided WLAN_EID_COUNTRY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 12/21] staging: rtl8723bs: replace _CHLGETXT_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _CHLGETXT_IE_ macro with kernel provided WLAN_EID_CHALLENGE from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 drivers/staging/rtl8723bs/include/wifi.h | 1 - 2 files changed, 4 insertions(+), 5 deletions

[PATCH v2 14/21] staging: rtl8723bs: replace _EXT_SUPPORTEDRATES_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _EXT_SUPPORTEDRATES_IE_ macro with kernel provided WLAN_EID_EXT_SUPP_RATES from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- drivers/staging/rtl8723bs/core

[PATCH v2 13/21] staging: rtl8723bs: replace _ERPINFO_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _ERPINFO_IE_ macro with kernel provided WLAN_EID_ERP_INFO from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 12 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- drivers/staging/rtl8723bs/core

[PATCH v2 07/21] staging: rtl8723bs: replace _SUPPORTEDRATES_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _SUPPORTEDRATES_IE_ macro with kernel provided WLAN_EID_SUPP_RATES from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++-- drivers/staging/rtl8723bs/core

[PATCH v2 10/21] staging: rtl8723bs: replace _IBSS_PARA_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _IBSS_PARA_IE_ macro with kernel provided WLAN_EID_IBSS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c

[PATCH v2 09/21] staging: rtl8723bs: replace _TIM_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _TIM_IE_ macro with kernel provided WLAN_EID_DS_PARAMS from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 10 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_recv.c | 4

[PATCH v2 06/21] staging: rtl8723bs: replace _SSID_IE_

2020-12-07 Thread Ross Schmidt
Replace unique _SSID_IE_ macro with kernel provided WLAN_EID_SSID from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c| 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20

[PATCH v2 04/21] staging: rtl8723bs: use WLAN_EID_HT_OPERATION

2020-12-07 Thread Ross Schmidt
Replace unique _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ macros with kernel provided WLAN_EID_HT_OPERATION from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 10 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- drivers

[PATCH v2 01/21] staging: rtl8723bs: use WLAN_EID_HT_CAPABILITY

2020-12-07 Thread Ross Schmidt
Replace unique WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability with kernel provided WLAN_EID_HT_CAPABILITY from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 8 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2

[PATCH v2 03/21] staging: rtl8723bs: use WLAN_EID_RSN

2020-12-07 Thread Ross Schmidt
Replace unique _WPA2_IE_ID_, EID_WPA2, and _RSN_IE_2_ with kernel provided WLAN_EID_RSN from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++--- drivers/staging/rtl8723bs/core

[PATCH v2 02/21] staging: rtl8723bs: use WLAN_EID_VENDOR_SPECIFIC

2020-12-07 Thread Ross Schmidt
Replace unique WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and _VENDOR_SPECIFIC_IE_ macros with kernel provided WLAN_EID_VENDOR_SPECIFIC from linux/ieee80211.h. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- .../staging/rtl8723bs/core/rtw_ieee80211.c

[PATCH v2 00/21] replace unique macros and ELEMENT_ID

2020-12-07 Thread Ross Schmidt
divided into per-constant replacement patches v1 can be found here: https://lore.kernel.org/driverdev-devel/20201206034517.4276-10-ross.schm@gmail.com/ Ross Schmidt (21): staging: rtl8723bs: use WLAN_EID_HT_CAPABILITY staging: rtl8723bs: use WLAN_EID_VENDOR_SPECIFIC staging: rtl8723bs

[PATCH 07/10] staging: rtl8723bs: replace RTW_IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK

2020-12-05 Thread Ross Schmidt
Replace unique macro RTW_IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK with kernel provided IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK. The other IEEE80211_ADDBA_* and IEEE_DELBA_* macros are duplicates already defined in linux/ieee80211.h, remove them. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs

[PATCH 02/10] staging: rtl8723bs: replace WIFI_REASON_CODE

2020-12-05 Thread Ross Schmidt
Replace unique macros and WIFI_REASON_CODE enum with the kernel provided ieee80211_reasoncode. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 +-- drivers/staging/rtl8723bs/include/wifi.h | 36 --- 2 files changed, 2 insertions(+), 38

[PATCH 09/10] staging: rtl8723bs: remove LIST_CONTAINOR

2020-12-05 Thread Ross Schmidt
Remove unnecessary macro for container_of and call it directly. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 16 +++--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 18 +++ drivers

[PATCH 04/10] staging: rtl8723bs: replace HT_CAP_AMPDU_FACTOR

2020-12-05 Thread Ross Schmidt
Replace unique HT_CAP_AMPDU_FACTOR enum with kernel provided ieee80211_max_ampdu_length_exp enum. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 ++-- drivers/staging/rtl8723bs/hal

[PATCH 08/10] staging: rtl8723bs: remove unused macros

2020-12-05 Thread Ross Schmidt
Remove many macros from wifi.h because they are unused. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/wifi.h | 33 1 file changed, 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h

[PATCH 03/10] staging: rtl8723bs: replace cap_* macros

2020-12-05 Thread Ross Schmidt
Replace unique cap_* macros with kernel provided WLAN_CAPABILITY_* macros. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++-- drivers

[PATCH 06/10] staging: rtl8723bs: remove WLAN_HT_CAP_SM_PS_* macros

2020-12-05 Thread Ross Schmidt
The WLAN_HT_CAP_SM_PS_* macro family is already defined in linux/ieee80211.h, remove them. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/wifi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs

[PATCH 01/10] staging: rtl8723bs: replace unique macros and WIFI_STATUS_CODE

2020-12-05 Thread Ross Schmidt
Replace many unique macros and WIFI_STATUS_CODE enum with kernel provided ieee80211_statuscode. A duplicate WLAN_STATUS_ASSOC_DENIED_NOSHORT macro is also removed. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 54 +-- drivers/staging/rtl8723bs

[PATCH 10/10] staging: rtl8723bs: replace unique macros and ELEMENT_ID

2020-12-05 Thread Ross Schmidt
replaced by WLAN_EID_RSN. _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ are replaced by WLAN_EID_HT_OPERATION. WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and _VENDOR_SPECIFIC_IE_ are replaced by WLAN_EID_VENDOR_SPECIFIC. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c

[PATCH 05/10] staging: rtl8723bs: replace OP_MODE_* and HT_INFO_OPERATION_MODE_* macros

2020-12-05 Thread Ross Schmidt
Replace unique OP_MODE_* and HT_INFO_OPERATION_MODE_* macro families with kernel provided IEEE80211_HT_OP_MODE_* macros. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 30 drivers/staging/rtl8723bs/include/wifi.h | 13 -- 2 files

[PATCH 04/10] staging: rtl8723bs: clean up open ended lines

2020-11-09 Thread Ross Schmidt
Move declarations to fix coding style issues and clear checkpatch checks. CHECK: Lines should not end with a '(' Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_efuse.c| 44 +-- .../staging/rtl8723bs/core/rtw_ieee80211.c| 13 +- .../staging/rtl8

[PATCH 10/10] staging: rtl8723bs: clean up leading space

2020-11-09 Thread Ross Schmidt
Convert spaces to tabs to fix coding style issues and clear checkpatch warnings. WARNING: please, no spaces at the start of a line Signed-off-by: Ross Schmidt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 80 +-- .../staging/rtl8723bs/os_dep/osdep_service.c | 2 +- 2

[PATCH 07/10] staging: rtl8723bs: clean up trailing statements

2020-11-09 Thread Ross Schmidt
Move trailing statements to the next line to fix coding style issues and clear checkpatch errors. ERROR: trailing statements should be on next line Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c| 9

[PATCH 06/10] staging: rtl8723bs: clean up switch case indentation

2020-11-09 Thread Ross Schmidt
Move cases to align with switch indentation to fix coding style issues and clear checkpatch errors. ERROR: switch and case should be at the same indent Signed-off-by: Ross Schmidt --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 219 +- drivers/staging/rtl8723bs/os_dep

[PATCH 09/10] staging: rtl8723bs: clean up pointer locations

2020-11-09 Thread Ross Schmidt
Move pointer locations to fix coding style issues and clear checkpatch errors. ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/rtw_io.h| 2 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 14 +++

[PATCH 01/10] staging: rtl8723bs: clean up line spacing

2020-11-09 Thread Ross Schmidt
Add or remove lines to fix coding style issues and clear checkpatch. WARNING: Missing a blank line after declarations CHECK: Please use a blank line after function/struct/union/enum declarations CHECK: Please don't use multiple blank lines Signed-off-by: Ross Schmidt --- drivers/st

[PATCH 05/10] staging: rtl8723bs: clean up open braces

2020-11-09 Thread Ross Schmidt
Move braces to fix coding style issues and clear checkpatch errors. Some braces are removed for single statements. ERROR: open brace '{' following function definitions go on the next line ERROR: that open brace { should be on the previous line Signed-off-by: Ross Schmidt --- .

[PATCH 08/10] staging: rtl8723bs: clean up logical continuations

2020-11-09 Thread Ross Schmidt
Move operators to fix coding style issues and clear checkpatch checks. CHECK: Logical continuations should be on the previous line Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 41 +++ drivers/staging/rtl8723bs/core/rtw_recv.c | 27

[PATCH 02/10] staging: rtl8723bs: clean up braces

2020-11-09 Thread Ross Schmidt
on all arms of this statement CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_security.c | 42 ++-

[PATCH 03/10] staging: rtl8723bs: clean up space before tabs

2020-11-09 Thread Ross Schmidt
Remove spaces before tabs to fix coding style issues and clear checkpatch warnings. WARNING: please, no space before tabs Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 16 +++ drivers/staging/rtl8723bs/core/rtw_recv.c | 42 +- drivers

[PATCH 2/9] staging: rtl8723bs: use %pM format for MAC addresses

2020-11-04 Thread Ross Schmidt
Use %pM format instead of custom printing code. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal

[PATCH 9/9] staging: rtl8723bs: replace ieee80211_back_actioncode

2020-11-04 Thread Ross Schmidt
Replace the unique rtw_ieee80211_back_actioncode with the standard provided ieee80211_back_actioncode. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16 drivers/staging/rtl8723bs/include/ieee80211.h | 7 --- 2 files changed, 8 insertions

[PATCH 7/9] staging: rtl8723bs: replace rtw_ieee80211_spectrum_mgmt_actioncode

2020-11-04 Thread Ross Schmidt
Replace the unique rtw_ieee80211_mgmt_actioncode enum with the provided standard ieee80211_spectrum_mgmt_actioncode. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +- drivers/staging/rtl8723bs/include/ieee80211.h | 10 -- 2 files changed, 5

[PATCH 4/9] staging: rtl8723bs: remove NDEV_FMT macro

2020-11-04 Thread Ross Schmidt
Remove unnecessary macro for %s and call it directly. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/include/osdep_service_linux.h | 1 - drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 5/9] staging: rtl8723bs: remove ADPT_FMT macro

2020-11-04 Thread Ross Schmidt
Remove unnecessary macro for %s and call it directly. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c| 4 ++-- drivers/staging/rtl8723bs/core/rtw_security.c| 4 ++-- drivers/staging

[PATCH 6/9] staging: rtl8723bs: replace rtw_ieee80211_ht_cap

2020-11-04 Thread Ross Schmidt
Replace the unique rtw_ieee80211_ht_cap struct with the provided standard ieee80211_ht_cap. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 2 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 20

[PATCH 8/9] staging: rtl8723bs: replace rtw_ieee80211_ht_actioncode

2020-11-04 Thread Ross Schmidt
Replace the unique rtw_ieee80211_ht_actioncode enum with the provided standard ieee80211_ht_actioncode. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 12 2 files changed, 1 insertion(+), 13

[PATCH 1/9] staging: rtl8723bs: remove MAC_FMT macro

2020-11-04 Thread Ross Schmidt
Remove unnecessary macro for %pM and call it directly. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 39 +-- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- .../staging/rtl8723bs/core/rtw_ieee80211.c| 2 +- .../staging/rtl8723bs/core

[PATCH 3/9] staging: rtl8723bs: remove IP_FMT macro

2020-11-04 Thread Ross Schmidt
Remove unnecessary macro for %pI4 and call it directly. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 4 ++-- drivers/staging/rtl8723bs/include/ieee80211.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-10-21 Thread Ross Philipson
20 at 04:51:51PM -0400, Arvind Sankar wrote: >>>>> On Thu, Oct 15, 2020 at 08:26:54PM +0200, Daniel Kiper wrote: >>>>>> >>>>>> I am discussing with Ross the other option. We can create >>>>>> .rodata.mle_header section and put it at fix

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-10-19 Thread Ross Philipson
On 10/19/20 1:06 PM, Arvind Sankar wrote: > On Mon, Oct 19, 2020 at 10:38:08AM -0400, Ross Philipson wrote: >> On 10/16/20 4:51 PM, Arvind Sankar wrote: >>> On Thu, Oct 15, 2020 at 08:26:54PM +0200, Daniel Kiper wrote: >>>> >>>> I am discussing

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-10-19 Thread Ross Philipson
On 10/16/20 4:51 PM, Arvind Sankar wrote: > On Thu, Oct 15, 2020 at 08:26:54PM +0200, Daniel Kiper wrote: >> >> I am discussing with Ross the other option. We can create >> .rodata.mle_header section and put it at fixed offset as >> kernel_info is. So, we would have

Re: [PATCH] x86/boot: Place kernel_info at a fixed offset

2020-10-05 Thread Ross Philipson
> Ensure that kernel_info is aligned, and use the SYM_DATA.* macros > instead of bare labels. This stores the size of the kernel_info > structure in the ELF symbol table. I pulled this change in and made all the changes to remove other code that was causing relocations in the compressed k

[PATCH 3/8] staging: rtl8723bs: replace _RND8 with round_up()

2020-10-03 Thread Ross Schmidt
Use round_up instead of inline _RND8. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c| 2 +- drivers/staging/rtl8723bs/include/osdep_service.h | 11 --- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH 8/8] staging: rtl8723bs: replace _cancel_timer with del_timer_sync

2020-10-03 Thread Ross Schmidt
Replace _cancel_timer with API function del_timer_sync. One instance of del_timer_sync is moved and an unnecessary pair of spin locks are removed. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 +-- drivers/staging/rtl8723bs/core/rtw_mlme.c| 16

[PATCH 6/8] staging: rtl8723bs: replace RTW_GET_LE16 with get_unaligned_le16

2020-10-03 Thread Ross Schmidt
Replace RTW_GET_LE16 macro with get_unaligned_le16. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ap.c | 5 +++-- drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 --- drivers/staging/rtl8723bs

[PATCH 4/8] staging: rtl8723bs: remove unused macros

2020-10-03 Thread Ross Schmidt
Remove several macros in osdep_service.h because they are not used. Signed-off-by: Ross Schmidt --- .../staging/rtl8723bs/include/osdep_service.h | 57 --- 1 file changed, 57 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging

[PATCH 5/8] staging: rtl8723bs: replace RTW_GET_BE24 with get_unaligned_be24

2020-10-03 Thread Ross Schmidt
Replace RTW_GET_BE24 macro with get_unaligned_be24. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 3 ++- drivers/staging/rtl8723bs/include/osdep_service.h | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH 2/8] staging: rtl8723bs: replace _RND4 with round_up()

2020-10-03 Thread Ross Schmidt
Use round_up instead of inline _RND4. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- drivers/staging/rtl8723bs/include/osdep_service.h | 11 --- 3 files changed, 2 insertions(+), 13

[PATCH 1/8] staging: rtl8723bs: replace RND4 with round_up()

2020-10-03 Thread Ross Schmidt
Use round_up instead of define RND4. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++-- drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 +++--- drivers/staging/rtl8723bs/include

[PATCH 7/8] staging: rtl8723bs: replace RTW_GET_BE16 with get_unaligned_be16

2020-10-03 Thread Ross Schmidt
Replace RTW_GET_BE16 macro with get_unlaligned_be16. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++-- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- drivers/staging/rtl8723bs/include/osdep_service.h | 2 -- drivers/staging/rtl8723bs/os_dep

Re: [PATCH] x86/boot: Place kernel_info at a fixed offset

2020-09-29 Thread Ross Philipson
> Ensure that kernel_info is aligned, and use the SYM_DATA.* macros > instead of bare labels. This stores the size of the kernel_info > structure in the ELF symbol table. That is great. It looks like just what we will need. Thank you very much. Acked-by: Ross Philipson >

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-09-29 Thread Ross Philipson
On 9/25/20 3:18 PM, Arvind Sankar wrote: > On Fri, Sep 25, 2020 at 10:56:43AM -0400, Ross Philipson wrote: >> On 9/24/20 1:38 PM, Arvind Sankar wrote: >>> On Thu, Sep 24, 2020 at 10:58:35AM -0400, Ross Philipson wrote: >>> >>>> diff --git a/arch/x86/boot/com

Re: [PATCH 01/13] x86: Secure Launch Kconfig

2020-09-25 Thread Ross Philipson
On 9/24/20 10:08 PM, Randy Dunlap wrote: > On 9/24/20 7:58 AM, Ross Philipson wrote: >> Initial bits to bring in Secure Launch functionality. Add Kconfig >> options for compiling in/out the Secure Launch code. >> >> Signed-off-by: Ross Philipson > > Hi, &g

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-09-25 Thread Ross Philipson
On 9/24/20 1:38 PM, Arvind Sankar wrote: > On Thu, Sep 24, 2020 at 10:58:35AM -0400, Ross Philipson wrote: >> The Secure Launch (SL) stub provides the entry point for Intel TXT (and >> later AMD SKINIT) to vector to during the late launch. The symbol >> sl_stub_entry is tha

[PATCH 00/13] x86: Trenchboot secure dynamic launch Linux kernel support

2020-09-24 Thread Ross Philipson
upport patchset (WIP): https://lists.gnu.org/archive/html/grub-devel/2020-05/msg00011.html Thanks Ross Philipson and Daniel P. Smith Daniel P. Smith (4): x86: Add early TPM TIS/CRB interface support for Secure Launch x86: Add early TPM1.2/TPM2.0 interface support for Secure Launch x86: A

  1   2   3   4   5   6   7   8   9   10   >