Hi Greg,
I don’t have any commit ID since the fix is not in mainline or any Linus’ tree
yet. The driver has completely changed for newer stable versions (and also
mainline) and the fix only applies for 5.4, 4.19, and 4.14 stable kernels.
Thanks,
Saeed
> On Apr 13, 2021, at 12:32 AM, Greg
:00.4 fail, -12
[2.490358] ehci-pci: probe of :01:00.4 failed with error -12
This issue happens when the value of the sagaw corresponds to a
48-bit agaw. This fix updates the calculation of the agaw based on
the minimum of IOMMU's sagaw value and MGAW.
Cc: sta...@vger.kernel.org
Signed-off-by:
Hi Greg,
This patch fixes an issue with the IOMMU driver and it only applies to 5.4,
4.19, and 4.14 stable kernels. May I know when this patch would be available in
the stable kernels?
Subject: iommu/vt-d: Fix agaw for a supported 48 bit guest address width
Thanks,
Saeed
> On Apr 11, 2
Greetings,
I am the investment officer of a UAE based investment company who are ready to
fund projects outside UAE, in the form of debt finance. We grant loans to both
Corporate and private entities at a low interest rate of 3% ROI per annum.
Thanks
investment officer
:00.4 fail, -12
[2.490358] ehci-pci: probe of :01:00.4 failed with error -12
This issue happens when the value of the sagaw corresponds to a
48-bit agaw. This fix updates the calculation of the agaw based on
the minimum of IOMMU's sagaw value and MGAW.
Signed-off-by: Saeed Mirzamohammadi
T
nfrastructur")
> > Signed-off-by: Xiaoming Ni
> > ---
> > .../net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +-
> >
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
>
> Thanks,
> Reviewed-by: Leon Romanovsky
Applied to net-mlx5.
Thanks,
Saeed.
ehci-pci: probe of :01:00.4 failed with error -12
This issue happens when the value of the sagaw corresponds to a
48-bit agaw. This fix updates the calculation of the agaw based on
the IOMMU's sagaw value.
Signed-off-by: Saeed Mirzamohammadi
Tested-by: Camille Lu
---
drivers/iom
On Mon, 2021-03-15 at 12:30 +, Colin King wrote:
> From: Colin Ian King
>
> There are two spelling mistakes in a mlx5_core_info message. Fix
> them.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
On Wed, 2021-03-03 at 09:54 +0200, Roi Dayan wrote:
>
>
> On 2021-03-03 4:40 AM, angkery wrote:
> > From: Junlin Yang
> >
> > It is allocated with kvzalloc(), the corresponding release function
> > should not be kfree(), use kvfree() instead.
> >
> > Generated by: scripts/coccinelle/api/kfree_
On Wed, 2021-03-03 at 08:52 +, Parav Pandit wrote:
> Hi Saeed,
>
> > From: Parav Pandit
> > Sent: Monday, February 22, 2021 3:32 PM
> >
> >
> > > From: Jiapeng Chong
> > > Sent: Monday, February 22, 2021 3:27 PM
> > >
> >
On Sun, 2021-03-07 at 10:50 +0200, Leon Romanovsky wrote:
> On Thu, Mar 04, 2021 at 06:18:14AM -0800, Jia-Ju Bai wrote:
> > When mlx5_is_fpga_lookaside() returns a non-zero value, no error
> > return code is assigned.
> > To fix this bug, err is assigned with -EINVAL as error return code.
> >
> >
On Mon, 2021-03-08 at 18:28 +0200, Tariq Toukan wrote:
>
>
> On 3/8/2021 5:32 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > Increasing the size of the indirection_rqt array from 128 to 256
> > bytes
> > pushed the stack usage of the mlx5e_hairpin_fill_rqt_rqns()
> > function
> > over
On Mon, 2021-03-08 at 20:23 +0200, Roi Dayan wrote:
>
>
> On 2021-03-08 5:31 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > error: implicit declaration of function 'fib_info_nh' [-Werror,-
> > Wimplicit-function-de
> > > > > *dev, struct mlx5e_priv *priv,
> > > > > u64 lastuse2;
> > > > > counter = mlx5e_tc_get_counter(flow->peer_flow);
> > > > > - if (!counter)
> > > > > + if (!counter) {
> > > > > + err = -EINVAL;
> > >
> > > this change is problematic. the current goto is to do stats
> > > update with
> > > the first counter stats we got but if you now want to return an
> > > error
> > > then you probably should not do any update at all.
> >
> > Thanks for your reply :)
> > I am not sure whether an error code should be returned here?
> > If so, flow_stats_update(...) should not be called here?
> >
> >
> > Best wishes,
> > Jia-Ju Bai
> >
>
> basically flow and peer_flow should be valid and protected from
> changes,
> and counter should be valid.
> it looks like the check here is more of a sanity check if something
> goes
> wrong but shouldn't. you can just let it be, update the stats from
> the
> first queried counter.
>
Roi, let's consider returning an error code here, we shouldn't be
silently returning if we are not expecting these errors,
why would mlx5e_stats_flower() be called if stats are not offloaded ?
Thanks,
Saeed.
On Mon, 2021-03-01 at 11:57 +0200, Vlad Buslov wrote:
> On Thu 25 Feb 2021 at 14:54, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > The alternative implementation of this function in a header file
> > is declared as a global symbol, and gets added to every .c file
> > that includes it, whi
> On Feb 23, 2021, at 5:56 AM, Baoquan He wrote:
>
> On 02/23/21 at 08:01pm, Kairui Song wrote:
>> On Thu, Feb 18, 2021 at 10:03 AM Baoquan He wrote:
>>>
>>> On 02/11/21 at 10:08am, Saeed Mirzamohammadi wrote:
> ...
>>>> diff --git a/arc
This adds crashkernel=auto feature to configure reserved memory for
vmcore creation. CONFIG_CRASH_AUTO_STR is defined to be set for
different kernel distributions and different archs based on their
needs.
Signed-off-by: Saeed Mirzamohammadi
Signed-off-by: John Donnelly
Tested-by: John Donnelly
On Mon, 2021-02-15 at 23:17 +0530, James Spader wrote:
> Hi All,
>
> Does HW crypto offload support for mlx5 work under virtualized
> environment?
> For e.g with PF (Physical Function) driver and VF(Virtual Function)
> driver.
>
> If yes, then how does the information that is required to create
>
be mentioned to your upstream maintainer when your
> tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any
> particularly
> complex conflicts.
>
Resolution looks correct.
Thanks,
Saeed.
This adds crashkernel=auto feature to configure reserved memory for
vmcore creation. CONFIG_CRASH_AUTO_STR is defined to be set for
different kernel distributions and different archs based on their
needs.
Signed-off-by: Saeed Mirzamohammadi
Signed-off-by: John Donnelly
Tested-by: John Donnelly
section underline while visiting this document.
>
> Signed-off-by: Lukas Bulwahn
> ---
> Saeed, please pick this patch for your -next tree on top of the
> commit above.
Applied to net-next-mlx5,
Thanks,
Saeed.
On Wed, 2021-02-10 at 10:50 +0530, Naresh Kamboju wrote:
> While building Linux next tag 20210209 s390 (defconfig) with gcc-9
> make modules failed.
>
...
> Reported-by: Naresh Kamboju
>
Thanks for the report a patch was already posted earlier today
https://patchwork.kernel.org/project/netdevb
On Wed, 2021-02-03 at 14:57 -0800, Jesse Brandeburg wrote:
> Colin King wrote:
>
> > From: Colin Ian King
> >
> > There is a spelling mistake in a netdev_warn message. Fix it.
> >
> > Signed-off-by: Colin Ian King
>
> Trivial patch, looks fine!
>
> Reviewed-by: Jesse Brandeburg
Applied to
On Thu, 2021-02-04 at 09:32 +, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in a netdev_warn message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Applied to net-next-mlx5
thanks!
This adds crashkernel=auto feature to configure reserved memory for
vmcore creation. CONFIG_CRASH_AUTO_STR is defined to be set for
different kernel distributions and different archs based on their
needs.
Signed-off-by: Saeed Mirzamohammadi
Signed-off-by: John Donnelly
Tested-by: John Donnelly
On Thu, 2021-01-21 at 19:49 +0200, Leon Romanovsky wrote:
> On Wed, Jan 20, 2021 at 08:58:30PM -0800, Pan Bian wrote:
> > Instead of directly return, goto the error handling label to free
> > allocated page.
> >
> > Fixes: 5f29458b77d5 ("net/mlx5e: Support dump callback in TX
> > reporter")
> > Si
magic numbers and some redefined constant values
according to some mysterious sources ;-) .. It would be nice to have
some wording in the commit messages explaining reasoning and maybe
"semi-official" sources behind the changes.
LGMT code style wise :)
Reviewed-by: Saeed Mahameed
&g
On Tue, 2021-01-12 at 15:16 -0800, Saeed Mahameed wrote:
> On Mon, 2021-01-04 at 12:50 +0530, Geetha sowjanya wrote:
> > Hardware supports 8 RSS groups per interface. Currently we are
> > using
> > only group '0'. This patch allows user to create new RSS
> > gr
in patchwork
https://patchwork.kernel.org/project/netdevbpf/patch/20210104072039.27297-1-gak...@marvell.com/
but it is not actually applied, maybe resend..
you can add:
Reviewed-by: Saeed Mahameed
On Tue, 2021-01-05 at 13:02 -0800, Saeed Mahameed wrote:
> On Mon, 2020-12-28 at 16:48 +0800, Dinghao Liu wrote:
> > mlx5e_create_ttc_table_groups() frees ft->g on failure of
> > kvzalloc(), but such failure will be caught by its caller
> > in mlx5e_create_ttc_table() and f
On Tue, 2020-12-15 at 14:49 +, Colin King wrote:
> From: Colin Ian King
>
> There are some spelling mistakes in the Kconfig. Fix these.
>
> Signed-off-by: Colin Ian King
>
applied to net-next-mlx5,
Thanks!
On Wed, 2020-12-23 at 11:45 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
>
> Standard integer promotion is already d
On Sun, 2020-12-27 at 10:33 +0200, Leon Romanovsky wrote:
> On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote:
> > When mlx5_create_flow_group() fails, ft->g should be
> > freed just like when kvzalloc() fails. The caller of
> > mlx5e_create_l2_table_groups() does not catch this
> > issue
On Mon, 2020-12-28 at 16:48 +0800, Dinghao Liu wrote:
> mlx5e_create_ttc_table_groups() frees ft->g on failure of
> kvzalloc(), but such failure will be caught by its caller
> in mlx5e_create_ttc_table() and ft->g will be freed again
> in mlx5e_destroy_flow_table(). The same issue also occurs
> in
On Wed, 2020-12-09 at 15:01 +0800, Zou Wei wrote:
> Remove including that don't need it.
>
> Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name")
> Signed-off-by: Zou Wei
> ---
Applied to net-next-mlx5.
Thanks!
still don't see this patch in net-next, i will take it to my tree
and submit it in my next pr.
Thanks,
Saeed.
c->num_tc = params->num_tc;
> c->xdp = !!params->xdp_prog;
> c->stats= &priv->channel_stats[ix].ch;
> - c->irq_desc = irq_to_desc(irq);
> + c->aff_mask = irq_get_affinity_mask(irq);
as long as the affinity mask pointer stays the same for the lifetime of
the irq vector.
Assuming that:
Acked-by: Saeed Mahameed
pace,
> but the architecture can or even must reduce the mask to the
> effective set,
> which means that checking the affinity mask itself does not really
> tell
> about the actual target CPUs.
>
> Signed-off-by: Thomas Gleixner
> Cc: Saeed Mahameed
> Cc: Leon Romanovsky
>
On Thu, 2020-12-10 at 20:24 +0800, tanhuazhong wrote:
>
> On 2020/12/10 13:40, Saeed Mahameed wrote:
> > On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
> > > From: Jian Shen
> > >
> > > For some new device, it supports forwarding packet to queues
&
On Thu, 2020-12-10 at 20:27 +0800, tanhuazhong wrote:
>
> On 2020/12/10 12:50, Saeed Mahameed wrote:
> > On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
> > > From: Jian Shen
> > >
> > > Currently, the HNS3 driver only supports offload for tc nu
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
> From: Jian Shen
>
> For some new device, it supports forwarding packet to queues
> of specified TC when flow director rule hit. So extend the
> command handle to support it.
>
...
> static int hclge_config_action(struct hclge_dev *hdev,
On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote:
> From: Jian Shen
>
> Currently, the HNS3 driver only supports offload for tc number
> and prio_tc. This patch adds support for other qopts, including
> queues count and offset for each tc.
>
> When enable tc mqprio offload, it's not allowed
On Wed, 2020-12-09 at 22:39 +0530, Geetha sowjanya wrote:
> Hardware supports 8 RSS groups per interface. Currently we are using
> only group '0'. This patch allows user to create new RSS
> groups/contexts
> and use the same as destination for flow steering rules.
>
> usage:
> To steer the traffic
On Fri, 2020-12-04 at 08:25 -0800, Jakub Kicinski wrote:
> On Fri, 4 Dec 2020 14:54:55 +0200 Leon Romanovsky wrote:
> > Thanks, pulled to mlx5-next
> >
> > Jason, Jakob,
> >
> > Can you please pull that mlx5-next branch to your trees?
> > git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/lin
ved to the arch specified part
> where parse_crashkernel is called?
Thanks for the suggestion. Could you please elaborate why do we need to do that?
Thanks,
Saeed
;
> use tab instead of spaces above.
>
Thanks, Randy. I’ll be fixing the them in the v2. I’ll be removing the ‘CC:
stable’ as well.
Saeed
This adds crashkernel=auto feature to configure reserved memory for
vmcore creation to both x86 and ARM platforms based on the total memory
size.
Cc: sta...@vger.kernel.org
Signed-off-by: John Donnelly
Signed-off-by: Saeed Mirzamohammadi
---
Documentation/admin-guide/kdump/kdump.rst | 5
On Sat, 2020-11-14 at 19:52 +0800, Wang Hai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic
> flows")
> Reported-by: Hulk Robot
> Signed-off-by: Wang Ha
On Thu, 2020-11-12 at 22:28 +0800, YueHaibing wrote:
> Fix smatch warnings:
>
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105
> esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR'
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177
> esw_acl_egress_ofld_
gt; - Fixed Saeed's review comments on v2.
> - Fixed modifying the netdev->flags from driver.
> - Fixed modifying the netdev features and hw_features after
> register_netdev.
> - Removed unwanted ndo_features_check callback.
> v2:
> - Fixed the sparse issues reported by Jakub.
>
Reviewed-by: Saeed Mahameed
yte offset of VLAN header. The NPC KPU
> parser was modified to point LB_PTR to the starting byte offset
> of VLAN header which points to the tpid field.
>
> Signed-off-by: Stanislaw Kardach
> Signed-off-by: Sunil Goutham
> Signed-off-by: Naveen Mamindlapalli
>
Reviewed-by: Saeed Mahameed
0
>
I don't want to block this series or anything, but you might want to
use devlink dpipe interface for this:
https://www.kernel.org/doc/html/latest/networking/devlink/devlink-dpipe.html
As a future patch of course.
Thanks,
Saeed.
On Thu, 2020-11-05 at 14:58 +0530, Naveen Mamindlapalli wrote:
> From: Hariprasad Kelam
>
> This patch implements egress VLAN offload by appending NIX_SEND_EXT_S
> header to NIX_SEND_HDR_S. The VLAN TCI information is specified
> in the NIX_SEND_EXT_S. The VLAN offload in the ingress path is
> im
On Thu, 2020-11-05 at 14:58 +0530, Naveen Mamindlapalli wrote:
> From: Hariprasad Kelam
>
> Add unicast MAC address filtering support using install flow
> message. Total of 8 MCAM entries are allocated for adding
> unicast mac filtering rules. If the MCAM allocation fails,
> the unicast filtering
On Thu, 2020-11-05 at 21:26 +0530, Anmol Karn wrote:
> rose_send_frame() dereferences `neigh->dev` when called from
> rose_transmit_clear_request(), and the first occurance of the `neigh`
> is in rose_loopback_timer() as `rose_loopback_neigh`, and it is
> initialized
> in rose_add_loopback_neigh()
On Fri, 2020-11-06 at 00:59 +0530, Sunil Kovvuri wrote:
> > > > > Output:
> > > > > # ./devlink health
> > > > > pci/0002:01:00.0:
> > > > >reporter npa
> > > > > state healthy error 0 recover 0
> > > > >reporter nix
> > > > > state healthy error 0 recover 0
> > > > > # ./devli
On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote:
> On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote:
> > If you report an error without recovering, devlink health will
> > report a
> > bad device state
> >
> > $ ./devlink health
> >
On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Create auxiliary devices under new virtual bus. This will replace
> the custom-made mlx5 ->add()/->remove() interfaces and next patches
> will fill the missing callback and remove the old interface logic.
>
> T
On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Move mlx5_vdpa IFC header file to the general include folder, so
> mlx5_core will be able to reuse it to check if VDPA is supported
> prior to creating an auxiliary device.
>
I don't really like this, the whol
On Thu, 2020-11-05 at 09:07 -0800, Jakub Kicinski wrote:
> On Thu, 5 Nov 2020 13:36:56 + George Cherian wrote:
> > > Now i am a little bit skeptic here, devlink health reporter
> > > infrastructure was
> > > never meant to deal with dump op only, the main purpose is to
> > > diagnose/dump and r
On Thu, 2020-11-05 at 13:36 +, George Cherian wrote:
> Hi Saeed,
>
> Thanks for the review.
>
> > -Original Message-----
> > From: Saeed Mahameed
> > Sent: Thursday, November 5, 2020 10:39 AM
> > To: George Cherian ; net...@vger.kernel.org;
> >
On Wed, 2020-11-04 at 17:57 +0530, George Cherian wrote:
> Add health reporters for RVU NPA block.
^^^ NIX ?
Cc: Jiri
Anyway, could you please spare some words on what is NPA and what is
NIX?
Regarding the reporters names, all drivers register well known generic
n
On Sat, 2020-10-31 at 10:50 +0800, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
> b/drivers/net/etherne
Thanks, adding stable.
Saeed
> On Oct 22, 2020, at 12:34 AM, Thomas Zimmermann wrote:
>
> Hi
>
> On 22.10.20 01:57, saeed.mirzamohamm...@oracle.com wrote:
>> From: Saeed Mirzamohammadi
>>
>> This patch fixes the issue due to:
>>
>> [ 89.
Adding stable.
> On Oct 21, 2020, at 1:08 PM, Saeed Mirzamohammadi
> wrote:
>
> Attached the syzkaller C repro.
>
> Tested-by: Saeed Mirzamohammadi
>
>> On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi
>> wrote:
>>
>> Thanks! Yes, that loo
Attached the Syzkaller C reproducer.
repro.c
Description: Binary data
> On Oct 21, 2020, at 4:57 PM, saeed.mirzamohamm...@oracle.com wrote:
>
> From: Saeed Mirzamohammadi
>
> This patch fixes the issue due to:
>
> [ 89.572883] divide_error: [#1] SMP KASAN PTI
From: Saeed Mirzamohammadi
This patch fixes the issue due to:
[ 89.572883] divide_error: [#1] SMP KASAN PTI
[ 89.572897] CPU: 3 PID: 16083 Comm: repro Not tainted
5.9.0-rc7.20200930.rc1.allarch-19-g3e32d0d.syzk #5
[ 89.572902] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996
Attached the syzkaller C repro.
Tested-by: Saeed Mirzamohammadi
repro.c
Description: Binary data
> On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi
> wrote:
>
> Thanks! Yes, that looks good to me.
>
> Saeed
>
>> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso
Thanks! Yes, that looks good to me.
Saeed
> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso wrote:
>
> On Mon, Oct 19, 2020 at 10:25:32AM -0700, saeed.mirzamohamm...@oracle.com
> wrote:
>> From: Saeed Mirzamohammadi
>>
>> This patch fixes the issue due to:
From: Saeed Mirzamohammadi
This patch fixes the issue due to:
BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2
net/netfilter/nf_tables_offload.c:40
Read of size 8 at addr 888103910b58 by task syz-executor227/16244
The error happens when expr->ops is accessed early
VDPA_NET
> while
> MLX5_CORE is compiled as a module causing link errors.
>
> Reported-by: kernel test robot
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5
> device")s
> Signed-off-by: Eli Cohen
Reviewed-by: Saeed Mahameed
war
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 17 +
>
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
Hi Alex, thanks for the patch,
Colin submitted a one liner patch that I already picked up.
I hope you are ok with this.
Thanks,
Saeed.
On Tue, 2020-10-06 at 19:12 +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently the error exit path err_free kfree's attr. In the case
> where
> flow and parse_attr failed to be allocated this return path will free
> the uninitialized pointer attr, which is not correct. In the other
>
On Mon, 2020-09-28 at 17:06 +0100, Colin Ian King wrote:
> Hi,
>
> static analysis with Coverity has found a null pointer dereference
> issue
> with the following commit:
>
> commit c620b772152b8274031083bdb2e11c963e596c5c
> Author: Ariel Levkovich
> Date: Thu Apr 30 05:54:08 2020 +0300
>
>
On Fri, 2020-09-25 at 11:49 -0500, Gustavo A. R. Silva wrote:
> Calls to kzalloc() and kvzalloc() should be null-checked
> in order to avoid any potential failures. In this case,
> a potential null pointer dereference.
>
> Fix this by adding null checks for _parse_attr_ and _flow_
> right after al
On Thu, 2020-09-24 at 09:03 -0700, Jakub Kicinski wrote:
> On Wed, 23 Sep 2020 22:49:37 -0700 Saeed Mahameed wrote:
> > 2) Another problematic scenario which i see is repeated in many
> > drivers:
> >
> > shutdown/suspend()
> > rtnl_lock()
> >
On Wed, 2020-09-23 at 17:23 -0700, David Miller wrote:
> From: David Miller
> Date: Wed, 23 Sep 2020 17:21:25 -0700 (PDT)
>
> > If an async code path tests 'present', gets true, and then the RTNL
> > holding synchronous code path puts the device into D3hot
> immediately
> > afterwards, the async
On Wed, 2020-09-23 at 22:44 +0200, Heiner Kallweit wrote:
> On 23.09.2020 22:15, David Miller wrote:
> > From: Heiner Kallweit
> > Date: Wed, 23 Sep 2020 21:58:59 +0200
> >
> > > On 23.09.2020 20:35, Saeed Mahameed wrote:
> > > > Why would a driver detac
On Wed, 2020-09-23 at 13:49 +0200, Heiner Kallweit wrote:
> On 18.09.2020 19:58, Saeed Mahameed wrote:
> > On Tue, 2020-09-01 at 17:02 +0200, Geert Uytterhoeven wrote:
> > > This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c.
> > >
> > > Inami-san rep
On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote:
> On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote:
> > The last return statement is unreachable code. I'm not sure if it
> > will
> > provoke any warnings, but it looks ugly.
> >
>
On Tue, 2020-09-22 at 08:04 -0700, Jakub Kicinski wrote:
> On Mon, 21 Sep 2020 22:52:30 -0700 Saeed Mahameed wrote:
> > On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> > > Simplify the return expression.
> > >
> > > Signed-off-by: Qinglang Miao
&
On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote:
> The last return statement is unreachable code. I'm not sure if it
> will
> provoke any warnings, but it looks ugly.
>
> Signed-off-by: Pavel Machek (CIP)
>
>
Applied to net-next-mlx5.
Thanks,
Saeed.
On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao
> ---
> drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>
Applied to net-next-mlx5.
Thanks.
On Mon, 2020-09-21 at 19:23 +0300, Denis Efremov wrote:
> Memory ft->g in accel_fs_tcp_create_groups() is allocaed with
> kcalloc().
> It's excessive to free ft->g with kvfree(). Use kfree() instead.
>
> Signed-off-by: Denis Efremov
> ---
>
series applied to net-next-mlx5
On Fri, 2020-09-18 at 17:23 +0800, Luo bin wrote:
> Make a distinction between different irqs by netdev name or pci name.
>
> Signed-off-by: Luo bin
> ---
>
Reviewed-by: Saeed Mahameed
On Tue, 2020-09-01 at 17:02 +0200, Geert Uytterhoeven wrote:
> This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c.
>
> Inami-san reported that this commit breaks bridge support in a Xen
> environment, and that reverting it fixes this.
>
> During system resume, bridge ports are no longer
:6: warning:
> no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-
> prototypes]
>
> Signed-off-by: Wang Hai
>
Reviewed-by: Saeed Mahameed
ild warning(s):
>
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6:
> warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-
> prototypes]
>
> Signed-off-by: Wang Hai
> ---
Reviewed-by: Saeed Mahameed
e/mr.o: in function
> `mlx5_vdpa_handle_set_map':
> mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'
>
> Signed-off-by: Randy Dunlap
> Cc: "Michael S. Tsirkin"
> Cc: Jason Wang
> Cc: virtualizat...@lists.linux-foundation.org
> Cc: Saeed
On Thu, 2020-09-17 at 08:31 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> 0d2ffdc8d400 ("net/mlx5: Don't call timecounter cyc2time directly
> from 1PPS flow")
> 87f3495cbe8d ("net/mlx5: Release clock lock before scheduling a PPS
> work")
> aac2df7f022e ("net/mlx5: Rename ptp cloc
On Wed, 2020-09-16 at 17:33 +0800, Huazhong Tan wrote:
> There are some optimizations related to IO path.
>
> Change since V1:
> - fixes a unsuitable handling in hns3_lb_clear_tx_ring() of #6 which
> pointed out by Saeed Mahameed.
>
> previous version:
> V1:
> h
On Wed, 2020-09-16 at 22:18 +0800, YueHaibing wrote:
> There is no callers in tree, so can remove it.
>
You have a typo in the patch title:
funtions -> functions
> Signed-off-by: YueHaibing
Please feel free to add my R.B tag after on V2.
Reviewed-by: Saeed Mahameed
And by the w
On Tue, 2020-09-15 at 15:04 +0800, Yunsheng Lin wrote:
> On 2020/9/15 13:09, Saeed Mahameed wrote:
> > On Mon, 2020-09-14 at 20:06 +0800, Huazhong Tan wrote:
> > > From: Yunsheng Lin
> > >
> > > Use napi_consume_skb() to batch consuming skb when cl
On Mon, 2020-09-14 at 20:06 +0800, Huazhong Tan wrote:
> From: Yunsheng Lin
>
> Use napi_consume_skb() to batch consuming skb when cleaning
> tx desc in NAPI polling.
>
> Signed-off-by: Yunsheng Lin
> Signed-off-by: Huazhong Tan
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 27
On Mon, 2020-09-14 at 20:19 +0100, Alex Dewar wrote:
> The for loop checks whether cur_section is NULL on every iteration,
> but
> we know it can never be NULL as there is another check towards the
> bottom of the loop body. Remove this unnecessary check.
>
> Also change i to start at 1, so that w
On Fri, 2020-08-07 at 15:13 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote:
> > From: Roi Dayan
> >
> > Support for phys switch id ndo added for representors and if
> > we do not have representors there is no need to
side the spinlock.
This patch should also go to net.
I will provide a newer version of the patch to deal with this and with
a missing kfree on error handling i found while looking at the code.
Thanks,
Saeed.
x27;t exist upstream as the code got refactored and the
netdev api is totally different.
Fixes: cb67b832921c ("net/mlx5e: Introduce SRIOV VF representors")
Signed-off-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
Hi Greg,
Sorry for submitting a non upstream patch, but this bug is
bothe
git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.gi
> > > > t mlx5-next
> > >
> > > I can only merge this tree if no one else will. Linus does not
> > > like
> > > getting same patches through two trees.
> > >
> > > Is thi
On Thu, 2020-07-30 at 18:29 +0800, Xin Xiong wrote:
> The function invokes bpf_prog_inc(), which increases the reference
> count of a bpf_prog object "rq->xdp_prog" if the object isn't NULL.
>
> The refcount leak issues take place in two error handling paths. When
> either mlx5_wq_ll_create() or m
1 - 100 of 290 matches
Mail list logo
