RE: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-06 Thread M R, Sathya Prakash
-Original Message- From: Pierre-Louis Bossart [mailto:pierre-louis.boss...@linux.intel.com] Sent: Tuesday, May 7, 2019 7:11 AM To: Evan Green ; Liam Girdwood ; Mark Brown Cc: M, Naveen ; M R, Sathya Prakash ; Ben Zhang ; Rajat Jain ; Jaroslav Kysela ; alsa-de...@alsa-project.org

RE: [GIT PULL] SCSI fixes for 4.17-rc2

2018-04-25 Thread Sathya Prakash Veerichetty
James, The mpt3sas should be changed to mptsas. Just responding back to have record on this problem is with old mptsas and not with mpt3sas managed controllers. Thanks Sathya -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of

Re: [PATCH v1 1/2] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2018-01-27 Thread sathya
Hi Andy, Thanks for the review. On 01/26/2018 08:17 AM, Andy Shevchenko wrote: On Fri, Jan 26, 2018 at 12:53 AM, wrote: From: Kuppuswamy Sathyanarayanan Currently, we have lot of repetitive code in dependent device resource allocation and device creation handling code. This logic can be imp

Re: [RFC v8 4/7] platform: x86: Add generic Intel IPC driver

2018-01-20 Thread sathya
Hi Heikki, On 11/23/2017 05:29 AM, Heikki Krogerus wrote: Hi, On Sun, Oct 29, 2017 at 02:49:57AM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: +/** + * devm_intel_ipc_dev_create() - Create IPC device + * @dev: IPC parent device. + * @devname: Name of the IPC de

Re: [RFC v8 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2018-01-20 Thread sathya
Hi Heikki, Thanks for the review. On 11/23/2017 03:49 AM, Heikki Krogerus wrote: Hi, On Sun, Oct 29, 2017 at 02:49:55AM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan Currently, we have lot of repetitive code in dependent device resource allocati

RE: [PATCH] mpt3sas: fix dma_addr_t casts

2017-11-06 Thread Sathya Prakash Veerichetty
Acked-by: Sathya Prakash Veerichetty -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Monday, November 6, 2017 6:35 AM To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Tomas Henzl; Sreekanth Reddy

Re: [PATCH 02/11] mux: core: Add support for getting a mux controller on a non DT platform

2017-09-02 Thread sathya
Hi, On 09/01/2017 02:48 PM, Hans de Goede wrote: On non DT platforms we cannot get the mux_chip by pnode. Other subsystems (regulator, clock, pwm) have the same problem and solve this by allowing platform / board-setup code to add entries to a lookup table and then use this table to look things

Re: [RFC v1 4/6] platform: x86: Add generic Intel IPC driver

2017-08-21 Thread sathya
mode; + int irq; + int irqflags; + int chan_type; + bool use_msi; +}; - Sathya

Re: [RFC v1 2/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe

2017-08-21 Thread sathya
vice_unregister(ipcdev.tco_dev); platform_device_unregister(ipcdev.punit_dev); platform_device_unregister(ipcdev.telemetry_dev); ipcdev.dev = NULL; return 0; } - Sathya

Re: [RFC v1 3/6] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2017-08-21 Thread sathya
c_resources; + pmc_mfd_cells[n].ignore_resource_conflicts = 1; + n++; } ...and here you do mfd_add_devices() instead of this stuff. Check how lpc_ich.c designed. Will fix it in next version. - Sathya

Re: [RFC v1 1/6] platform/x86: intel_pmc_ipc: Fix error handling in ipc_pci_probe()

2017-08-21 Thread sathya
to switch to managed PCI functions in the first place. ok. I will merge this patch and "Use devm_* calls in driver probe" patch into a single patch. - Sathya

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-27 Thread Sathya Perla
On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote: [...] > > On today's linux-next: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': > bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' > bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

2017-07-26 Thread Sathya Perla
On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: [...] >> Sathya already sent 3 patches to fix some of these issues. But I need >> to rework one of his patch and resend. > > Ok, thanks. I just ran into one more issue, and don't know if that's included > as we

RE: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread Sathya Prakash Veerichetty
Willy, I think this patch had a problem and later modified to a different blocking mechanism. Could you please pull in the latest change for this? Thanks Sathya -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: Sunday, February 05, 2017 12:19 PM To: linux-kernel

RE: [PATCH v4 2/4] fusion: remove iopriority handling

2016-10-13 Thread Sathya Prakash Veerichetty
By removing the code below, we put all the commands for all the types of devices (SAS/SATA) as simple-Q (requeue as the device require) and I am not sure whether it is the intention of this change. -Original Message- From: Adam Manzanares [mailto:adam.manzana...@hgst.com] Sent: Thursday, O

RE: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

2016-05-16 Thread Sathya Prakash Veerichetty
?. Doesn't this need to be taken care in enclosure_removal? -Original Message- From: Calvin Owens [mailto:calvinow...@fb.com] Sent: Monday, May 16, 2016 2:25 PM To: Elliott, Robert (Persistent Memory) Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J. Bottomley; Mar

RE: [PATCH] mptsas: fix checks for dma mapping errors

2016-04-29 Thread Sathya Prakash Veerichetty
Please consider this patch as Ack-by: Sathya Prakash Veerichetty PS: We don't have test environment to test this patch as this is for an old controller. So ACKing based on code review and similar mpt3sas driver code. -Original Message- From: Martin K. Petersen [mailto:martin.

RE: [PATCH] mpt3sas: Remove usage of 'struct timeval'

2016-04-15 Thread Sathya Prakash Veerichetty
Hi, Please consider this patch as Ack-by: Sathya Prakash Thanks, Sathya -Original Message- From: mpt-fusionlinux@broadcom.com [mailto:mpt-fusionlinux@broadcom.com] On Behalf Of Martin K. Petersen Sent: Thursday, April 14, 2016 8:48 PM To: Tina Ruchandani Cc: mpt-fusionlinux

RE: [PATCH] mpt3sas: fix possible NULL dereference

2016-04-15 Thread Sathya Prakash Veerichetty
provide a complete patch. Thanks Sathya -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Thursday, April 14, 2016 8:44 PM To: Sudip Mukherjee Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J. Bottomley; Martin K. Petersen; linux

RE: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Sathya Prakash
those drivers from newer kernels or mark them as unmaintained?. Thanks Sathya -Original Message- From: mpt-fusionlinux@avagotech.com [mailto:mpt-fusionlinux@avagotech.com] On Behalf Of Martin K. Petersen Sent: Tuesday, January 26, 2016 7:23 PM To: Tomas Henzl Cc: Alexey Khoroshilov; Sree

Re: [PATCH] benet:Make the function be_get_sriov_config have a return type of void

2015-06-16 Thread Sathya Perla
s particular function has failed > and the error is unrecoverable from. > > Signed-off-by: Nicholas Krause Hi, you should have prefixed the subject line with "net-next" as this is a cleanup fix and so must go to the net-next tree. Thanks! Acked-by: Sathya Perla -- To unsubscrib

RE: [PATCH 00/20] mpt3sas: driver update

2015-04-24 Thread Sathya Prakash
compiled out of single source directory for each of our products) to avoid maintenance overhead. So please let us know whether the current patches can be ACKED if we provide the applicable bug fixes to SAS2 or you see any other issues?. Thanks Sathya -Original Message- From: Christoph

sparse warning about endianness mismatch on 0xffff assignment

2015-04-15 Thread Sathya Perla
and/or fix the sparse tool to not warn about endianness mismatch on an "all 1s" assignment thanks, -Sathya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

RE: [PATCHv2 net 2/4] be2net: Implement ndo_gso_check()

2014-11-14 Thread Sathya Perla
> -Original Message- > From: Joe Stringer [mailto:joestrin...@nicira.com] > > Use vxlan_gso_check() to advertise offload support for this NIC. > > Signed-off-by: Joe Stringer Acked-by: Sathya Perla Thanks! > --- > v2: Refactor out vxlan helper. > --- >

RE: be2net crash on next-20140730 ("Driver probe function unexpectedly returned 1966082")

2014-07-31 Thread Sathya Perla
old FW versions (< v4.2) after the recent net-next commit bec84e6b ("create optimal number of queues on SR-IOV config") We're cooking a fix; I'll post a patch for this as soon as it's ready. Thanks for reporting this issue! -Sathya > > It causes the follo

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

2014-04-15 Thread Sathya Perla
ck(); } and similarly for be_open_sync() And, I'd need some time to test these flows too. Would you be OK with this? thanks, -Sathya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

2014-04-15 Thread Sathya Perla
> -Original Message- > From: Li, Zhen-Hua [mailto:zhen-h...@hp.com] > > In benet driver, netif_device_detach and netif_device_attach should be > called between rtnl_lock and rtnl_unlock. Zhen, it's not clear to me why rtnl_lock is needed around netif_device_attach(). Can you pls explain w

RE: [PATCH 11/34] benet: Use pci_enable_msix_range()

2014-02-02 Thread Sathya Perla
hese two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. > > Signed-off-by: Alexander Gordeev Acked-by: Sathya Perla < sathya.pe...@emulex.com> > --- > drivers/net/ethernet/emulex/benet/be_main.c | 31 +

RE: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Perla, Sathya
+4409,7 @@ static int be_resume(struct pci_dev *pde > rtnl_unlock(); > } > > + pci_bus_add_device_vfs(adapter->pdev); > schedule_delayed_work(&adapter->func_recovery_work, > msecs_to_jiffies(1000)); > netif_device_attach

RE: [PATCH v2 net-next] drivers/net: Enable IOMMU pass through for be2net

2013-04-05 Thread Perla, Sathya
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > > From: Ivan Vecera > Date: Fri, 05 Apr 2013 09:51:24 +0200 > > > Dave, I'd like to ask when do you plan to apply this patch? > > I'm waiting for the be2net driver maintainers to integrate it and resend it to > me,

RE: be2net failed to initialize regression

2013-03-11 Thread Perla, Sathya
E reg > >> > >> The fix for this is (still on David's net tree I guess): > >> commit c5b3ad4c67989c778e4753be4f91dc7193a04d21 > >> be2net: use CSR-BAR SEMAPHORE reg for BE2/BE3 > > Sathya, the fix introduced to the following patch wouldn't be safe enough > because it possiblly

RE: be2net failed to initialize regression

2013-03-08 Thread Perla, Sathya
or BE2/BE3 Dave, can these 2 commits be queued for stable too: commit1: c5b3ad4c67989c778e4753be4f91dc7193a04d21 commit2: 1bc8e7e4f36c0c19dd7dea29e7c248b7c6ef3a15 thanks, -Sathya