Re: [PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

2023-12-15 Thread Serge E. Hallyn
On Tue, Dec 12, 2023 at 02:55:33PM -0800, Casey Schaufler wrote: > On 12/12/2023 9:59 AM, Michael S. Tsirkin wrote: > > On Tue, Dec 12, 2023 at 08:33:39AM -0800, Casey Schaufler wrote: > >> On 12/12/2023 5:17 AM, Maxime Coquelin wrote: > >>> This patch introduces a LSM hook for devices creation, >

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-24 Thread Serge Semin
25m { >compatible = "fixed-clock"; >#clock-cells = <0>; > - clock-frequency = <2500>; > + clock-frequency = <2500>; >clock-output-names = "clk25m"; > }; > ... For Baikal-T1 CCU PLL DT-schema Acked-by: Serge Semin -Serge(y)

[PATCH v3.4] capabilities: require CAP_SETFCAP to map uid 0

2021-04-20 Thread Serge E. Hallyn
llow writing ambiguous v3 file capabilities")"). [1]: https://github.com/containers/buildah/issues/3071 Signed-off-by: Serge Hallyn Reviewed-by: Andrew G. Morgan Tested-by: Christian Brauner Reviewed-by: Christian Brauner Tested-by: Giuseppe Scrivano Cc: "Eric W. Biederman"

Re: [PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.2)

2021-04-20 Thread Serge E. Hallyn
user namespace all the capabilities are kept > and AFAIK Docker does the same. I'd expect a change in behavior only > for nested user namespaces in containers where CAP_SETFCAP is not > granted, but that is not a common configuration given that CAP_SETFCAP > is added by default. > >

Re: [PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.3)

2021-04-19 Thread Serge E. Hallyn
On Mon, Apr 19, 2021 at 06:09:11PM +0200, Christian Brauner wrote: > On Mon, Apr 19, 2021 at 07:25:14AM -0500, Serge Hallyn wrote: > > cap_setfcap is required to create file capabilities. > > > > Since 8db6c34f1dbc ("Introduce v3 namespaced file capabilities"),

[PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.3)

2021-04-19 Thread Serge E. Hallyn
seen here: https://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux.git/log/?h=2021-04-15/setfcap-nsfscaps-v4 Signed-off-by: Serge Hallyn Reviewed-by: Andrew G. Morgan Tested-by: Christian Brauner Reviewed-by: Christian Brauner Cc: "Eric W. Biederman" Changelog: * f

[PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.2)

2021-04-17 Thread Serge E. Hallyn
/setcap cap_setfcap=p /sbin/setcap unable to set CAP_SETFCAP effective capability: Operation not permitted root@caps:/home/ubuntu# unshare -Ur unshare: write failed /proc/self/uid_map: Operation not permitted Signed-off-by: Serge Hallyn Changelog: * fix logic in the case of writing to another task's

Re: [RFC PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3)

2021-04-16 Thread Serge E. Hallyn
On Fri, Apr 16, 2021 at 04:34:53PM -0500, Serge E. Hallyn wrote: > On Fri, Apr 16, 2021 at 05:05:01PM +0200, Christian Brauner wrote: > > On Thu, Apr 15, 2021 at 11:58:51PM -0500, Serge Hallyn wrote: > > > (Eric - this patch (v3) is a cleaned up version of the previous

Re: [RFC PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3)

2021-04-16 Thread Serge E. Hallyn
On Fri, Apr 16, 2021 at 05:05:01PM +0200, Christian Brauner wrote: > On Thu, Apr 15, 2021 at 11:58:51PM -0500, Serge Hallyn wrote: > > (Eric - this patch (v3) is a cleaned up version of the previous approach. > > v4 is at > > https://git.kernel.org/pub/scm/linux/kernel/git/se

[RFC PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3)

2021-04-15 Thread Serge E. Hallyn
/setcap unable to set CAP_SETFCAP effective capability: Operation not permitted root@caps:/home/ubuntu# unshare -Ur unshare: write failed /proc/self/uid_map: Operation not permitted Signed-off-by: Serge Hallyn Changelog: * fix logic in the case of writing to another task's uid_map * rename 'ns

Re: [PATCH] security: commoncap: clean up kernel-doc comments

2021-04-12 Thread Serge E. Hallyn
k_ioprio(). Prototype was for cap_task_setnice() instead > > Signed-off-by: Randy Dunlap > Cc: Serge Hallyn Reviewed-by: Serge Hallyn thanks, -serge > Cc: James Morris > Cc: linux-security-mod...@vger.kernel.org > --- > security/commoncap.c | 50

[PATCH RESEND v8 0/7] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-04-09 Thread Serge Semin
s Cc: linux-arm-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-snps-...@lists.infradead.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (7): arc: dts: Harmonize EHCI/OHCI DT nodes name arm: dts: lpc18xx: Harmoniz

[PATCH RESEND v8 7/7] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-04-09 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH RESEND v8 5/7] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

2021-04-09 Thread Serge Semin
spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH RESEND v8 6/7] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string

2021-04-09 Thread Serge Semin
ble string to match the "snps,dwc3". The semantic of the code won't change seeing all the DWC USB3 nodes are supposed to have the compatible property with any of those strings set. Signed-off-by: Serge Semin --- Changelog v7: - Replace "of_get_child_by_name(np, "usb"

[PATCH RESEND v8 1/7] arc: dts: Harmonize EHCI/OHCI DT nodes name

2021-04-09 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Alexey Brodkin Acked-by: Krzysztof Kozlowski --- arch/arc/boot/dts/axc003.dtsi| 4 ++-- arch/arc/boot/dts/axc003_idu.dtsi| 4 ++-- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dt

[PATCH RESEND v8 2/7] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

2021-04-09 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Vladimir Zapolskiy Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/l

[PATCH RESEND v8 4/7] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

2021-04-09 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH RESEND v8 3/7] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-04-09 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df1

Re: [PATCH] kernel: automatically split user namespace extent

2021-04-02 Thread Serge E. Hallyn
On Wed, Dec 02, 2020 at 05:12:27PM +0100, Giuseppe Scrivano wrote: > Hi Eric, > > ebied...@xmission.com (Eric W. Biederman) writes: > > > Nit: The tag should have been "userns:" rather than kernel. > > > > Giuseppe Scrivano writes: > > > >> writing to the id map fails when an extent overlaps

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Serge E. Hallyn
On Wed, Mar 24, 2021 at 09:14:02AM -0700, James Bottomley wrote: > On Tue, 2021-03-23 at 14:07 -0400, Mimi Zohar wrote: > > On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote: > > > Hello Horia, > > > > > > On 21.03.21 21:48, Horia Geantă wrote: > > > > On 3/16/2021 7:02 PM, Ahmad Fatoum

Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-31 Thread Serge Semin
On Sun, Mar 28, 2021 at 06:59:26PM -0700, Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson > --- > drivers/gpio/Kconfig | 6 ++ > drivers/gpio/Makefile | 1 +

Re: [PATCH v2 03/13] spi: dw: Add support for Pensando Elba SoC SPI

2021-03-31 Thread Serge Semin
On Sun, Mar 28, 2021 at 06:59:28PM -0700, Brad Larson wrote: > The Pensando Elba SoC uses a GPIO based chip select > for two DW SPI busses with each bus having two > chip selects. > > Signed-off-by: Brad Larson > --- > drivers/spi/spi-dw-mmio.c | 28 +++- > 1 file

Re: [PATCH v2 07/13] arm64: dts: Add Pensando Elba SoC support

2021-03-31 Thread Serge Semin
Rob, Could you give your opinion on my comment regarding the nodes layout in this dts-file. I was told to fix a similar problem in one of patches submitted by me some time ago. Please see my last comment in this message. On Sun, Mar 28, 2021 at 06:59:32PM -0700, Brad Larson wrote: > Add Pensando

Re: [PATCH v2 00/13] Support Pensando Elba SoC

2021-03-31 Thread Serge Semin
Hi Brad On Sun, Mar 28, 2021 at 06:59:25PM -0700, Brad Larson wrote: > This series enables support for Pensando Elba SoC based platforms. > The Elba SoC has the following features: > > - Sixteen ARM64 A72 cores > - Dual DDR 4/5 memory controllers > - 32 lanes of PCIe Gen3/4 to the Host > -

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-03-26 Thread Serge Semin
On Fri, Mar 26, 2021 at 02:34:23PM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 24, 2021 at 03:18:58PM +0300, Serge Semin wrote: > > Hi Greg, > > > > On Tue, Mar 23, 2021 at 12:29:17PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Feb 18, 2021 at 06:40

[PATCH v7 7/7] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-03-24 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v7 3/7] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-03-24 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df1

[PATCH v7 1/7] arc: dts: Harmonize EHCI/OHCI DT nodes name

2021-03-24 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Alexey Brodkin Acked-by: Krzysztof Kozlowski --- arch/arc/boot/dts/axc003.dtsi| 4 ++-- arch/arc/boot/dts/axc003_idu.dtsi| 4 ++-- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dt

[PATCH v7 6/7] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string

2021-03-24 Thread Serge Semin
ble string to match the "snps,dwc3". The semantic of the code won't change seeing all the DWC USB3 nodes are supposed to have the compatible property with any of those strings set. Signed-off-by: Serge Semin --- Changelog v7: - Replace "of_get_child_by_name(np, "usb"

[PATCH v7 5/7] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

2021-03-24 Thread Serge Semin
spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH v7 0/7] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-03-24 Thread Serge Semin
ng maintainers repos. - Cleanup the list of recipients. - Rebase onto kernel 5.12-rc4. Cc: Khuong Dinh Cc: Patrice Chotard Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-arm-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-snps-...@

[PATCH v7 4/7] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

2021-03-24 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v7 2/7] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

2021-03-24 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Vladimir Zapolskiy Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/l

Re: [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM

2021-03-24 Thread Serge Semin
Hi Andy On Wed, Mar 24, 2021 at 02:18:22PM +0200, Andy Shevchenko wrote: > Some architectures do not provide devm_*() APIs. Hence make the driver > dependent on HAVE_IOMEM. You must have meant "HAS_IOMEM", right? -Sergey > > Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-03-24 Thread Serge Semin
Hi Greg, On Tue, Mar 23, 2021 at 12:29:17PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 06:40:51PM +0300, Serge Semin wrote: > > On Thu, Feb 18, 2021 at 04:32:29PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Feb 18, 2021 at 06:29:04PM +0300, Serge Semin wr

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-19 Thread Serge Belyshev
Al Viro writes: > ... > > Do you have reports of libata variants of drivers actually tested on > those? PATA_CMD64X works fine on my 164LX for many years, last tested with 5.12-rc3. (with a caveat: in my setup with CF card DMA is broken, but it is broken with BLK_DEV_CMD64X as well).

Re: [PATCH v3] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-08 Thread Serge Semin
l we reserve the first 4k (1k for R3k) for > either normal exception vector space (legacy CPUs) or special vectors > like cache exceptions. > > Huge thanks to Serge for analysing and proposing a solution to this > issue. Reviewed-by: Serge Semin -Sergey > > Fixes:

Re: [PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-07 Thread Serge Semin
On Sun, Mar 07, 2021 at 10:20:01PM +0100, Thomas Bogendoerfer wrote: > On Sun, Mar 07, 2021 at 11:06:12PM +0300, Serge Semin wrote: > > > + > > > + if (cpu_has_mips_r2_r6) > > > + reserve_exception_space(0, 0x400); > > > > Are you sure it shoul

Re: [PATCH -next] bus: bt1-apb: remove duplicate include

2021-03-07 Thread Serge Semin
Hi Arnd, Could you merge this patch in via your repo? On Wed, Aug 19, 2020 at 10:43:51AM +0800, Wang Hai wrote: > Remove linux/clk.h which is included more than once > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Acked-by: Serge Semin -Sergey > --- > drivers

Re: [PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-07 Thread Serge Semin
get for analysing and proposing a solution to this > issue. > > Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations with > kernel_end") > Reported-by: Kamal Dasu > Debugged-by: Serge Semin > Signed-off-by: Thomas Bogendoerfer > --- > Changes in v2: >

Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-04 Thread Serge Semin
Hello Linus, I started reviewing from the DW APB SPI driver part of this series, that's why I suggested to remove the CS callback from there seeing it doesn't really differ much from the generic one. But after looking at the dts file and in this driver I think that the alterations layout needs to

Re: [PATCH 7/8] arm64: dts: Add Pensando Elba SoC support

2021-03-04 Thread Serge Semin
On Wed, Mar 03, 2021 at 07:41:40PM -0800, Brad Larson wrote: > Add Pensando common and Elba SoC specific device nodes > and corresponding binding documentation. This also needs to be split up into sub-patches seeing these are unrelated changes like device bindings update, new platform DT file.

Re: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI

2021-03-03 Thread Serge Semin
Hello Brad. Thanks for the patch. See my comments below. On Wed, Mar 03, 2021 at 07:41:36PM -0800, Brad Larson wrote: > The Pensando Elba SoC uses a GPIO based chip select > for two DW SPI busses with each bus having two > chip selects. I see a contradiction here. Normally GPIO-based chip-select

Re: [PATCH] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-03 Thread Serge Semin
his > issue. > > Fixes: Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations > with kernel_end") Fixes tag is used twice. > Debugged-by: Serge Semin > Reported-by: Kamal Dasu I'd switch these tags order. First it was reported, then the problem was debug

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-02 Thread Serge Semin
("memblock: do not start bottom-up allocations > with kernel_end") > Debugged-by: Serge Semin > Reported-by: Kamal Dasu I'd change the order of these two tags... > Signed-off-by: Florian Fainelli > --- > Thomas, > > This is intended as a stop-gap solution for

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-03-02 Thread Serge Semin
On Mon, Mar 01, 2021 at 08:09:52PM -0800, Florian Fainelli wrote: > > > On 3/1/2021 1:22 AM, Serge Semin wrote: > > On Sun, Feb 28, 2021 at 07:50:45PM -0800, Florian Fainelli wrote: > >> Hi Serge, > >> > >> On 2/28/2021 3:08 PM, Serge Semin wrote: > &

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-03-02 Thread Serge Semin
On Mon, Mar 01, 2021 at 07:55:21PM -0800, Roman Gushchin wrote: > On Mon, Mar 01, 2021 at 11:45:42AM +0200, Mike Rapoport wrote: > > On Sun, Feb 28, 2021 at 07:50:45PM -0800, Florian Fainelli wrote: > > > Hi Serge, > > > > > > On 2/28/2021 3:08 PM,

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-03-01 Thread Serge Semin
On Sun, Feb 28, 2021 at 07:50:45PM -0800, Florian Fainelli wrote: > Hi Serge, > > On 2/28/2021 3:08 PM, Serge Semin wrote: > > Hi folks, > > What you've got here seems a more complicated problem than it > > could originally look like. Please, see my comments below. &g

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-02-28 Thread Serge Semin
Hi folks, What you've got here seems a more complicated problem than it could originally look like. Please, see my comments below. (Note I've discarded some of the email logs, which of no interest to the discovered problem. Please also note that I haven't got any Broadcom hardware to test out a

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-21 Thread Serge Semin
On Sat, Feb 20, 2021 at 04:49:22PM +0100, Andrew Lunn wrote: > > If in doubt, leaving the patch as is would be fine with me. > > The patch is O.K. as is, no need to export something so simple for a > single users. When the next user come along, we can reconsider. Ok. Thanks for clarification. I

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29A

Re: [PATCH v28 07/12] landlock: Support filesystem access-control

2021-02-19 Thread Serge E. Hallyn
On Wed, Feb 10, 2021 at 09:17:25PM +0100, Mickaël Salaün wrote: > > On 10/02/2021 20:36, Serge E. Hallyn wrote: > > On Tue, Feb 02, 2021 at 05:27:05PM +0100, Mickaël Salaün wrote: > >> From: Mickaël Salaün > >> > >> Thanks to the Landlock objects

Re: [PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

2021-02-18 Thread Serge Semin
On Thu, Feb 11, 2021 at 12:58:00AM +0300, Serge Semin wrote: > On Tue, Feb 09, 2021 at 04:26:08PM -0600, Rob Herring wrote: > > On Mon, Feb 08, 2021 at 04:55:48PM +0300, Serge Semin wrote: > > > Currently the "snps,axi-config", "snps,mtl-rx-config" and

Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties

2021-02-18 Thread Serge Semin
On Thu, Feb 11, 2021 at 01:28:06AM +0300, Serge Semin wrote: > On Tue, Feb 09, 2021 at 05:13:52PM -0600, Rob Herring wrote: > > On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote: > > > Synopsys DesignWare Ethernet controllers can be synthesized with > > >

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-18 Thread Serge Semin
On Thu, Feb 18, 2021 at 04:32:29PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 06:29:04PM +0300, Serge Semin wrote: > > Bjorn, Greg, Felippe, Andy, > > Any comments on this series? Bjorn, Greg you asked me to resend the > > patches related with the DW USB3 no

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-18 Thread Serge Semin
, 2021 at 11:55:19PM +0300, Serge Semin wrote: > of_get_child_by_name() increments the reference counter of the OF node it > managed to find. So after the code is done using the device node, the > refcount must be decremented. Add missing of_node_put() invocation then > to the dwc3_qcom_of_r

[PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-12 Thread Serge Semin
there. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Signed-off-by: Serge Semin --- Note the patch will get cleanly applied on the commit 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI"), while the bug has been there since the Qualc

[PATCH v7 2/3] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string

2021-02-12 Thread Serge Semin
ble string to match the "snps,dwc3". The semantic of the code won't change seeing all the DWC USB3 nodes are supposed to have the compatible property with any of those strings set. Signed-off-by: Serge Semin --- Changelog v7: - Replace "of_get_child_by_name(np, "usb"

[PATCH v7 3/3] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-02-12 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Serge Semin
On Fri, Feb 12, 2021 at 11:49:15AM -0600, Bjorn Andersson wrote: > On Wed 10 Feb 13:33 CST 2021, Serge Semin wrote: > > > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > > >

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Serge Semin
On Wed, Feb 10, 2021 at 10:33:26PM +0300, Serge Semin wrote: > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > &

Re: [PATCH] mtd: physmap: physmap-bt1-rom: Fix unintentional stack access

2021-02-12 Thread Serge Semin
actually intended to be a byte offset. Thanks, one more time.) Acked-by: Serge Semin > > Fixes: b3e79e7682e0 ("mtd: physmap: Add Baikal-T1 physically mapped ROM > support") > Addresses-Coverity-ID: 1497765 ("Out-of-bounds access") > Cc: sta...@vger.kernel.org >

Re: [PATCH] spi: dw: Avoid stack content exposure

2021-02-11 Thread Serge Semin
/spi-dw-bt1.c:77:6: note: 'data' declared here >77 | u32 data; > | ^~~~ Can't believe I missed that. Thanks! Acked-by: Serge Semin > > Addresses-Coverity: CID 1497771 Out-of-bounds access > Fixes: abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver"

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-11 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29A

Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 05:13:52PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote: > > Synopsys DesignWare Ethernet controllers can be synthesized with > > General-Purpose IOs support. GPIOs can work either as inputs or as outputs

Re: [PATCH v2 16/24] net: stmmac: Use optional reset control API to work with stmmaceth

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 02:49:24PM +0800, Jisheng Zhang wrote: > Hi, > > On Mon, 8 Feb 2021 16:56:00 +0300 Serge Semin wrote: > > > > > > Since commit bb3222f71b57 ("net: stmmac: platform: use optional clk/reset > > get APIs") a manual implemen

Re: [PATCH v2 07/24] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 04:32:58PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 04:55:51PM +0300, Serge Semin wrote: > > Currently the snps,dwmac.yaml DT bindings file is used for both DT nodes > > describing generic DW MAC devices and as DT schema with common properties >

Re: [PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 04:26:08PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 04:55:48PM +0300, Serge Semin wrote: > > Currently the "snps,axi-config", "snps,mtl-rx-config" and > > "snps,mtl-tx-config" properties are declared as a single phand

Re: [PATCH v28 07/12] landlock: Support filesystem access-control

2021-02-10 Thread Serge E. Hallyn
sible to identify > a lot of files without tagging every inodes nor modifying the > filesystem, while still following the view and understanding the user > has from the filesystem. > > Add a new ARCH_EPHEMERAL_INODES for UML because it currently does not > keep the same struct inodes for the same inodes whereas these inodes are > in use. -serge

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > > > wrote: > > > &

Re: [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 10:21:47AM -0800, Florian Fainelli wrote: > On 2/10/21 9:28 AM, Serge Semin wrote: > > As the subject states this series is an attempt to harmonize the xHCI, > > EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the > > framewo

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > wrote: > > > > In accordance with the USB HCD/DRD schema all the USB controllers are > > supposed to have DT-nodes named with prefix "^usb(@.*)?"

Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 03:11:41PM +0100, Andrew Lunn wrote: > > Regarding splitting the series up. I don't see a problem in just > > sending the cover-letter patch and actual GPIO-related patches to > > the GPIO-maintainers with no need to have them added to Cc in the rest > > of the series. >

[PATCH v6 10/10] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 05/10] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df1

[PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
deprecated naming so not to fail on the legacy DTS-files passed to the newer kernels. Signed-off-by: Serge Semin Reviewed-by: Bjorn Andersson --- drivers/usb/dwc3/dwc3-qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/d

[PATCH v6 08/10] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH v6 07/10] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 06/10] arm: dts: keystone: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 01/10] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 02/10] arm: dts: keystone: Correct DWC USB3 compatible string

2021-02-10 Thread Serge Semin
Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. Use it instead of the deprecated "synopsys" one. Signed-off-by: Serge Semin Reviewed-by: Krzysztof Kozlowski --- arch/arm/boot/dts/keystone-k2e.dtsi | 2 +- arch/arm/boot/dts/keystone.dtsi | 2 +-

[PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Serge Semin
r.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (10): arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name arm: dts: keystone: Correct DWC USB3 compatible string arc: dts: Harmonize EHCI/OHCI DT nodes name arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes nam

[PATCH v6 03/10] arc: dts: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Alexey Brodkin Acked-by: Krzysztof Kozlowski --- arch/arc/boot/dts/axc003.dtsi| 4 ++-- arch/arc/boot/dts/axc003_idu.dtsi| 4 ++-- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dt

[PATCH v6 04/10] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Vladimir Zapolskiy Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/l

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin wrote: > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > too much sense for now. What I meant is just exporting

Re: [PATCH v3 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 03, 2021 at 10:06:46AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 05:02:08PM -0600, Bjorn Andersson wrote: > > On Sat 05 Dec 09:56 CST 2020, Serge Semin wrote: > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are &

Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: th

Re: [PATCH v2 00/24] net: stmmac: Fix clocks/reset-related procedures

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 11:05:21AM -0800, Jakub Kicinski wrote: > On Mon, 8 Feb 2021 16:55:44 +0300 Serge Semin wrote: > > Baikal-T1 SoC is equipped with two Synopsys DesignWare GMAC v3.73a-based > > ethernet interfaces with no internal Ethernet PHY attached. The IP-cores >

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 09:14:02PM +0100, Heiner Kallweit wrote: > On 08.02.2021 15:03, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled. > > The freez

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Serge Semin
On Mon, Feb 08, 2021 at 04:27:36PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:03:22PM +0300, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled.

[PATCH 14/16] net: stmmac: Add Generic DW MAC GPIO port driver

2021-02-08 Thread Serge Semin
state too. Instead we suggest to at least restore the DMA/MAC registers to the initial state, when the software reset were supposed to happen. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac.rst | 4 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 + drivers/ne

[PATCH 15/16] net: stmmac: Add DW GMAC GPIOs support

2021-02-08 Thread Serge Semin
. Signed-off-by: Serge Semin --- Folks, I don't know whether the same GPIO CSR layout is defined for some other DW MAC IP-core. So for now the accessors have been created for GMACs only. But if you are sure the callbacks can be used for some other IP, I can move them to dwmac_lib.c. Though in order

[PATCH 08/16] net: stmmac: Introduce Safety Feature IRQs enable/disable methods

2021-02-08 Thread Serge Semin
of them have been enabled by default. Signed-off-by: Serge Semin --- Folks, the zero initialization of the DW xGMAC XGMAC_MTL_ECC_CONTROL register looks suspicious. Are you sure it is supposed to be cleared out in order to enable the safety IRQs? --- .../net/ethernet/stmicro/stmmac/dwmac4_core.c

[PATCH 16/16] net: stmmac: Add DW MAC IPs of 3.72a/3.73a/3.74a versions

2021-02-08 Thread Serge Semin
if there were no more specific glue-driver for them. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c

[PATCH 12/16] net: stmmac: Introduce NIC software reset function

2021-02-08 Thread Serge Semin
for some early versions of DW GMAC (in our case it's DW GMAC v3.73a). Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 32 +-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers

[PATCH 10/16] net: stmmac: Convert STMMAC_DOWN flag to STMMAC_UP

2021-02-08 Thread Serge Semin
switching together with the IRQs unmasking and masking. Luckily the IRQs are normally enabled/disable in the late/early network initialization stages respectively. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +- drivers/net/ethernet/stmicro/stmmac

[PATCH 06/16] net: stmmac: Extend DMA IRQs enable/disable interface

2021-02-08 Thread Serge Semin
anymore. Such modification won't break the DMA-related code because the default macro has both Tx and Rx DMA IRQs flags set anyway. So in order to make things working as usual we just need to call the stmmac_enable_dma_irq() method aside with the generic IRQs activating function. Signed-off-by: Serge

[PATCH 13/16] net: stmmac: Request IRQs at device probe stage

2021-02-08 Thread Serge Semin
. Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 157 +++--- 1 file changed, 96 insertions(+), 61 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c4c41b554c6a

[PATCH 05/16] net: stmmac: Introduce MAC IRQs enable/disable methods

2021-02-08 Thread Serge Semin
for the case of the IRQs handler being setup at the device probe stage, which will be introduced later in one of the following up commits. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/dwmac1000_core.c | 28 + .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 32

  1   2   3   4   5   6   7   8   9   10   >