Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

2021-04-09 Thread skakit
On 2021-04-09 17:27, Sebastian Reichel wrote: Hi, On Fri, Apr 09, 2021 at 01:48:58PM +0530, ska...@codeaurora.org wrote: Please do not drop the example :) As per my understanding on Rob's comments [1] I have added one complete example in qcom,pm8941-pwrkey.yaml (see patch 4/4) and dropped it

Re: [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A

2021-04-09 Thread skakit
On 2021-04-08 19:18, Linus Walleij wrote: On Thu, Apr 1, 2021 at 2:36 PM satya priya wrote: satya priya (3): pinctrl: qcom: spmi-gpio: Add support for four variants dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants dt-bindings: pinctrl: qcom-pmic-gpio

Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

2021-04-09 Thread skakit
Hi Sebastian, On 2021-04-08 18:30, Sebastian Reichel wrote: Hi, On Thu, Apr 08, 2021 at 05:01:08PM +0530, satya priya wrote: Convert qcom PON binding from .txt to .yaml format. Signed-off-by: satya priya --- Thanks for doing this. Changes in V2: - As per Rob's comments, converted the ma

Re: [PATCH 2/3] dt-bindings: mfd: Convert pm8xxx bindings to yaml

2021-04-07 Thread skakit
Hi Bjorn, On 2021-03-11 22:33, Bjorn Andersson wrote: On Thu 11 Mar 01:29 CST 2021, satya priya wrote: Convert pm8xxx rtc bindings from .txt to .yaml format. Wonderful initiative, thank you! Signed-off-by: satya priya --- .../devicetree/bindings/mfd/qcom-pm8xxx.txt| 99 ---

Re: [PATCH 1/3] input: pm8941-pwrkey: add support for PMK8350 PON_HLOS PMIC peripheral

2021-04-07 Thread skakit
Gentle Reminder! Thanks, Satya Priya On 2021-03-05 11:08, satya priya wrote: From: David Collins On Qualcomm Technologies, Inc. PMIC PMK8350, the PON peripheral is split into two peripherals: PON_HLOS and PON_PBS. The application processor only has write access to PON_HLOS which limits it to

Re: [PATCH V2 4/5] arm64: dts: qcom: pmr735a: Add PMIC peripherals for pmr735a

2021-04-07 Thread skakit
On 2021-04-03 00:56, Matthias Kaehlcke wrote: Same comments as '[1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325', plus another nit: '[3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350' has an ADC config for the die temperature of the pmr735a, hence it seems this

Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325

2021-04-07 Thread skakit
On 2021-04-03 02:05, Matthias Kaehlcke wrote: On Fri, Apr 02, 2021 at 10:35:54AM -0700, Matthias Kaehlcke wrote: On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote: > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 nit: maybe just 'arm64: dts: qcom: Add pm7325 suppo

Re: [PATCH V2 3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350

2021-04-07 Thread skakit
On 2021-04-03 00:15, Matthias Kaehlcke wrote: On Thu, Apr 01, 2021 at 02:43:14PM +0530, satya priya wrote: subject: arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 same nit as for 1/5: maybe just 'arm64: dts: qcom: Add pml7350 support/.dtsi' or similar since this adds the initial

Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325

2021-04-07 Thread skakit
Hi Matthias, On 2021-04-02 23:05, Matthias Kaehlcke wrote: On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote: subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or similar? Add temp-alarm and GPIO supp

Re: [PATCH 2/3] dt-bindings: input: pm8941-pwrkey: Convert power key bindings to yaml

2021-03-24 Thread skakit
Hi Rob, On 2021-03-05 20:10, Rob Herring wrote: On Fri, Mar 05, 2021 at 11:08:40AM +0530, satya priya wrote: Convert power key bindings from .txt to .yaml format. Signed-off-by: satya priya --- .../bindings/input/qcom,pm8941-pwrkey.txt | 53 --- .../bindings/input/qcom,

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-24 Thread skakit
Hi Matthias, On 2021-03-22 23:04, Matthias Kaehlcke wrote: Hi Satya, On Mon, Mar 22, 2021 at 06:50:47PM +0530, ska...@codeaurora.org wrote: Hi Matthias, On 2021-03-13 02:10, Matthias Kaehlcke wrote: > Hi Satya, > > On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: > > Add PM7325/PM

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-22 Thread skakit
On 2021-03-13 02:17, Matthias Kaehlcke wrote: On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, GPIOs, RTC and other PMIC infra modules for SC7280. Signed-off-by: satya priya --- This patch depends on base DT and board file

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-22 Thread skakit
Hi Matthias, On 2021-03-13 02:10, Matthias Kaehlcke wrote: Hi Satya, On Thu, Mar 11, 2021 at 04:10:29PM +0530, satya priya wrote: Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, GPIOs, RTC and other PMIC infra modules for SC7280. Signed-off-by: satya priya --- This patch depends

Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

2021-03-22 Thread skakit
Hi Bjorn, On 2021-03-12 23:06, Bjorn Andersson wrote: On Thu 11 Mar 04:40 CST 2021, satya priya wrote: Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON, GPIOs, RTC and other PMIC infra modules for SC7280. Overall this looks good, just two small things below. Signed-off-by: satya

Re: [PATCH V2 3/5] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp

2021-03-19 Thread skakit
On 2021-03-17 04:56, Matthias Kaehlcke wrote: On Mon, Mar 15, 2021 at 07:24:12PM +0530, satya priya wrote: Add regulator devices for SC7280 as RPMh regulators. This ensures that consumers are able to modify the physical state of PMIC regulators. Signed-off-by: satya priya --- Changes in V2: -

Re: [PATCH V2 4/5] dt-bindings: regulator: Convert regulator bindings to YAML format

2021-03-19 Thread skakit
On 2021-03-17 00:17, Matthias Kaehlcke wrote: Subject: dt-bindings: regulator: Convert regulator bindings to YAML format Make sure to mention that this is about the RPMh regulators, not the general regulator binding which was already converted. Okay, will change the commit message.

Re: [PATCH V2 2/5] regulator: qcom-rpmh: Add PM7325/PMR735A regulator support

2021-03-19 Thread skakit
Hi Matthias, Thanks for reviewing the patches! On 2021-03-17 01:22, Matthias Kaehlcke wrote: On Mon, Mar 15, 2021 at 07:24:11PM +0530, satya priya wrote: Add support for PM7325/PMR735A regulators. This ensures that consumers are able to modify the physical state of PMIC regulators. Signed-off

Re: [PATCH 3/7] regulator: qcom-rpmh: Correct the pmic5_hfsmps515 buck

2021-03-10 Thread skakit
On 2021-03-02 19:51, Dmitry Baryshkov wrote: Hello, On Mon, 1 Mar 2021 at 13:37, wrote: On 2021-02-26 15:57, Dmitry Baryshkov wrote: > On Fri, 26 Feb 2021 at 09:59, wrote: >> >> Hi, >> >> On 2021-02-25 16:39, Dmitry Baryshkov wrote: >> > On 24/02/2021 11:33, satya priya wrote: >> >> Correct

Re: [PATCH 1/7] dt-bindings: regulator: Convert regulator bindings to YAML format

2021-03-03 Thread skakit
Hi Rob, Thanks for reviewing the patch! +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/qcom,rpmh-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. RPMh Regulators +

Re: [PATCH 1/7] dt-bindings: regulator: Convert regulator bindings to YAML format

2021-03-03 Thread skakit
On 2021-03-01 20:14, Rob Herring wrote: On Wed, 24 Feb 2021 14:03:06 +0530, satya priya wrote: Convert regulator bindings from .txt to .yaml format. Signed-off-by: satya priya --- .../bindings/regulator/qcom,rpmh-regulator.txt | 180 - .../bindings/regulator/qcom,rpmh

Re: [PATCH 3/7] regulator: qcom-rpmh: Correct the pmic5_hfsmps515 buck

2021-03-01 Thread skakit
On 2021-02-26 15:57, Dmitry Baryshkov wrote: On Fri, 26 Feb 2021 at 09:59, wrote: Hi, On 2021-02-25 16:39, Dmitry Baryshkov wrote: > On 24/02/2021 11:33, satya priya wrote: >> Correct the REGULATOR_LINEAR_RANGE and n_voltges for >> pmic5_hfsmps515 buck. >> >> Signed-off-by: satya priya >> --

Re: [PATCH 3/7] regulator: qcom-rpmh: Correct the pmic5_hfsmps515 buck

2021-02-25 Thread skakit
Hi, On 2021-02-25 16:39, Dmitry Baryshkov wrote: On 24/02/2021 11:33, satya priya wrote: Correct the REGULATOR_LINEAR_RANGE and n_voltges for pmic5_hfsmps515 buck. Signed-off-by: satya priya --- drivers/regulator/qcom-rpmh-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH 6/7] regulator: qcom-rpmh: Use correct buck for S1C regulator

2021-02-25 Thread skakit
On 2021-02-24 22:01, Mark Brown wrote: On Wed, Feb 24, 2021 at 02:03:11PM +0530, satya priya wrote: Use correct buck, that is, pmic5_hfsmps515 for S1C regulator of PM8350C PMIC. Fixes like this and patch 3 should be at the start of the series, this ensures that they have no dependencies and ca

Re: [PATCH 7/7] arm64: dts: qcom: sc7280: Add RPMh regulators for sc7280-idp

2021-02-25 Thread skakit
On 2021-02-25 00:47, Konrad Dybcio wrote: Hi, + }; + + pm8350c-regulators { + compatible = "qcom,pm8350c-rpmh-regulators"; + qcom,pmic-id = "c"; + vreg_s1c_2p2: smps1 { + regulator-min-microvolt = <219>; The indentation on "com

Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

2020-09-11 Thread skakit
Hi Bjorn, Thanks for reviewing the patches. On 2020-09-11 05:15, Bjorn Andersson wrote: On Thu 10 Sep 12:53 UTC 2020, satya priya wrote: Add a suitable sleep configuration for uart3 to support Bluetooth wakeup. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during

Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

2020-09-11 Thread skakit
Hi Matthias, On 2020-09-10 21:05, Matthias Kaehlcke wrote: El Thu, Sep 10, 2020 at 06:23:56PM +0530 satya priya ha dit: Add a suitable sleep configuration for uart3 to support Bluetooth wakeup. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT So

Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

2020-09-11 Thread skakit
On 2020-09-10 20:10, Doug Anderson wrote: Hi, On Thu, Sep 10, 2020 at 5:55 AM satya priya wrote: Add a suitable sleep configuration for uart3 to support Bluetooth wakeup. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT SoC not able to send w

Re: [PATCH V5 3/4] arm64: dts: qcom: sc7180-trogdor: Add pinctrl and interrupt config for BT UART

2020-09-11 Thread skakit
On 2020-09-10 20:12, Doug Anderson wrote: Hi, On Thu, Sep 10, 2020 at 5:55 AM satya priya wrote: Add a suitable sleep configuration for uart3 to support Bluetooth wakeup. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT SoC not able to send w

Re: [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX

2020-09-11 Thread skakit
Hi Doug, On 2020-09-10 20:10, Doug Anderson wrote: Hi, On Thu, Sep 10, 2020 at 5:55 AM satya priya wrote: Remove output-high from CTS and TX as this is not really required. During bringup to fix transfer failures this was added to match with console uart settings. Probably some boot load

Re: [PATCH V4 3/4] arm64: dts: qcom: sc7180: Add sleep state for BT UART

2020-09-10 Thread skakit
On 2020-09-10 02:59, Doug Anderson wrote: Hi, On Thu, Sep 3, 2020 at 8:08 AM satya priya wrote: diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index cecac3e..77e3523 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/d

Re: [PATCH V4 2/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX

2020-09-10 Thread skakit
Hi Doug, On 2020-09-10 02:58, Doug Anderson wrote: Hi, On Thu, Sep 3, 2020 at 8:07 AM satya priya wrote: --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -474,32 +474,30 @@ &qup_uart3_default { pinconf-cts { /* -

Re: [PATCH V4 1/4] arm64: dts: sc7180: Add wakeup support over UART RX

2020-09-09 Thread skakit
Hi Matthias, On 2020-09-03 21:35, Matthias Kaehlcke wrote: On Thu, Sep 03, 2020 at 08:34:55PM +0530, satya priya wrote: Add the necessary pinctrl and interrupts to make UART wakeup capable. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT SoC not

Re: [PATCH V4 1/4] arm64: dts: sc7180: Add wakeup support over UART RX

2020-09-09 Thread skakit
On 2020-09-03 22:47, Matthias Kaehlcke wrote: On Thu, Sep 03, 2020 at 08:34:55PM +0530, satya priya wrote: Add the necessary pinctrl and interrupts to make UART wakeup capable. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT SoC not able to send w

Re: [PATCH V4 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue

2020-09-09 Thread skakit
On 2020-09-03 22:20, Matthias Kaehlcke wrote: On Thu, Sep 03, 2020 at 08:34:58PM +0530, satya priya wrote: As a part of system suspend uart_port_suspend is called from the Serial driver, which calls set_mctrl passing mctrl as NULL. This nit: s/NULL/0/ Okay, will correct it. makes RFR high

Re: [PATCH V3 1/3] arm64: dts: sc7180: Add wakeup support over UART RX

2020-09-02 Thread skakit
Hi Matthias, On 2020-08-21 21:56, Matthias Kaehlcke wrote: On Thu, Aug 20, 2020 at 07:21:05PM +0530, satya priya wrote: Add the necessary pinctrl and interrupts to make UART wakeup capable. Signed-off-by: satya priya Reviewed-by: Akash Asthana --- Changes in V2: - As per Matthias's comment

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-28 Thread skakit
Hi Matthias, On 2020-08-27 20:53, Matthias Kaehlcke wrote: Hi Satya, On Thu, Aug 27, 2020 at 08:37:33PM +0530, ska...@codeaurora.org wrote: Hi Matthias, On 2020-08-26 22:10, Matthias Kaehlcke wrote: > Hi Satya, > > On Wed, Aug 26, 2020 at 09:35:15PM +0530, ska...@codeaurora.org wrote: > > Hi

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-27 Thread skakit
Hi Matthias, On 2020-08-26 22:10, Matthias Kaehlcke wrote: Hi Satya, On Wed, Aug 26, 2020 at 09:35:15PM +0530, ska...@codeaurora.org wrote: Hi Matthias, On 2020-08-25 22:08, Matthias Kaehlcke wrote: > On Tue, Aug 25, 2020 at 06:42:28PM +0530, ska...@codeaurora.org wrote: > > On 2020-08-21 22:

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-26 Thread skakit
Hi Matthias, On 2020-08-25 22:08, Matthias Kaehlcke wrote: On Tue, Aug 25, 2020 at 06:42:28PM +0530, ska...@codeaurora.org wrote: On 2020-08-21 22:52, Matthias Kaehlcke wrote: > On Thu, Aug 20, 2020 at 07:21:06PM +0530, satya priya wrote: > > Add sleep pin ctrl for BT uart, and also change the

Re: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-25 Thread skakit
On 2020-08-21 22:52, Matthias Kaehlcke wrote: On Thu, Aug 20, 2020 at 07:21:06PM +0530, satya priya wrote: Add sleep pin ctrl for BT uart, and also change the bias configuration to match Bluetooth module. Signed-off-by: satya priya Reviewed-by: Akash Asthana --- Changes in V2: - This patch a

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-20 Thread skakit
Hi Matthias, On 2020-08-19 21:43, Matthias Kaehlcke wrote: On Wed, Aug 19, 2020 at 07:19:25PM +0530, ska...@codeaurora.org wrote: On 2020-08-17 23:31, Matthias Kaehlcke wrote: > On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > > Add sleep pin ctrl for BT uart, and also change the

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-19 Thread skakit
On 2020-08-17 23:31, Matthias Kaehlcke wrote: On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: Add sleep pin ctrl for BT uart, and also change the bias configuration to match Bluetooth module. Signed-off-by: satya priya --- Changes in V2: - This patch adds sleep state for BT UART.

Re: [PATCH V2 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue

2020-08-19 Thread skakit
On 2020-08-17 23:12, Matthias Kaehlcke wrote: On Fri, Jul 24, 2020 at 09:28:02AM +0530, satya priya wrote: As a part of system suspend we call uart_port_suspend from the Serial driver, which calls set_mctrl passing mctrl as NULL. This makes RFR high(NOT_READY) during suspend. Due to this BT SoC

Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart

2020-08-19 Thread skakit
Hi Matthias, Thanks for reviewing the patches. On 2020-08-18 05:03, Matthias Kaehlcke wrote: On Mon, Aug 17, 2020 at 11:01:58AM -0700, Matthias Kaehlcke wrote: On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote: > Add sleep pin ctrl for BT uart, and also change the bias > configuratio

Re: [PATCH] arm64: dts: sc7180: Add wakeup support over UART RX

2020-07-23 Thread skakit
Hi Matthias, On 2020-04-27 22:26, Matthias Kaehlcke wrote: Hi, On Mon, Apr 27, 2020 at 11:57:24AM +0530, satya priya wrote: Add the necessary pinctrl and interrupts to make UART wakeup capable. Signed-off-by: satya priya --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +-- 1 file changed,