This binding is for LPASS has internal codec TX macro which is
for connecting with Soundwire TX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Rob Herring
---
.../bindings/sound/qcom,lpass-tx-macro.yaml | 67 +++
1 file changed, 67 insertions(+)
create
ively.
Thanks,
srini
Changes since v4:
- One more ktest fix for unused-but-set-variable warning
and a fix for W=2 warning and removed unused macros
- added bindings ack from Rob
Srinivas Kandagatla (7):
ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
This binding is for LPASS has internal codec RX macro which is
for connecting with SoundWire RX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Rob Herring
---
.../bindings/sound/qcom,lpass-rx-macro.yaml | 62 +++
1 file changed, 62 insertions(+)
create
On 08/02/2021 20:04, Jonathan Marek wrote:
dma_map_sgtable() returns 0 on success, which is the opposite of what this
code was doing.
Fixes: 7cd7edb89437 ("misc: fastrpc: fix common struct sg_table related issues")
Signed-off-by: Jonathan Marek
---
Reviewed-by: Srinivas
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
TX macro block which is used for connecting with external
Soundwire TX Codecs like WCD938x.
This patch adds support to the codec part of the TX Macro block
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-tx-macro.c | 685 ++
1 file changed, 685 insertions(+)
diff --git a/sound/soc/codecs/lpass-tx-macro.c
b/sound/soc/codecs/lpass-tx-macro.c
index
This binding is for LPASS has internal codec TX macro which is
for connecting with Soundwire TX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-tx-macro.yaml | 67 +++
1 file changed, 67 insertions(+)
create mode 100644
Documentation
This patch adds iir widgets and mixers on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 264 ++
1 file changed, 264 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 1341 +
1 file changed, 1341 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
ively.
Thanks,
srini
Changes since v3:
- fixed two minor warnings reported by kernel test robot using clang
Srinivas Kandagatla (7):
ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
ASoC: codecs: lpass-rx-macro: add support for lpass rx macro
ASoC: codecs: lpass-rx-macro
This binding is for LPASS has internal codec RX macro which is
for connecting with SoundWire RX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-rx-macro.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644
Documentation
LPASS RX Codec Macro is available in Qualcomm LPASS (Low Power Audio SubSystem).
This is used for connecting with SoundWire devices like WCD938x Codecs to
provide
headphone/ear/lineout functionality.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |5 +
sound/soc
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-tx-macro.c | 685 ++
1 file changed, 685 insertions(+)
diff --git a/sound/soc/codecs/lpass-tx-macro.c
b/sound/soc/codecs/lpass-tx-macro.c
index
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
TX macro block which is used for connecting with external
Soundwire TX Codecs like WCD938x.
This patch adds support to the codec part of the TX Macro block
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig
LPASS RX Codec Macro is available in Qualcomm LPASS (Low Power Audio SubSystem).
This is used for connecting with SoundWire devices like WCD938x Codecs to
provide
headphone/ear/lineout functionality.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |5 +
sound/soc
This patch adds iir widgets and mixers on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 264 ++
1 file changed, 264 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 1339 +
1 file changed, 1339 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This binding is for LPASS has internal codec RX macro which is
for connecting with SoundWire RX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-rx-macro.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644
Documentation
This binding is for LPASS has internal codec TX macro which is
for connecting with Soundwire TX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-tx-macro.yaml | 67 +++
1 file changed, 67 insertions(+)
create mode 100644
Documentation
y and WCD938x
TX and RX connected via Soundwire via TX and RX Macros reseptively.
Thanks,
srini
Changes since v2:
- Suffix some of the simple on/off control names with "Switch"
Srinivas Kandagatla (7):
ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
ASoC: codecs:
On 08/02/2021 16:08, Mark Brown wrote:
+ SOC_SINGLE_EXT("RX_Softclip Enable", SND_SOC_NOPM, 0, 1, 0,
+rx_macro_soft_clip_enable_get,
+rx_macro_soft_clip_enable_put),
+ SOC_SINGLE_EXT("AUX_HPF Enable", SND_SOC_NOPM, 0, 1, 0,
+
This binding is for LPASS has internal codec TX macro which is
for connecting with Soundwire TX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-tx-macro.yaml | 67 +++
1 file changed, 67 insertions(+)
create mode 100644
Documentation
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
TX macro block which is used for connecting with external
Soundwire TX Codecs like WCD938x.
This patch adds support to the codec part of the TX Macro block
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-tx-macro.c | 685 ++
1 file changed, 685 insertions(+)
diff --git a/sound/soc/codecs/lpass-tx-macro.c
b/sound/soc/codecs/lpass-tx-macro.c
index
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 1339 +
1 file changed, 1339 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This binding is for LPASS has internal codec RX macro which is
for connecting with SoundWire RX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-rx-macro.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644
Documentation
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/lpass-rx-macro.c | 2001 +
3 files changed, 2008 insertions(+)
create mode 100644 sound/soc/codecs/lpass-rx-macro.c
diff
This patch adds irr widgets and mixers on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 264 ++
1 file changed, 264 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
aming!
- inline swrm_clock function.
Srinivas Kandagatla (7):
ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
ASoC: codec: lpass-rx-macro: add support for lpass rx macro
ASoC: codec: lpass-rx-macro: add dapm widgets and route
ASoC: codec: lpass-rx-macro: add iir widgets
ASoC: qco
Hi Greg,
Here are some last nvmem patches (set 2) for 5.12 which includes
- fixing a typo in Kconfig
- a fix of uninitialized pointer
If its not too late, Can you please queue them up for 5.12.
thanks for you help,
srini
Nicolas Saenz Julienne (1):
nvmem: Kconfig: Correct typo in NVMEM_RMEM
ernel.org
Signed-off-by: Subbaraman Narayanamurthy
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/qcom-spmi-sdam.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c
index a72704cd0468..f6e9f96933ca 100
From: Nicolas Saenz Julienne
s/drivers/driver/ as the configuration selects a single driver.
Suggested-by: Randy Dunlap
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Randy Dunlap
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1
On 03/02/2021 18:15, Subbaraman Narayanamurthy wrote:
"sdam->pdev" is uninitialized and it is used to print error logs.
Fix it. Since device pointer can be used from sdam_config, use it
directly thereby removing pdev pointer.
Cc: sta...@vger.kernel.org
Signed-off-by: Subbaraman Narayanamurthy
On 03/02/2021 10:29, Nicolas Saenz Julienne wrote:
s/drivers/driver/ as the configuration selects a single driver.
Fixes: 2bf4fd065384 ("nvmem: Add driver to expose reserved memory as nvmem")
Suggested-by: Randy Dunlap
Signed-off-by: Nicolas Saenz Julienne
---
drivers/nvmem/Kconfig | 2 +-
On 01/02/2021 16:42, Pierre-Louis Bossart wrote:
On 2/1/21 9:50 AM, Srinivas Kandagatla wrote:
On 29/01/2021 19:33, Pierre-Louis Bossart wrote:
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked
/0xb8
el0_sync+0x158/0x180
...
Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wsa881x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c
index 45
On 29/01/2021 19:38, Pierre-Louis Bossart wrote:
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
Add support to new interrupts and update irq routine in a way
to deal with multiple pending interrupts with in a single interrupt!
I can't parse the wording after 'update irq routi
On 01/02/2021 14:31, Vinod Koul wrote:
On 29-01-21, 17:32, Srinivas Kandagatla wrote:
Add support to new interrupts and update irq routine in a way
to deal with multiple pending interrupts with in a single interrupt!
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 191
On 01/02/2021 14:26, Vinod Koul wrote:
On 29-01-21, 17:32, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id that
generates interrupt after it successfully finishes. This is really
On 01/02/2021 14:21, Vinod Koul wrote:
On 29-01-21, 17:32, Srinivas Kandagatla wrote:
Start the clock during initialization.
A detailed log please, which clock..? Also how do older controllers work
w/o this clk
By default this is ON, however depending on that is not really reliable
On 29/01/2021 19:33, Pierre-Louis Bossart wrote:
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id that
what does 'kinda blocked' mean?
I
On 29/01/2021 19:20, Pierre-Louis Bossart wrote:
struct qcom_swrm_port_config {
u8 si;
u8 off1;
u8 off2;
u8 bp_mode;
+ u8 hstart;
+ u8 hstop;
+ u8 word_length;
+ u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how you
ca
On 01/02/2021 14:16, Vinod Koul wrote:
/* Configure number of retries of a read/write cmd */
- ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES);
+ if (ctrl->version_major == 1 && ctrl->version_minor >= 5 &&
+ ctrl->version_step >= 1) {
why no
On 01/02/2021 14:13, Vinod Koul wrote:
+
+ ret = of_property_read_u8_array(np, "qcom,ports-hstop", hstop, nports);
+ if (ret)
+ memset(hstop, SWR_INVALID_PARAM, QCOM_SDW_MAX_PORTS);
why not memset the whole area here and then populate it..?
That is other way to do
simply read/write the fifo that should also give exactly
what we need! This will also allow to read/write registers in
interrupt context, which was not possible with the special
command approach.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 148
.
Srinivas Kandagatla (6):
soundwire: qcom: add support to missing transport params
soundwire: qcom: extract version field
soundwire: qcom: set continue execution flag for ignored commands
soundwire: qcom: start the clock during initialization
soundwire: qcom: update register read/write routine
Some of the transport parameters derived from device tree
are not fully parsed by the driver.
This patch adds support to parse those missing parameters.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 107 +--
1 file changed, 103 insertions
Extract version field to major, minor and step, so that we can add
dynamic version checks to read/writes.
This will help for controller versions that need specific bits
to be programmed.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 12
1 file changed, 8
Start the clock during initialization.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 3669bac11a32..83df15d83935 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers
version 1.5.1 and higher IPs of this controller required to set
continue execution on ingored command flag. This patch sets this flag.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers
Add support to new interrupts and update irq routine in a way
to deal with multiple pending interrupts with in a single interrupt!
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 191 ++-
1 file changed, 146 insertions(+), 45 deletions
expose this data to other drivers and user-space, the driver
models the reserved memory area as an nvmem device.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Rob Herring
Tested-by: Tim Gover
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/Kconfig | 8
drivers/nvmem/Makefile
all nodes with a unit address must have
a reg property and vice versa.
Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time").
Signed-off-by: Ahmad Fatoum
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 d
From: Dan Carpenter
This doesn't call of_node_put() on the error path so it leads to a
memory leak.
Fixes: 0749aa25af82 ("nvmem: core: fix regression in of_nvmem_cell_get()")
Signed-off-by: Dan Carpenter
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/core.c | 1 +
1
the dt-bindings to nvmem's rmem.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Rob Herring
Signed-off-by: Srinivas Kandagatla
---
.../devicetree/bindings/nvmem/rmem.yaml | 49 +++
1 file changed, 49 insertions(+)
create mode 100644 Documentation/devicetree/bin
From: Fabio Estevam
The retrieval of driver data via of_device_get_match_data() can make
the code simpler.
Use of_device_get_match_data() to simplify the code.
Signed-off-by: Fabio Estevam
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/imx-iim.c | 7 +--
1 file changed, 1
Hi Greg,
Here are some nvmem patches for 5.12 which includes
- adding support to new rmem nvmem provider
- a improvement in core to skip invalid node and a fix a leak
- patch in imx driver to use of_device_get_match_data
Can you please queue them up for 5.12.
thanks for you help,
srini
Ahmad Fa
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
TX macro block which is used for connecting with external
Soundwire TX Codecs like WCD938x.
This patch adds support to the codec part of the TX Macro block
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig
This patch adds irr widgets and mixers on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 264 ++
1 file changed, 264 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 1339 +
1 file changed, 1339 insertions(+)
diff --git a/sound/soc/codecs/lpass-rx-macro.c
b/sound/soc/codecs/lpass-rx-macro.c
index
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-tx-macro.c | 685 ++
1 file changed, 685 insertions(+)
diff --git a/sound/soc/codecs/lpass-tx-macro.c
b/sound/soc/codecs/lpass-tx-macro.c
index
This binding is for LPASS has internal codec TX macro which is
for connecting with Soundwire TX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-tx-macro.yaml | 67 +++
1 file changed, 67 insertions(+)
create mode 100644
Documentation
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/lpass-rx-macro.c | 2020 +
3 files changed, 2027 insertions(+)
create mode 100644 sound/soc/codecs/lpass-rx-macro.c
diff
ively.
Thanks,
srini
Srinivas Kandagatla (7):
ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
ASoC: codec: lpass-rx-macro: add support for lpass rx macro
ASoC: codec: lpass-rx-macro: add dapm widgets and route
ASoC: codec: lpass-rx-macro: add iir widgets
ASoC: qcom: dt-bin
This binding is for LPASS has internal codec RX macro which is
for connecting with SoundWire RX codecs like WCD938x.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,lpass-rx-macro.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644
Documentation
opens twice
for playaback/capture and closes once for capture and playback continues.
It can resolve the errors in such scenarios.
Fixes: b1824968221c ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid
state")
Signed-off-by: Srinivasa Rao Mandadapu
Reviewed-by: Srin
On 27/01/2021 10:54, Srinivasa Rao Mandadapu wrote:
Actually this is MI2S OSR clock disable on failure of bit clock enable.
Do You think it's redundant?
My Bad!! Just ignore my comment on removing this!
--srini
On 27/01/2021 06:30, Srinivasa Rao Mandadapu wrote:
No need of BCLK state maintenance from driver side as
clock_enable and clk_disable API's maintaing state counter.
One of the major issue was spotted when Headset jack inserted
while playback continues, due to same PCM device node opens twice
ess error prone!
This also applies to writing!
There are various places in kernel which provides such field interfaces
however soc_component seems to be missing this.
This patch is inspired by FIELD_GET/FIELD_PREP macros in
include/linux/bitfield.h
Signed-off-by: Srinivas Kandagatla
---
C
Make use of snd_soc_component_read_field() to make the code more readable!
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-wsa-macro.c | 43 ++
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/sound/soc/codecs/lpass-wsa-macro.c
b/sound
On 26/01/2021 13:36, Mark Brown wrote:
On Tue, Jan 26, 2021 at 12:20:19PM +, Srinivas Kandagatla wrote:
+#define __soc_component_field_shift(x) (__builtin_ffs(x) - 1)
Why not have this be a static inline?
Sure, that makes it even better to validate the mask aswell!
+unsigned int
ess error prone!
This also applies to writing!
There are various places in kernel which provides such field interfaces
however soc_component seems to be missing this.
This patch is inspired by FIELD_GET/FIELD_PREP macros in
include/linux/bitfield.h
Signed-off-by: Srinivas Kandagatla
---
in
Make use of snd_soc_component_read_field() to make the code more readable!
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-wsa-macro.c | 43 ++
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/sound/soc/codecs/lpass-wsa-macro.c
b/sound
On 22/01/2021 16:42, Pierre-Louis Bossart wrote:
if you completely remove the stream and re-add it with updated
configuration things should work.
That's exactly what we do currently!
The updated ports due to new configuration ex: for "mic capture"
dailink needs to be communicated from sl
On 22/01/2021 15:32, Pierre-Louis Bossart wrote:
Are you suggesting that we have dailink for each usecase like:
"headset capture"
"Analog MIC1 capture"
"Analog MIC2 Capture"
...
"Analog MIC4 Capture"
...
"DMIC0 capture"
"DMIC1 Capture"
"DMIC2 Capture"
...
"DMIC7 Capture"
..
"Headset Pl
On 18/01/2021 13:24, Ahmad Fatoum wrote:
The nvmem cell binding applies to all eeprom child nodes matching
"^.*@[0-9a-f]+$" without taking a compatible into account.
Linux drivers, like at24, are even more extensive and assume
_all_ at24 eeprom child nodes to be nvmem cells since e888d445ac33
On 21/01/2021 21:30, Pierre-Louis Bossart wrote:
Am looking at intel_hw_params(). Isn't sdw_stream_add_master() called
for every dai in the dai link.
Yes, that's correct, but again a dai may use one or more ports.
if you defined each port as a dai, and want to call
sdw_stream_add_master(
On 21/01/2021 18:00, Pierre-Louis Bossart wrote:
On 1/21/21 9:41 AM, Srinivas Kandagatla wrote:
On 21/01/2021 14:56, Pierre-Louis Bossart wrote:
Port allocations are something like this:
RX: (Simple)
Port 1 -> HPH L/R
Port 2 -> CLASS H Amp
Port 3 -> COMP
Port 4 -> DSD
On 21/01/2021 15:12, Pierre-Louis Bossart wrote:
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
On 19/01/2021 19:09, Pierre-Louis Bossart wrote:
currently we have
/sys/kernel/debug/soundwire/master-*
Are you suggesting that we have something like this:
/sys/kernel/debug/soundwire
On 21/01/2021 14:56, Pierre-Louis Bossart wrote:
Port allocations are something like this:
RX: (Simple)
Port 1 -> HPH L/R
Port 2 -> CLASS H Amp
Port 3 -> COMP
Port 4 -> DSD.
TX: (This get bit more complicated)
Port 1: PCM
Port 2: ADC 1 & 2
Port 3: ADC 3 & 4
Port 4: DMIC-0, DMIC-1, DIMC-2
On 19/01/2021 19:09, Pierre-Louis Bossart wrote:
currently we have
/sys/kernel/debug/soundwire/master-*
Are you suggesting that we have something like this:
/sys/kernel/debug/soundwire/xyz-controller/master- ??
Yes this is what I was thinking about.
Vinod/Pierre,
One Question here,
W
Thanks Pierre for your inputs,
On 20/01/2021 22:15, Pierre-Louis Bossart wrote:
On 1/20/21 12:01 PM, Srinivas Kandagatla wrote:
Some of the soundwire controllers can have static functions assigned
to each port, like some ports can only do PCM or PDM. This is the
situation
with some of the
structure during stream config, so that master can assign correct
ports based on the provided static mapping.
Srinivas Kandagatla (2):
soundwire: add support for static port mapping
soundwire: qcom: add support for static port mapping
drivers/soundwire/bus.h | 4
drivers/soundwire
way to pass mapped port number along
with the port config, so that master can assign correct ports based
on the provided static mapping.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/bus.h | 4
drivers/soundwire/stream.c| 4
include/linux/soundwire/sdw.h | 4
3
On some of Qualcomm SoundWire controller instances ports are statically
mapped based on the functionalities. So add support for such mapping.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers
On 19/01/2021 15:54, Pierre-Louis Bossart wrote:
On 1/19/21 8:52 AM, Vinod Koul wrote:
On 15-01-21, 16:25, Srinivas Kandagatla wrote:
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in
For some reason global GFM_MASK ended up with bit 1 instead of bit 0.
Remove the global GFM_MASK and reuse mux_mask field.
Fixes: a2d8f507803e ("clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux
clocks")
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/lpass-gfm-sm
On 12/01/2021 14:23, Nicolas Saenz Julienne wrote:
Soon to be released versions of RPi4's firmware will take of care
passing their bootloader's configuration[1] to the OS by copying it into
memory and creating a reserved memory node in the board's DT. By
modeling this reserved memory node as a
Add full list of ASoC drivers that are maintained!
Signed-off-by: Srinivas Kandagatla
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b1545817c899..7699d9d94a49 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14516,6 +14516,14 @@ M
Add myself as maintainer of qcom audio drivers, as Patrick
has very little time to look at the patches.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Banajit Goswami
Acked-by: Patrick Lai
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b
7;master-0' with parent 'soundwire' already present!"
Fixes: bf03473d5bcc ("soundwire: add debugfs support")
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/debug
e involved. I'll get to it later. There's also
some questionable clk_get() usage that should probably be
clk_get_optional(). For now this should help a little.
Cc: V Sujith Kumar Reddy
Cc: Srinivasa Rao
Cc: Srinivas Kandagatla
Cc: Cheng-Yi Chiang
Stephen Boyd (4):
ASoC: qcom: Remove
Hi Stephan,
On 13/01/2021 20:08, Stephan Gerhold wrote:
Hi Srinivas,
On Thu, Oct 08, 2020 at 06:37:40AM +0100, Srinivas Kandagatla wrote:
On 08/10/2020 06:16, Srinivasa Rao Mandadapu wrote:
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS
Asoc. It includes ma
On 19/12/2020 10:55, Dan Carpenter wrote:
This doesn't call of_node_put() on the error path so it leads to a
memory leak.
Fixes: 0749aa25af82 ("nvmem: core: fix regression in of_nvmem_cell_get()")
Signed-off-by: Dan Carpenter
Applied, thanks
--srini
---
The kfree_const() could just be re
On 05/12/2020 22:36, Linus Walleij wrote:
On Wed, Dec 2, 2020 at 5:35 PM Srinivas Kandagatla
wrote:
Add initial pinctrl driver to support pin configuration for
LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl
on SM8250.
Patch applied!
+config PINCTRL_LPASS_LPI
: 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")
Signed-off-by: Arnd Bergmann
Thanks for the patch,
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconf
: 520a1c396d196 ("ASoC: q6afe-clocks: add q6afe clock controller")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6afe-clocks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/qdsp6/q6afe-clocks.c
b/sound/soc/qcom/qdsp6/q6afe-clocks.c
index 87e4633afe2c..f0
Add audiocc and aoncc clock controller nodes required for audio on RB5.
Signed-off-by: Srinivas Kandagatla
Tested-by: Dmitry Baryshkov
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 ++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
b
This patch add support for two WSA881X smart speakers attached via Soundwire
and a DMIC0 on the main board.
Signed-off-by: Srinivas Kandagatla
Tested-by: Dmitry Baryshkov
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 121 +++
arch/arm64/boot/dts/qcom/sm8250.dtsi | 3
Add primary and tertinary mi2s pinconfs required to get I2S audio.
Signed-off-by: Srinivas Kandagatla
Tested-by: Dmitry Baryshkov
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 55
1 file changed, 55 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
b
201 - 300 of 1625 matches
Mail list logo
