On Sun, Mar 18, 2018 at 4:34 PM, Jonathan Cameron
wrote:
> On Sat, 17 Mar 2018 13:42:24 -0700
> Randy Dunlap wrote:
>
>> [adding linux-iio mailing list]
>>
>> Hi,
>>
>> It's always a good idea to include the kernel version in a problem report.
>
Hello,
I was trying to work with the iio dummy driver, and when I try to load
the iio_dummy_evgen.ko module I am getting unknown symbols found in
module error on running modprobe.
These variables are unknown
iio_bus_type
irq_sim_init
irq_sim_fini
irq_sim_fire
irq_sim_fini
All of these variables a
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl818
This patch series performs code cleanup like using list_for_each_entry_safe
to make code more compact and using list_entry instead of container_of for
struct list_head* variable types.
Srishti Sharma (4):
Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe
Staging: rtl8188eu
@
kfree(
-(P *)
x )
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Do transformation left out by coccinelle
-Improve commit message
drivers/staging/rtl8723bs/core/rtw_cmd.c | 60
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/r
On Sun, Oct 8, 2017 at 1:36 AM, Julia Lawall wrote:
>
>
> On Sun, 8 Oct 2017, Srishti Sharma wrote:
>
>> On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 7 Oct 2017, Srishti Sharma wrote:
>> >
>> >> T
On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall wrote:
>
>
> On Sat, 7 Oct 2017, Srishti Sharma wrote:
>
>> The cast to pointer types in kfree is not needed and can be dropped.
>> Done using the following semantic by coccinelle.
>>
>> @r@
>> type T,P;
lumn_end)
c2 = int (p2[0].column)
if l1 == l2 and c1+1 == c2:
cocci.include_match(False)
@r3@
position r1.p1, r1.p2;
@@
if(...
- )@p1
-{@p2
+) {
...
}
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Improve commit message.
drivers/staging/pi433/pi4
l->data = d;
|
- l->data = d;
...
- l->function = f;
)
Signed-off-by: Srishti Sharma
---
drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_interface.c
b/drivers/stag
p1;
p2 << r1.p2;
@@
l1 = int (p1[0].line)
l2 = int (p2[0].line)
c1 = int (p1[0].column_end)
c2 = int (p2[0].column)
if l1 == l2 and c1+1 == c2:
cocci.include_match(False)
@r3@
position r1.p1, r1.p2;
@@
if(...
- )@p1
-{@p2
+) {
...
}
Signed-off-by: Srishti Sharma
---
drivers/s
occinelle.T1 = T[:-2]
else:
coccinelle.T1 = T
print T, T1
@r2@
type r1.T;
identifier p.T1;
@@
- typedef
struct
+ T1
{
...
}
- T
;
@r3@
type r1.T;
identifier p.T1;
@@
- T
+ struct T1
Signed-off-by: Srishti Sharma
---
.../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/src/spctrl.c | 6 +++---
1
The cast to pointer types in kfree is not needed and can be dropped.
Done using the following semantic by coccinelle.
@r@
type T,P;
T* x;
@@
kfree(
-(P *)
x )
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 58
1 file changed, 29
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
Changes in v3
-Add a blank line after de
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...
}
Signed-off-by: Srishti Sharma
---
Changes in v2
-Make commit message clear.
-Add fi
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
Changes in v2
-Make the commit message mor
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
Changes in v2
-Make commit message more c
name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
Changes in v2
-Make commit message more c
On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Srishti Sharma wrote:
>
>> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter
>> wrote:
>> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
>> >> Again, you h
On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
>> Again, you have three patches on different files with the same subject
>> line. You could add the file name eg rtw_ap: to the subject line to make
>> them unique.
>>
>
> And the
On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Dan Carpenter wrote:
>
>> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
>> >
>> >
>> > On Wed, 4 Oct 2017, Dan Carpenter wrote:
>> >
>> > &
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --gi
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
d
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/driver
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
;
...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(&pos->m)
...+>
}
...
}
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 22 ++
1 file changed, 6 insertions(+),
On Tue, Oct 3, 2017 at 9:44 PM, Greg KH wrote:
> On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote:
>> Replaces instances of container_of with list_entry to
>> access current list element.
>>
>> Srishti Sharma (6):
>> Staging: rtl8188eu: core: Use l
For variables of type struct list_head* use list_entry to access
current list element instead of using container_of. Done by the
following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu
For variables of type struct list_head* use list_entry to access
current list element instead of using container_of. Done using
the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
For variables of the type struct list_head* use list_entry to access
current list element instead of using container_of. Done using the
following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
For variables of the type struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
For variables of the type struct list_head use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging
Replaces instances of container_of with list_entry to
access current list element.
Srishti Sharma (6):
Staging: rtl8188eu: core: Use list_entry instead of container_of
Staging: rtl8188eu: core: Use list_entry instead of container_of
Staging: rtl8188eu: core: Use list_entry instead of
On Sat, Sep 30, 2017 at 11:51 AM, Julia Lawall wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 30 Sep 2017, Srishti Sharma wrote:
>> >
>> >
On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 30 Sep 2017, Srishti Sharma wrote:
>> >
>> >
On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> For variables of the type struct list_head* use list_entry to access
>> the current list element instead of using container_of.
>> Done using the followin
_entry
(
...)
)
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index 22cf362..f9df4ac
_entry
(
...)
)
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 3fd5f41..af59c16 100644
--- a/d
Replace reference/unreference with get/put as it is consistent
with the kernel coding style. Done using the following semantic
patch by coccinelle.
@r@
expression e;
@@
-drm_gem_object_unreference_unlocked(e);
+drm_gem_object_put_unlocked(e);
Signed-off-by: Srishti Sharma
---
drivers/gpu/drm
Replace drm_dev_unref with drm_dev_put as it is more consistent
with kernel coding style. Done using the following semantic
patch by coccinelle.
@r@
expression e;
@@
-drm_dev_unref();
+drm_dev_put();
Signed-off-by: Srishti Sharma
---
drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++--
drivers/gpu/drm
Eliminate the fields that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc
Remove unused fields and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc
Remove fields that are not used, from structure definitions , and
eliminate the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15
This patch series attempts to remove unused variables in structure
variables and the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15
Eliminate the variables that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 5d2566e
Remove unused variables and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index
On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 16 Sep 2017, Srishti Sharma wrote:
>> >
>> >&
On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Some variables in the structure were unused and hence them and
>> the comments associated with them can be removed.
>
> How did you find these? The last two c
Some variables in the structure were unused and hence them and
the comments associated with them can be removed.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers
)
S
|
-if(E==NULL)
+if(!E)
S
)
Signed-off-by: Srishti Sharma
---
drivers/staging/irda/net/discovery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/irda/net/discovery.c
b/drivers/staging/irda/net/discovery.c
index 364d70a..1e54954 100644
--- a/drivers
On Sat, Sep 16, 2017 at 2:39 AM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 16 Sep 2017, Srishti Sharma wrote:
>> >
>> >&g
On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Write assignment statement outside the if statement. Done using
>> the following semantic patch by coccinelle.
>>
>> @@
>> identifier E;
>>
Parentheses are not needed on the right hand side of assignment
statement in most cases. Done using the following semantic
patch by coccinelle.
@@
identifier E,F,G,f;
expression e,r;
@@
(
E = (G == F);
|
E = (e == r);
|
E =
-(
...
-)
;
)
Signed-off-by: Srishti Sharma
---
drivers/staging/irda
Write assignment statement outside of the if statement. Done
using the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F;
+if(E)
S
Signed-off-by: Srishti Sharma
---
drivers/staging/irda/drivers/irda-usb.c | 4 ++--
drivers/staging
This patch series intends to remove the assignment statements
inside the if statement, and eliminates the cases of parentheses
around the right hand side of assignment generated as a result of
the same.
Srishti Sharma (2):
Staging: irda: Don't use assignment inside if statement
St
Write assignment statement outside the if statement. Done using
the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F;
+if(E)
S
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Semicolon was missing in one of the statements of the
On Sat, Sep 16, 2017 at 1:08 AM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Write assignment statement outside the if statement. Done using
>> the following semantic patch by coccinelle.
>>
>> @@
>> identifier E;
>>
On Sat, Sep 16, 2017 at 1:03 AM, Srishti Sharma wrote:
> Write assignment statement outside the if statement. Done using
> the following semantic patch by coccinelle.
>
> @@
> identifier E;
> expression F;
> statement S;
> @@
>
> -if((E = F))
> +E = F
> +if
Write assignment statement outside the if statement. Done using
the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F
+if(E)
S
Signed-off-by: Srishti Sharma
---
drivers/staging/irda/drivers/irda-usb.c | 4 ++--
drivers/staging/irda
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma
---
Changes in v2:
- eliminate parentheses around the first argument
drivers/staging
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma
---
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
1 file changed, 1
Use kcalloc instead of kzalloc to check for an overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +++-
1
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/pci/atomisp2/hmm
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/i2c/ov5693/ov5693
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/ccree/ss
On Mon, Sep 11, 2017 at 9:54 PM, Greg KH wrote:
> On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
>> Use BIT(x) instead of using (1<>
>> Signed-off-by: Srishti Sharma
>> ---
>> Changes in v2:
>> - Add tab spaces before BIT macro.
>>
On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma wrote:
> On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote:
>>
>>
>> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>>
>>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
>>> > On Mon, Sep 11
Remove the variable monitor_lock as it is not used anywhere.
Signed-off-by: Srishti Sharma
---
Changes in v2:
-The variable that was not to be declared as volatile can be
eliminated as it is not being used anywhere.
drivers/staging/ccree/ssi_request_mgr.c | 1 -
1 file changed, 1 deletion
On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote:
>
>
> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>
>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
>> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> >> The use of volatile for t
On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/ccree/ssi_reques
The use of volatile for the variable monitor_lock is unnecessary.
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_request_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging/ccree/ssi_request_mgr.c
Remove extra blank line.
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8712/rtl8712_event.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_event.h
b/drivers/staging/rtl8712/rtl8712_event.h
index b383740..cad7085 100644
--- a/drivers/staging/rtl8712
Fix alignment so that it matches open parentheses.
Signed-off-by: Srishti Sharma
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index b450c74..b813f1d
On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>
> Coccinelle is not always perfect about pretty printing,
Merge the assignment and return statements to return the value
directly. Done using the following semantic patch by
coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Correct coding style problems
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_sysfs.c | 4 +---
1 file changed, 1 insertion(+), 3
On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local idexpression ret;
>> expre
Merge the assignment and the return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v4:
-Edit commit message so that it respects 80 character limit
On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
>> >
>> >&
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v3:
-Edit commit message so that it respects 80 character limit
On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local idexpression ret;
>> expre
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Edit commit message so that it respects the 80 character limit
On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Return the return value of a function directly, instead of first saving it
>> in a variable and then returning it. This change was made using the following
>
&
Return the return value of a function directly, instead of first saving it in a
variable and then returning it. This change was made using the following
semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
On Fri, Sep 8, 2017 at 8:59 PM, Sean Paul wrote:
> On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma wrote:
>> Use BIT(x) instead of (1<>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/imx/imx-media.h | 16
>> 1 fil
Use BIT(x) instead of (1<
---
drivers/staging/media/imx/imx-media.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media.h
b/drivers/staging/media/imx/imx-media.h
index d409170..e5b8d29 100644
--- a/drivers/staging/media/imx/imx-
On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/omap4is
On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall wrote:
>
>
> On Fri, 8 Sep 2017, Srishti Sharma wrote:
>
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/omap4iss/is
Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
Signed-off-by: Srishti Sharma
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging/media/omap4iss/iss.c
index c26c99fd
Use BIT(x) instead of using (1<
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..c9a83df
Use BIT(x) instead of (1<
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..6fbcf9d 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/driv
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>
> I've been meani
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging
possible to guess correctly. However, one does not generally include the
> extension on a filename.
>
Yes, they have not used the filename in the subject line . So I'll change it to
the required format .
Thanks ,
Srishti
> julia
>
> On Thu, 7 Sep 2017, Srishti Sharma w
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not based on the original patch, hence
On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
> ‘inflight_counter
1 - 100 of 148 matches
Mail list logo
