Re: [PATCH][v2] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-15 Thread Stefan Hajnoczi
remove unused variable "fpq" > > fs/fuse/virtio_fs.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [PATCH] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-15 Thread Stefan Hajnoczi
spin_lock(&fpq->lock); list_move_tail(&req->list, &reqs); spin_unlock(&fpq->lock); } Looks safe, but please see the kernel test robot email about an unused variable warning. Reviewed-by: Stefan Hajnoczi > > diff --git a/fs/fuse/virtio_fs.c b/fs/fu

Re: [PATCH 1/2] vhost-scsi: Fix typos and formatting in comments and logs

2025-06-11 Thread Stefan Hajnoczi
X86_64on ". changing to "X86_64 on " > - Cleaning up stray semicolons in struct definition endings > > These changes improve code readability and consistency. > no functionality changes. > > Signed-off-by: Alok Tiwari > --- > drivers/vhost/scsi.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make_nexus and tpg

2025-06-11 Thread Stefan Hajnoczi
ERR_PTR(ret) in vhost_scsi_make_tpg to follow kernel > conventions for pointer-returning functions, allowing callers to use > IS_ERR and PTR_ERR for proper error handling. > > Signed-off-by: Alok Tiwari > --- > drivers/vhost/scsi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deleti

Re: [PATCH] vhost-scsi: Fix check for inline_sg_cnt exceeding preallocated limit

2025-06-09 Thread Stefan Hajnoczi
ser-provided value. > > prevents silently accepting values exceeding the maximum inline_sg_cnt. > > Fixes: bca939d5bcd0 ("vhost-scsi: Dynamically allocate scatterlists") > Signed-off-by: Alok Tiwari > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] virtio: document ENOSPC

2025-05-28 Thread Stefan Hajnoczi
tio_ring.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [PATCH net v3 0/3] Avoid calling WARN_ON() on allocation failure in cfg802154_switch_netns()

2025-04-06 Thread Stefan Schmidt
ttps://git.kernel.org/wpan/wpan-next/c/32d90bcea6c3 [2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns() https://git.kernel.org/wpan/wpan-next/c/44dcb0bbc4a4 [3/3] ieee802154: Remove WARN_ON() in cfg802154_pernet_exit() https://git.kernel.org/wpan/wpan-next/c/1dd9291eb903 regards, Stefan Schmidt

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-05 Thread Stefan Hajnoczi
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > Ever since the introduction of the virtio vsock driver, it included > pushback logic that blocks it from taking any new RX packets until the > TX queue backlog becomes shallower than the virtqueue size. > > This logic works fine whe

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Stefan Metzmacher
Am 20.03.25 um 11:46 schrieb Pavel Begunkov: On 3/19/25 19:15, Stefan Metzmacher wrote: Am 19.03.25 um 19:37 schrieb Jens Axboe: On 3/19/25 11:45 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: ... My argument would be the same as for other features - if

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Stefan Metzmacher
Am 19.03.25 um 19:37 schrieb Jens Axboe: On 3/19/25 11:45 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: On 3/19/25 11:04 AM, Joe Damato wrote: On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: On 3/19/25 9:32 AM, Joe Damato wrote: On Wed, Mar 19,

Re: [PATCH net-next v4 0/4] ieee802154: ca8210: Sparse fix and GPIOd conversion

2025-03-06 Thread Stefan Schmidt
date polarity of the reset pin https://git.kernel.org/wpan/wpan-next/c/a5d4d993fac4 regards, Stefan Schmidt

Re: [PATCH] vduse: add virtio_fs to allowed dev id

2025-01-23 Thread Stefan Hajnoczi
On Thu, Jan 23, 2025 at 08:26:57AM +0100, Eugenio Perez Martin wrote: > On Thu, Jan 23, 2025 at 2:50 AM Jason Wang wrote: > > > > On Wed, Jan 22, 2025 at 11:49 PM Stefan Hajnoczi > > wrote: > > > > > > On Tue, Jan 21, 2025 at 11:33:46AM +0100, Eugenio P

Re: [PATCH] vduse: add virtio_fs to allowed dev id

2025-01-22 Thread Stefan Hajnoczi
l work fine with just virtqueue and configuration space support. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

2024-12-30 Thread Stefan Schmidt
Hello Dave, On 30.12.24 18:44, Dr. David Alan Gilbert wrote: * Stefan Schmidt (ste...@datenfreihafen.org) wrote: Hello li...@treblig.org. On Wed, 25 Dec 2024 01:24:23 +, li...@treblig.org wrote: ieee802154_mlme_tx_one() was added in 2022 by commit ddd9ee7cda12 ("net: mac802154: Intr

Re: [RFC net-next] net: mac802154: Remove unused ieee802154_mlme_tx_one

2024-12-30 Thread Stefan Schmidt
gt; > Note, there's still a ieee802154_mlme_tx_one_locked() > variant that is used. > > [...] Applied to wpan/wpan-next.git, thanks! [1/1] net: mac802154: Remove unused ieee802154_mlme_tx_one https://git.kernel.org/wpan/wpan-next/c/bddfe23be8f8 regards, Stefan Schmidt

Re: [PATCH V2] mac802154: check local interfaces before deleting sdata list

2024-11-19 Thread Stefan Schmidt
> ieee802154_if_remove > list_del_rcu > > [...] Applied to wpan/wpan.git, thanks! [1/1] mac802154: check local interfaces before deleting sdata list https://git.kernel.org/wpan/wpan/c/eb09fbeb4870 regards, Stefan Schmidt

Re: [PATCH net-next] ieee802154: Replace BOOL_TO_STR() with str_true_false()

2024-10-28 Thread Stefan Schmidt
Hello. On 28.10.24 17:42, Thorsten Blum wrote: Hi Stefan, On 28. Oct 2024, at 16:57, Stefan Schmidt wrote: Hello Thorsten Blum. On Sun, 20 Oct 2024 13:23:13 +0200, Thorsten Blum wrote: Replace the custom BOOL_TO_STR() macro with the str_true_false() helper function and remove the macro

Re: [PATCH net-next] ieee802154: Replace BOOL_TO_STR() with str_true_false()

2024-10-28 Thread Stefan Schmidt
r_true_false() https://git.kernel.org/wpan/wpan-next/c/299875256571 regards, Stefan Schmidt

Re: [PATCH v3] mac802154: Fix potential RCU dereference issue in mac802154_scan_worker

2024-09-24 Thread Stefan Schmidt
it, thanks! [1/1] mac802154: Fix potential RCU dereference issue in mac802154_scan_worker https://git.kernel.org/wpan/wpan/c/bff1709b3980 regards, Stefan Schmidt

Re: [PATCH v2] mac802154: Fix potential RCU dereference issue in mac802154_scan_worker

2024-09-23 Thread Stefan Schmidt
aynal --- Thanks, Miquèl Do I need to resend patch v2 with the "Resend" label? Please make it a v3 right away, the resend with changes is to confusing for maintainers to keep up what to apply. In your case remove the blank line, add the stable cc and I am happy to apply this. regards Stefan Schmidt

Re: [PATCH] Fix the RCU usage in mac802154_scan_worker

2024-09-19 Thread Stefan Schmidt
v2 patch? Yes, please always increase the version whenever you change something and re-send. Also a ChangeLog of the changes makes it a lot easier for the reviewer. regards Stefan Schmidt

Re: [PATCH 4/7] net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-10 Thread Stefan Schmidt
next directly here is my ack (and Miquel's review as well). Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] ieee802154: Fix build error

2024-09-09 Thread Stefan Schmidt
`__devm_regmap_init_spi' > > Select REGMAP_SPI for IEEE802154_MCR20A to fix it. > > [...] Applied, thanks! [1/1] ieee802154: Fix build error commit: addf89774e48c992316449ffab4f29c2309ebefb Best regards, Stefan Schmidt

Re: [PATCH v4 15/15] fs/fuse/virtio_fs: allow idmapped mounts

2024-09-05 Thread Stefan Hajnoczi
ned-off-by: Alexander Mikhalitsyn > Reviewed-by: Christian Brauner > --- > v3: > - this commit added > --- > fs/fuse/virtio_fs.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH] MAINTAINERS: add virtio-vsock driver in the VIRTIO CORE section

2024-08-29 Thread Stefan Hajnoczi
x27;s tree, so let's also put the driver in > the VIRTIO CORE section to have its maintainers in CC for changes > to the virtio-vsock driver. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Signed-off-by: Stefano Garzarella > --- > MAINTAINERS | 1 + >

Re: [PATCH] test/vsock: add install target

2024-07-11 Thread Stefan Hajnoczi
On Thu, Jul 11, 2024 at 09:07:04AM +0200, Stefano Garzarella wrote: > CCing Stefan. > > On Wed, Jul 10, 2024 at 07:00:59PM GMT, Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 13:58:39 +0200 Stefano Garzarella wrote: > > > There is a comment there: > > > > >

Re: [PATCH virt] virt: fix uninit-value in vhost_vsock_dev_open

2024-04-22 Thread Stefan Hajnoczi
elds, so you could argue seqpacket_allow should just be explicitly initialized to false. However, eliminating this class of errors by zeroing seems reasonable in this code path. vhost_vsock_dev_open() is not performance-critical. Acked-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-21 Thread Stefan Hajnoczi
On Thu, Mar 21, 2024 at 08:52:03AM -0700, syzbot wrote: > Hello, > > syzbot tried to test the proposed patch but the build/boot failed: > > bcore: registered new interface driver viperboard > [7.297712][T1] usbcore: registered new interface driver dln2 > [7.299149][T1] usbcore: re

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-21 Thread Stefan Hajnoczi
On Wed, Mar 20, 2024 at 01:08:02PM -0700, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger any > issue: > > Reported-and-tested-by: syzbot+70f57d8a3ae84934c...@syzkaller.appspotmail.com > > Tested on: > > commit: 4bedfb31 mm,page_owner:

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-20 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 03:51:18PM -0500, Mike Christie wrote: > On 3/19/24 12:19 PM, Stefan Hajnoczi wrote: > > On Tue, Mar 19, 2024 at 03:40:53AM -0400, Michael S. Tsirkin wrote: > >> On Tue, Mar 19, 2024 at 12:32:26AM -0700, syzbot wrote: > >>> Hello, > >

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Stefan Hajnoczi
virtio_scsi.c commits need to be bisected. Stefan signature.asc Description: PGP signature

Re: [syzbot] [virtualization?] upstream boot error: WARNING: refcount bug in __free_pages_ok

2024-03-19 Thread Stefan Hajnoczi
0 init/main.c:1437 > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243 > > > > > > I think I saw this already and also with virtio scsi. virtio > core does not seem to be doing anything special h

Re: [PATCH] virtiofs: don't mark virtio_fs_sysfs_exit as __exit

2024-02-28 Thread Stefan Hajnoczi
_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Arnd. Please see the duplicate patch that Miklos applied: https://lore.kernel.org/linux-fsdevel/cajfpegsjcz-dnzyft3b5gbgcntmdr6r1n8pm5yclmw9fjy1...@mail.gmail.com/T/#t Stefan > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/vi

Re: [PATCH v3] vduse: Fix off by one in vduse_dev_mmap()

2024-02-28 Thread Stefan Hajnoczi
pa/vdpa_user/vduse_dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c > b/drivers/vdpa/vdpa_user/vduse_dev.c > index b7a1fb88c506..eb914084c650 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c

Re: [PATCH v2] vduse: Fix off by one in vduse_dev_mmap()

2024-02-28 Thread Stefan Hajnoczi
On Wed, 28 Feb 2024 at 12:44, Dan Carpenter wrote: > > The dev->vqs[] array has "dev->vq_num" elements. It's allocated in > vduse_dev_init_vqs(). Thus, this > comparison needs to be >= to avoid > reading one element beyond the end of the array. > > Add an array_index_nospec() as well to prevent

[PATCH v6 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2024-02-15 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Without this, it is not possible to use the USB port for serial debugging via a "Carkit debug cable". Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- .../boot/dts/qcom/qcom-msm8226-samsu

[PATCH v6 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2024-02-15 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. The common dtsi is also modified to describe the widest constraints, which required modifications to the matisse-wifi dts. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski

[PATCH v6 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2024-02-15 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v6 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2024-02-15 Thread Stefan Hansson
point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- .../qcom

[PATCH v6 0/4] Add samsung-matisselte and common matisse dtsi

2024-02-15 Thread Stefan Hansson
more readable patch. Changes since v3: - Collect tags. - Remove spurious copyright notice. - Miscellaneous fixes following review feedback. Changes since v4: - Collect tags. - Enable SD card support on matisselte. Changes since v5: - Rebased on latest linux-next. Stefan Hansson (4):

Re: [syzbot] [virtualization?] KMSAN: uninit-value in virtqueue_add (4)

2024-01-24 Thread Stefan Hajnoczi
On Wed, Jan 24, 2024 at 11:47:32AM +0100, Alexander Potapenko wrote: > On Thu, Jan 4, 2024 at 9:45 PM Stefan Hajnoczi wrote: > > > > On Tue, Jan 02, 2024 at 08:03:46AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 01, 2024 at 05:38:24AM -0800, syz

Re: [syzbot] [virtualization?] KMSAN: uninit-value in virtqueue_add (4)

2024-01-04 Thread Stefan Hajnoczi
= Hi Alexander, Please take a look at this KMSAN failure. The uninitialized memory was created for the purpose of writing a coredump. vring_map_one_sg() should have direction=DMA_TO_DEVICE. I can't easily tell whether this is a genuine bug or an issue with commit 88938359e2df ("vir

[PATCH v5 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-31 Thread Stefan Hansson
point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- .../qcom

[PATCH v5 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-31 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. The common dtsi is also modified to describe the widest constraints, which required modifications to the matisse-wifi dts. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski

[PATCH v5 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-31 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v5 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-31 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Without this, it is not possible to use the USB port for serial debugging via a "Carkit debug cable". Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- .../boot/dts/qcom/qcom-msm8226-samsu

[PATCH v5 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-31 Thread Stefan Hansson
more readable patch. Changes since v3: - Collect tags. - Remove spurious copyright notice. - Miscellaneous fixes following review feedback. Changes since v4: - Collect tags. - Enable SD card support on matisselte. Stefan Hansson (4): ARM: dts: qcom: samsung-matisse-common: Add initial c

Re: [PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-31 Thread Stefan Hansson
On 2023-10-31 12:08, Konrad Dybcio wrote: On 25.10.2023 10:37, Stefan Hansson wrote: Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. Signed-off-by: Stefan Hansson --- arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom

[PATCH v4 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-26 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. The common dtsi is also modified to describe the widest constraints, which required modifications to the matisse-wifi dts. Signed-off-by: Stefan Hansson --- arch/arm/boot/dts/qcom/Makefile

[PATCH v4 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-26 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Without this, it is not possible to use the USB port for serial debugging via a "Carkit debug cable". Signed-off-by: Stefan Hansson --- .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4 1 file changed, 4 insertion

[PATCH v4 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-26 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v4 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-26 Thread Stefan Hansson
point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson --- .../qcom-apq8026-samsung-matisse-wifi.dts

[PATCH v4 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-26 Thread Stefan Hansson
more readable patch. Changes since v3: - Collect tags. - Remove spurious copyright notice. - Miscellaneous fixes following review feedback. Stefan Hansson (4): ARM: dts: qcom: samsung-matisse-common: Add initial common device tree dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Stefan Hansson
On 2023-10-25 10:48, Krzysztof Kozlowski wrote: On 25/10/2023 10:37, Stefan Hansson wrote: This series adds a common samsung-matisse dtsi and reworks samsung-matisse-wifi to use it, and introduces samsung-matisselte. I choose matisselte over matisse-lte as this is how most other devices

Re: [PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Stefan Hansson
On 2023-10-25 10:48, Krzysztof Kozlowski wrote: On 25/10/2023 10:37, Stefan Hansson wrote: This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- This is a friendly reminder during the

[PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-25 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. Signed-off-by: Stefan Hansson --- arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++ 2 files changed, 37 insertions

[PATCH v3 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-25 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Without this, it is not possible to use the USB port for serial debugging via a "Carkit debug cable". Signed-off-by: Stefan Hansson --- .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4 1 file changed, 4 insertion

[PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-25 Thread Stefan Hansson
point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson --- .../qcom-apq8026-samsung-matisse-wifi.dts

[PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-25 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm

[PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-25 Thread Stefan Hansson
more readable patch. Stefan Hansson (4): ARM: dts: qcom: samsung-matisse-common: Add initial common device tree dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535) ARM: dts: qcom: samsung-matisse-common: Add

[PATCH v2 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE

2023-10-24 Thread Stefan Hansson
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm

[PATCH v2 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART

2023-10-24 Thread Stefan Hansson
This was not enabled in the matisse-wifi tree. Signed-off-by: Stefan Hansson --- .../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi b/arch/arm/boot/dts/qcom/qcom

[PATCH v2 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree

2023-10-24 Thread Stefan Hansson
point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson --- .../qcom-apq8026-samsung-matisse-wifi.dts

[PATCH v2 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

2023-10-24 Thread Stefan Hansson
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet based on the MSM8926 platform. Signed-off-by: Stefan Hansson --- arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++ 2 files changed, 37 insertions

[PATCH v2 0/4] Add samsung-matisselte and common matisse dtsi

2023-10-24 Thread Stefan Hansson
msm8226, and I was not sure how to resolve that. As such, I'm copying what was done in the Lumia 830 (microsoft-tesla) patch given that it was accepted. Stefan Hansson (4): ARM: dts: qcom: samsung-matisse-common: Add initial common device tree dt-bindings: arm: qcom: Add Samsung Galax

Re: [PATCH] [v4] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-10-07 Thread Stefan Schmidt
8210_unregister_ext_clock(). v4: -Remove an unused variable 'ret'. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] [v3] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-10-05 Thread Stefan Schmidt
: warning: unused variable 'ret' [-Wunused-variable] 2743 | int ret = 0; | ^~~ Please take care of this now unused variable after your re-factor. With this fixed and send out as v4 I am happy to get this applied to the wpan tree. regards Stefan Schmidt

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread Stefan Schmidt
truct ca8210_priv *priv = spi_get_drvdata(spi); - if (!priv->clk) + if (IS_ERR_OR_NULL(priv->clk)) return of_clk_del_provider(spi->dev.of_node); Alex, Stefan, who handles wpan and wpan/next this release? IIRC it would be me for wpan and Alex for wpan-next. regards Stefan Schmidt

Re: [PATCH v3 25/25] integrity: Switch from rbtree to LSM-managed blob for integrity_iint_cache

2023-09-12 Thread Stefan Berger
On 9/4/23 09:40, Roberto Sassu wrote: From: Roberto Sassu Before the security field of kernel objects could be shared among LSMs with the LSM stacking feature, IMA and EVM had to rely on an alternative storage of inode metadata. The association between inode metadata and inode is maintained t

Re: [PATCH v2 2/2] certs: Add support for using elliptic curve keys for signing modules

2021-04-20 Thread Stefan Berger
On 4/20/21 10:03 AM, Jessica Yu wrote: +++ Stefan Berger [08/04/21 11:24 -0400]: diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c index 967329e0a07b..2546ec6a0505 100644 --- a/crypto/asymmetric_keys/pkcs7_parser.c +++ b/crypto/asymmetric_keys

[PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

2021-04-15 Thread Stefan Riedmueller
The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format. Signed-off-by: Stefan Riedmueller --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel

[PATCH 2/3] drm/panel: Add connector_type for some EDT displays

2021-04-15 Thread Stefan Riedmueller
The connector_type for following two EDT displays is missing: - EDT ETM0430G0DH6 - EDT ETM0700G0BDH6 Both are parallel displays thus add the corresponding connector_type. Signed-off-by: Stefan Riedmueller --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 3/3] drm/panel: Add bus_format and bus_flags for EDT ETM0430G0DH6

2021-04-15 Thread Stefan Riedmueller
Add corresponding bus_format and bus_flags for the EDT ETM0430G0DH6 display. Signed-off-by: Stefan Riedmueller --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index

Re: [PATCH] io_thread/x86: don't reset 'cs', 'ss', 'ds' and 'es' registers for io_threads

2021-04-14 Thread Stefan Metzmacher
e natural to me to just keep the values of the copy_thread() caller. Do you plan to do something about this before 5.12 final? metze Am 11.04.21 um 17:27 schrieb Stefan Metzmacher: > This allows gdb attach to userspace processes using io-uring, > which means that they have io_threads (PF_IO_

[PATCH] leds: pca9532: Assign gpio base dynamically

2021-04-14 Thread Stefan Riedmueller
When using devicetree, gpio_base holds its initial zero value which can lead to a rejection if another gpio controller already occupies this base. To prevent that collision let the gpio base be assigned dynamically. Signed-off-by: Stefan Riedmueller --- drivers/leds/leds-pca9532.c | 2 ++ 1

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-14 Thread Stefan Hajnoczi
ed yet. Why exactly is exposing eMMC-style lifetime information problematic? Can you and Enrico discuss the use case to figure out an alternative interface? Thanks, Stefan signature.asc Description: PGP signature

Re: [PATCH] virtiofs: remove useless function

2021-04-14 Thread Stefan Hajnoczi
; fs/fuse/virtio_fs.c | 5 - > 1 file changed, 5 deletions(-) The function was never used... Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> -Original Message- > From: Marcin Wojtas > Sent: Tuesday, April 13, 2021 12:59 PM > To: Stefan Chulski > Cc: Russell King - ARM Linux admin ; > net...@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan > Markman ; linu

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Tuesday, April 13, 2021 12:18 PM > > To: Stefan Chulski > > Cc: net...@vger.kernel.org; thomas.petazz...@bootlin.com; > > da...@davemloft.net; Nadav Haklai ; Yan > Markman

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Tuesday, April 13, 2021 12:18 PM > To: Stefan Chulski > Cc: net...@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan > Markman ; linux-kernel@vger.kernel.org;

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-12 Thread Stefan Hajnoczi
On Tue, Mar 30, 2021 at 11:16:02PM +, Enrico Granata wrote: > The VirtIO TC has adopted a new feature in virtio-blk enabling > discovery of lifetime information. > > This commit adds support for the VIRTIO_BLK_T_LIFETIME command > to the virtio_blk driver, and adds two new attributes to the >

[PATCH] io_thread/x86: don't reset 'cs', 'ss', 'ds' and 'es' registers for io_threads

2021-04-11 Thread Stefan Metzmacher
ned-off-by: Stefan Metzmacher cc: Linus Torvalds cc: Jens Axboe cc: linux-kernel@vger.kernel.org cc: io-ur...@vger.kernel.org --- arch/x86/kernel/process.c | 49 +++ 1 file changed, 49 insertions(+) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/proce

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-04-09 Thread Stefan Wahren
Hi Nicolas, Am 09.04.21 um 12:54 schrieb Nicolas Saenz Julienne: > Hi again, > > On Wed, 2021-04-07 at 16:37 -0400, Alan Cooper wrote: >> Nicolas, >> >> I got a better description of the failure and it looks like the bus >> clock needs to be limited to 300KHz for a 500MHz core clock. >> What's hap

Re: [PATCH v2 1/2] certs: Trigger creation of RSA module signing key if it's not an RSA key

2021-04-08 Thread Stefan Berger
On 4/8/21 1:15 PM, Mimi Zohar wrote: On Thu, 2021-04-08 at 11:24 -0400, Stefan Berger wrote: Address a kbuild issue where a developer created an ECDSA key for signing kernel modules and then builds an older version of the kernel, when bi- secting the kernel for example, that does not support

[PATCH v2 0/2] Add support for ECDSA-signed kernel modules

2021-04-08 Thread Stefan Berger
://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/log/?h=ecc Stefan v2: - Adjustment to ECDSA key detector string in 2/2 - Rephrased cover letter and patch descriptions with Mimi Stefan Berger (2): certs: Trigger creation of RSA module signing key if it's not an RSA

[PATCH v2 1/2] certs: Trigger creation of RSA module signing key if it's not an RSA key

2021-04-08 Thread Stefan Berger
: cfc411e7fff3 ("Move certificate handling to its own directory") Signed-off-by: Stefan Berger --- certs/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/certs/Makefile b/certs/Makefile index e3185c57fbd8..f64bc89ccbf1 100644 --- a/certs/Makefile +++ b/certs/Makefile @@ -5

[PATCH v2 2/2] certs: Add support for using elliptic curve keys for signing modules

2021-04-08 Thread Stefan Berger
/signing_key.*) when building an older version of a kernel that only supports RSA keys. Unless kbuild automati- cally detects and generates a new kernel module key, ECDSA-signed kernel modules will fail signature verification. Signed-off-by: Stefan Berger --- v2: - check for ECDSA key by id

Re: [PATCH 0/2] Add support for ECDSA-signed kernel modules

2021-04-07 Thread Stefan Berger
On 4/7/21 12:10 PM, Mimi Zohar wrote: On Wed, 2021-04-07 at 18:53 +0300, Jarkko Sakkinen wrote: On Tue, Apr 06, 2021 at 02:53:38PM -0400, Stefan Berger wrote: This series adds support for ECDSA-signed kernel modules. The first patch in this series attempts to address the issue where a

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-06 Thread Stefan Schmidt
gerrit public mirror. I'm using it to check patches with syzbot. Change ids are useless outside gerrit, so it shouldn't be here. Btw, should I sent v2 or this is already fixed? Otherwise the patch looks good. May Stefan can fix this. Acked-by: Alexander Aring I removed the Change-

[PATCH 2/2] certs: Add support for using elliptic curve keys for signing modules

2021-04-06 Thread Stefan Berger
/signing_key.*) when falling back to building an older version of a kernel that only supports RSA keys since otherwise ECDSA-signed modules will not be usable when that older kernel runs and the ECDSA key was still used for signing modules. Signed-off-by: Stefan Berger --- certs/Kconfig

[PATCH 1/2] certs: Trigger recreation of module signing key if it's not an RSA key

2021-04-06 Thread Stefan Berger
if falling back to kernels that have actually been patched with this kernel, such as the stable trees. Fixes: cfc411e7fff3 ("Move certificate handling to its own directory") Signed-off-by: Stefan Berger --- certs/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/certs/

[PATCH 0/2] Add support for ECDSA-signed kernel modules

2021-04-06 Thread Stefan Berger
ueued here: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/log/?h=ecc Stefan Stefan Berger (2): certs: Trigger recreation of module signing key if it's not an RSA key certs: Add support for using elliptic curve keys for signing modules cer

Re: [PATCH 2/3] mmc: sdhci-iproc: Cap min clock frequency on BCM2711

2021-04-06 Thread Stefan Wahren
Hi Nicolas, Am 06.04.21 um 12:48 schrieb Nicolas Saenz Julienne: > There is a known bug on BCM2711's SDHCI core integration where the > controller will hang when the difference between the core clock and the > bus clock is too great. Specifically this can be reproduced under the > following condit

Re: [PATCH] tools/kvm_stat: fix out of date aarch64 kvm_exit reason definations

2021-04-05 Thread Stefan Raspl
{ 'HVC64':0x16, 'SMC64':0x17, 'SYS64':0x18, +'SVE': 0x19, +'ERET': 0x1a, +'FPAC':

Re: [PATCH 0/6] Allow signals for IO threads

2021-04-02 Thread Stefan Metzmacher
Am 01.04.21 um 18:24 schrieb Linus Torvalds: > On Thu, Apr 1, 2021 at 9:00 AM Stefan Metzmacher wrote: >> >> I haven't tried it, but it seems gdb tries to use PTRACE_PEEKUSR >> against the last thread tid listed under /proc//tasks/ in order to >> get the architectu

Re: [PATCH v3 3/3] ima: enable loading of build time generated key on .ima keyring

2021-04-02 Thread Stefan Berger
On 3/30/21 9:16 AM, Nayna Jain wrote: The kernel currently only loads the kernel module signing key onto the builtin trusted keyring. Load the module signing key onto the IMA keyring as well. Signed-off-by: Nayna Jain Acked-by: Stefan Berger --- certs/system_certificates.S | 13

Re: [PATCH v3 2/3] ima: enable signing of modules with build time generated key

2021-04-02 Thread Stefan Berger
On 3/30/21 9:16 AM, Nayna Jain wrote: The kernel build process currently only signs kernel modules when MODULE_SIG is enabled. Also, sign the kernel modules at build time when IMA_APPRAISE_MODSIG is enabled. Signed-off-by: Nayna Jain Acked-by: Stefan Berger --- certs/Kconfig | 2

Re: [PATCH 0/2] Don't show PF_IO_WORKER in /proc//task/

2021-04-01 Thread Stefan Metzmacher
Hi Jens, >> I know you brought this one up as part of your series, not sure I get >> why you want it owned by root and read-only? cmdline and exe, yeah those >> could be hidden, but is there really any point? >> >> Maybe I'm missing something here, if so, do clue me in! > > I looked through /proc

Re: [PATCH 2/8] kernel: unmask SIGSTOP for IO threads

2021-04-01 Thread Stefan Metzmacher
Hi Jens, >>> I don't assume signals wanted by userspace should potentially handled in an >>> io_thread... >>> e.g. things set with fcntl(fd, F_SETSIG,) used together with F_SETLEASE? >> >> I guess we do actually need it, if we're not fiddling with >> wants_signal() for them. To quell Oleg's conce

Re: [PATCH] Document that PF_KTHREAD _is_ ABI

2021-04-01 Thread Stefan Metzmacher
Am 31.03.21 um 21:23 schrieb Alexey Dobriyan: > On Mon, Mar 22, 2021 at 07:53:10AM +, Christoph Hellwig wrote: >> On Sat, Mar 20, 2021 at 10:23:12AM -0700, Andy Lutomirski wrote: https://github.com/systemd/systemd/blob/main/src/basic/process-util.c#L354 src/basic/process-util.c:is_k

  1   2   3   4   5   6   7   8   9   10   >