Re: UFS API in the kernel

On 2016-09-28 02:19, Joao Pinto wrote: Hi again! Could you also send me an example of how you are using the IOCTL from your user app (send/receive data)? I already have my implemented but you use a different mechanism (I have checked your structures in uapi/scsi/ufs/) and I have to port it!

Re: UFS API in the kernel

On 2016-09-28 02:19, Joao Pinto wrote: Hi again! Could you also send me an example of how you are using the IOCTL from your user app (send/receive data)? I already have my implemented but you use a different mechanism (I have checked your structures in uapi/scsi/ufs/) and I have to port it!

Re: UFS API in the kernel

On 2016-09-28 02:57, Joao Pinto wrote: I was able to get the 7 patches to have the UFS IOCTL features from your repo. BTW, why weren't these features submitted to the kernel? I checked lots of tweaks that you have been making to the UFS... do you synchronize them periodically with the mainline?

Re: UFS API in the kernel

On 2016-09-28 02:57, Joao Pinto wrote: I was able to get the 7 patches to have the UFS IOCTL features from your repo. BTW, why weren't these features submitted to the kernel? I checked lots of tweaks that you have been making to the UFS... do you synchronize them periodically with the mainline?

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

On 2016-09-27 22:14, Martin K. Petersen wrote: "Subhash" == subhashj <subha...@codeaurora.org> writes: Subhash> Looks good to me. - /* Data segment length */ - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( - 0, 0, len >>

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

On 2016-09-27 22:14, Martin K. Petersen wrote: "Subhash" == subhashj writes: Subhash> Looks good to me. - /* Data segment length */ - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( - 0, 0, len >> 8, (u8)len); + /* Data se

Re: UFS API in the kernel

Hi Joao, On 2016-09-26 18:10, Kiwoong Kim wrote: Hi. If you want to declare some things for user interface, is it be better to put those thing include/uapi/linux/ than include/linux? Agreed with Mr. Pinto's opinion with respect to implementing additional ioctls. Yes,

Re: UFS API in the kernel

Hi Joao, On 2016-09-26 18:10, Kiwoong Kim wrote: Hi. If you want to declare some things for user interface, is it be better to put those thing include/uapi/linux/ than include/linux? Agreed with Mr. Pinto's opinion with respect to implementing additional ioctls. Yes,

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

Looks good to me. Reviewed-by: Subhash Jadavani On 2016-08-25 02:39, Zang Leigang wrote: Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang ---

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

Looks good to me. Reviewed-by: Subhash Jadavani On 2016-08-25 02:39, Zang Leigang wrote: Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file

Re: [PATCH v3 04/15] scsi: ufs: clear outstanding_request bit in case query timeout

Looks good to me. Reviewed-by: Subhash Jadavani > When sending a query to the device returns with a timeout error, > we clear the corresponding bit in the DOORBELL register but > we don't clear the outstanding_request field as we should. > This patch fixes this bug. > > Signed-off-by: Yaniv

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

Looks good to me. Reviewed-by: Subhash Jadavani > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which aborts the command and

Re: [PATCH v3 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

Looks good to me. Reviewed-by: Subhash Jadavani > Some of the data structures (like response UPIU) and/or its elements > (unused fields) should be cleared before sending out the respective > command to UFS device. > > This change clears the UPIU response data structure for query commands > and

Re: [PATCH v7 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

Looks good to me. Reviewed-by: Subhash Jadavani > New revisions of UFS host controller supports the new UniPro > hardware controller (referred as QUniPro). This patch adds > the support to enable this new UniPro controller hardware. > > This change also adds power optimization for bus scaling

Re: [PATCH v7 7/8] scsi: ufs-qcom: add debug prints for test bus

Looks good to me. Reviewed-by: Subhash Jadavani > Adds support for configuring and reading the test bus and debug > registers. This change also adds another vops in order to print the > debug registers. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 165 >

Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

Comments inline below: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it only serves as a group of platform APIs such as PM

Re: [PATCH v7 4/8] add ufshcd_get_variant ufshcd_set_variant

Looks good to me. Reviewed-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 34 +- > drivers/scsi/ufs/ufshcd.h | 21 + > 2 files changed, 38 insertions(+), 17 deletions(-) > > diff --git

Re: [PATCH v7 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

Looks good to me. Reviewed-by: Subhash Jadavani > This change is required in order to be able to build the component > as a module. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v7 5/8] scsi: ufs: creates wrapper functions for vops

Looks good to me. Reviewed-by: Subhash Jadavani > In order to simplify the code a set of wrapper functions is created > to test and call each of the variant operations. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 1 - > drivers/scsi/ufs/ufshcd.c | 104 >

Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

Looks good to me. Reviewed-by: Subhash Jadavani > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel." > > Signed-off-by: Yaniv

Re: [PATCH v7 1/8] phy: qcom-ufs: fix build error when the component is built as a module

Looks good to me. Reviewed-by: Subhash Jadavani > Export the following functions in order to avoid build errors > when the component PHY_QCOM_UFS is compiled as a module: > > ERROR: "ufs_qcom_phy_disable_ref_clk" > [drivers/scsi/ufs/ufs-qcom.ko] undefined! > ERROR:

Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

Looks good to me. Reviewed-by: Subhash Jadavani > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Signed-off-by: Dolev Raviv > Signed-off-by: Noa Rubens >

Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

Comments inline below: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it only serves as a group of platform APIs such as PM

Re: [PATCH v3 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

Looks good to me. Reviewed-by: Subhash Jadavani > Some of the data structures (like response UPIU) and/or its elements > (unused fields) should be cleared before sending out the respective > command to UFS device. > > This change clears the UPIU response data structure

Re: [PATCH v7 4/8] add ufshcd_get_variant ufshcd_set_variant

Looks good to me. Reviewed-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 34 +- > drivers/scsi/ufs/ufshcd.h | 21 + > 2 files changed, 38

Re: [PATCH v7 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

Looks good to me. Reviewed-by: Subhash Jadavani > New revisions of UFS host controller supports the new UniPro > hardware controller (referred as QUniPro). This patch adds > the support to enable this new UniPro controller hardware. > > This change also adds power

Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

Looks good to me. Reviewed-by: Subhash Jadavani > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Signed-off-by: Dolev Raviv

Re: [PATCH v7 5/8] scsi: ufs: creates wrapper functions for vops

Looks good to me. Reviewed-by: Subhash Jadavani > In order to simplify the code a set of wrapper functions is created > to test and call each of the variant operations. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 1 -

Re: [PATCH v7 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

Looks good to me. Reviewed-by: Subhash Jadavani > This change is required in order to be able to build the component > as a module. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v7 1/8] phy: qcom-ufs: fix build error when the component is built as a module

Looks good to me. Reviewed-by: Subhash Jadavani > Export the following functions in order to avoid build errors > when the component PHY_QCOM_UFS is compiled as a module: > > ERROR: "ufs_qcom_phy_disable_ref_clk" > [drivers/scsi/ufs/ufs-qcom.ko] undefined! > ERROR:

Re: [PATCH v7 7/8] scsi: ufs-qcom: add debug prints for test bus

Looks good to me. Reviewed-by: Subhash Jadavani > Adds support for configuring and reading the test bus and debug > registers. This change also adds another vops in order to print the > debug registers. > > Signed-off-by: Yaniv Gardi > > --- >

Re: [PATCH v3 04/15] scsi: ufs: clear outstanding_request bit in case query timeout

Looks good to me. Reviewed-by: Subhash Jadavani > When sending a query to the device returns with a timeout error, > we clear the corresponding bit in the DOORBELL register but > we don't clear the outstanding_request field as we should. > This patch fixes this bug. >

Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

Looks good to me. Reviewed-by: Subhash Jadavani > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel."

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

Looks good to me. Reviewed-by: Subhash Jadavani > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

>> On Aug 14, 2014, at 9:22 AM, Yaniv Gardi wrote: >>> The files in this change implement the UFS HW (controller & PHY) specific >>> behavior in Qualcomm MSM chips. >>> Signed-off-by: Yaniv Gardi >>> --- >>> Documentation/devicetree/bindings/ufs/ufs-msm.txt | 37 + >>>

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

On Aug 14, 2014, at 9:22 AM, Yaniv Gardi yga...@codeaurora.org wrote: The files in this change implement the UFS HW (controller PHY) specific behavior in Qualcomm MSM chips. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- Documentation/devicetree/bindings/ufs/ufs-msm.txt | 37 +