[PATCH] dt-bindings: anybus-controller: move to staging/ tree

2019-09-08 Thread thesven73
From: Sven Van Asbroeck The devicetree bindings for anybus-controller were mistakenly merged into the main Linux tree. Its driver resides in staging/, so the bindings belong in staging/ too. Cc: Greg Kroah-Hartman Fixes: 20a980e957bf ("dt-bindings: anybus-controller: document devicetree

[PATCH v2] Input: synaptics_i2c - remove redundant spinlock

2019-02-16 Thread thesven73
From: Sven Van Asbroeck Remove a leftover spinlock. This was required back when mod_delayed_work() did not exist, and had to be implemented with a cancel + queue. See commit e7c2f967445d ("workqueue: use mod_delayed_work() instead of __cancel + queue") schedule_delayed_work() and

[PATCH] Input: synaptics_i2c - remove redundant spinlock

2019-02-11 Thread thesven73
From: Sven Van Asbroeck Remove a leftover spinlock. This was required back when mod_delayed_work() did not exist, and had to be implemented with a cancel + schedule. See commit e7c2f967445d ("workqueue: use mod_delayed_work() instead of __cancel + queue") schedule_delayed_work() and

[PATCH] Input: qt2160 - remove redundant spinlock

2019-02-10 Thread thesven73
From: Sven Van Asbroeck Remove a spinlock which prevents schedule_delayed_work() and mod_delayed_work() from executing concurrently. This was required back when mod_delayed_work() did not exist, and had to be implemented with a cancel + schedule. See commit e7c2f967445d ("workqueue: use

[PATCH v2 0/2] bus: imx-weim

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Support multiple address ranges per child node on imx-weim. While we're at it, insert some code which guards against common config conflicts. v2: corrected acme@... in commit message example Sven Van Asbroeck (2): bus: imx-weim: support multiple address ranges

[PATCH v2 1/2] bus: imx-weim: support multiple address ranges per child node

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Ensure that timing values for the child node are applied to all chip selects in the child's address ranges. Note that this does not support multiple timing settings per child; this can be added in the future if required. Example: { acme@0,0 {

[PATCH v2 0/2] bus: imx-weim

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Support multiple address ranges per child node on imx-weim. While we're at it, insert some code which guards against common config conflicts. v2: corrected acme@... in commit message example Sven Van Asbroeck (2): bus: imx-weim: support multiple address ranges

[PATCH v2 1/2] bus: imx-weim: support multiple address ranges per child node

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Ensure that timing values for the child node are applied to all chip selects in the child's address ranges. Note that this does not support multiple timing settings per child; this can be added in the future if required. Example: { acme@0,0 {

[PATCH v2 2/2] bus: imx-weim: guard against timing configuration conflicts

2018-11-30 Thread thesven73
From: Sven Van Asbroeck When adding weim child devices, there is a risk that the developer will (by mistake) specify more than one timing setting for the same chip select. The driver cannot support such a configuration. In case of conflict, this patch will print a warning to the log, and will

[PATCH v2 2/2] bus: imx-weim: guard against timing configuration conflicts

2018-11-30 Thread thesven73
From: Sven Van Asbroeck When adding weim child devices, there is a risk that the developer will (by mistake) specify more than one timing setting for the same chip select. The driver cannot support such a configuration. In case of conflict, this patch will print a warning to the log, and will

[PATCH 1/2] bus: imx-weim: support multiple address ranges per child node

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Ensure that timing values for the child node are applied to all chip selects in the child's address ranges. Note that this does not support multiple timing settings per child; this can be added in the future if required. Example: { acme@0 {

[PATCH 0/2] bus: imx-weim

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Support multiple address ranges per child node on imx-weim. While we're at it, insert some code which guards against common config conflicts. Sven Van Asbroeck (2): bus: imx-weim: support multiple address ranges per child node bus: imx-weim: guard against timing

[PATCH 2/2] bus: imx-weim: guard against timing configuration conflicts

2018-11-30 Thread thesven73
From: Sven Van Asbroeck When adding weim child devices, there is a risk that the developer will (by mistake) specify more than one timing setting for the same chip select. The driver cannot support such a configuration. In case of conflict, this patch will print a warning to the log, and will

[PATCH 2/2] bus: imx-weim: guard against timing configuration conflicts

2018-11-30 Thread thesven73
From: Sven Van Asbroeck When adding weim child devices, there is a risk that the developer will (by mistake) specify more than one timing setting for the same chip select. The driver cannot support such a configuration. In case of conflict, this patch will print a warning to the log, and will

[PATCH 1/2] bus: imx-weim: support multiple address ranges per child node

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Ensure that timing values for the child node are applied to all chip selects in the child's address ranges. Note that this does not support multiple timing settings per child; this can be added in the future if required. Example: { acme@0 {

[PATCH 0/2] bus: imx-weim

2018-11-30 Thread thesven73
From: Sven Van Asbroeck Support multiple address ranges per child node on imx-weim. While we're at it, insert some code which guards against common config conflicts. Sven Van Asbroeck (2): bus: imx-weim: support multiple address ranges per child node bus: imx-weim: guard against timing

[PATCH anybus v4 7/7] fieldbus_dev: support HMS Profinet IRT industrial controller

2018-11-21 Thread thesven73
The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official documentation:

[PATCH anybus v4 4/7] dt-bindings: anybus-bridge: document devicetree binding

2018-11-21 Thread thesven73
This patch adds devicetree binding documentation for the Arcx anybus bridge. Reviewed-by: Rob Herring Signed-off-by: Sven Van Asbroeck --- .../bindings/fieldbus/arcx,anybus-bridge.txt | 34 +++ 1 file changed, 34 insertions(+) create mode 100644

[PATCH anybus v4 5/7] fieldbus: support HMS Anybus-S bus

2018-11-21 Thread thesven73
The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the application to focus on other

[PATCH anybus v4 7/7] fieldbus_dev: support HMS Profinet IRT industrial controller

2018-11-21 Thread thesven73
The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official documentation:

[PATCH anybus v4 4/7] dt-bindings: anybus-bridge: document devicetree binding

2018-11-21 Thread thesven73
This patch adds devicetree binding documentation for the Arcx anybus bridge. Reviewed-by: Rob Herring Signed-off-by: Sven Van Asbroeck --- .../bindings/fieldbus/arcx,anybus-bridge.txt | 34 +++ 1 file changed, 34 insertions(+) create mode 100644

[PATCH anybus v4 5/7] fieldbus: support HMS Anybus-S bus

2018-11-21 Thread thesven73
The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the application to focus on other

[PATCH anybus v4 2/7] fieldbus: support the Arcx anybus bridge

2018-11-21 Thread thesven73
Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus, modelled as a regulator. Signed-off-by: Sven Van Asbroeck ---

[PATCH anybus v4 2/7] fieldbus: support the Arcx anybus bridge

2018-11-21 Thread thesven73
Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus, modelled as a regulator. Signed-off-by: Sven Van Asbroeck ---

[PATCH anybus v4 3/7] dt-bindings: Add vendor prefix for arcx / Archronix

2018-11-21 Thread thesven73
arcx Inc. is an engineering company which provides advanced embedded systems and consulting services. Archronix is a technology design and product engineering firm specializing in hardware control systems and enabling software. Clients include OEM's in the transportation, aerospace, medical and

[PATCH anybus v4 3/7] dt-bindings: Add vendor prefix for arcx / Archronix

2018-11-21 Thread thesven73
arcx Inc. is an engineering company which provides advanced embedded systems and consulting services. Archronix is a technology design and product engineering firm specializing in hardware control systems and enabling software. Clients include OEM's in the transportation, aerospace, medical and

[PATCH anybus v4 6/7] dt-bindings: anybuss-host: document devicetree binding

2018-11-21 Thread thesven73
This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/fieldbus/arcx,anybuss-host.txt | 66 +++ 1 file changed, 66 insertions(+) create mode 100644

[PATCH anybus v4 6/7] dt-bindings: anybuss-host: document devicetree binding

2018-11-21 Thread thesven73
This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/fieldbus/arcx,anybuss-host.txt | 66 +++ 1 file changed, 66 insertions(+) create mode 100644

[PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-21 Thread thesven73
Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. This framework is designed

[PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-21 Thread thesven73
Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. This framework is designed

[PATCH anybus v4 0/7] Add Fieldbus subsystem + support HMS Profinet card

2018-11-21 Thread thesven73
This patch: 1. adds a Fieldbus subsystem 2. adds support for the HMS Industrial Networks AB Profinet card. 1. Fieldbus subsystem - Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are

[PATCH anybus v4 0/7] Add Fieldbus subsystem + support HMS Profinet card

2018-11-21 Thread thesven73
This patch: 1. adds a Fieldbus subsystem 2. adds support for the HMS Industrial Networks AB Profinet card. 1. Fieldbus subsystem - Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are

[PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official

[PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the

[PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official

[PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the

[PATCH anybus v3 3/6] dt-bindings: anybus-bridge: document devicetree binding

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/misc/arcx,anybus-bridge.txt | 34 +++ 1 file changed, 34 insertions(+) create mode 100644

[PATCH anybus v3 3/6] dt-bindings: anybus-bridge: document devicetree binding

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/misc/arcx,anybus-bridge.txt | 34 +++ 1 file changed, 34 insertions(+) create mode 100644

[PATCH anybus v3 1/6] misc: support the Arcx anybus bridge

2018-11-04 Thread thesven73
From: Sven Van Asbroeck Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus, modelled as a regulator. Signed-off-by: Sven Van

[PATCH anybus v3 2/6] dt-bindings: Add vendor prefix for arcx / Archronix

2018-11-04 Thread thesven73
From: Sven Van Asbroeck arcx Inc. is an engineering company which provides advanced embedded systems and consulting services. Archronix is a technology design and product engineering firm specializing in hardware control systems and enabling software. Clients include OEM's in the

[PATCH anybus v3 5/6] dt-bindings: anybuss-host: document devicetree binding

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/bus/arcx,anybuss-host.txt| 36 +++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch set adds support for the HMS Industrial Networks AB Profinet card. Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a

[PATCH anybus v3 1/6] misc: support the Arcx anybus bridge

2018-11-04 Thread thesven73
From: Sven Van Asbroeck Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus, modelled as a regulator. Signed-off-by: Sven Van

[PATCH anybus v3 2/6] dt-bindings: Add vendor prefix for arcx / Archronix

2018-11-04 Thread thesven73
From: Sven Van Asbroeck arcx Inc. is an engineering company which provides advanced embedded systems and consulting services. Archronix is a technology design and product engineering firm specializing in hardware control systems and enabling software. Clients include OEM's in the

[PATCH anybus v3 5/6] dt-bindings: anybuss-host: document devicetree binding

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/bus/arcx,anybuss-host.txt| 36 +++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH anybus v3 0/6] Support HMS Profinet Card over Anybus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck This patch set adds support for the HMS Industrial Networks AB Profinet card. Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a

[PATCH v1] regulator: pfuze100-regulator: add coin support for pfuze100

2018-11-02 Thread thesven73
Add support for PF0100 coin cell/super capacitor charger which works as a current limited voltage source via the LICELL pin. When VIN goes below a certain threshold LICELL is used to provide power for VSNVS which is usually used to hold up secure non-volatile storage and the real-time clock on the

[PATCH v1] regulator: pfuze100-regulator: add coin support for pfuze100

2018-11-02 Thread thesven73
Add support for PF0100 coin cell/super capacitor charger which works as a current limited voltage source via the LICELL pin. When VIN goes below a certain threshold LICELL is used to provide power for VSNVS which is usually used to hold up secure non-volatile storage and the real-time clock on the

No interrupt was generated using MSI

2018-11-01 Thread thesven73
I am seeing this in my kernel log: [ 10.235625] tg3 :03:00.0 eth20: No interrupt was generated using MSI. Switching to INTx mode. Please report this failure to the PCI maintainer and include system chipset information I looked through MAINTAINERS, but I can't find the PCI

No interrupt was generated using MSI

2018-11-01 Thread thesven73
I am seeing this in my kernel log: [ 10.235625] tg3 :03:00.0 eth20: No interrupt was generated using MSI. Switching to INTx mode. Please report this failure to the PCI maintainer and include system chipset information I looked through MAINTAINERS, but I can't find the PCI

[PATCH anybus v2 2/5] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/misc/arcx,anybus-bridge.txt | 34 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 35

[PATCH anybus v2 2/5] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/misc/arcx,anybus-bridge.txt | 34 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 35

[PATCH anybus v2 3/5] bus: support HMS Anybus-S bus.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the

[PATCH anybus v2 3/5] bus: support HMS Anybus-S bus.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the

[PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus. Signed-off-by: Sven Van Asbroeck ---

[PATCH anybus v2 5/5] misc: support HMS Profinet IRT industrial controller.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official

[PATCH anybus v2 4/5] dt-bindings: anybuss-host: document devicetree binding.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/bus/arcx,anybuss-host.txt| 36 +++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH anybus v2 0/5] Support HMS Profinet Card over Anybus

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch set adds support for the HMS Industrial Networks AB Profinet card. Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a

[PATCH anybus v2 4/5] dt-bindings: anybuss-host: document devicetree binding.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch adds devicetree binding documentation for the Arcx Anybus-S host. Signed-off-by: Sven Van Asbroeck --- .../bindings/bus/arcx,anybuss-host.txt| 36 +++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH anybus v2 0/5] Support HMS Profinet Card over Anybus

2018-10-31 Thread thesven73
From: Sven Van Asbroeck This patch set adds support for the HMS Industrial Networks AB Profinet card. Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a

[PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus. Signed-off-by: Sven Van Asbroeck ---

[PATCH anybus v2 5/5] misc: support HMS Profinet IRT industrial controller.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official

Re: [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus.

2018-10-30 Thread thesven73
>> struct anybus_s_host *cd = data; >> drivers/bus/anybus-s-host.c >> include/linux/anybus-s-client.h > > Hm I think this looks pretty neat actually. Anyways, in the overall > architecture explain the three Anybus:es and why things pertaining > to Anybus-s are named as they are. Ok, so should I

Re: [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus.

2018-10-30 Thread thesven73
>> struct anybus_s_host *cd = data; >> drivers/bus/anybus-s-host.c >> include/linux/anybus-s-client.h > > Hm I think this looks pretty neat actually. Anyways, in the overall > architecture explain the three Anybus:es and why things pertaining > to Anybus-s are named as they are. Ok, so should I

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
>> This is why the bridge driver has a dependency on a pwm. >> If the pwm could be enabled individually, I could drop this dependency. >> Can you think of a way? > > How about using the pwm-clock device tree binding to turn the PWM into > a clock? >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
>> This is why the bridge driver has a dependency on a pwm. >> If the pwm could be enabled individually, I could drop this dependency. >> Can you think of a way? > > How about using the pwm-clock device tree binding to turn the PWM into > a clock? >

Re: [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus.

2018-10-25 Thread thesven73
Hi Linus, thanks a million for the detailed patch review, you've given this patch a lot more attention than I was expecting. Great !! > What you need to add is a bit of how the driver is architected. I agree. Written once, read/maintained 100s of times, right? > This is really needed because

Re: [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus.

2018-10-25 Thread thesven73
Hi Linus, thanks a million for the detailed patch review, you've given this patch a lot more attention than I was expecting. Great !! > What you need to add is a bit of how the driver is architected. I agree. Written once, read/maintained 100s of times, right? > This is really needed because

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Linus, thank you for the patch review !! >> + - pwms : the pwm connected to the bridge's 'pwm input'. > > That is really unintuitive and needs a detailed explanation. What > is a bridge doing with a PWM? Is it 100% certain this is a PWM, > it's not just a clock? A pwm is a pule WIDTH

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Linus, thank you for the patch review !! >> + - pwms : the pwm connected to the bridge's 'pwm input'. > > That is really unintuitive and needs a detailed explanation. What > is a bridge doing with a PWM? Is it 100% certain this is a PWM, > it's not just a clock? A pwm is a pule WIDTH

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Rob, thank you so much for taking a look at this patch ! >> +This chip communicates with the SoC over the WEIM bus. It is >> +expected that its Device Tree node is specified as the child of a node >> +corresponding to the WEIM bus used for communication. > >By WEIM you are referring to i.MX

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Rob, thank you so much for taking a look at this patch ! >> +This chip communicates with the SoC over the WEIM bus. It is >> +expected that its Device Tree node is specified as the child of a node >> +corresponding to the WEIM bus used for communication. > >By WEIM you are referring to i.MX