Re: [PATCH] arch: mips: bcm63xx: Spello fix in the file clk.c

2021-03-10 Thread Thomas Bogendoerfer
On Fri, Mar 05, 2021 at 07:35:35AM +0530, Bhaskar Chowdhury wrote: > > > s/revelant/relevant/ > > Signed-off-by: Bhaskar Chowdhury > --- > arch/mips/bcm63xx/clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next with fixed subject. Th

Re: [PATCH 1/2] mips: syscalls: switch to generic syscalltbl.sh

2021-03-10 Thread Thomas Bogendoerfer
| 31 ++--- > arch/mips/kernel/syscalls/syscalltbl.sh | 36 - > 7 files changed, 17 insertions(+), 71 deletions(-) > delete mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

[PATCH] arm64: dts: rockchip: add infrared receiver node to rockpro64

2021-03-10 Thread Thomas Schneider
This adds the RockPro64’s infrared receiver to its dtsi. The configuration is almost the same as on rk3328-rock64, except for the GPIO pins, and thus adapted from there. Signed-off-by: Thomas Schneider --- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 13 + 1 file changed

Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct

2021-03-10 Thread Thomas Gleixner
On Tue, Mar 09 2021 at 13:01, Thomas Gleixner wrote: > On Fri, Mar 05 2021 at 11:57, Oleg Nesterov wrote: >> On 03/04, Thomas Gleixner wrote: >>> On Wed, Mar 03 2021 at 16:37, Oleg Nesterov wrote: >>> >> +static bool sigqueue_add_cache(struct task_stru

Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

2021-03-10 Thread Thomas Gleixner
On Tue, Mar 09 2021 at 16:21, Sebastian Andrzej Siewior wrote: > On 2021-03-09 16:00:37 [+0100], To Thomas Gleixner wrote: >> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h >> index 07c7329d21aa7..1c14ccd351091 100644 >> --- a/include/linux/interrupt.h &

[PATCH v2 1/2] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-09 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers

[PATCH v2 0/2] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
helps to resolve that. v2: * Updated copyright year as a part of code change Rijo Thomas (2): crypto: ccp - reduce tee command status polling interval from 5ms to 1ms crypto: ccp - fix command queuing to TEE ring buffer drivers/crypto/ccp/tee-dev.c | 57

[PATCH v2 2/2] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-09 Thread Rijo Thomas
TEE request from a client, then further command submission to queue will be disabled. Fixes: 33960acccfbd (crypto: ccp - add TEE support for Raven Ridge) Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 49 +--- drivers/crypto/ccp/tee-dev.h | 20

Re: [PATCH 0/3] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
On 09/03/21 10:06 pm, Tom Lendacky wrote: > On 3/9/21 2:11 AM, Rijo Thomas wrote: >> The first patch helps to improve the response time by reducing the >> polling time of the tee command status variable. >> >> Second patch is a bug fix to handle multi-threaded use-ca

Re: [PATCH 3/3] crypto: ccp - update copyright year for tee

2021-03-09 Thread Rijo Thomas
On 09/03/21 10:03 pm, Tom Lendacky wrote: > On 3/9/21 2:11 AM, Rijo Thomas wrote: >> Update the copyright year for PSP TEE driver files. >> >> Signed-off-by: Rijo Thomas > > The copyright updates really should occur as part of the changes in the > other pat

[GIT PULL] MIPS fixes for v5.12

2021-03-09 Thread Thomas Bogendoerfer
Paul Cercueil (1): MIPS: boot/compressed: Copy DTB to aligned address Thomas Bogendoerfer (1): MIPS: kernel: Reserve exception base early to prevent corruption arch/mips/boot/compressed/decompress.c | 8 arch/mips/crypto/Makefile | 4 ++-- arch/mips/include/asm

Re: [PATCH v11 5/6] staging: mt7621-dts: use valid vendor 'mediatek' instead of invalid 'mtk'

2021-03-09 Thread Thomas Bogendoerfer
k,mt7621-wdt', 'mtk,mt7621-nand', > 'mtk,mt7621-mc', and 'mtk,mt7621-cpc'. > > Acked-by: Greg Kroah-Hartman > Signed-off-by: Sergio Paracuellos > --- > arch/mips/ralink/mt7621.c | 6 +++--- Acked-by: Thomas Bogen

[PATCH] tool/perf: Perf build fails on 5.12.0rc2 on s390

2021-03-09 Thread Thomas Richter
d a value when it is defined. Output after: [root@m35lp76 perf]# make util/synthetic-events.o CC util/synthetic-events.o [root@m35lp76 perf]# Signed-off-by: Thomas Richter --- tools/perf/util/synthetic-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/

Re: [PATCH v3] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-09 Thread Thomas Bogendoerfer
On Mon, Mar 08, 2021 at 10:24:47AM +0100, Thomas Bogendoerfer wrote: > BMIPS is one of the few platforms that do change the exception base. > After commit 2dcb39645441 ("memblock: do not start bottom-up allocations > with kernel_end") we started seeing BMIPS boards fail to boot

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-09 Thread Thomas Bogendoerfer
On Sat, Mar 06, 2021 at 04:57:30PM +0800, zhangqing wrote: > > > On 03/06/2021 04:03 PM, Thomas Bogendoerfer wrote: > > as you are already touching mach-loongson64 files... > > > > Is there a chance you clean up that up even further ? My goal is to > > have only

[patch V3 3/6] softirq: Move various protections into inline helpers

2021-03-09 Thread Thomas Gleixner
To allow reuse of the bulk of softirq processing code for RT and to avoid #ifdeffery all over the place, split protections for various code sections out into inline helpers so the RT variant can just replace them in one go. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior

[patch V3 6/6] rcu: Prevent false positive softirq warning on RT

2021-03-09 Thread Thomas Gleixner
Soft interrupt disabled sections can legitimately be preempted or schedule out when blocking on a lock on RT enabled kernels so the RCU preempt check warning has to be disabled for RT kernels. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior Reviewed-by: Paul E. McKenney

[patch V3 5/6] tick/sched: Prevent false positive softirq pending warnings on RT

2021-03-09 Thread Thomas Gleixner
temporarily blocked as well which means that such a warning is a false positive. To prevent that check the per CPU state which indicates that a scheduled out task has soft interrupts disabled. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior Reviewed-by: Frederic Weisbecker

[patch V3 1/6] softirq: Add RT specific softirq accounting

2021-03-09 Thread Thomas Gleixner
relevant macros in preempt.h. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior Reviewed-by: Frederic Weisbecker --- include/linux/hardirq.h |1 + include/linux/preempt.h |6 +- include/linux/sched.h |3 +++ 3 files changed, 9 insertions(+), 1 deletion

[patch V3 4/6] softirq: Make softirq control and processing RT aware

2021-03-09 Thread Thomas Gleixner
Provide a local lock based serialization for soft interrupts on RT which allows the local_bh_disabled() sections and servicing soft interrupts to be preemptible. Provide the necessary inline helpers which allow to reuse the bulk of the softirq processing code. Signed-off-by: Thomas Gleixner

[patch V3 2/6] irqtime: Make accounting correct on RT

2021-03-09 Thread Thomas Gleixner
and$0x00,%eax Reported-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior Reviewed-by: Frederic Weisbecker --- kernel/sched/cputime.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/sched/cputime.c +++ b

[patch V3 0/6] softirq: Add RT specific softirq accounting

2021-03-09 Thread Thomas Gleixner
RT runs softirq processing always in thread context and it requires that both the softirq execution and the BH disabled sections are preemptible. This is achieved by serialization through per CPU local locks and substituting a few parts of the existing softirq processing code with helper functions

[patch 13/14] firewire: ohci: Use tasklet_disable_in_atomic() where required

2021-03-09 Thread Thomas Gleixner
Siewior Signed-off-by: Thomas Gleixner Cc: Stefan Richter Cc: linux1394-de...@lists.sourceforge.net --- drivers/firewire/ohci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -2545,7 +2545,7 @@ static int

[patch 14/14] tasklets: Switch tasklet_disable() to the sleep wait variant

2021-03-09 Thread Thomas Gleixner
-- NOT FOR IMMEDIATE MERGING -- Now that all users of tasklet_disable() are invoked from sleepable context, convert it to use tasklet_unlock_wait() which might sleep. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a

[patch 10/14] ath9k: Use tasklet_disable_in_atomic()

2021-03-09 Thread Thomas Gleixner
It's unclear how that can be distangled, so use tasklet_disable_in_atomic() for now. This allows tasklet_disable() to become sleepable once the remaining atomic users are cleaned up. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: ath9k-de...@qca.qualcomm.com

[patch 12/14] PCI: hv: Use tasklet_disable_in_atomic()

2021-03-09 Thread Thomas Gleixner
driver, so use tasklet_disable_in_atomic() which allows to make tasklet_disable() sleepable once the remaining atomic users are addressed. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Wei Liu C

[patch 11/14] atm: eni: Use tasklet_disable_in_atomic() in the send() callback

2021-03-09 Thread Thomas Gleixner
tasklet_disable_in_atomic() which allows tasklet_disable() to be made sleepable once the remaining atomic context usage sites are cleaned up. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Chas Williams <3ch...@gmail.com> Cc: linux-atm-gene...@lists.sourceforge.net C

[patch 08/14] net: jme: Replace link-change tasklet with work

2021-03-09 Thread Thomas Gleixner
become sleeping. Replace the linkch_task tasklet with a work. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner --- drivers/net/ethernet/jme.c | 10 +- drivers/net/ethernet/jme.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) --- a/drivers/net

[patch 09/14] net: sundance: Use tasklet_disable_in_atomic().

2021-03-09 Thread Thomas Gleixner
s are converted. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Denis Kirjanov Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org --- drivers/net/ethernet/dlink/sundance.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

[patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

2021-03-09 Thread Thomas Gleixner
processed on a different CPU then the local_bh_disable()/enable() pair is just a waste of processor cycles. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h |2 +- kernel/softirq.c | 28 +++- 2 files changed, 28

[patch 06/14] tasklets: Replace spin wait in tasklet_kill()

2021-03-09 Thread Thomas Gleixner
is scheduled out. tasklet_kill() is used in teardown paths and not performance critical at all. Replace the spin wait with wait_var_event(). Signed-off-by: Peter Zijlstra Signed-off-by: Thomas Gleixner --- kernel/softirq.c | 23 +++ 1 file changed, 15 insertions(+), 8

[patch 04/14] tasklets: Use spin wait in tasklet_disable() temporarily

2021-03-09 Thread Thomas Gleixner
To ease the transition use spin waiting in tasklet_disable() until all usage sites from atomic context have been cleaned up. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/include/linux/interrupt.h +++ b/include

[patch 05/14] tasklets: Replace spin wait in tasklet_unlock_wait()

2021-03-09 Thread Thomas Gleixner
fixed up and will be converted to the sleep wait variant later. Signed-off-by: Peter Zijlstra Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h | 13 ++--- kernel/softirq.c | 18 ++ 2 files changed, 20 insertions(+), 11 deletions(-) --- a/include

[patch 02/14] tasklets: Use static inlines for stub implementations

2021-03-09 Thread Thomas Gleixner
Inlines exist for a reason. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -676,9 +676,9 @@ static inline void

[patch 03/14] tasklets: Provide tasklet_disable_in_atomic()

2021-03-09 Thread Thomas Gleixner
() to convert the few atomic use cases over, which allows to change tasklet_disable() and tasklet_unlock_wait() in a later step. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h | 22 ++ 1 file changed, 22 insertions(+) --- a/include/linux/interrupt.h +++ b

[patch 00/14] tasklets: Replace the spin wait loops and make it RT safe

2021-03-09 Thread Thomas Gleixner
This is a follow up to the review comments of the series which makes softirq processing PREEMPT_RT safe: https://lore.kernel.org/r/20201207114743.gk3...@hirez.programming.kicks-ass.net Peter suggested to replace the spin waiting in tasklet_disable() and tasklet_kill() with wait_event(). This als

[patch 01/14] tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait()

2021-03-09 Thread Thomas Gleixner
A barrier() in a tight loop which waits for something to happen on a remote CPU is a pointless exercise. Replace it with cpu_relax() which allows HT siblings to make progress. Signed-off-by: Thomas Gleixner Tested-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h |3 ++- 1 file

[PATCH 3/3] crypto: ccp - update copyright year for tee

2021-03-09 Thread Rijo Thomas
Update the copyright year for PSP TEE driver files. Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 2 +- drivers/crypto/ccp/tee-dev.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/tee-dev.c b/drivers/crypto/ccp/tee-dev.c index

[PATCH 2/3] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-09 Thread Rijo Thomas
TEE request from a client, then further command submission to queue will be disabled. Fixes: 33960acccfbd (crypto: ccp - add TEE support for Raven Ridge) Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 49 +--- drivers/crypto/ccp/tee-dev.h | 18

[PATCH 0/3] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
helps to resolve that. Third patch is to update the copyright year for the tee driver files. Rijo Thomas (3): crypto: ccp - reduce tee command status polling interval from 5ms to 1ms crypto: ccp - fix command queuing to TEE ring buffer crypto: ccp - update copyright year for tee drivers

[PATCH 1/3] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-09 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers

Re: [PATCH v3] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-08 Thread Thomas Bogendoerfer
On Mon, Mar 08, 2021 at 10:21:10AM -0800, Florian Fainelli wrote: > On 3/8/21 1:24 AM, Thomas Bogendoerfer wrote: > > BMIPS is one of the few platforms that do change the exception base. > > After commit 2dcb39645441 ("memblock: do not start bottom-up allocations > > wi

Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

2021-03-08 Thread Thomas Bogendoerfer
On Mon, Mar 08, 2021 at 10:04:15AM -0700, Rob Herring wrote: > On Sat, Mar 6, 2021 at 3:59 PM Thomas Bogendoerfer > wrote: > > > > On Sat, Mar 06, 2021 at 02:35:21PM -0700, Rob Herring wrote: > > > On Sat, Mar 6, 2021 at 1:45 AM Thomas Bogendoerfer > > > w

Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

2021-03-08 Thread Thomas Bogendoerfer
arch/mips/kernel/vmlinux.lds.S | 2 ++ > 2 files changed, 10 insertions(+) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] crypto: mips/poly1305 - enable for all MIPS processors

2021-03-08 Thread Thomas Bogendoerfer
> $ > > Patch included, please apply. > > So while your change is surely right, what you want is this really. > > Maciej > --- > arch/mips/crypto/Makefile |4 ++-- > crypto/Kconfig|2 +- > drivers/net/Kconfig |2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-08 Thread Thomas Bogendoerfer
On Sat, Mar 06, 2021 at 06:55:41PM +0800, Jiaxun Yang wrote: > > > On Sat, Mar 6, 2021, at 5:53 PM, Thomas Bogendoerfer wrote: > [...] > > Just to understand you, you want > > > > arch/mips/include/asm/loongson/2ef > > arch/mips/include/asm/loongson/32 &

[PATCH v3] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-08 Thread Thomas Bogendoerfer
analysing and proposing a solution to this issue. Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations with kernel_end") Reported-by: Kamal Dasu Debugged-by: Serge Semin Signed-off-by: Thomas Bogendoerfer --- Changes in v3: - always reserve the first 4k for all CPUs (

Re: [PATCH v2 0/5] Add option to mmap GEM buffers cached

2021-03-08 Thread Thomas Zimmermann
s mapping flags in struct drm_gem_object. Best regards Thomas Am 07.03.21 um 21:28 schrieb Paul Cercueil: Rework of my previous patchset which added support for GEM buffers backed by non-coherent memory to the ingenic-drm driver. Having GEM buffers backed by non-coherent memory is interest

Re: [PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-07 Thread Thomas Bogendoerfer
the conditional statement you've added? some of them are not R2 (SB1), others are. So best bet would be to simply reserve the first 0x1000 bytes for every CPU and special handling for the BMIPS case. Does this cover all cases ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

[PATCH RESEND v2 STABLE 4.4] futex: fix irq self-deadlock and satisfy assertion

2021-03-06 Thread Thomas Schoebel-Theuer
From: Thomas Schoebel-Theuer This patch and problem analysis is specific for 4.4 LTS, due to incomplete backporting of other fixes. Later LTS series have different backports. Since v4.4.257 when CONFIG_PROVE_LOCKING=y the following triggers right after reboot of our pre-life systems which equal

[PATCH RESEND v2 STABLE 4.4] futex: fix spin_lock() / spin_unlock_irq() imbalance

2021-03-06 Thread Thomas Schoebel-Theuer
From: Thomas Schoebel-Theuer This patch and problem analysis is specific for 4.4 LTS, due to incomplete backporting of other fixes. Later LTS series have different backports. The following is obviously incorrect: static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this

[PATCH] tee: amdtee: unload TA only when its refcount becomes 0

2021-03-06 Thread Rijo Thomas
: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/tee/amdtee/amdtee_private.h | 13 + drivers/tee/amdtee/call.c | 73 +++-- drivers/tee/amdtee/core.c | 15 +++--- 3 files changed, 92

Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

2021-03-06 Thread Thomas Bogendoerfer
On Sat, Mar 06, 2021 at 02:35:21PM -0700, Rob Herring wrote: > On Sat, Mar 6, 2021 at 1:45 AM Thomas Bogendoerfer > wrote: > > > > On Wed, Mar 03, 2021 at 02:37:55PM -0600, Rob Herring wrote: > > > On Wed, Mar 3, 2021 at 1:33 PM Paul Cercueil wrote: > > >

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-06 Thread Thomas Bogendoerfer
On Sat, Mar 06, 2021 at 05:00:15PM +0800, Jiaxun Yang wrote: > > > On Sat, Mar 6, 2021, at 4:03 PM, Thomas Bogendoerfer wrote: > > On Thu, Mar 04, 2021 at 07:00:57PM +0800, Qing Zhang wrote: > > > The purpose of separating loongson_system_configuration from boot_para

Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

2021-03-06 Thread Thomas Bogendoerfer
ed some of the many ways MIPS can have a dtb. Appended and > built-in DTBs were supposed to be temporary. :( and a fdt can also be provided by firmware. And according to spec there is no aligmnet requirement. So this whole change will break then. What was the reason for the whole churn ? Thomas

[PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-06 Thread Thomas Bogendoerfer
t(). Huge thanks to Serget for analysing and proposing a solution to this issue. Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations with kernel_end") Reported-by: Kamal Dasu Debugged-by: Serge Semin Signed-off-by: Thomas Bogendoerfer --- Changes in v2: - do only mem

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-06 Thread Thomas Bogendoerfer
; This isn't a bomb really: 63 insertions(+), 48 deletions(-) > > > > Too many changes at once for my brain stack doesn't mean others are > > willing to review it. But to me that means each time I'll have to pass over > > it while bisecting or reviewing git h

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-06 Thread Thomas Bogendoerfer
ich have an mach-generic counterpart. Everything else should go to its own directory. So in case of loongson something like arch/mips/include/asm/loongson for common stuff arch/mips/include/asm/loongson/32 arch/mips/include/asm/loongson/64 Comments ? Thomas. -- Crap can work. Given eno

[PATCH STABLE 4.4] futex: fix irq self-deadlock and satisfy assertion

2021-03-05 Thread Thomas Schoebel-Theuer
From: Thomas Schoebel-Theuer Since v4.4.257 when CONFIG_PROVE_LOCKING=y the following triggers right after reboot of our pre-life systems which equal our production setup: Mar 03 11:27:33 icpu-test-bap10 kernel: = Mar 03 11:27:33 icpu-test-bap10 kernel: [ INFO

[PATCH STABLE 4.4] futex: fix spin_lock() / spin_unlock_irq() imbalance

2021-03-05 Thread Thomas Schoebel-Theuer
From: Thomas Schoebel-Theuer The following is obviously incorrect: static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this, struct futex_hash_bucket *hb) { [...] raw_spin_lock(&pi_state->pi_mutex.wait_lock); [...] raw_spin_unlock_irq(&a

Re: [PATCH] MIPS: Support large stack.

2021-03-05 Thread Thomas Bogendoerfer
On Fri, Mar 05, 2021 at 11:12:57AM +0800, HongJieDeng wrote: > From: Hongjie Deng > > We need more stack space, xori/ori no longer apply when > _THREAD_MASK exceeds 16 bits who is we and why do need more ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it'

Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct

2021-03-04 Thread Thomas Gleixner
On Wed, Mar 03 2021 at 16:37, Oleg Nesterov wrote: > On 03/03, Sebastian Andrzej Siewior wrote: >> +static void __sigqueue_cache_or_free(struct sigqueue *q) >> +{ >> +struct user_struct *up; >> + >> +if (q->flags & SIGQUEUE_PREALLOC) >> +return; >> + >> +up = q->user; >> +

Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct

2021-03-04 Thread Thomas Gleixner
On Wed, Mar 03 2021 at 16:37, Oleg Nesterov wrote: > On 03/03, Sebastian Andrzej Siewior wrote: >> >> +static struct sigqueue *sigqueue_from_cache(struct task_struct *t) >> +{ >> +struct sigqueue *q = t->sigqueue_cache; >> + >> +if (q && cmpxchg(&t->sigqueue_cache, q, NULL) == q) >> +

Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct

2021-03-04 Thread Thomas Gleixner
On Thu, Mar 04 2021 at 13:04, Eric W. Biederman wrote: > Thomas Gleixner writes: >> >> We could of course do the caching unconditionally for all tasks. > > Is there any advantage to only doing this for realtime tasks? It was mostly to avoid tons of cached entries hangin

Re: [tip: irq/core] genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()

2021-03-04 Thread Thomas Gleixner
Dmitry, On Thu, Mar 04 2021 at 11:57, Thomas Gleixner wrote: > On Thu, Mar 04 2021 at 10:53, tip-bot wrote: > >> The following commit has been merged into the irq/core branch of tip: >> >> Commit-ID: e749df1bbd23f4472082210650514548d8a39e9b >> Gitweb:

Re: futex breakage in 4.9 stable branch

2021-03-04 Thread Thomas Gleixner
On Thu, Mar 04 2021 at 10:12, Mike Galbraith wrote: > On Mon, 2021-03-01 at 18:29 +0100, Ben Hutchings wrote: > > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -874,8 +874,12 @@ static void free_pi_state(struct futex_p >* and has cleaned up the pi_state already >*/ > if (pi

[patch 2/7] drm/vmgfx: Replace kmap_atomic()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a

[patch 1/7] drm/ttm: Replace kmap_atomic() usage

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a

[patch 6/7] drm/i915: Replace io_mapping_map_atomic_wc()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, and clean up gtt_user_read() and gtt_user_write() to use a plain copy_from_user() as the local maps are not disabling pagefaults. Signed-off-by

[patch 4/7] drm/qxl: Replace io_mapping_map_atomic_wc()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, rename the related functions accordingly and clean up qxl_process_single_command() to use a plain copy_from_user() as the local maps are not

[patch 7/7] io-mapping: Remove io_mapping_map_atomic_wc()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner No more users. Get rid of it and remove the traces in documentation. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- Documentation/driver-api/io-mapping.rst | 22 +--- include/linux/io-mapping.h | 42

[patch 5/7] drm/nouveau/device: Replace io_mapping_map_atomic_wc()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner Neither fbmem_peek() nor fbmem_poke() require to disable pagefaults and preemption as a side effect of io_mapping_map_atomic_wc(). Use io_mapping_map_local_wc() instead. Signed-off-by: Thomas Gleixner Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-de

[patch 3/7] highmem: Remove kmap_atomic_prot()

2021-03-04 Thread Thomas Gleixner
From: Thomas Gleixner No more users. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- include/linux/highmem-internal.h | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem

[patch 0/7] drm, highmem: Cleanup io/kmap_atomic*() usage

2021-03-04 Thread Thomas Gleixner
None of the DRM usage sites of temporary mappings requires the side effects of io/kmap_atomic(), i.e. preemption and pagefault disable. Replace them with the io/kmap_local() variants, simplify the copy_to/from_user() error handling and remove the atomic variants. Thanks, tglx --- Docume

Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct

2021-03-04 Thread Thomas Gleixner
On Thu, Mar 04 2021 at 09:11, Sebastian Andrzej Siewior wrote: > On 2021-03-03 16:09:05 [-0600], Eric W. Biederman wrote: >> Sebastian Andrzej Siewior writes: >> >> > From: Thomas Gleixner >> > >> > Allow realtime tasks to cache one sigqueue in task st

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-04 Thread Thomas Gleixner
Feng, On Thu, Mar 04 2021 at 15:43, Feng Tang wrote: > On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: >> Anything pre TSC_ADJUST wants the watchdog on. With TSC ADJUST available >> we can probably avoid it. >> >> There is a caveat though. If the machi

Re: [tip: irq/core] genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()

2021-03-04 Thread Thomas Gleixner
thor:Barry Song > AuthorDate:Wed, 03 Mar 2021 11:49:15 +13:00 > Committer: Thomas Gleixner > CommitterDate: Thu, 04 Mar 2021 11:47:52 +01:00 > > genirq: Add IRQF_NO_AUTOEN for request_irq/nmi() this commit is immutable and I tagged it so you can pull it into your tre

Re: [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-04 Thread Thomas Zimmermann
g support */ - drm_encoder_init(ddev, encoder, <dc_encoder_funcs, -DRM_MODE_ENCODER_DPI, NULL); + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI); drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs); -- Thomas Zimmermann Graphics Driver Develope

Re: drm/ttm: ttm_bo_release called without lock

2021-03-03 Thread Thomas Zimmermann
freedesktop.org/mailman/listinfo/dri-devel -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature

[PATCH] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-03 Thread Thomas Bogendoerfer
t(). Huge thanks to Serget for analysing and proposing a solution to this issue. Fixes: Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations with kernel_end") Debugged-by: Serge Semin Reported-by: Kamal Dasu Signed-off-by: Thomas Bogendoerfer --- arch/mips/include

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Thomas Bogendoerfer
On Wed, Mar 03, 2021 at 06:45:52PM +0100, Maciej W. Rozycki wrote: > On Wed, 3 Mar 2021, Thomas Bogendoerfer wrote: > > > perfect, I only forgot about R3k... I'll submit a formal patch submission > > later today. > > What's up with the R3k (the usual tri

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-03 Thread Thomas Gleixner
On Tue, Mar 02 2021 at 20:06, Feng Tang wrote: > On Tue, Mar 02, 2021 at 10:16:37AM +0100, Peter Zijlstra wrote: >> On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: >> > clocksource watchdog runs every 500ms, which creates some OS noise. >> > As the clocksource wreckage (especially for th

Re: [PATCH] x86/tsc: mark tsc reliable for qualified platforms

2021-03-03 Thread Thomas Gleixner
o protect the innocent tsc, Thomas Gleixner proposed [1]: > > "I'm inclined to lift that requirement when the CPU has: > > 1) X86_FEATURE_CONSTANT_TSC > 2) X86_FEATURE_NONSTOP_TSC > 3) X86_FEATURE_NONSTOP_TSC_S3 > 4) X86_FEATURE_TSC_ADJUST > 5) A

[patch 2/2] highmem: Remove kmap_atomic_pfn()

2021-03-03 Thread Thomas Gleixner
From: Thomas Gleixner No more users. Signed-off-by: Thomas Gleixner Cc: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- include/linux/highmem-internal.h | 12 1 file changed, 12 deletions(-) --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem

[patch 1/2] ARM: mm: Replace kmap_atomic_pfn()

2021-03-03 Thread Thomas Gleixner
From: Thomas Gleixner There is no requirement to disable pagefaults and preemption for these cache management mappings. Replace kmap_atomic_pfn() with kmap_local_pfn(). This allows to remove kmap_atomic_pfn() in the next step. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: linux-arm-ker

[patch 0/2] highmem/ARM: kmap_atomic cleanups

2021-03-03 Thread Thomas Gleixner
The last users of kmap_atomic_pfn() are in arch/arm and none of them requires the kmap_atomic semantics. Replace them with kmap_local_pfn() and remove kmap_atomic_pfn(). Thanks, tglx

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Thomas Bogendoerfer
On Tue, Mar 02, 2021 at 05:30:18PM -0800, Florian Fainelli wrote: > > > On 3/2/2021 3:54 PM, Thomas Bogendoerfer wrote: > > On Mon, Mar 01, 2021 at 08:19:38PM -0800, Florian Fainelli wrote: > >> BMIPS is one of the few platforms that do change the exception base. > &

Re: [PATCH] perf test: Test case 27 fails on s390 and non-x86 platforms

2021-03-03 Thread Thomas Richter
On 3/2/21 9:10 PM, Liang, Kan wrote: > > > On 3/2/2021 12:08 PM, Thomas Richter wrote: >> On 3/2/21 4:23 PM, Liang, Kan wrote: >>> >>> >>> On 3/2/2021 9:48 AM, Thomas Richter wrote: >>>> On 3/2/21 3:03 PM, Liang, Kan wrote: >>>&

Re: [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-03 Thread Thomas Zimmermann
Am 02.03.21 um 18:57 schrieb Jagan Teki: STM ltdc driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Jagan Teki Acked-by: Thomas Zimmermann --- drivers/gpu/drm/stm/ltdc.c | 12 ++-- 1 file changed, 2

Re: [PATCH v2] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs

2021-03-03 Thread Thomas Bogendoerfer
On Mon, Mar 01, 2021 at 05:27:46PM +0100, Jason A. Donenfeld wrote: > Hey Thomas, > > Would you mind sending this for 5.12 in an rc at some point, rather > than waiting for 5.13? I'd like to see this backported to 5.10 and 5.4 > for OpenWRT. why is this so important for Open

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Thomas Bogendoerfer
quot;memblock: do not start bottom-up allocations > with kernel_end") > Debugged-by: Serge Semin > Reported-by: Kamal Dasu > Signed-off-by: Florian Fainelli > --- > Thomas, > > This is intended as a stop-gap solution for 5.12-rc1 and to be picked up > by the sta

Re: [PATCH] perf test: Test case 27 fails on s390 and non-x86 platforms

2021-03-02 Thread Thomas Richter
On 3/2/21 4:23 PM, Liang, Kan wrote: > > > On 3/2/2021 9:48 AM, Thomas Richter wrote: >> On 3/2/21 3:03 PM, Liang, Kan wrote: >>> >>> + Athira Rajeev >>> >>> On 3/2/2021 8:31 AM, Thomas Richter wrote: >>>> Executing perf test 27

Re: [PATCH] perf test: Test case 27 fails on s390 and non-x86 platforms

2021-03-02 Thread Thomas Richter
On 3/2/21 3:03 PM, Liang, Kan wrote: > > + Athira Rajeev > > On 3/2/2021 8:31 AM, Thomas Richter wrote: >> Executing perf test 27 fails on s390: >>   [root@t35lp46 perf]# ./perf test -Fv 27 >>   27: Sample parsing >>   --- start --- >>   end --

[PATCH] perf test: Test case 27 fails on s390 and non-x86 platforms

2021-03-02 Thread Thomas Richter
@t35lp46 perf]# Fixes: commit c7444297fd3769 ("perf test: Support PERF_SAMPLE_WEIGHT_STRUCT") Signed-off-by: Thomas Richter --- tools/perf/util/evsel.c| 8 +--- tools/perf/util/synthetic-events.c | 6 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff

Re: [PATCH] drm/fb-helper: only unmap if buffer not null

2021-03-02 Thread Thomas Zimmermann
ot being called, thus fb_helper->buffer remains NULL -- Since there could be the case that the fb_probe is never called, a subsequent modprobe -r will cause the following drm_client_buffer_vunmap(NULL) in drm_fbdev_cleanup() Thanks! I added Fixes tags to your patch and merged it into drm-misc-fix

Re: [PATCH v2 2/3] x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls

2021-03-01 Thread Thomas Gleixner
On Tue, Feb 23 2021 at 10:15, Andy Lutomirski wrote: > On a 32-bit fast syscall that fails to read its arguments from user > memory, the kernel currently does syscall exit work but not > syscall entry work. This confuses audit and ptrace. For example: > > $ ./tools/testing/selftests/x86/sysca

[PATCH 2/2] MIPS: Remove KVM_TE support

2021-03-01 Thread Thomas Bogendoerfer
After removal of the guest part of KVM TE (trap and emulate), also remove the host part. Signed-off-by: Thomas Bogendoerfer --- arch/mips/configs/loongson3_defconfig |1 - arch/mips/include/asm/kvm_host.h | 238 arch/mips/kvm/Kconfig | 34 - arch/mips/kvm

[PATCH 1/2] MIPS: Remove KVM_GUEST support

2021-03-01 Thread Thomas Bogendoerfer
KVM_GUEST is broken and unmaintained, so let's remove it. Signed-off-by: Thomas Bogendoerfer --- arch/mips/Kconfig | 17 - arch/mips/configs/malta_kvm_guest_defconfig | 436 arch/mips/include/asm/mach-generic/spaces.h | 12 - arch/mips/in

Re: [PATCH 2/2] MIPS: enable GENERIC_FIND_FIRST_BIT

2021-03-01 Thread Thomas Bogendoerfer
> > Suggested-by: Yury Norov > Signed-off-by: Alexander Lobakin > Signed-off-by: Yury Norov > --- > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] mips: cavium: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-03-01 Thread Thomas Bogendoerfer
Li > --- > arch/mips/cavium-octeon/oct_ilm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

<    1   2   3   4   5   6   7   8   9   10   >