Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning

2015-05-15 Thread vasu....@linux.intel.com
On Fri, 2015-05-15 at 09:14 +0200, Nicholas Mc Guire wrote: > On Thu, 14 May 2015, Prasad Gondi wrote: > > > It seems like rpriv is used to set the fsp->tgt_flags originally > > > > > fsp->tgt_flags = rpriv->flags > > > > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this > > > >

Re: [Open-FCoE] [PATCH] scsi: match wait_for_completion_timeout return type

2015-05-14 Thread vasu....@linux.intel.com
On Thu, 2015-05-14 at 20:12 +0200, Nicholas Mc Guire wrote: > Return type of wait_for_completion_timeout is unsigned long not int. > An appropriately named unsigned long is added, and the assignments > as well as error checking fixed up. > > API conformance testing for completions with coccinelle

Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning

2015-05-14 Thread vasu....@linux.intel.com
On Thu, 2015-05-14 at 20:12 +0200, Nicholas Mc Guire wrote: > commit "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct" > removed the last usage of rpriv (rpriv->flags) but forgot to remove > the unused rpriv struct resulting in: > drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':