Re: [PATCH v7 0/4] New Microsemi PCI Switch Management Driver

2017-03-09 Thread Wei Zhang
This is great! Thanks Bjorn and Logan for getting this drivers upstreamed! -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 3/9/17, 11:56 AM, "Logan Gunthorpe" <log...@deltatee.com> wrote: On 09/03/17 12:55 PM, Bjorn Helgaas wrot

Re: [PATCH v7 0/4] New Microsemi PCI Switch Management Driver

2017-03-09 Thread Wei Zhang
This is great! Thanks Bjorn and Logan for getting this drivers upstreamed! -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 3/9/17, 11:56 AM, "Logan Gunthorpe" wrote: On 09/03/17 12:55 PM, Bjorn Helgaas wrote: > Applied to

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-09 Thread Wei Zhang
Corrections to the email below. It should be Tested-by: Krishna Dhulipala krish...@fb.com Reviewed-by: Wei Zhang wzh...@fb.com Thanks, -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 2/9/17, 3:16 PM, "Wei Zhang" <wzh...@fb.com>

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-09 Thread Wei Zhang
Corrections to the email below. It should be Tested-by: Krishna Dhulipala krish...@fb.com Reviewed-by: Wei Zhang wzh...@fb.com Thanks, -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 2/9/17, 3:16 PM, "Wei Zhang" wrot

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-09 Thread Wei Zhang
...@fb.com Tested-by: Wei Zhang wzh...@fb.com Thanks, -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 2/2/17, 10:05 AM, "Logan Gunthorpe" <log...@deltatee.com> wrote: Changes since v1: * Rebased onto 4.10-rc6 (cleanly) * Split the

Re: [PATCH v2 0/4] New Microsemi PCI Switch Management Driver

2017-02-09 Thread Wei Zhang
...@fb.com Tested-by: Wei Zhang wzh...@fb.com Thanks, -Wei -- wei zhang | software engineer | facebook wzh...@fb.com | (408) 460-4803 On 2/2/17, 10:05 AM, "Logan Gunthorpe" wrote: Changes since v1: * Rebased onto 4.10-rc6 (cleanly) * Split the patch into a few more easily

[PATCH v2] net: fix incorrect original ingress device index in PKTINFO

2016-12-29 Thread Wei Zhang
interface dnsmasq bind to) Fixes: 0b922b7a829c ("net: original ingress device index in PKTINFO") Acked-by: David Ahern <d...@cumulusnetworks.com> Signed-off-by: Wei Zhang <asuka@163.com> --- v2: - add the missing Fixes line - better comment come from David Ahern net/ipv4/ip

[PATCH v2] net: fix incorrect original ingress device index in PKTINFO

2016-12-29 Thread Wei Zhang
interface dnsmasq bind to) Fixes: 0b922b7a829c ("net: original ingress device index in PKTINFO") Acked-by: David Ahern Signed-off-by: Wei Zhang --- v2: - add the missing Fixes line - better comment come from David Ahern net/ipv4/ip_sockglue.c | 8 +++- 1 file changed, 7 insertions(+),

[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread Wei Zhang
interface dnsmasq bind to) Signed-off-by: Wei Zhang <asuka@163.com> --- net/ipv4/ip_sockglue.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index b8a2d63..76d78a7 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ip

[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread Wei Zhang
interface dnsmasq bind to) Signed-off-by: Wei Zhang --- net/ipv4/ip_sockglue.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index b8a2d63..76d78a7 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ipv4/ip_sockglue.c @@ -1202,

Re:[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread wei zhang
At 2016-12-27 15:52:18, "Wei Zhang" <asuka@163.com> wrote: >When we send a packet for our own local address on a non-loopback interface >(e.g. eth0), due to the change had been introduced from commit 0b922b7a829c >("net: original ingress device index in PKTINFO&q

Re:[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread wei zhang
At 2016-12-27 15:52:18, "Wei Zhang" wrote: >When we send a packet for our own local address on a non-loopback interface >(e.g. eth0), due to the change had been introduced from commit 0b922b7a829c >("net: original ingress device index in PKTINFO"), the original ingre

[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-26 Thread Wei Zhang
the packet should be considered as if it is being arrived via the sending interface (eth0), otherwise it would break the expectation of the userspace application (e.g. the DHCPRELEASE message from dhcp_release binary would be ignored by the dnsmasq daemon) Signed-off-by: Wei Zhang <asuka@163.

[PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-26 Thread Wei Zhang
the packet should be considered as if it is being arrived via the sending interface (eth0), otherwise it would break the expectation of the userspace application (e.g. the DHCPRELEASE message from dhcp_release binary would be ignored by the dnsmasq daemon) Signed-off-by: Wei Zhang --- net/ipv4/ip_

Re: [PATCH v2] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-04 Thread wei zhang
At 2014-04-05 07:05:59,"Jesse Gross"  wrote: >On Tue, Apr 1, 2014 at 5:23 PM, Wei Zhang  wrote: >> >> v2 -> v1: use the same logic of the gre_rcv() to distinguish which packet is >> intended to us! > >As a tip on kernel process: if you put the versi

Re: [PATCH v2] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-04 Thread wei zhang
At 2014-04-05 07:05:59,Jesse Gross je...@nicira.com wrote: On Tue, Apr 1, 2014 at 5:23 PM, Wei Zhang asuka@163.com wrote:  v2 - v1: use the same logic of the gre_rcv() to distinguish which packet is  intended to us! As a tip on kernel process: if you put the version information after three

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-01 Thread wei zhang
At 2014-04-02 02:27:56,"Jesse Gross"  wrote: >On Tue, Apr 1, 2014 at 8:24 AM, wei zhang  wrote: >> At 2014-04-01 08:49:53,"Jesse Gross"  wrote: >>>On Sun, Mar 30, 2014 at 5:12 AM, wei zhang  wrote: >>>> At 2014-03-29 06:02:25,"Jesse Gross&qu

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-01 Thread wei zhang
At 2014-04-01 08:49:53,"Jesse Gross"  wrote: >On Sun, Mar 30, 2014 at 5:12 AM, wei zhang  wrote: >> At 2014-03-29 06:02:25,"Jesse Gross"  wrote: >> Maybe I misunderstand something? I think if we discard all packet pass to us >> when we use gre vpor

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-01 Thread wei zhang
At 2014-04-01 08:49:53,Jesse Gross je...@nicira.com wrote: On Sun, Mar 30, 2014 at 5:12 AM, wei zhang asuka@163.com wrote:  At 2014-03-29 06:02:25,Jesse Gross je...@nicira.com wrote:  Maybe I misunderstand something? I think if we discard all packet pass to us  when we use gre vport, new

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-01 Thread wei zhang
At 2014-04-02 02:27:56,Jesse Gross je...@nicira.com wrote: On Tue, Apr 1, 2014 at 8:24 AM, wei zhang asuka@163.com wrote:  At 2014-04-01 08:49:53,Jesse Gross je...@nicira.com wrote: On Sun, Mar 30, 2014 at 5:12 AM, wei zhang asuka@163.com wrote:  At 2014-03-29 06:02:25,Jesse Gross je

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-03-30 Thread wei zhang
sh the packet which is realy intended to it, although it could not always get the key from the icmp packet. Should we do as the same as it? I'm not sure this is feasible, any advice is appreciate. Regards, Wei Zhang N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~

Re: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-03-30 Thread wei zhang
 is realy intended to it, although it could not always get the key from the icmp packet. Should we do as the same as it? I'm not sure this is feasible, any advice is appreciate. Regards, Wei Zhang N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w

Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-25 Thread wei zhang
At 2014-03-25 03:14:17,"David Miller"  wrote: >From: Wei Zhang  >Date: Mon, 24 Mar 2014 15:34:31 +0800 > >> When use the gre vport, openvswitch register a gre_cisco_protocol but >> does not supply a err_handler with it. The gre_cisco_err() call the >> err_h

Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-25 Thread wei zhang
At 2014-03-25 03:14:17,David Miller da...@davemloft.net wrote: From: Wei Zhang asuka@163.com Date: Mon, 24 Mar 2014 15:34:31 +0800  When use the gre vport, openvswitch register a gre_cisco_protocol but  does not supply a err_handler with it. The gre_cisco_err() call the  err_handler without

Re:[PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-24 Thread wei zhang
The crash is occur on Centos 6.4, when we use gre vport of openvswitch! <1>BUG: unable to handle kernel NULL pointer dereference at (null) <1>IP: [<(null)>] (null) <4>PGD c2910b067 PUD c2927d067 PMD 0  <4>Oops: 0010 [#1] SMP  <4>last sysfs file: /sys/devices/virtual/net/gretap0/flags <4>CPU 20 

[PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-24 Thread Wei Zhang
When use the gre vport, openvswitch register a gre_cisco_protocol but does not supply a err_handler with it. The gre_cisco_err() call the err_handler without existence check, cause the kernel crash. This patch base on v3.14-rc7. But the bug affect all kernel newer than 3.11! Signed-off-by: Wei

[PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-24 Thread Wei Zhang
When use the gre vport, openvswitch register a gre_cisco_protocol but does not supply a err_handler with it. The gre_cisco_err() call the err_handler without existence check, cause the kernel crash. This patch base on v3.14-rc7. But the bug affect all kernel newer than 3.11! Signed-off-by: Wei

Re:[PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()

2014-03-24 Thread wei zhang
The crash is occur on Centos 6.4, when we use gre vport of openvswitch! 1BUG: unable to handle kernel NULL pointer dereference at (null) 1IP: [(null)] (null) 4PGD c2910b067 PUD c2927d067 PMD 0  4Oops: 0010 [#1] SMP  4last sysfs file: /sys/devices/virtual/net/gretap0/flags 4CPU 20  4Modules linked