Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit

On 04/25 Christian wrote: >On Wed, Apr 24, 2019 at 6:16 PM Oleg Nesterov wrote: >> >> On 04/24, weizhenliang wrote: >> > >> > On 04/24, Oleg wrote: >> > >On 04/24, Christian Brauner wrote: >> > >> >> > >> On Wed, Apr 24, 2

Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit

On 04/24, Oleg wrote: >On 04/24, Christian Brauner wrote: >> >> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote: >> >> > Reviewed-by: Oleg Nesterov > >Yes, but ... > >> > Reported-by: kbuild test robot > >Hmm, really? Yes, the kbuild test robot says that if I fix the problem with t

Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit

On 04/24, Christian Brauner wrote: >On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote: >> >> Acked-by: Christian Brauner > >I think we're supposed to use more Reviewed-bys so feel free (or Andrew) to >change this to: > >Reviewed-by: Christian Brauner Ok, I will change this in patch

Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On 04/23, Greg KH wrote: >On Mon, Apr 22, 2019 at 10:59:50PM +0800, Zhenliang Wei wrote: >> In the fixes commit, removing SIGKILL from each thread signal mask and >> executing "goto fatal" directly will skip the call to >> "trace_signal_deliver". At this point, the delivery tracking of the >> SI

Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On 04/23, Oleg wrote: >On 04/23, weizhenliang wrote: >> >> Last time Oleg suggested using SIG_DFL as the third parameter, but its type >> is 'void (*)(int)', but not expected 'struct k_sigaction *'. > >Yes I misread the signature of TRACE_EVEN

Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On Tue, Apr 23, 2019 at 09:41 PM Christian wrote: >On Tue, Apr 23, 2019 at 01:10:52PM +0000, weizhenliang wrote: >> On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov wrote: >> >On 04/22, Zhenliang Wei wrote: >> >> >> >> --- a/kernel/signal.c >> &

Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov wrote: >On 04/22, Zhenliang Wei wrote: >> >> --- a/kernel/signal.c >> +++ b/kernel/signal.c >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig) >> if (signal_group_exit(signal)) { >> ksig->info.si_signo = signr = SIGKILL;

Re: [PATCH v2] signal: trace_signal_deliver when signal_group_exit

On Mon, Apr 22, 2019 at 6:37 PM Christian Brauner wrote: >On Mon, Apr 22, 2019 at 8:57 AM Zhenliang Wei wrote: >> >> In the following commit, removing SIGKILL from each thread signal mask >> and executing "goto fatal" directly will skip the call to >> "trace_signal

RE: [PATCH] signal: trace_signal_deliver when signal_group_exit

On 04/20, Oleg Nesterov wrote: >On 04/20, Zhenliang Wei wrote: >> >> --- a/kernel/signal.c >> +++ b/kernel/signal.c >> @@ -2441,6 +2441,8 @@ bool get_signal(struct ksignal *ksig) >> if (signal_group_exit(signal)) { >> ksig->info.si_signo = signr = SIGKILL; >> sigdelse