Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand_scan()

2018-07-25 Thread xiaolei li
On Thu, 2018-07-26 at 08:49 +0200, Miquel Raynal wrote: > Hi xiaolei, > > xiaolei li wrote on Thu, 26 Jul 2018 14:46:29 > +0800: > > > On Thu, 2018-07-26 at 08:14 +0200, Boris Brezillon wrote: > > > On Thu, 26 Jul 2018 14:06:41 +0800 > > > xiaolei li wro

Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand_scan()

2018-07-25 Thread xiaolei li
On Thu, 2018-07-26 at 08:14 +0200, Boris Brezillon wrote: > On Thu, 26 Jul 2018 14:06:41 +0800 > xiaolei li wrote: > > > On Sat, 2018-07-21 at 19:10 +0200, Boris Brezillon wrote: > > > On Fri, 20 Jul 2018 17:15:06 +0200 > > > Miquel Raynal wrote: > > >

Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand_scan()

2018-07-25 Thread xiaolei li
On Sat, 2018-07-21 at 19:10 +0200, Boris Brezillon wrote: > On Fri, 20 Jul 2018 17:15:06 +0200 > Miquel Raynal wrote: > > > Two helpers have been added to the core to make ECC-related > > configuration between the detection phase and the final NAND scan. Use > > these hooks and convert the driver

Re: [PATCH] mtd: nand: mtk: use of_device_get_match_data()

2018-04-15 Thread xiaolei li
); > - if (!of_ecc_id) > - return -ENODEV; > - > - ecc->caps = of_ecc_id->data; > + ecc->caps = of_device_get_match_data(dev); > Thanks. Reviewed-by: Xiaolei Li > max_eccdata_size = ecc->caps->num_ecc_strength - 1; > max_e