Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Stephen, On 2016/2/26 7:42, Stephen Boyd wrote: >> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c >> new file mode 100644 >> index 000..50e00e7 >> --- /dev/null >> +++ b/drivers/clk/hisilicon/reset.c >> + >> +int hisi_reset_init(struct device_node *np) >> +{ >>

Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Stephen, On 2016/2/26 7:42, Stephen Boyd wrote: >> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c >> new file mode 100644 >> index 000..50e00e7 >> --- /dev/null >> +++ b/drivers/clk/hisilicon/reset.c >> + >> +int hisi_reset_init(struct device_node *np) >> +{ >>

Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Stephen, Thank you for your advice. I'll fixed them in next version. Regards, Jiancheng. On 2016/2/26 7:42, Stephen Boyd wrote: > On 02/22, Jiancheng Xue wrote: >> diff --git a/Documentation/devicetree/bindings/clock/hi3519-crg.txt >>

Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Stephen, Thank you for your advice. I'll fixed them in next version. Regards, Jiancheng. On 2016/2/26 7:42, Stephen Boyd wrote: > On 02/22, Jiancheng Xue wrote: >> diff --git a/Documentation/devicetree/bindings/clock/hi3519-crg.txt >>

Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi all, I'll fix this warning in next version. Other comments will be appreciated! Thank you! On 2016/2/22 18:01, kbuild test robot wrote: > Hi Jiancheng, > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on v4.5-rc5 next-20160222] > [if your patch is applied to the

Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi all, I'll fix this warning in next version. Other comments will be appreciated! Thank you! On 2016/2/22 18:01, kbuild test robot wrote: > Hi Jiancheng, > > [auto build test WARNING on clk/clk-next] > [also build test WARNING on v4.5-rc5 next-20160222] > [if your patch is applied to the

Re: [RESEND PATCH v8 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike, Thank you very much for your comments. On 2016/2/17 8:46, Michael Turquette wrote: > Hello Jiancheng Xue, > > Quoting Jiancheng Xue (2016-02-04 18:31:07) >> diff --git a/drivers/clk/hisilicon/Makefile b/drivers/clk/hisilicon/Makefile >> index 74dba31..3f57b09 100644 >> ---

Re: [RESEND PATCH v8 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike, Thank you very much for your comments. On 2016/2/17 8:46, Michael Turquette wrote: > Hello Jiancheng Xue, > > Quoting Jiancheng Xue (2016-02-04 18:31:07) >> diff --git a/drivers/clk/hisilicon/Makefile b/drivers/clk/hisilicon/Makefile >> index 74dba31..3f57b09 100644 >> ---

Re: [PATCH v5] mtd: spi-nor: add hisilicon spi-nor flash controller driver

Hi Ezequiel, Thank you very much for your comments. I read them carefully. All of your suggestions are very good and helpful. I will correct in next version. Regards, Jiancheng . On 2016/1/29 22:45, Ezequiel Garcia wrote: > Hi Jiancheng, > > Driver looks mostly good. Few comments below. > >

Re: [PATCH v5] mtd: spi-nor: add hisilicon spi-nor flash controller driver

Hi Ezequiel, Thank you very much for your comments. I read them carefully. All of your suggestions are very good and helpful. I will correct in next version. Regards, Jiancheng . On 2016/1/29 22:45, Ezequiel Garcia wrote: > Hi Jiancheng, > > Driver looks mostly good. Few comments below. > >

Re: [PATCH v7 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Paul Bolle， Thank you for your reply. On 2016/1/26 9:17, Paul Bolle wrote: > On ma, 2016-01-25 at 11:01 +0800, Jiancheng Xue wrote: >> --- a/drivers/clk/hisilicon/Kconfig >> +++ b/drivers/clk/hisilicon/Kconfig > >> +config COMMON_CLK_HI3519 >> +bool "Hi3519 Clock Driver" >> +

Re: [PATCH v7 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Paul Bolle， Thank you for your reply. On 2016/1/26 9:17, Paul Bolle wrote: > On ma, 2016-01-25 at 11:01 +0800, Jiancheng Xue wrote: >> --- a/drivers/clk/hisilicon/Kconfig >> +++ b/drivers/clk/hisilicon/Kconfig > >> +config COMMON_CLK_HI3519 >> +bool "Hi3519 Clock Driver" >> +

Re: [PATCH v7 4/6] ARM: debug: add hi3519 debug uart

On 2016/1/25 11:01, Jiancheng Xue wrote: > add hi3519 debug uart > > Signed-off-by: Jiancheng Xue > --- > arch/arm/Kconfig.debug | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index c6b6175..b02a7c1 100644 > ---

Re: [PATCH v7 4/6] ARM: debug: add hi3519 debug uart

On 2016/1/25 11:01, Jiancheng Xue wrote: > add hi3519 debug uart > > Signed-off-by: Jiancheng Xue > --- > arch/arm/Kconfig.debug | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index

Re: [PATCH v5 1/6] clk: hisilicon: add CRG driver for hi3519 soc

On 2016/1/20 14:38, Tomeu Vizoso wrote: > On 19 January 2016 at 19:20, Rob Herring wrote: >> On Fri, Jan 15, 2016 at 1:57 AM, xuejiancheng >> wrote: >>> >>> On 2016/1/14 21:16, xuejiancheng wrote: >>>> Hi Mike, >>>> >>>> O

Re: [PATCH v5 1/6] clk: hisilicon: add CRG driver for hi3519 soc

On 2016/1/20 14:38, Tomeu Vizoso wrote: > On 19 January 2016 at 19:20, Rob Herring <robh...@kernel.org> wrote: >> On Fri, Jan 15, 2016 at 1:57 AM, xuejiancheng <xuejianch...@huawei.com> >> wrote: >>> >>> On 2016/1/14 21:16, xuejiancheng wrote: >&

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike， I am sorry. I have to correct my answer about using CLK_OF_DECLARE. On 2016/1/5 15:21, xuejiancheng wrote: > Hi Mike, >Happy new year to you! >Thank you for taking time to reply. > > On 2015/12/31 8:23, Michael Turquette wrote: >> Hello Jianche

Re: [PATCH v4 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl

On 2016/1/5 18:12, Philipp Zabel wrote: > Am Mittwoch, den 30.12.2015, 09:43 +0800 schrieb Jiancheng Xue: >> Add device tree bindings for Hi3519 system controller. >> >> Signed-off-by: Jiancheng Xue >> --- >> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++ >> 1 file

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Philipp, Thank you very much for your quick reply. On 2016/1/5 18:12, Philipp Zabel wrote: > H Jiancheng, > > Am Mittwoch, den 30.12.2015, 09:43 +0800 schrieb Jiancheng Xue: >> The CRG(Clock and Reset Generator) block provides clock >> and reset signals for other modules in hi3519 soc. >>

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Philipp, Thank you very much for your quick reply. On 2016/1/5 18:12, Philipp Zabel wrote: > H Jiancheng, > > Am Mittwoch, den 30.12.2015, 09:43 +0800 schrieb Jiancheng Xue: >> The CRG(Clock and Reset Generator) block provides clock >> and reset signals for other modules in hi3519 soc. >>

Re: [PATCH v4 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl

On 2016/1/5 18:12, Philipp Zabel wrote: > Am Mittwoch, den 30.12.2015, 09:43 +0800 schrieb Jiancheng Xue: >> Add device tree bindings for Hi3519 system controller. >> >> Signed-off-by: Jiancheng Xue >> --- >> Documentation/devicetree/bindings/mfd/hi3519.txt | 14

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike， I am sorry. I have to correct my answer about using CLK_OF_DECLARE. On 2016/1/5 15:21, xuejiancheng wrote: > Hi Mike, >Happy new year to you! >Thank you for taking time to reply. > > On 2015/12/31 8:23, Michael Turquette wrote: >> Hello Jianche

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike, Happy new year to you! Thank you for taking time to reply. On 2015/12/31 8:23, Michael Turquette wrote: > Hello Jiancheng Xue, > > Quoting Jiancheng Xue (2015-12-29 17:43:47) >> The CRG(Clock and Reset Generator) block provides clock >> and reset signals for other modules in

Re: [PATCH] mtd: spi-nor: add hisilicon spi-nor flash controller driver

Hi Rob, Happy new year to you! Thank you for your patience. On 2016/1/1 6:26, Rob Herring wrote: > On Wed, Dec 30, 2015 at 10:26:11AM +0800, Jiancheng Xue wrote: >> add hisilicon spi-nor flash controller driver >> >> Signed-off-by: Binquan Peng >> Signed-off-by: Jiancheng Xue >> --- >>

Re: [PATCH] mtd: spi-nor: add hisilicon spi-nor flash controller driver

Hi Rob, Happy new year to you! Thank you for your patience. On 2016/1/1 6:26, Rob Herring wrote: > On Wed, Dec 30, 2015 at 10:26:11AM +0800, Jiancheng Xue wrote: >> add hisilicon spi-nor flash controller driver >> >> Signed-off-by: Binquan Peng >> Signed-off-by:

Re: [PATCH v4 1/6] clk: hisilicon: add CRG driver for hi3519 soc

Hi Mike, Happy new year to you! Thank you for taking time to reply. On 2015/12/31 8:23, Michael Turquette wrote: > Hello Jiancheng Xue, > > Quoting Jiancheng Xue (2015-12-29 17:43:47) >> The CRG(Clock and Reset Generator) block provides clock >> and reset signals for other modules in

Re: [PATCH v3 7/7] ARM: dts: add dts files for Hi3519

Hi Rob, On 2015/12/12 0:28, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:21PM +0800, Jiancheng Xue wrote: >> add dts files for Hi3519 >> >> Signed-off-by: Jiancheng Xue >> --- >> arch/arm/boot/dts/Makefile| 2 + >> arch/arm/boot/dts/hi3519-demb.dts | 42 +++ >>

Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519

On 2015/12/11 23:21, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:17PM +0800, Jiancheng Xue wrote: >> add dt_machine definition for hi3519. >> >> Signed-off-by: Jiancheng Xue >> --- >> arch/arm/mach-hisi/hisilicon.c | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git

Re: [PATCH v3 2/7] clk: hisilicon: add dt-binding document for Hi3519 CRG

On 2015/12/11 23:19, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:16PM +0800, Jiancheng Xue wrote: >> add dt-binding document for Hi3519 CRG block >> >> Signed-off-by: Jiancheng Xue >> --- >> .../devicetree/bindings/clock/hi3519-crg.txt | 46 >> ++ >> 1 file

Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519

On 2015/12/11 23:21, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:17PM +0800, Jiancheng Xue wrote: >> add dt_machine definition for hi3519. >> >> Signed-off-by: Jiancheng Xue >> --- >> arch/arm/mach-hisi/hisilicon.c | 9 + >> 1 file changed, 9

Re: [PATCH v3 2/7] clk: hisilicon: add dt-binding document for Hi3519 CRG

On 2015/12/11 23:19, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:16PM +0800, Jiancheng Xue wrote: >> add dt-binding document for Hi3519 CRG block >> >> Signed-off-by: Jiancheng Xue >> --- >> .../devicetree/bindings/clock/hi3519-crg.txt | 46 >>

Re: [PATCH v3 7/7] ARM: dts: add dts files for Hi3519

Hi Rob, On 2015/12/12 0:28, Rob Herring wrote: > On Fri, Dec 11, 2015 at 03:45:21PM +0800, Jiancheng Xue wrote: >> add dts files for Hi3519 >> >> Signed-off-by: Jiancheng Xue >> --- >> arch/arm/boot/dts/Makefile| 2 + >> arch/arm/boot/dts/hi3519-demb.dts | 42

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/10 16:04, Arnd Bergmann wrote: > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: >>> >>> This is not what I meant. You have to use "syscon" as the most generic >>> "compatible" value here, but should add a machine spec

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/10 16:04, Arnd Bergmann wrote: > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: >>> >>> This is not what I meant. You have to use "syscon" as the most generic >>> "compatible" value here, but should add a machine spec

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/9 23:31, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: >> On 2015/12/7 14:37, xuejiancheng wrote: >>> >>> On 2015/12/4 18:49, Arnd Bergmann wrote: >>>> On Friday 04 December 2015 10:27:58 xuejiancheng wrote:

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/9 23:32, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:03:20 xuejiancheng wrote: >>>> >>>> I think we should come up with a way to handle this in general for >>>> ARCH_HISI. It's not problem to have a couple of sub-options, but I'd >&g

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/9 23:32, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:03:20 xuejiancheng wrote: >>>> >>>> I think we should come up with a way to handle this in general for >>>> ARCH_HISI. It's not problem to have a couple of sub-options, but I'd >&g

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/9 23:31, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: >> On 2015/12/7 14:37, xuejiancheng wrote: >>> >>> On 2015/12/4 18:49, Arnd Bergmann wrote: >>>> On Friday 04 December 2015 10:27:58 xuejiancheng wrote:

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >>>> Hi Arnd, >>>> >>>> On 2015

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >>>> Hi Arnd, >>>> >>>> On 2015

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/7 14:37, xuejiancheng wrote: > > On 2015/12/4 18:49, Arnd Bergmann wrote: >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>>> >>>>> +sysctrl: system-controller@1202 { >>>>>

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/8 9:55, xuejiancheng wrote: > > > On 2015/12/7 17:46, Arnd Bergmann wrote: >> On Monday 07 December 2015 14:58:14 xuejiancheng wrote: >>> On 2015/12/5 5:54, Arnd Bergmann wrote: >>>> On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/7 17:46, Arnd Bergmann wrote: > On Monday 07 December 2015 14:58:14 xuejiancheng wrote: >> On 2015/12/5 5:54, Arnd Bergmann wrote: >>> On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >>>> On 2015/12/3 17:40, Arnd Bergmann wrote: >>>&

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >>>> Hi Arnd, >>>> >>>> On 2015

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/4 18:56, Arnd Bergmann wrote: > On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >> Hi Arnd, >> >> On 2015/12/3 17:44, Arnd Bergmann wrote: >>> On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >>>> +#ifndef __DTS_HI3519_

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/4 18:56, Arnd Bergmann wrote: > On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >> Hi Arnd, >> >> On 2015/12/3 17:44, Arnd Bergmann wrote: >>> On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >>>> +#ifndef __DTS_HI3519_

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/8 9:55, xuejiancheng wrote: > > > On 2015/12/7 17:46, Arnd Bergmann wrote: >> On Monday 07 December 2015 14:58:14 xuejiancheng wrote: >>> On 2015/12/5 5:54, Arnd Bergmann wrote: >>>> On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/7 14:37, xuejiancheng wrote: > > On 2015/12/4 18:49, Arnd Bergmann wrote: >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>>> >>>>> +sysctrl: system-controller@1202 { >>>>>

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >>>> Hi Arnd, >>>> >>>> On 2015

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

On 2015/12/7 17:46, Arnd Bergmann wrote: > On Monday 07 December 2015 14:58:14 xuejiancheng wrote: >> On 2015/12/5 5:54, Arnd Bergmann wrote: >>> On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >>>> On 2015/12/3 17:40, Arnd Bergmann wrote: >>>&

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

Hi Arnd, On 2015/12/5 5:54, Arnd Bergmann wrote: > On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >> On 2015/12/3 17:40, Arnd Bergmann wrote: >>> On Thursday 03 December 2015 10:42:45 Jiancheng Xue wrote: >>>> --- a/arch/arm/mach-hisi/Kconfig >>

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/4 18:49, Arnd Bergmann wrote: > On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>> >>>> +sysctrl: system-controller@1202 { >>>> +compatible = "hisilicon,sysctrl"; >

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/4 18:49, Arnd Bergmann wrote: > On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>> >>>> +sysctrl: system-controller@1202 { >>>> +compatible = "hisilicon,sysctrl"; >

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

Hi Arnd, On 2015/12/5 5:54, Arnd Bergmann wrote: > On Friday 04 December 2015 12:07:58 xuejiancheng wrote: >> On 2015/12/3 17:40, Arnd Bergmann wrote: >>> On Thursday 03 December 2015 10:42:45 Jiancheng Xue wrote: >>>> --- a/arch/arm/mach-hisi/Kconfig >>

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

Hi Arnd, On 2015/12/3 17:40, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:42:45 Jiancheng Xue wrote: >> --- a/arch/arm/mach-hisi/Kconfig >> +++ b/arch/arm/mach-hisi/Kconfig >> @@ -12,6 +12,14 @@ if ARCH_HISI >> >> menu "Hisilicon platform type" >> >> +config ARCH_HI3519 >> +

Re: [PATCH v2 9/9] dmaengine: Kconfig: rename ARCH_HI3xxx to ARCH_HI36xx

Hi Arnd, On 2015/12/3 17:41, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:49:37 Jiancheng Xue wrote: >> Rename ARCH_HI3xxx to ARCH_HI36xx. >> >> Signed-off-by: Jiancheng Xue > > Maybe just change it to 'depends on ARCH_HISI'? That would make it > possible to merge the change

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >> +#ifndef __DTS_HI3519_CLOCK_H >> +#define __DTS_HI3519_CLOCK_H > > Please try to avoid adding headers like this if you can at all. > > I might ask you to merge the header file in

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

Hi Arnd, Thank you very much for all your comments. On 2015/12/3 17:36, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > >> + >> +/dts-v1/; >> +#include "hi3519.dtsi" >> + >> +/ { >> +model = "HiSilicon HI3519 DEMO Board"; >> +compatible =

Re: [PATCH v2 9/9] dmaengine: Kconfig: rename ARCH_HI3xxx to ARCH_HI36xx

Hi Arnd, On 2015/12/3 17:41, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:49:37 Jiancheng Xue wrote: >> Rename ARCH_HI3xxx to ARCH_HI36xx. >> >> Signed-off-by: Jiancheng Xue > > Maybe just change it to 'depends on ARCH_HISI'? That would make it > possible to

Re: [PATCH v2 3/9] ARM: hisi: enable Hi3519 soc

Hi Arnd, On 2015/12/3 17:40, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:42:45 Jiancheng Xue wrote: >> --- a/arch/arm/mach-hisi/Kconfig >> +++ b/arch/arm/mach-hisi/Kconfig >> @@ -12,6 +12,14 @@ if ARCH_HISI >> >> menu "Hisilicon platform type" >> >> +config ARCH_HI3519 >> +

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >> +#ifndef __DTS_HI3519_CLOCK_H >> +#define __DTS_HI3519_CLOCK_H > > Please try to avoid adding headers like this if you can at all. > > I might ask you to merge the header file in

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

Hi Arnd, Thank you very much for all your comments. On 2015/12/3 17:36, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > >> + >> +/dts-v1/; >> +#include "hi3519.dtsi" >> + >> +/ { >> +model = "HiSilicon HI3519 DEMO Board"; >> +compatible =

Re: [PATCH 2/5] ARM: hisi: enable Hi3519 soc

Hi Kevin, Thank you for your suggestions. On 2015/12/1 8:02, Kevin Hilman wrote: > Jiancheng Xue writes: > >> Hi3519 SOC is mainly used for ip camera and sport dv >> solutions. >> >> Signed-off-by: Jiancheng Xue >> --- >> arch/arm/mach-hisi/Kconfig | 9 + >>

Re: [PATCH 1/5] clk: hi3519: add CRG driver for hisilicon hi3519 soc

Hello Rob, Thanks for your suggestions! On 2015/12/1 4:35, Rob Herring wrote: > On Sat, Nov 28, 2015 at 03:13:26PM +0800, Jiancheng Xue wrote: >> The CRG(Clock and Reset Generator) module provides >> clock and reset signals for other modules in hi3519 soc. >> >> Signed-off-by: Jiancheng Xue >>

Re: [PATCH 1/5] clk: hi3519: add CRG driver for hisilicon hi3519 soc

Hello Rob, Thanks for your suggestions! On 2015/12/1 4:35, Rob Herring wrote: > On Sat, Nov 28, 2015 at 03:13:26PM +0800, Jiancheng Xue wrote: >> The CRG(Clock and Reset Generator) module provides >> clock and reset signals for other modules in hi3519 soc. >> >> Signed-off-by: Jiancheng Xue

Re: [PATCH 2/5] ARM: hisi: enable Hi3519 soc

Hi Kevin, Thank you for your suggestions. On 2015/12/1 8:02, Kevin Hilman wrote: > Jiancheng Xue writes: > >> Hi3519 SOC is mainly used for ip camera and sport dv >> solutions. >> >> Signed-off-by: Jiancheng Xue >> --- >>