On 2021/04/08 20:46, Miquel Raynal wrote:
Hi Yu,
Yu Kuai wrote on Thu, 8 Apr 2021 19:15:14 +0800:
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Reported-by: Hulk Robot
Signed-off-by: Yu Kuai
---
On 2021/04/08 13:04, Christophe Leroy wrote:
Le 08/04/2021 à 03:18, Yu Kuai a écrit :
The sparse tool complains as follow:
arch/powerpc/kernel/btext.c:48:5: warning:
symbol 'boot_text_mapped' was not declared. Should it be static?
This symbol is not used outside of btext.c, so this commit
On 2021/04/08 13:01, Christophe Leroy wrote:
Le 08/04/2021 à 03:18, Yu Kuai a écrit :
Fixes gcc '-Wunused-but-set-variable' warning:
arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext'
defined but not used.
You don't get this error as it is now.
You will get this error only
On 2021/04/08 0:57, kernel test robot wrote:
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.12-rc6 next-20210407]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch,
Hi
On 2020/12/29 9:15, Ming Lei wrote:
Just wondering why you try to set 128 via sysfs for all disks? If you do that,
you should know the potential result given the whole tags queue depth is just
128.
It's just a extreme example to show the unexpected result of "always
return true from
Hi
On 2020/12/28 16:28, Ming Lei wrote:
Another candidate solution may be to always return true from hctx_may_queue()
for this kind of queue because queue_depth has provided fair allocation for
each LUN, and looks not necessary to do that again.
If always return true from hctx_may_queue() in
Hi,
On 2020/12/27 19:58, Ming Lei wrote:
Hi Yu Kuai,
On Sat, Dec 26, 2020 at 06:28:06PM +0800, Yu Kuai wrote:
When sharing a tag set, if most disks are issuing small amount of IO, and
only a few is issuing a large amount of IO. Current approach is to limit
the max amount of tags a disk can
On 2020/11/25 20:32, Tejun Heo wrote:
Hello,
Thanks for the fix. A couple comments below.
On Sat, Nov 21, 2020 at 04:34:20PM +0800, Yu Kuai wrote:
+#define BLKG_DESTROY_BATH 4096
I think you meant BLKG_DESTROY_BATCH.
static void blkg_destroy_all(struct request_queue *q)
{
On 2020/11/10 23:21, Krzysztof Kozlowski wrote:
On Tue, Nov 10, 2020 at 09:33:11AM +0800, Yu Kuai wrote:
The reference to device obtained with of_find_device_by_node() should
be dropped. Thus add jump target to fix the exception handling for this
function implementation.
Fixes:
ping..
On 2020/10/31 18:54, Yu Kuai wrote:
of_find_device_by_node() already takes a reference to the device, and
ingenic_ecc_release() will drop the reference. So, the get_device() in
ingenic_ecc_get() is redundand.
Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC
在 2020/11/08 6:09, Jakub Kicinski 写道:
On Sat, 7 Nov 2020 17:09:25 +0800 Yu Kuai wrote:
if of_find_device_by_node() succeed, fman_port_probe() doesn't have a
corresponding put_device(). Thus add jump target to fix the exception
handling for this function implementation.
Fixes: 0572054617f3
On 2020/11/03 9:30, Jakub Kicinski wrote:
On Sat, 31 Oct 2020 18:54:18 +0800 Yu Kuai wrote:
if of_find_device_by_node() succeed, fman_port_probe() doesn't have a
corresponding put_device(). Thus add jump target to fix the exception
handling for this function implementation.
Fixes:
On 2020/10/29 21:51, Robin Murphy wrote:
On 2020-10-29 13:19, yukuai (C) wrote:
On 2020/10/29 18:08, Robin Murphy wrote:
On 2020-10-29 09:22, Yu Kuai wrote:
If of_find_device_by_node() failed in rk_iommu_of_xlate(), null pointer
dereference will be triggered. Thus return error code
On 2020/10/29 18:08, Robin Murphy wrote:
On 2020-10-29 09:22, Yu Kuai wrote:
If of_find_device_by_node() failed in rk_iommu_of_xlate(), null pointer
dereference will be triggered. Thus return error code if
of_find_device_by_node() failed.
How can that happen? (Given that
On 2020/09/29 7:08, Will Deacon wrote:
On Mon, Sep 21, 2020 at 09:45:57PM +0100, Will Deacon wrote:
On Tue, Sep 22, 2020 at 03:13:53AM +0800, kernel test robot wrote:
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on
On 2020/09/11 20:05, Matthew Wilcox wrote:
@@ -683,7 +736,7 @@ static size_t __iomap_write_end(struct inode *inode,
loff_t pos, size_t len,
if (unlikely(copied < len && !PageUptodate(page)))
return 0;
iomap_set_range_uptodate(page, offset_in_page(pos), len);
-
Hi,
Sorry that after copy and paste, the content of the patch somehow
changed and looks strange.
Best regards,
Yu Kuai
On 2020/09/11 16:27, yukuai (C) wrote:
On 2020/08/21 20:44, Matthew Wilcox wrote:
On Fri, Aug 21, 2020 at 08:33:06PM +0800, Yu Kuai wrote:
changes from v3: - add
On 2020/08/21 20:44, Matthew Wilcox wrote:
On Fri, Aug 21, 2020 at 08:33:06PM +0800, Yu Kuai wrote:
changes from v3: - add IOMAP_STATE_ARRAY_SIZE - replace set_bit /
clear_bit with bitmap_set / bitmap_clear - move
iomap_set_page_dirty() out of 'iop->state_lock' - merge
On 2020/09/08 6:56, Chun-Kuang Hu wrote:
Hi Yu Kuai:
Yu Kuai 於 2020年9月5日 週六 下午4:31寫道：
if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
This patch looks
On 2020/08/25 21:38, Maxime Ripard wrote:
Hi,
On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote:
If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a
corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes:
On 2020/08/25 20:11, Mark Brown wrote:
On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote:
If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe()
doesn't have corresponding kfree() in exception handling. Thus add
kfree() for this function implementation.
@@ -151,7
On 2020/8/19 20:56, Gao Xiang wrote:
On Wed, Aug 19, 2020 at 08:05:42PM +0800, Yu Kuai wrote:
...
+static void
+iomap_iop_set_range_dirty(struct page *page, unsigned int off,
+ unsigned int len)
+{
+ struct iomap_page *iop = to_iomap_page(page);
+ struct inode *inode
On 2020/7/30 11:19, Matthew Wilcox wrote:
Maybe let the discussion on removing the ->uptodate array finish
before posting another patch for review?
Hi, Matthew!
Of course, I missed the discussion thread before sending this path.
And thanks for your suggestions.
Best regards,
Yu Kuai
On 2020/7/30 10:27, Gao Xiang wrote:
Hi Kuai,
On Thu, Jul 30, 2020 at 09:19:01AM +0800, Yu Kuai wrote:
commit 9dc55f1389f9 ("iomap: add support for sub-pagesize buffered I/O
without buffer heads") replace the per-block structure buffer_head with
the per-page structure iomap_page. However,
On 2020/7/18 6:55, Alexandre Belloni wrote:
A better fix would have been to also factorize imx_suspend_alloc_ocram,
imx6q_suspend_init, socfpga_setup_ocram_self_refresh and
at91_pm_sram_init as they were all copied from pm-imx6.c
imx_suspend_alloc_ocram and imx6q_suspend_init are done
On 2020/7/3 4:09, Alexandre Belloni wrote:
Hi,
On 04/06/2020 20:33:01+0800, yu kuai wrote:
if of_find_device_by_node() succeed, at91_pm_sram_init() doesn't have
a corresponding put_device(). Thus add a jump target to fix the exception
handling for this function implementation.
Fixes:
ping?
On 2020/6/4 21:10, yu kuai wrote:
if of_find_device_by_node() succeed, socfpga_setup_ocram_self_refresh()
doesn't have a corresponding put_device(). Thus add a jump target to fix
the exception handling for this function implementation.
Fixes: 44fd8c7d4005 ("ARM: socfpga: support suspend
ping?
On 2020/6/4 20:33, yu kuai wrote:
if of_find_device_by_node() succeed, at91_pm_sram_init() doesn't have
a corresponding put_device(). Thus add a jump target to fix the exception
handling for this function implementation.
Fixes: d2e467905596 ("ARM: at91: pm: use the mmio-sram pool to
On 2020/6/23 20:11, Shawn Guo wrote:
On Thu, Jun 04, 2020 at 08:54:49PM +0800, yu kuai wrote:
if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a
corresponding put_device(). Thus add a jump target to fix the exception
handling for this function implementation.
On 2020/6/11 10:45, Dave Chinner wrote:
From: Dave Chinner
xlog_wait() on the CIL context can reference a freed context if the
waiter doesn't get scheduled before the CIL context is freed. This
can happen when a task is on the hard throttle and the CIL push
aborts due to a shutdown. This was
On 2020/6/11 10:28, Dave Chinner wrote
Actually, it's a lot simpler:
thread1 thread2
__xfs_trans_commit
xfs_log_commit_cil
xlog_wait
schedule
xlog_cil_push_work
wake_up_all
On 2020/6/5 3:07, Markus Elfring wrote:
if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a
corresponding put_device(). Thus add a jump target to fix the exception
handling for this function implementation.
Do you find a previous update suggestion useful?
ARM: imx6: Add
On 2020/6/3 9:35, yu kuai wrote:
A coccicheck run provided information like the following:
drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 792, but without a corresponding
object release within this function.
Generated by:
On 2020/6/3 2:56, Markus Elfring wrote:
in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed,
put_device() is missing in the error handling patch.
How do you think about another wording variant?
A coccicheck run provided information like the following.
34 matches
Mail list logo
