Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-13 Thread Stefano Stabellini
On Thu, 13 Apr 2017, Julien Grall wrote: > Hi Stefano, > > Sorry for the late answer. > > On 12/04/17 00:39, Stefano Stabellini wrote: > > On Tue, 11 Apr 2017, Catalin Marinas wrote: > > > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > > > On 11/04/17 02:14, Bart Van Assche wro

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-13 Thread Julien Grall
Hi Stefano, Sorry for the late answer. On 12/04/17 00:39, Stefano Stabellini wrote: On Tue, 11 Apr 2017, Catalin Marinas wrote: On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: On 11/04/17 02:14, Bart Van Assche wrote: On 04/10/17 17:31, Stefano Stabellini wrote: I think the re

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-12 Thread Catalin Marinas
On Tue, Apr 11, 2017 at 04:39:09PM -0700, Stefano Stabellini wrote: > On Tue, 11 Apr 2017, Catalin Marinas wrote: > > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > > On 11/04/17 02:14, Bart Van Assche wrote: > > > > On 04/10/17 17:31, Stefano Stabellini wrote: > > > >> I think t

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-11 Thread Stefano Stabellini
On Tue, 11 Apr 2017, Catalin Marinas wrote: > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > On 11/04/17 02:14, Bart Van Assche wrote: > > > On 04/10/17 17:31, Stefano Stabellini wrote: > > >> I think the reason is that, as you can see, if (dev && dev->dma_ops), > > >> dev->dma_o

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-11 Thread Catalin Marinas
On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > On 11/04/17 02:14, Bart Van Assche wrote: > > On 04/10/17 17:31, Stefano Stabellini wrote: > >> I think the reason is that, as you can see, if (dev && dev->dma_ops), > >> dev->dma_ops is returned, while before this changes, xen_dma_ops

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-11 Thread Julien Grall
Hi Bart, On 11/04/17 02:14, Bart Van Assche wrote: > On 04/10/17 17:31, Stefano Stabellini wrote: >> I think the reason is that, as you can see, if (dev && dev->dma_ops), >> dev->dma_ops is returned, while before this changes, xen_dma_ops was >> returned on Xen on ARM. >> >> Unfortunately DMA cann

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-10 Thread Bart Van Assche
On 04/10/17 17:31, Stefano Stabellini wrote: > I think the reason is that, as you can see, if (dev && dev->dma_ops), > dev->dma_ops is returned, while before this changes, xen_dma_ops was > returned on Xen on ARM. > > Unfortunately DMA cannot work properly without using the appropriate > xen_dma_op

"Consolidate get_dma_ops" breaks Xen on ARM

2017-04-10 Thread Stefano Stabellini
Hi all, Julien Grall (CC'ed) discovered that the following commit breaks Xen on ARM: commit 815dd18788fe0d41899f51b91d0560279cf16b0d Author: Bart Van Assche Date: Fri Jan 20 13:04:04 2017 -0800 treewide: Consolidate get_dma_ops() implementations The relevant changes are: