Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-26 Thread Vincenzo Frascino
On 26/06/2019 10:38, Will Deacon wrote: > On Tue, Jun 25, 2019 at 06:00:27PM +0100, Vincenzo Frascino wrote: >> On 25/06/2019 17:26, Nick Desaulniers wrote: >>> On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino >>> wrote: > but clang 7.0 is still use in many distros by default, so maybe thi

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-26 Thread Will Deacon
On Tue, Jun 25, 2019 at 06:00:27PM +0100, Vincenzo Frascino wrote: > On 25/06/2019 17:26, Nick Desaulniers wrote: > > On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino > > wrote: > >>> but clang 7.0 is still use in many distros by default, so maybe this > >>> commit can > >>> be fixed by adding a

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qian, On 25/06/2019 18:31, Qian Cai wrote: > On Tue, 2019-06-25 at 18:00 +0100, Vincenzo Frascino wrote: >> Hi Nick, >> >> On 25/06/2019 17:26, Nick Desaulniers wrote: >>> On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino >>> wrote: Hi Qian, ... > > but clang 7

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 18:00 +0100, Vincenzo Frascino wrote: > Hi Nick, > > On 25/06/2019 17:26, Nick Desaulniers wrote: > > On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino > > wrote: > > > > > > Hi Qian, > > > > > > ... > > > > > > > > > > > but clang 7.0 is still use in many distros by def

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Nick, On 25/06/2019 17:26, Nick Desaulniers wrote: > On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino > wrote: >> >> Hi Qian, >> >> ... >> >>> >>> but clang 7.0 is still use in many distros by default, so maybe this commit >>> can >>> be fixed by adding a conditional check to use "small" if

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Nick Desaulniers
On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino wrote: > > Hi Qian, > > ... > > > > > but clang 7.0 is still use in many distros by default, so maybe this commit > > can > > be fixed by adding a conditional check to use "small" if clang version < > > 8.0. > > > > Could you please verify that t

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 15:54 +0100, Vincenzo Frascino wrote: > Hi Qian, > > ... > > > > > but clang 7.0 is still use in many distros by default, so maybe this commit > > can > > be fixed by adding a conditional check to use "small" if clang version < > > 8.0. > > > > Could you please verify tha

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qian, ... > > but clang 7.0 is still use in many distros by default, so maybe this commit > can > be fixed by adding a conditional check to use "small" if clang version < 8.0. > Could you please verify that the patch below works for you? Thanks, Vincenzo --->8 >From 0546f3bbea910cd2

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qian, On 25/06/2019 15:28, Qian Cai wrote: > On Tue, 2019-06-25 at 15:11 +0100, Vincenzo Frascino wrote: >> Hi Qian, >> >> On 25/06/2019 14:51, Qian Cai wrote: >>> On Tue, 2019-06-25 at 14:40 +0100, Vincenzo Frascino wrote: On 25/06/2019 13:56, Qian Cai wrote: > On Tue, 2019-06-25 at 1

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 15:11 +0100, Vincenzo Frascino wrote: > Hi Qian, > > On 25/06/2019 14:51, Qian Cai wrote: > > On Tue, 2019-06-25 at 14:40 +0100, Vincenzo Frascino wrote: > > > On 25/06/2019 13:56, Qian Cai wrote: > > > > On Tue, 2019-06-25 at 13:47 +0100, Vincenzo Frascino wrote: > > > > > H

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qian, On 25/06/2019 14:51, Qian Cai wrote: > On Tue, 2019-06-25 at 14:40 +0100, Vincenzo Frascino wrote: >> On 25/06/2019 13:56, Qian Cai wrote: >>> On Tue, 2019-06-25 at 13:47 +0100, Vincenzo Frascino wrote: Hi Qian, On 25/06/2019 13:16, Qian Cai wrote: > The linux-next comm

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 14:40 +0100, Vincenzo Frascino wrote: > On 25/06/2019 13:56, Qian Cai wrote: > > On Tue, 2019-06-25 at 13:47 +0100, Vincenzo Frascino wrote: > > > Hi Qian, > > > > > > On 25/06/2019 13:16, Qian Cai wrote: > > > > The linux-next commit "arm64: vdso: Substitute gettimeofday() w

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qin, On 25/06/2019 13:56, Qian Cai wrote: > On Tue, 2019-06-25 at 13:47 +0100, Vincenzo Frascino wrote: >> Hi Qian, >> >> On 25/06/2019 13:16, Qian Cai wrote: >>> The linux-next commit "arm64: vdso: Substitute gettimeofday() with C >>> implementation" [1] breaks clang build. >>> >>> error: inva

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 13:47 +0100, Vincenzo Frascino wrote: > Hi Qian, > > On 25/06/2019 13:16, Qian Cai wrote: > > The linux-next commit "arm64: vdso: Substitute gettimeofday() with C > > implementation" [1] breaks clang build. > > > > error: invalid value 'tiny' in '-mcode-model tiny' > > make[

Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Vincenzo Frascino
Hi Qian, On 25/06/2019 13:16, Qian Cai wrote: > The linux-next commit "arm64: vdso: Substitute gettimeofday() with C > implementation" [1] breaks clang build. > > error: invalid value 'tiny' in '-mcode-model tiny' > make[1]: *** [scripts/Makefile.build:279: > arch/arm64/kernel/vdso/vgettimeofday.

"arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

2019-06-25 Thread Qian Cai
The linux-next commit "arm64: vdso: Substitute gettimeofday() with C implementation" [1] breaks clang build. error: invalid value 'tiny' in '-mcode-model tiny' make[1]: *** [scripts/Makefile.build:279: arch/arm64/kernel/vdso/vgettimeofday.o] Error 1 make[1]: *** Waiting for unfinished jobs mak