Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Thomas Gleixner
On Thu, 25 Jan 2018, Lyude Paul wrote: > On Thu, 2018-01-25 at 19:46 +0100, Thomas Gleixner wrote: > > On Thu, 25 Jan 2018, Lyude Paul wrote: > > > > > I think you are right, apologies. Glad to know this isn't a regression in > > > the > > > IRQ handling code :). It looks like our nouveau problems

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Lyude Paul
On Thu, 2018-01-25 at 19:46 +0100, Thomas Gleixner wrote: > On Thu, 25 Jan 2018, Lyude Paul wrote: > > > I think you are right, apologies. Glad to know this isn't a regression in > > the > > IRQ handling code :). It looks like our nouveau problems are probably coming > > from the fact that we don'

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Thomas Gleixner
On Thu, 25 Jan 2018, Lyude Paul wrote: > I think you are right, apologies. Glad to know this isn't a regression in the > IRQ handling code :). It looks like our nouveau problems are probably coming > from the fact that we don't just leave IRQs setup through suspend/resume which > as far as I can t

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Lyude Paul
Will cc you with some patches in a bit, think I have this problem figured out :) On Thu, 2018-01-25 at 04:29 +0100, Mike Galbraith wrote: > On Wed, 2018-01-24 at 15:02 -0500, Lyude Paul wrote: > > Almost forgot to mention: I came across this patch because reverting it > > locally on the mainline k

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Lyude Paul
I think you are right, apologies. Glad to know this isn't a regression in the IRQ handling code :). It looks like our nouveau problems are probably coming from the fact that we don't just leave IRQs setup through suspend/resume which as far as I can tell, is probably not the correct thing to do. G

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-25 Thread Thomas Gleixner
On Wed, 24 Jan 2018, Lyude Paul wrote: > Sorry about that! Let me clarify a little bit: this is a problem that shows up > on mainline. Normally when we suspend the GPU in nouveau, we free the IRQs > it's using before going into suspend > (drivers/gpu/drm/nouveau/nvkm/subdev/pci/base.c:88), then res

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Mike Galbraith
On Wed, 2018-01-24 at 15:02 -0500, Lyude Paul wrote: > Almost forgot to mention: I came across this patch because reverting it > locally on the mainline kernel makes request_irq() behave normally (it doesn't > attempt to allocate the same vector twice anymore) and nouveau starts doing > suspend/res

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Lyude Paul
> > > Sent: Wednesday, January 24, 2018 12:49 PM > > > To: Thomas Gleixner > > > Cc: h...@zytor.com; keith.bu...@intel.com; mi...@kernel.org; linux- > > > ker...@vger.kernel.org > > > Subject: Re: "irq/matrix: Spread interrupts on allocation" b

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Lyude Paul
To: Thomas Gleixner > > Cc: h...@zytor.com; keith.bu...@intel.com; mi...@kernel.org; linux- > > ker...@vger.kernel.org > > Subject: Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau > > in > > mainline kernel > > > > Hi, please ignore the

RE: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Ghannam, Yazen
.org; linux- > ker...@vger.kernel.org > Subject: Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in > mainline kernel > > Hi, please ignore the warning: it happens before and after the regressing > commit (I didn't actually mean to include it on the log I gave

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Lyude Paul
Hi, please ignore the warning: it happens before and after the regressing commit (I didn't actually mean to include it on the log I gave here, whoops). As for how I determined nouveau is getting assigned the same IRQ vector as another device, I checked using /sys/kernel/debug/irq. Additionally; whe

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Borislav Petkov
On Wed, Jan 24, 2018 at 01:50:52PM +0100, Thomas Gleixner wrote: > On Tue, 23 Jan 2018, Lyude Paul wrote: > > > Hi! Sorry to be the bearer of bad news, but this patch actually seems to > > break > > suspending and resuming with nouveau on my machine: > > > [ 31.003578] WARNING: CPU: 0 PID: 115

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Thomas Gleixner
On Tue, 23 Jan 2018, Lyude Paul wrote: > JFYI: I confirmed this patch is definitely broken. I'm seeing nouveau get > assigned the same MSI vector as another device on the system, which would > explain why interrupts suddenly stop working. I'll keep looking into it > further > tomorrow. How did y

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-24 Thread Thomas Gleixner
On Tue, 23 Jan 2018, Lyude Paul wrote: > Hi! Sorry to be the bearer of bad news, but this patch actually seems to break > suspending and resuming with nouveau on my machine: > [ 31.003578] WARNING: CPU: 0 PID: 11523 at kernel/smp.c:291 > smp_call_function_single+0xdc/0xe0 This warning has abso

Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-23 Thread Lyude Paul
JFYI: I confirmed this patch is definitely broken. I'm seeing nouveau get assigned the same MSI vector as another device on the system, which would explain why interrupts suddenly stop working. I'll keep looking into it further tomorrow. On Tue, 2018-01-23 at 17:01 -0500, Lyude Paul wrote: > Hi! S

"irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

2018-01-23 Thread Lyude Paul
Hi! Sorry to be the bearer of bad news, but this patch actually seems to break suspending and resuming with nouveau on my machine: [ 29.694755] PM: suspend entry (deep) [ 29.694773] PM: Syncing filesystems ... done. [ 29.696203] Freezing user space processes ... (elapsed 0.001 seconds) done.