Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Fabio Estevam
On Wed, Aug 26, 2020 at 10:13 AM Matthias Schiffer wrote: > Using GPIOs for chipselect would require different pinmuxing. Also, why > use GPIOs, when the SPI controller has this built in? In the initial chips with the ECSPI controller there was a bug with the native chipselect controller and we

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 10:01 -0300, Fabio Estevam wrote: > On Wed, Aug 26, 2020 at 8:54 AM Matthias Schiffer > wrote: > > > Before 8cdcd8aeee281, num_chipselect was set to 3 for spi0 and to 1 > > for > > spi1 in arch/arm/mach-imx/mach-mx31lite.c. My understanding is that > > it > > would make sens

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Fabio Estevam
On Wed, Aug 26, 2020 at 8:54 AM Matthias Schiffer wrote: > Before 8cdcd8aeee281, num_chipselect was set to 3 for spi0 and to 1 for > spi1 in arch/arm/mach-imx/mach-mx31lite.c. My understanding is that it > would make sense to add this as num-cs to > arch/arm/boot/dts/imx31-lite.dts. Or just pass

Re: (EXT) Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 07:59 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Wed, Aug 26, 2020 at 7:32 AM Matthias Schiffer > wrote: > > > But the previous platform data that was removed in 8cdcd8aeee281 > > ("spi: > > imx/fsl-lpspi: Convert to GPIO descriptors") set different values > > for >

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Fabio Estevam
Hi Matthias, On Wed, Aug 26, 2020 at 7:32 AM Matthias Schiffer wrote: > But the previous platform data that was removed in 8cdcd8aeee281 ("spi: > imx/fsl-lpspi: Convert to GPIO descriptors") set different values for > different boards. So maybe some DTS should be using num-cs? Could you provide

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Wed, 2020-08-26 at 12:32 +0200, Matthias Schiffer wrote: > On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > > wrote: > > > > > Makes sense. Does the following logic sound correct? > > > > > > - If num-cs is set, use that (and add

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-26 Thread Matthias Schiffer
On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > wrote: > > > Makes sense. Does the following logic sound correct? > > > > - If num-cs is set, use that (and add it to the docs) > > I would not add num-cs to the docs. As far as I can

Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Fabio Estevam
On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer wrote: > Makes sense. Does the following logic sound correct? > > - If num-cs is set, use that (and add it to the docs) I would not add num-cs to the docs. As far as I can see there is no imx dts that uses num-cs currently. > - If num-cs is uns

Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Matthias Schiffer
On Tue, 2020-08-25 at 11:24 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Tue, Aug 25, 2020 at 4:22 AM Matthias Schiffer > wrote: > > > Hmm, unless I'm overlooking something, this is not going to work: > > > > - spi_get_gpio_descs() sets num_chipselect to the maximum of the > > num_chipsele